From patchwork Tue Sep 4 02:44:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965720 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="awfw3bfh"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FXSpGv6Q"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7J0TJSz9s3x for ; Tue, 4 Sep 2018 12:46:52 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hGXuPqwhzY4UcCkpUqJ35O9zGFpXiUoRn+fdTSHF32M=; b=awfw3bfhUK8yocE7/jCVpg5TUP YMdNNi6xTEZPsnS41NdPLIM38gJGraR0w6VUMbJGP3eUxBvtC1fv7eLIdj9Lw3WWgu6irvbCfvfdD WukoAF9a/FOz+aOIs5U7kTxwvzUW6veAe2/WMxLGe0xzDRgn3W02POfZPOMPJOJ72d2OzGfu8ohte orVlSpqeAEUqYPrdvA2TQ8FMDYfsoFBvN8Ltr8tBWXN2EmKqeZERcxQYcAwkuw/AN+wcxnWxZ0sw5 lpANpctdPrHmlIWl69mxAqakB6ipm3k/uJn1UUSmULCLVMr1/1PFyqYuLfxysvXx7ttgIYHUy9JxW k7mzawlQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mb-0005kS-8X; Tue, 04 Sep 2018 02:46:45 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MY-0005fz-Dx for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:43 +0000 Received: by mail-pf1-x442.google.com with SMTP id b11-v6so916750pfo.3 for ; Mon, 03 Sep 2018 19:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fA2ErCgkNSVCLrHl8v8rTEOByo32QmaLjON3C67ERi8=; b=FXSpGv6Q+gVKqqkcRWl2vNMAOcNEdvYrXJL3ksktI+W6kt6ISgNAG0igOutTk5HyXJ ZW575WBe+/s6WfKUy1k5kv7a6ENWwjFJoQ9fdqllgGaI1ZW6hqIZexvnZGKjyrfTOBVK YIjINe7bm7REInnq72i6mTEg2qR8TTIZXXJxqa3Qfg6WC5fv5dBKcvNTUhSDQUkEe1xo 5TKXGWS0vbp7Jy8sTD1RMiWAJ+otJSs+jBmy80tDyPO+7f/qiiXN+af1OgfhydXSP0dh FnComxuodg8phvHHndO7CBd+/+rlGF5KWvW8iYXGhnLEbZjYK3tbI7nxzb+lHQGKlXyk 8Y+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fA2ErCgkNSVCLrHl8v8rTEOByo32QmaLjON3C67ERi8=; b=bi7fnCk1X4YDw+IlcDKW5b6XcVxLCMgwxy80uIm86a8UmkkgkBEOwpzcM4pwuRRv0f hvy7hcy5ibLu/S3ocQ5d1zmVO7YdbJ2TPxY0fmxK7l/k3bx/68m1hK9CbQ1fPsKBANYj uEa/0brf6pIaoub/xq+vSRekOZD2G7nkxFPv13cJHzb8d7BdA5mWPl/HdWAtqtI2LyXj USH+8o9jrOP/nPA8C/YOtR2TW5A3/Dc8+s9ECVNN3jfeIeAJQl46r68aO2VO80M8D55x yYbaWl24CMxTDIPecTPXzU4F8g8t4cYJQTY0iJWwvU22AAedPuQgc6luLiGwX81rag6W qPcg== X-Gm-Message-State: APzg51A17Ov47twfHMg514V3qXocEhqVpiG/PKlylJ/kTdb6RPxpZZPP 6gf431wWKxjnmXGgCAj6axbHAx1r X-Google-Smtp-Source: ANB0VdbpNOEuUanWj5bVqUTmDeWxbrNm+KLWHG/fYkXr3pvSIbXucixHajRhrYWyzCbEeM2pBhP+MA== X-Received: by 2002:a63:4f14:: with SMTP id d20-v6mr29062720pgb.121.1536029191652; Mon, 03 Sep 2018 19:46:31 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:31 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 20/25] staging: gdm724x: gdm_tty: Change return type to void Date: Tue, 4 Sep 2018 11:44:46 +0900 Message-Id: <1536029091-4426-21-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194642_493531_C2427FC6 X-CRM114-Status: GOOD ( 12.68 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/staging/gdm724x/gdm_tty.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c index 6e81369..d6348df 100644 --- a/drivers/staging/gdm724x/gdm_tty.c +++ b/drivers/staging/gdm724x/gdm_tty.c @@ -62,6 +62,7 @@ static int gdm_tty_install(struct tty_driver *driver, struct tty_struct *tty) return -ENODEV; mutex_lock(&gdm_table_lock); + gdm = gdm_table[ret][tty->index]; if (!gdm) { mutex_unlock(&gdm_table_lock); @@ -69,15 +70,9 @@ static int gdm_tty_install(struct tty_driver *driver, struct tty_struct *tty) } tty_port_get(&gdm->port); - - ret = tty_standard_install(driver, tty); - if (ret) { - tty_port_put(&gdm->port); - mutex_unlock(&gdm_table_lock); - return ret; - } - + tty_standard_install(driver, tty); tty->driver_data = gdm; + mutex_unlock(&gdm_table_lock); return 0;