From patchwork Tue Sep 4 02:44:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965716 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XYzDs4ZV"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RZRQSv09"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B760K7Mz9s1x for ; Tue, 4 Sep 2018 12:46:42 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=bR1YPguMBxvkOmFF7d/hxfbVT691Z01Dr0sTgMHfp/U=; b=XYzDs4ZVGdgfIQbAjs75a6BI3b cQMqRIg4AnLGjQE4m95u3gUAcOFGSSrpBl8HfPjaxcJofoTVQitcw+dMqIY96eSgURF/xO0j8Y1WW 5db8ekHLoD/MP6JaQCjRbzlUqxe53BQF6i7CSunLgncQN82Hcc9I6oCByF7wPZXBxTSxT4g1BwcJ4 0wn7JAsQP+oMdHM3qSA9M3VNibbFxLb+TZEByjnfyegGrZQoo2NmfeLo/1iv3NU+xuDRCTb2/ODKd +zXIAGVyET+gLu5tzRygYbCiqP03g02tkVDvK4f7e/t5P9K1Qk0Nk0rgh7+IxDiwL2lNDK/rPKprw CxYMYN+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MQ-0005hW-Tl; Tue, 04 Sep 2018 02:46:34 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MO-0005cK-MG for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:34 +0000 Received: by mail-pl1-x642.google.com with SMTP id u11-v6so890607plq.5 for ; Mon, 03 Sep 2018 19:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xyGQJoxJuf80yEKrzQZlMJDHZF2IdzTQKqa/0pjxKR0=; b=RZRQSv09uLpehuYeYRJL6n4Q+9TLDbL6dSMtuVoLpRQUlGaoKC3kWqooJlxuODUJWT EfjyJ3kJ60G5cT8s9NZDTPSizeufFEfjWlruXgokm32X0iCT3eu9lIo5jqhhH5+ttbeO GR3j2lN9B0dHCi0a56lQOyIemsWoT6FS3ziU66qQQnWt5CxPVv+CRiwV8/5xjBAfCN+8 XKr1tmgwZrB3BOblVlZXxLpY9jNPvVjHjOMnJxXeoFtqkuPtIlfPB6dJ0/Ha+jz2RNed 0qisgumt35KtA3dl7ef1Qhb7b3sUxCto3o2Q/KnL9k+Z5JRMzfkUcFPyurjUKkr1etDU 5blw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xyGQJoxJuf80yEKrzQZlMJDHZF2IdzTQKqa/0pjxKR0=; b=lbip7ID7GE8wmlpliU7IqXRnBw9AiGdFN69VaMrunWA56DBwPiU9CMNqTmml4xbyxi UKQU/nDgEMlCoB0qgVmvJrQIy1I2GUPWLupTEMhr+jNoGoQkDGCyv3ZrhzCOmfwsr/4D GOJY3tDVqhOfTln84TYLLwOaLIAUARbpZ9D1H8RgFJXmLV0NgxQW3seUTZkPfEjQoMU+ d7UHzHwCxpusgITwsafky3sQ7/8YPnWiXWlDCOaoIHuQ63AzKSmeBCDPZK/oVwfFPJdF NnIWssMs2Qn/XKvP8zaet/RetyPhi0vaR/6rjF/sIX8UWEEwPOErqWoBcBt/IU4Sj/6W Mo8A== X-Gm-Message-State: APzg51AFRv2Ef9BRPWzPRV1yyoByvurQkNdpZ+IwGmE/3KEzqyv2suJ3 SKHjiVBVw3IiVX+sS6zj8AnqDTvs X-Google-Smtp-Source: ANB0VdZmMidsyx2NWPQtHr5RHUY52+IJB6tCqYbLEiuS9YcnTq+cf27rQdkbGX1mUppJOaCVTPM1HQ== X-Received: by 2002:a17:902:7d83:: with SMTP id a3-v6mr31483472plm.0.1536029182110; Mon, 03 Sep 2018 19:46:22 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:21 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 18/25] mmc: core: sdio_uart: Change return type to void Date: Tue, 4 Sep 2018 11:44:44 +0900 Message-Id: <1536029091-4426-19-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194632_770575_77CC5B70 X-CRM114-Status: GOOD ( 13.02 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:642 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/mmc/core/sdio_uart.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/core/sdio_uart.c b/drivers/mmc/core/sdio_uart.c index 25e1130..b727186 100644 --- a/drivers/mmc/core/sdio_uart.c +++ b/drivers/mmc/core/sdio_uart.c @@ -731,14 +731,11 @@ static int sdio_uart_install(struct tty_driver *driver, struct tty_struct *tty) { int idx = tty->index; struct sdio_uart_port *port = sdio_uart_port_get(idx); - int ret = tty_standard_install(driver, tty); - if (ret == 0) - /* This is the ref sdio_uart_port get provided */ - tty->driver_data = port; - else - sdio_uart_port_put(port); - return ret; + tty_standard_install(driver, tty); + tty->driver_data = port; + + return 0; } /**