From patchwork Tue Sep 4 02:44:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965688 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bIm7qUHq"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Lbkt1Plx"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6D2Qcpz9s47 for ; Tue, 4 Sep 2018 12:45:56 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=9hc1ExoF1KE6ccwTRByzNcyZTGaQNkZEJ8eTWLuMy4I=; b=bIm7qUHq66/g19JRhc5NbIO1Bo AOOcEoQUWtWVGsL03Xo2pHSwmEJLMcvoQmPv06V7kDwS1x7erPEfs0wXucGAGFlz1eHMgbEiG4sBj +wkmIM2xeq4l1U5hU0Yu+C8Td1yklnrNZTVgb2UezbjnbXJZVHJjFf8Cfq1xvViOoKZXuENo98V45 BaCSUeCX9OyBNuO5s9SXe5waqJ5gen0w7ltnEfyYV4lCfLFEsdPzHCxKmzg7rYRmboWOWpHTY0JR2 h/eJUMpVuB6UWGSBqmq18lJQpbZgzVpG/+IAPux5AfuZftYRopqIAwEJPtV9y4nc6iz854+RYhJyw lcqTgGJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LY-0005Mm-VQ; Tue, 04 Sep 2018 02:45:40 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LV-0005Ha-VB for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:39 +0000 Received: by mail-pg1-x544.google.com with SMTP id y4-v6so879694pgp.9 for ; Mon, 03 Sep 2018 19:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tRdeqz+78ESzrb/nXjyBB6nqAAwIdJ3C0aGuFwzfOGg=; b=Lbkt1PlxVxfnVteEhPuZCMen61t/VT9dOcKgDaqKWjZ9uaMuAeJC1g2S72yEPZThiH jn/XI/ZimRlTHJ5JUCrUuzijODGVRgV7RwSfAuAuAn3cCwi0OXJSK+bZzA3MhA3ue3oY ykaxoEFwTzDAJQ+wAkTnPJvHL+0BRCoP5pq858TSLFDRjcfTbqFlgsLWvKmQM+HQwnQ7 Xehsi9XWThKKXhu/+NOcW2UJyNcJHzOhtB3OTO4mYsfsIPC/Rpe1cpr8st02yfxnYAyT yHPCG7i0rrekINkocDYZ180/nHSZDNCnJK6kxoFz/n+zpvk8K6uyyOrTGHsQyR+nM5qu ul7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tRdeqz+78ESzrb/nXjyBB6nqAAwIdJ3C0aGuFwzfOGg=; b=BLWb6DextHy5TOl5lFnLqUfck4+51YGs2BTd0nTEX2i2Bq1+HG7xPDL5KcyuGE+rtA RyXf2i45b+5bkot3vcxWsyw+wnYTCiYCoFpeuAi0L2LOWDq72/b0oETlXE+j52Dj3Q6d YDRujeVW/G0U+wWlXUE2cGlpoquEaDn2Fy/BK0YBkJLfWRDCTvSSIybl8nzDXIrdNGcr qo3inGAVrtd+II+z6RzfzIL+IFJcyI9p0oGdS7fO79BDNJCdJRLRTEFufLBfiBK38hBC IjtZRqURPL4WlYSVEe2F0rcQvtwIxo6S+sB+hZkf0ZTPYqGEBppZhBvpi1qHDRdIE6PJ vVPQ== X-Gm-Message-State: APzg51DKXbNMPKvMpTJ83LsCuo4tJjTExNCYVV1QKMnSLkYC05Qw1Iu/ 0YjCxGYm5jDUrVlCGOppMHVychMc X-Google-Smtp-Source: ANB0VdZxoeKVSzXKlsmQQoJgCTH/oH+q/pdwXVf1VJP0KvD27gLq8E/VdhUMgirGPdI+/A3Z958PYA== X-Received: by 2002:a63:e647:: with SMTP id p7-v6mr28111566pgj.218.1536029127255; Mon, 03 Sep 2018 19:45:27 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:26 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/25] tty: hvc: hvcs: Change return type to void Date: Tue, 4 Sep 2018 11:44:32 +0900 Message-Id: <1536029091-4426-7-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194538_061648_A7BB673A X-CRM114-Status: GOOD ( 12.23 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:544 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/hvc/hvcs.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c index cb4db1b..4dfa70c 100644 --- a/drivers/tty/hvc/hvcs.c +++ b/drivers/tty/hvc/hvcs.c @@ -1140,16 +1140,10 @@ static int hvcs_install(struct tty_driver *driver, struct tty_struct *tty) goto err_put; } - retval = tty_port_install(&hvcsd->port, driver, tty); - if (retval) - goto err_irq; + tty_port_install(&hvcsd->port, driver, tty); return 0; -err_irq: - spin_lock_irqsave(&hvcsd->lock, flags); - vio_disable_interrupts(hvcsd->vdev); - spin_unlock_irqrestore(&hvcsd->lock, flags); - free_irq(irq, hvcsd); + err_put: tty_port_put(&hvcsd->port);