diff mbox series

runltp: change the default cmdfile to exec when exec runltp -N

Message ID 1536022690-17612-1-git-send-email-yangx.jy@cn.fujitsu.com
State Accepted
Delegated to: Petr Vorel
Headers show
Series runltp: change the default cmdfile to exec when exec runltp -N | expand

Commit Message

Xiao Yang Sept. 4, 2018, 12:58 a.m. UTC
From: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>

when exec "runltp -N" and no command files were provided, the 
command file of "$LTPROOT/scenario_groups/network" should execute,
not the "$LTPROOT/scenario_groups/default".

Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
---
 runltp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Petr Vorel Sept. 3, 2018, 10:33 a.m. UTC | #1
Hi Sun,


> From: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>

> when exec "runltp -N" and no command files were provided, the 
> command file of "$LTPROOT/scenario_groups/network" should execute,
> not the "$LTPROOT/scenario_groups/default".

> Signed-off-by: Sun Lianwen <sunlw.fnst@cn.fujitsu.com>
> ---
>  runltp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/runltp b/runltp
> index 24ea94fe5..1810c9384 100755
> --- a/runltp
> +++ b/runltp
> @@ -609,7 +609,7 @@ main()

>  	SCENARIO_LISTS="$LTPROOT/scenario_groups/default"
>          if [ "$RUN_NETEST" -eq 1 ]; then
> -            SCENARIO_LISTS="$SCENARIO_LISTS $LTPROOT/scenario_groups/network"
> +            SCENARIO_LISTS="$LTPROOT/scenario_groups/network"
>          fi

>      # DO NOT INDENT/DEDENT!

Applied, thanks!

Using network.sh is the preferred way for running networking tests.
FYI runltp is somehow broken, we have long term goal to replace it with some
modern tool.


Kind regards,
Petr
diff mbox series

Patch

diff --git a/runltp b/runltp
index 24ea94fe5..1810c9384 100755
--- a/runltp
+++ b/runltp
@@ -609,7 +609,7 @@  main()
 
 	SCENARIO_LISTS="$LTPROOT/scenario_groups/default"
         if [ "$RUN_NETEST" -eq 1 ]; then
-            SCENARIO_LISTS="$SCENARIO_LISTS $LTPROOT/scenario_groups/network"
+            SCENARIO_LISTS="$LTPROOT/scenario_groups/network"
         fi
 
     # DO NOT INDENT/DEDENT!