| Message ID | 20180831143352.22970-2-cgxu519@gmx.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2,1/5] ext2: cache NULL when both default_acl and acl are NULL | expand |
On Fri 31-08-18 22:33:49, Chengguang Xu wrote: > default_acl and acl of newly created inode will be initiated > as ACL_NOT_CACHED in vfs function inode_init_always() and later > will be updated by calling xxx_init_acl() in specific filesystems. > Howerver, when default_acl and acl are NULL then they keep the value ^^^^ However > of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl > in this case. I'd rephrase the above as: ... then they keep the value of ACL_NOT_CACHED. This patch changes the code to cache NULL for acl / default_acl in this case to save unnecessary ACL lookup attempt. Otherwise the patch looks good to me. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > > Signed-off-by: Chengguang Xu <cgxu519@gmx.com> > --- > v1->v2: > - Coding style change. > > fs/ext4/acl.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c > index fb50f9aa6ead..c1d570ee1d9f 100644 > --- a/fs/ext4/acl.c > +++ b/fs/ext4/acl.c > @@ -284,12 +284,16 @@ ext4_init_acl(handle_t *handle, struct inode *inode, struct inode *dir) > error = __ext4_set_acl(handle, inode, ACL_TYPE_DEFAULT, > default_acl, XATTR_CREATE); > posix_acl_release(default_acl); > + } else { > + inode->i_default_acl = NULL; > } > if (acl) { > if (!error) > error = __ext4_set_acl(handle, inode, ACL_TYPE_ACCESS, > acl, XATTR_CREATE); > posix_acl_release(acl); > + } else { > + inode->i_acl = NULL; > } > return error; > } > -- > 2.17.1 > >
On 08/31/2018 10:33 PM, Chengguang Xu wrote: > default_acl and acl of newly created inode will be initiated > as ACL_NOT_CACHED in vfs function inode_init_always() and later > will be updated by calling xxx_init_acl() in specific filesystems. > Howerver, when default_acl and acl are NULL then they keep the value > of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl > in this case. > > Signed-off-by: Chengguang Xu <cgxu519@gmx.com> > --- > v1->v2: > - Coding style change. > > fs/ext4/acl.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c > index fb50f9aa6ead..c1d570ee1d9f 100644 > --- a/fs/ext4/acl.c > +++ b/fs/ext4/acl.c > @@ -284,12 +284,16 @@ ext4_init_acl(handle_t *handle, struct inode *inode, struct inode *dir) > error = __ext4_set_acl(handle, inode, ACL_TYPE_DEFAULT, > default_acl, XATTR_CREATE); > posix_acl_release(default_acl); > + } else { > + inode->i_default_acl = NULL; > } > if (acl) { > if (!error) > error = __ext4_set_acl(handle, inode, ACL_TYPE_ACCESS, > acl, XATTR_CREATE); > posix_acl_release(acl); > + } else { > + inode->i_acl = NULL; > } > return error; > } Hi Ted, Andreas Have you got chance to look at this patch? Thanks, Chengguang
On Wed, Sep 12, 2018 at 11:04:35PM +0800, cgxu519 wrote: > On 08/31/2018 10:33 PM, Chengguang Xu wrote: > > default_acl and acl of newly created inode will be initiated > > as ACL_NOT_CACHED in vfs function inode_init_always() and later > > will be updated by calling xxx_init_acl() in specific filesystems. > > Howerver, when default_acl and acl are NULL then they keep the value > > of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl > > in this case. > > > > Signed-off-by: Chengguang Xu <cgxu519@gmx.com> Applied, thanks. - Ted
diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c index fb50f9aa6ead..c1d570ee1d9f 100644 --- a/fs/ext4/acl.c +++ b/fs/ext4/acl.c @@ -284,12 +284,16 @@ ext4_init_acl(handle_t *handle, struct inode *inode, struct inode *dir) error = __ext4_set_acl(handle, inode, ACL_TYPE_DEFAULT, default_acl, XATTR_CREATE); posix_acl_release(default_acl); + } else { + inode->i_default_acl = NULL; } if (acl) { if (!error) error = __ext4_set_acl(handle, inode, ACL_TYPE_ACCESS, acl, XATTR_CREATE); posix_acl_release(acl); + } else { + inode->i_acl = NULL; } return error; }
default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl in this case. Signed-off-by: Chengguang Xu <cgxu519@gmx.com> --- v1->v2: - Coding style change. fs/ext4/acl.c | 4 ++++ 1 file changed, 4 insertions(+)