Patchwork Build more of libstdc++ exception throwing code with frame pointers (issue4539068)

login
register
mail settings
Submitter Paul Pluzhnikov
Date May 19, 2011, 5:46 p.m.
Message ID <20110519174601.259AE1909EC@elbrus2.mtv.corp.google.com>
Download mbox | patch
Permalink /patch/96440/
State New
Headers show

Comments

Paul Pluzhnikov - May 19, 2011, 5:46 p.m.
2011-05-19  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* libstdc++-v3/libsupc++/Makefile.am: Add -fno-omit-frame-pointer
	to vterminate.
	* libstdc++-v3/libsupc++/Makefile.in: Regenerate.



--
This patch is available for review at http://codereview.appspot.com/4539068
Paul Pluzhnikov - May 19, 2011, 6:24 p.m.
This patch is for google/integration branch.

Sorry about not setting the markers correctly.

Tested by doing a bootstrap build and verifying that
__gnu_cxx::__verbose_terminate_handler is built with frame pointers.

On Thu, May 19, 2011 at 10:46 AM, Paul Pluzhnikov
<ppluzhnikov@google.com> wrote:
> 2011-05-19  Paul Pluzhnikov  <ppluzhnikov@google.com>
>
>        * libstdc++-v3/libsupc++/Makefile.am: Add -fno-omit-frame-pointer
>        to vterminate.
>        * libstdc++-v3/libsupc++/Makefile.in: Regenerate.
Ollie Wild - May 19, 2011, 7:23 p.m.
Approved for google/integration (since Diego is on vacation).

Paul, please also merge this change only to google/main and google/gcc-4_6.

Thanks,
Ollie

On Thu, May 19, 2011 at 1:24 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
>
> This patch is for google/integration branch.
>
> Sorry about not setting the markers correctly.
>
> Tested by doing a bootstrap build and verifying that
> __gnu_cxx::__verbose_terminate_handler is built with frame pointers.
>
> On Thu, May 19, 2011 at 10:46 AM, Paul Pluzhnikov
> <ppluzhnikov@google.com> wrote:
> > 2011-05-19  Paul Pluzhnikov  <ppluzhnikov@google.com>
> >
> >        * libstdc++-v3/libsupc++/Makefile.am: Add -fno-omit-frame-pointer
> >        to vterminate.
> >        * libstdc++-v3/libsupc++/Makefile.in: Regenerate.
>
>
> --
> Paul Pluzhnikov

Patch

Index: libstdc++-v3/libsupc++/Makefile.in
===================================================================
--- libstdc++-v3/libsupc++/Makefile.in	(revision 173915)
+++ libstdc++-v3/libsupc++/Makefile.in	(working copy)
@@ -481,6 +481,7 @@ 
 # Google-specific pessimization
 eh_terminate.lo_no_omit_frame_pointer = -fno-omit-frame-pointer
 eh_throw.lo_no_omit_frame_pointer = -fno-omit-frame-pointer
+vterminate.lo_no_omit_frame_pointer = -fno-omit-frame-pointer
 all: all-am
 
 .SUFFIXES:
Index: libstdc++-v3/libsupc++/Makefile.am
===================================================================
--- libstdc++-v3/libsupc++/Makefile.am	(revision 173915)
+++ libstdc++-v3/libsupc++/Makefile.am	(working copy)
@@ -216,3 +216,4 @@ 
 # Google-specific pessimization
 eh_terminate.lo_no_omit_frame_pointer = -fno-omit-frame-pointer
 eh_throw.lo_no_omit_frame_pointer = -fno-omit-frame-pointer
+vterminate.lo_no_omit_frame_pointer = -fno-omit-frame-pointer