mbox

[PULL,0/9] Removal of deprecated options and improvements for qtests

Message ID 1535704738-8986-1-git-send-email-thuth@redhat.com
State New
Headers show

Pull-request

https://gitlab.com/huth/qemu.git tags/pull-request-2018-08-31

Message

Thomas Huth Aug. 31, 2018, 8:38 a.m. UTC
Hi Peter!

The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 16:44:20 +0100)

are available in the git repository at:

  https://gitlab.com/huth/qemu.git tags/pull-request-2018-08-31

for you to fetch changes up to ae6bf766048ecaeef90b85c4fb2b4db2aa0c094c:

  tests: add a qmp success-response test (2018-08-31 09:53:10 +0200)

----------------------------------------------------------------
Removal of deprecated options and improvements for the qtests
----------------------------------------------------------------

Eric Blake (1):
      tests/libqos: Utilize newer glib spawn check

Marc-André Lureau (4):
      tests: add qmp_assert_error_class()
      tests: add qmp/object-add-without-props test
      tests: add qmp/qom-set-without-value test
      tests: add a qmp success-response test

Thomas Huth (4):
      Remove the deprecated -balloon option
      Remove the deprecated -nodefconfig option
      Remove the deprecated options -startdate, -localtime and -rtc-td-hack
      net: Remove the deprecated -tftp, -bootp, -redir and -smb options

 docs/interop/live-block-operations.rst  |   4 +-
 docs/virtio-balloon-stats.txt           |   6 +-
 include/net/net.h                       |   3 -
 include/net/slirp.h                     |   4 -
 net/slirp.c                             | 132 +++++++-------------------------
 os-posix.c                              |   8 --
 qemu-deprecated.texi                    |  56 --------------
 qemu-options.hx                         |  36 +--------
 tests/drive_del-test.c                  |   5 +-
 tests/libqos/libqos.c                   |  12 +--
 tests/libqtest.c                        |  11 +++
 tests/libqtest.h                        |   9 +++
 tests/qapi-schema/qapi-schema-test.json |   2 +
 tests/qapi-schema/qapi-schema-test.out  |   2 +
 tests/qmp-cmd-test.c                    |  18 +++++
 tests/qmp-test.c                        |  87 +++++++++------------
 tests/test-qga.c                        |   9 +--
 tests/test-qmp-cmds.c                   |  17 ++++
 vl.c                                    | 132 ++++++--------------------------
 19 files changed, 158 insertions(+), 395 deletions(-)

Comments

Peter Maydell Sept. 24, 2018, 12:24 p.m. UTC | #1
On 31 August 2018 at 09:38, Thomas Huth <thuth@redhat.com> wrote:
>  Hi Peter!
>
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 16:44:20 +0100)
>
> are available in the git repository at:
>
>   https://gitlab.com/huth/qemu.git tags/pull-request-2018-08-31
>
> for you to fetch changes up to ae6bf766048ecaeef90b85c4fb2b4db2aa0c094c:
>
>   tests: add a qmp success-response test (2018-08-31 09:53:10 +0200)
>
> ----------------------------------------------------------------
> Removal of deprecated options and improvements for the qtests
> ----------------------------------------------------------------
>
> Eric Blake (1):
>       tests/libqos: Utilize newer glib spawn check
>
> Marc-André Lureau (4):
>       tests: add qmp_assert_error_class()
>       tests: add qmp/object-add-without-props test
>       tests: add qmp/qom-set-without-value test
>       tests: add a qmp success-response test
>
> Thomas Huth (4):
>       Remove the deprecated -balloon option
>       Remove the deprecated -nodefconfig option
>       Remove the deprecated options -startdate, -localtime and -rtc-td-hack
>       net: Remove the deprecated -tftp, -bootp, -redir and -smb options

Applied, thanks.

-- PMM
Thomas Huth Sept. 24, 2018, 12:29 p.m. UTC | #2
On 2018-09-24 14:24, Peter Maydell wrote:
> On 31 August 2018 at 09:38, Thomas Huth <thuth@redhat.com> wrote:
>>  Hi Peter!
>>
>> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>>
>>   Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 16:44:20 +0100)
>>
>> are available in the git repository at:
>>
>>   https://gitlab.com/huth/qemu.git tags/pull-request-2018-08-31
>>
>> for you to fetch changes up to ae6bf766048ecaeef90b85c4fb2b4db2aa0c094c:
>>
>>   tests: add a qmp success-response test (2018-08-31 09:53:10 +0200)
>>
>> ----------------------------------------------------------------
>> Removal of deprecated options and improvements for the qtests
>> ----------------------------------------------------------------
>>
>> Eric Blake (1):
>>       tests/libqos: Utilize newer glib spawn check
>>
>> Marc-André Lureau (4):
>>       tests: add qmp_assert_error_class()
>>       tests: add qmp/object-add-without-props test
>>       tests: add qmp/qom-set-without-value test
>>       tests: add a qmp success-response test
>>
>> Thomas Huth (4):
>>       Remove the deprecated -balloon option
>>       Remove the deprecated -nodefconfig option
>>       Remove the deprecated options -startdate, -localtime and -rtc-td-hack
>>       net: Remove the deprecated -tftp, -bootp, -redir and -smb options
> 
> Applied, thanks.

Oops, I was just about to send a v2 for this (since Markus had some
complaints about one of the patches)... I guess we should revert "tests:
add qmp/qom-set-without-value test" now...

 Thomas
Peter Maydell Sept. 24, 2018, 12:35 p.m. UTC | #3
On 24 September 2018 at 13:29, Thomas Huth <thuth@redhat.com> wrote:
> On 2018-09-24 14:24, Peter Maydell wrote:
>> Applied, thanks.
>
> Oops, I was just about to send a v2 for this (since Markus had some
> complaints about one of the patches)... I guess we should revert "tests:
> add qmp/qom-set-without-value test" now...

Yeah, I can revert that commit if you like.
(Unless "don't apply this" requests appear as followups to the
cover letter email, I won't see them.)

thanks
-- PMM
Thomas Huth Sept. 24, 2018, 12:38 p.m. UTC | #4
On 2018-09-24 14:35, Peter Maydell wrote:
> On 24 September 2018 at 13:29, Thomas Huth <thuth@redhat.com> wrote:
>> On 2018-09-24 14:24, Peter Maydell wrote:
>>> Applied, thanks.
>>
>> Oops, I was just about to send a v2 for this (since Markus had some
>> complaints about one of the patches)... I guess we should revert "tests:
>> add qmp/qom-set-without-value test" now...
> 
> Yeah, I can revert that commit if you like.

Yes, please.

> (Unless "don't apply this" requests appear as followups to the
> cover letter email, I won't see them.)

Ah, ok, sorry, didn't know that. I'll remember it for the next time.

 Thanks,
  Thomas
Peter Maydell Sept. 24, 2018, 1:35 p.m. UTC | #5
On 24 September 2018 at 13:38, Thomas Huth <thuth@redhat.com> wrote:
> On 2018-09-24 14:35, Peter Maydell wrote:
>> On 24 September 2018 at 13:29, Thomas Huth <thuth@redhat.com> wrote:
>>> On 2018-09-24 14:24, Peter Maydell wrote:
>>>> Applied, thanks.
>>>
>>> Oops, I was just about to send a v2 for this (since Markus had some
>>> complaints about one of the patches)... I guess we should revert "tests:
>>> add qmp/qom-set-without-value test" now...
>>
>> Yeah, I can revert that commit if you like.
>
> Yes, please.

Revert of 2b70ea92766f5a1a735a44e28c92cdfba3c4054f pushed to master.

thanks
-- PMM