| Message ID | 20180830101430.14862-1-asafka7@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [1/1] package/libsoup: needs host-python3 | expand |
Hello, On Thu, 30 Aug 2018 13:14:30 +0300, Asaf Kahlon wrote: > The tld-parser script in libsoup is now written in Python, > and needs python3 to run. > > Fixes: > http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258 > http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > > --- > > Maybe this specific script can run even with python2, but I don't think patchting the > "/usr/bin/env python3" line would be the right solution, especially considering > the fact that they already have python3-only code in recent commits. Meh, I was hoping we could avoid the host-python3 dependency :-/ Thomas
Hi Asaf, Thomas, Thomas Petazzoni writes: > On Thu, 30 Aug 2018 13:14:30 +0300, Asaf Kahlon wrote: >> The tld-parser script in libsoup is now written in Python, >> and needs python3 to run. >> >> Fixes: >> http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258 >> http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af >> >> Signed-off-by: Asaf Kahlon <asafka7@gmail.com> >> >> --- >> >> Maybe this specific script can run even with python2, but I don't think patchting the >> "/usr/bin/env python3" line would be the right solution, especially considering >> the fact that they already have python3-only code in recent commits. Which commits do you refer to? The get_apache_module_dirs.py script is only used by the meson build system, as far as I can see. > Meh, I was hoping we could avoid the host-python3 dependency :-/ Later commits remove this script entirely. So we might be able to remove this dependency in the future. baruch
Thomas, Baruch, Indeed I meant to the get_apache_module_dirs.py script. After looking deeper I can agree that the script seems to be used only with meson-context. Therefore, it seems like this dependency is relevant only for this version, and after we bump the version it will be removed. Asaf. On Thu, Aug 30, 2018 at 9:11 PM Baruch Siach <baruch@tkos.co.il> wrote: > Hi Asaf, Thomas, > > Thomas Petazzoni writes: > > On Thu, 30 Aug 2018 13:14:30 +0300, Asaf Kahlon wrote: > >> The tld-parser script in libsoup is now written in Python, > >> and needs python3 to run. > >> > >> Fixes: > >> > http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258 > >> > http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af > >> > >> Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > >> > >> --- > >> > >> Maybe this specific script can run even with python2, but I don't think > patchting the > >> "/usr/bin/env python3" line would be the right solution, especially > considering > >> the fact that they already have python3-only code in recent commits. > > Which commits do you refer to? The get_apache_module_dirs.py script is > only used by the meson build system, as far as I can see. > > > Meh, I was hoping we could avoid the host-python3 dependency :-/ > > Later commits remove this script entirely. So we might be able to remove > this dependency in the future. > > baruch > > -- > http://baruch.siach.name/blog/ ~. .~ Tk Open > Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > <div dir="ltr">Thomas, Baruch,<div><br></div><div>Indeed I meant to the get_apache_module_dirs.py script.</div><div>After looking deeper I can agree that the script seems to be used only with meson-context.</div><div><br></div><div>Therefore, it seems like this dependency is relevant only for this version, and after we bump the version it will be removed.</div><div><br></div><div>Asaf.</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Aug 30, 2018 at 9:11 PM Baruch Siach <<a href="mailto:baruch@tkos.co.il">baruch@tkos.co.il</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Asaf, Thomas,<br> <br> Thomas Petazzoni writes:<br> > On Thu, 30 Aug 2018 13:14:30 +0300, Asaf Kahlon wrote:<br> >> The tld-parser script in libsoup is now written in Python,<br> >> and needs python3 to run.<br> >> <br> >> Fixes:<br> >> <a href="http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258" rel="noreferrer" target="_blank">http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258</a><br> >> <a href="http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af" rel="noreferrer" target="_blank">http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af</a><br> >> <br> >> Signed-off-by: Asaf Kahlon <<a href="mailto:asafka7@gmail.com" target="_blank">asafka7@gmail.com</a>><br> >> <br> >> ---<br> >> <br> >> Maybe this specific script can run even with python2, but I don't think patchting the<br> >> "/usr/bin/env python3" line would be the right solution, especially considering<br> >> the fact that they already have python3-only code in recent commits.<br> <br> Which commits do you refer to? The get_apache_module_dirs.py script is<br> only used by the meson build system, as far as I can see.<br> <br> > Meh, I was hoping we could avoid the host-python3 dependency :-/<br> <br> Later commits remove this script entirely. So we might be able to remove<br> this dependency in the future.<br> <br> baruch<br> <br> -- <br> <a href="http://baruch.siach.name/blog/" rel="noreferrer" target="_blank">http://baruch.siach.name/blog/</a> ~. .~ Tk Open Systems<br> =}------------------------------------------------ooO--U--Ooo------------{=<br> - <a href="mailto:baruch@tkos.co.il" target="_blank">baruch@tkos.co.il</a> - tel: +972.52.368.4656, <a href="http://www.tkos.co.il" rel="noreferrer" target="_blank">http://www.tkos.co.il</a> -<br> _______________________________________________<br> buildroot mailing list<br> <a href="mailto:buildroot@busybox.net" target="_blank">buildroot@busybox.net</a><br> <a href="http://lists.busybox.net/mailman/listinfo/buildroot" rel="noreferrer" target="_blank">http://lists.busybox.net/mailman/listinfo/buildroot</a><br> </blockquote></div>
Hello, On Thu, 30 Aug 2018 13:14:30 +0300, Asaf Kahlon wrote: > Maybe this specific script can run even with python2, but I don't think patchting the > "/usr/bin/env python3" line would be the right solution, especially considering > the fact that they already have python3-only code in recent commits. I disagree: the tld-parser.py script was changed from python to python3 with no reason other than "hey, let's use Python 3", and the script works fine with Python 2. Plus in newer versions of libsoup, the script has been removed entirely, and libsoup relies on a separate library to provide TLD information. So for now, I've committed a change that simply reverts the script to use "python". Thanks for your initial research on this topic! Thomas
diff --git a/package/libsoup/libsoup.mk b/package/libsoup/libsoup.mk index 95bd682010..ef17f27fcd 100644 --- a/package/libsoup/libsoup.mk +++ b/package/libsoup/libsoup.mk @@ -14,7 +14,7 @@ LIBSOUP_INSTALL_STAGING = YES LIBSOUP_CONF_ENV = ac_cv_path_GLIB_GENMARSHAL=$(LIBGLIB2_HOST_BINARY) LIBSOUP_CONF_OPTS = --disable-glibtest --enable-vala=no --with-gssapi=no LIBSOUP_DEPENDENCIES = host-pkgconf host-libglib2 \ - libglib2 libxml2 sqlite host-intltool + libglib2 libxml2 sqlite host-intltool host-python3 ifeq ($(BR2_PACKAGE_LIBSOUP_GNOME),y) LIBSOUP_CONF_OPTS += --with-gnome
The tld-parser script in libsoup is now written in Python, and needs python3 to run. Fixes: http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258 http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af Signed-off-by: Asaf Kahlon <asafka7@gmail.com> --- Maybe this specific script can run even with python2, but I don't think patchting the "/usr/bin/env python3" line would be the right solution, especially considering the fact that they already have python3-only code in recent commits. --- package/libsoup/libsoup.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)