Message ID | 1305800661-4081-1-git-send-email-amwang@redhat.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
On Thu, 19 May 2011 18:24:17 +0800 Amerigo Wang <amwang@redhat.com> wrote: > In the previous patch I added NETDEV_ENSLAVE, now > we can notify netconsole when adding a device to a bridge too. > > By the way, s/netdev_bonding_change/call_netdevice_notifiers/ in > bond_main.c, since this is not bonding specific. > > Signed-off-by: WANG Cong <amwang@redhat.com> > Cc: Neil Horman <nhorman@redhat.com> > Is there a usage for this? What listens for this notification? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 19 May 2011 08:12:13 -0700 Stephen Hemminger <shemminger@linux-foundation.org> wrote: > On Thu, 19 May 2011 18:24:17 +0800 > Amerigo Wang <amwang@redhat.com> wrote: > > > In the previous patch I added NETDEV_ENSLAVE, now > > we can notify netconsole when adding a device to a bridge too. > > > > By the way, s/netdev_bonding_change/call_netdevice_notifiers/ in > > bond_main.c, since this is not bonding specific. > > > > Signed-off-by: WANG Cong <amwang@redhat.com> > > Cc: Neil Horman <nhorman@redhat.com> > > > > Is there a usage for this? What listens for this notification? Never mind it was in the first patch which you did not send. You should always put a number on group of patches and send to all parties. Also, sending networking patches to LKML is a waste of bandwidth please don't bother. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
于 2011年05月20日 00:04, Stephen Hemminger 写道: > On Thu, 19 May 2011 08:12:13 -0700 > Stephen Hemminger<shemminger@linux-foundation.org> wrote: > >> On Thu, 19 May 2011 18:24:17 +0800 >> Amerigo Wang<amwang@redhat.com> wrote: >> >>> In the previous patch I added NETDEV_ENSLAVE, now >>> we can notify netconsole when adding a device to a bridge too. >>> >>> By the way, s/netdev_bonding_change/call_netdevice_notifiers/ in >>> bond_main.c, since this is not bonding specific. >>> >>> Signed-off-by: WANG Cong<amwang@redhat.com> >>> Cc: Neil Horman<nhorman@redhat.com> >>> >> >> Is there a usage for this? What listens for this notification? > > Never mind it was in the first patch which you did not send. > You should always put a number on group of patches and send > to all parties. Ah, sorry, my script simply run get_maintainers.pl to get the Cc list, so bridge list was not in included in the first patch. > > Also, sending networking patches to LKML is a waste of bandwidth > please don't bother. Ok, will fix my script. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index b9c70c5..765fdcf 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1640,7 +1640,7 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev) } } - netdev_bonding_change(slave_dev, NETDEV_ENSLAVE); + call_netdevice_notifiers(NETDEV_ENSLAVE, slave_dev); /* If this is the first slave, then we need to set the master's hardware * address to be the same as the slave's. */ diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 5dbdfdf..b44fae5 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -338,6 +338,8 @@ int br_add_if(struct net_bridge *br, struct net_device *dev) if (IS_ERR(p)) return PTR_ERR(p); + call_netdevice_notifiers(NETDEV_ENSLAVE, dev); + err = dev_set_promiscuity(dev, 1); if (err) goto put_back;
In the previous patch I added NETDEV_ENSLAVE, now we can notify netconsole when adding a device to a bridge too. By the way, s/netdev_bonding_change/call_netdevice_notifiers/ in bond_main.c, since this is not bonding specific. Signed-off-by: WANG Cong <amwang@redhat.com> Cc: Neil Horman <nhorman@redhat.com> --- drivers/net/bonding/bond_main.c | 2 +- net/bridge/br_if.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html