| Message ID | 20180829073324.36866-1-yinbo.zhu@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v1] arm64: dts: dwc3: Add description of 'configure-gfladj' | expand |
On Wed, Aug 29, 2018 at 03:33:24PM +0800, Yinbo Zhu wrote: > This patch is to add description of 'configure-gfladj' to binding > so that configuring devicetree > > Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com> Ah, okay. You just started documenting the binding. So please send me dts patch only after the corresponding bindings and driver code are accepted. Shawn > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt > index 3e4c38b..40c6568 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -101,6 +101,7 @@ Optional properties: > When just one value, which means INCRX burst mode enabled. When > more than one value, which means undefined length INCR burst type > enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256. > + - configure-gfladj: determine whether frame length adjustment is required or not. > > - in addition all properties from usb-xhci.txt from the current directory are > supported as well > -- > 1.7.1 >
On Wed, Aug 29, 2018 at 2:38 AM Yinbo Zhu <yinbo.zhu@nxp.com> wrote: > > This patch is to add description of 'configure-gfladj' to binding > so that configuring devicetree > > Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com> This patch should be sent to the DWC3 driver maintainer to review and probably merged through usb tree. You shouldn't use the arm64: dts: prefix for this patch either. > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt > index 3e4c38b..40c6568 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -101,6 +101,7 @@ Optional properties: > When just one value, which means INCRX burst mode enabled. When > more than one value, which means undefined length INCR burst type > enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256. > + - configure-gfladj: determine whether frame length adjustment is required or not. > > - in addition all properties from usb-xhci.txt from the current directory are > supported as well > -- > 1.7.1 >
Yinbo Zhu <yinbo.zhu@nxp.com> writes: > This patch is to add description of 'configure-gfladj' to binding > so that configuring devicetree commit log looks incomplete.
On Wed, Aug 29, 2018 at 03:33:24PM +0800, Yinbo Zhu wrote: > This patch is to add description of 'configure-gfladj' to binding > so that configuring devicetree Not a complete sentence. The subject should be: "dt-bindings: usb: ..." > > Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com> > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt > index 3e4c38b..40c6568 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -101,6 +101,7 @@ Optional properties: > When just one value, which means INCRX burst mode enabled. When > more than one value, which means undefined length INCR burst type > enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256. > + - configure-gfladj: determine whether frame length adjustment is required or not. Needs a vendor prefix. What's the type? bool? What determines if this is needed. If fixed for an SoC or IP version, then the compatible string should imply this. Rob
diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt index 3e4c38b..40c6568 100644 --- a/Documentation/devicetree/bindings/usb/dwc3.txt +++ b/Documentation/devicetree/bindings/usb/dwc3.txt @@ -101,6 +101,7 @@ Optional properties: When just one value, which means INCRX burst mode enabled. When more than one value, which means undefined length INCR burst type enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256. + - configure-gfladj: determine whether frame length adjustment is required or not. - in addition all properties from usb-xhci.txt from the current directory are supported as well
This patch is to add description of 'configure-gfladj' to binding so that configuring devicetree Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com> --- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)