Message ID | alpine.LNX.2.20.13.1808272018350.10521@monopod.intra.ispras.ru |
---|---|
State | New |
Headers | show |
Series | [1/2] configure.ac: use 'suppress' instead of 'don't' | expand |
Alexander Monakov <amonakov@ispras.ru> writes: > Hello, > > If patch 2/2 is approved, I'd like to apply this alongside with that. > > Use positive form ("suppress") rather than negative ("don't") to explain > the option, because using the option results in passing -Wno-format > rather than not passing -Wformat. I felt confused when trying to follow > the logic of the option, and this change would clarify things for me. > > Unpaired apostrophe in "don't" also happens to break syntax matching in Vim. > > * configure.ac (build-format-warnings): Reword help text. > * configure: Regenerate. > > diff --git a/gcc/configure b/gcc/configure > index b7a8e364377..be6f0be6ba2 100755 > --- a/gcc/configure > +++ b/gcc/configure > @@ -1603,7 +1603,7 @@ Optional Features: > texinfo bison or flex > --disable-largefile omit support for large files > --disable-build-format-warnings > - don't use -Wformat while building GCC > + suppress -Wformat while building GCC > --enable-werror-always enable -Werror despite compiler version > --enable-checking[=LIST] > enable expensive run-time checks. With LIST, enable > diff --git a/gcc/configure.ac b/gcc/configure.ac > index 65f9c92ec85..a693bfa0e31 100644 > --- a/gcc/configure.ac > +++ b/gcc/configure.ac > @@ -478,7 +478,7 @@ AC_SUBST(aliasing_flags) > > # In stage 1, disable -Wformat warnings from old GCCs about new % codes > AC_ARG_ENABLE(build-format-warnings, > - AS_HELP_STRING([--disable-build-format-warnings],[don't use -Wformat while building GCC]), > + AS_HELP_STRING([--disable-build-format-warnings],[suppress -Wformat while building GCC]), > [],[enable_build_format_warnings=yes]) > AS_IF([test $enable_build_format_warnings = no], > [wf_opt=-Wno-format],[wf_opt=]) This is OK independently of 2/2. (And thanks for working on 2/2.) Richard
diff --git a/gcc/configure b/gcc/configure index b7a8e364377..be6f0be6ba2 100755 --- a/gcc/configure +++ b/gcc/configure @@ -1603,7 +1603,7 @@ Optional Features: texinfo bison or flex --disable-largefile omit support for large files --disable-build-format-warnings - don't use -Wformat while building GCC + suppress -Wformat while building GCC --enable-werror-always enable -Werror despite compiler version --enable-checking[=LIST] enable expensive run-time checks. With LIST, enable diff --git a/gcc/configure.ac b/gcc/configure.ac index 65f9c92ec85..a693bfa0e31 100644 --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -478,7 +478,7 @@ AC_SUBST(aliasing_flags) # In stage 1, disable -Wformat warnings from old GCCs about new % codes AC_ARG_ENABLE(build-format-warnings, - AS_HELP_STRING([--disable-build-format-warnings],[don't use -Wformat while building GCC]), + AS_HELP_STRING([--disable-build-format-warnings],[suppress -Wformat while building GCC]), [],[enable_build_format_warnings=yes]) AS_IF([test $enable_build_format_warnings = no], [wf_opt=-Wno-format],[wf_opt=])