Patchwork [Natty,master] SRU: Add support for Beagle XM rev B and C

login
register
mail settings
Submitter Ricardo Salveti de Araujo
Date May 18, 2011, 9:25 p.m.
Message ID <BANLkTikQxYs5w1zN7rjhkbq6O5CDJv8C6w@mail.gmail.com>
Download mbox
Permalink /patch/96254/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/rsalveti/ubuntu-natty.git master-xmbc

Comments

Ricardo Salveti de Araujo - May 18, 2011, 9:25 p.m.
SRU Justification:

Impact: Owners of Beagle xM rev C (newer ones) can't boot with current
Natty's kernel.

Fix: Detect the rev C revision and proper initialize it (like older xM).

Testcase: Boot the kernel with a Beagle xM rev C board. If you boot
fine you'll also be able to see the detected revision at dmesg, like:
ubuntu@omap:~$ dmesg | grep Beagle
[ 0.000000] Machine: OMAP3 Beagle Board
[ 0.154510] OMAP3 Beagle Rev: xM C

BugLink: http://bugs.launchpad.net/bugs/770679

The following changes since commit 4a93549299ec1b4b5c137449a13b5efd535487d9:

  Linux 2.6.38.6 (2011-05-10 08:43:04 -0600)

are available in the git repository at:
  git://kernel.ubuntu.com/rsalveti/ubuntu-natty.git master-xmbc

Robert Nelson (3):
      omap3: beagle: detect new xM revision B
      omap3: beagle: detect new xM revision C
      omap3: beagle: if rev unknown, assume xM revision C

 arch/arm/mach-omap2/board-omap3beagle.c |   32 +++++++++++++++++++++++-------
 1 files changed, 24 insertions(+), 8 deletions(-)
Leann Ogasawara - May 23, 2011, 2:03 p.m.
On Wed, 2011-05-18 at 18:25 -0300, Ricardo Salveti wrote:
> SRU Justification:
> 
> Impact: Owners of Beagle xM rev C (newer ones) can't boot with current
> Natty's kernel.
> 
> Fix: Detect the rev C revision and proper initialize it (like older xM).
> 
> Testcase: Boot the kernel with a Beagle xM rev C board. If you boot
> fine you'll also be able to see the detected revision at dmesg, like:
> ubuntu@omap:~$ dmesg | grep Beagle
> [ 0.000000] Machine: OMAP3 Beagle Board
> [ 0.154510] OMAP3 Beagle Rev: xM C
> 
> BugLink: http://bugs.launchpad.net/bugs/770679
> 
> The following changes since commit 4a93549299ec1b4b5c137449a13b5efd535487d9:
> 
>   Linux 2.6.38.6 (2011-05-10 08:43:04 -0600)
> 
> are available in the git repository at:
>   git://kernel.ubuntu.com/rsalveti/ubuntu-natty.git master-xmbc
> 
> Robert Nelson (3):
>       omap3: beagle: detect new xM revision B
>       omap3: beagle: detect new xM revision C
>       omap3: beagle: if rev unknown, assume xM revision C
> 
>  arch/arm/mach-omap2/board-omap3beagle.c |   32 +++++++++++++++++++++++-------
>  1 files changed, 24 insertions(+), 8 deletions(-)

Looks reasonable for SRU.  Just curious what the current status is for
the patches landing upstream?

Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>
robertcnelson@gmail.com - May 23, 2011, 2:32 p.m.
On Mon, May 23, 2011 at 9:03 AM, Leann Ogasawara
<leann.ogasawara@canonical.com> wrote:
> On Wed, 2011-05-18 at 18:25 -0300, Ricardo Salveti wrote:
>> SRU Justification:
>>
>> Impact: Owners of Beagle xM rev C (newer ones) can't boot with current
>> Natty's kernel.
>>
>> Fix: Detect the rev C revision and proper initialize it (like older xM).
>>
>> Testcase: Boot the kernel with a Beagle xM rev C board. If you boot
>> fine you'll also be able to see the detected revision at dmesg, like:
>> ubuntu@omap:~$ dmesg | grep Beagle
>> [ 0.000000] Machine: OMAP3 Beagle Board
>> [ 0.154510] OMAP3 Beagle Rev: xM C
>>
>> BugLink: http://bugs.launchpad.net/bugs/770679
>>
>> The following changes since commit 4a93549299ec1b4b5c137449a13b5efd535487d9:
>>
>>   Linux 2.6.38.6 (2011-05-10 08:43:04 -0600)
>>
>> are available in the git repository at:
>>   git://kernel.ubuntu.com/rsalveti/ubuntu-natty.git master-xmbc
>>
>> Robert Nelson (3):
>>       omap3: beagle: detect new xM revision B
>>       omap3: beagle: detect new xM revision C
>>       omap3: beagle: if rev unknown, assume xM revision C
>>
>>  arch/arm/mach-omap2/board-omap3beagle.c |   32 +++++++++++++++++++++++-------
>>  1 files changed, 24 insertions(+), 8 deletions(-)
>
> Looks reasonable for SRU.  Just curious what the current status is for
> the patches landing upstream?
>
> Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>
>

Koen's been posting them to l-o/l-a, but it might be too late for 40,
then with all the current arm cleanup's they will need to be tweaked
again for 41..

Regards,
Tim Gardner - May 25, 2011, 3:45 p.m.
On 05/23/2011 08:03 AM, Leann Ogasawara wrote:
> On Wed, 2011-05-18 at 18:25 -0300, Ricardo Salveti wrote:
>> SRU Justification:
>>
>> Impact: Owners of Beagle xM rev C (newer ones) can't boot with current
>> Natty's kernel.
>>
>> Fix: Detect the rev C revision and proper initialize it (like older xM).
>>
>> Testcase: Boot the kernel with a Beagle xM rev C board. If you boot
>> fine you'll also be able to see the detected revision at dmesg, like:
>> ubuntu@omap:~$ dmesg | grep Beagle
>> [ 0.000000] Machine: OMAP3 Beagle Board
>> [ 0.154510] OMAP3 Beagle Rev: xM C
>>
>> BugLink: http://bugs.launchpad.net/bugs/770679
>>
>> The following changes since commit 4a93549299ec1b4b5c137449a13b5efd535487d9:
>>
>>    Linux 2.6.38.6 (2011-05-10 08:43:04 -0600)
>>
>> are available in the git repository at:
>>    git://kernel.ubuntu.com/rsalveti/ubuntu-natty.git master-xmbc
>>
>> Robert Nelson (3):
>>        omap3: beagle: detect new xM revision B
>>        omap3: beagle: detect new xM revision C
>>        omap3: beagle: if rev unknown, assume xM revision C
>>
>>   arch/arm/mach-omap2/board-omap3beagle.c |   32 +++++++++++++++++++++++-------
>>   1 files changed, 24 insertions(+), 8 deletions(-)
>
> Looks reasonable for SRU.  Just curious what the current status is for
> the patches landing upstream?
>
> Acked-by: Leann Ogasawara<leann.ogasawara@canonical.com>
>
>
>

Looks straightforward. Applied as SAUCE patches to Natty and Oneiric 
master-next

rtg