From patchwork Wed May 18 20:57:23 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Gardiner X-Patchwork-Id: 96236 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0D4CF1007F8 for ; Thu, 19 May 2011 07:07:00 +1000 (EST) Received: from canuck.infradead.org ([2001:4978:20e::1]) by bombadil.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QMnwA-0005EZ-ON; Wed, 18 May 2011 21:05:46 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QMnw8-0005pr-Ri; Wed, 18 May 2011 21:05:44 +0000 Received: from na3sys009aog114.obsmtp.com ([74.125.149.211]) by canuck.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1QMnw5-0005pY-JC for linux-mtd@lists.infradead.org; Wed, 18 May 2011 21:05:42 +0000 Received: from mail-yw0-f44.google.com ([209.85.213.44]) (using TLSv1) by na3sys009aob114.postini.com ([74.125.148.12]) with SMTP ID DSNKTdQ0oMGp4zlSs03PgVOv/OZRU319iW66@postini.com; Wed, 18 May 2011 14:05:38 PDT Received: by mail-yw0-f44.google.com with SMTP id 31so983109ywp.17 for ; Wed, 18 May 2011 14:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nanometrics.ca; s=google; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=u+kQJVrhSBBbnteNwyWf3O1MEIVAaL8vM4r4he93NGU=; b=YSonLsOMjOXYzNjBQ4d0VnbBWAk8HJsa3oh86ychAISy+r2Z7VO/CpHhqhVphIdHYA 55YxMZNUoxGzMK5EpBrLAuZ2uaifR6dGOICE+PBcLP1HnE62g35iz+ru9Qyap2Ffkuqd EdDmDUZLFFeoFNX2jS4JQ0XKCm1y5QM0odyVk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=nanometrics.ca; s=google; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=ctE30tQGT32yGY9L5V2mBwkVx3liaD2zLKh2c6habvFZSpIkjE0r4ERdHCI+FtJRQO 3AiSENYJTHdeKAYG7yAxAu7MXHE19NltsocmqEdc6smWVGWzDJPfjaFnj+P0hunPSJHg vAJtsjS2Egp1jhGlQw3d1AtzZtsMbxptdz/vs= Received: by 10.236.192.228 with SMTP id i64mr2708769yhn.111.1305752245167; Wed, 18 May 2011 13:57:25 -0700 (PDT) Received: from localhost.localdomain ([206.191.47.130]) by mx.google.com with ESMTPS id t45sm849912yhm.66.2011.05.18.13.57.24 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 May 2011 13:57:24 -0700 (PDT) From: Ben Gardiner To: Artem Bityutskiy Subject: [PATCH] mkfs.ubifs: free-space-fixup: note supported kernels Date: Wed, 18 May 2011 16:57:23 -0400 Message-Id: <1305752243-4095-1-git-send-email-bengardiner@nanometrics.ca> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1305147748-13632-1-git-send-email-mlcreech@gmail.com> References: <1305147748-13632-1-git-send-email-mlcreech@gmail.com> X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110518_170541_868581_E4FCA1C0 X-CRM114-Status: GOOD ( 13.40 ) X-Spam-Score: -2.4 (--) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-2.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.211 listed in list.dnswl.org] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: linux-mtd@lists.infradead.org, "Matthew L. Creech" X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The free space fixup flag will only have an action taken on up-to-date kernels. Note in the help text and comment that kernel release 2.6.39 is required for the free space fixup to be performed. Signed-off-by: Ben Gardiner CC: Matthew L. Creech --- mkfs.ubifs/mkfs.ubifs.c | 4 +++- mkfs.ubifs/ubifs-media.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/mkfs.ubifs/mkfs.ubifs.c b/mkfs.ubifs/mkfs.ubifs.c index 96e17a3..f4cf09d 100644 --- a/mkfs.ubifs/mkfs.ubifs.c +++ b/mkfs.ubifs/mkfs.ubifs.c @@ -184,7 +184,9 @@ static const char *helptext = " how many percent better zlib should compress to make\n" " mkfs.ubifs use zlib instead of LZO (default 20%)\n" "-f, --fanout=NUM fanout NUM (default: 8)\n" -"-F, --space-fixup fixup free space on first mount (needed for some NANDs)\n" +"-F, --space-fixup fixup free space on first mount (needed for some NANDs;\n" +" the free space fixup will be performed only by kernel\n" +" releases 2.6.39 or greater)\n" "-k, --keyhash=TYPE key hash type - \"r5\" or \"test\" (default: \"r5\")\n" "-p, --orph-lebs=COUNT count of erase blocks for orphans (default: 1)\n" "-D, --devtable=FILE use device table FILE\n" diff --git a/mkfs.ubifs/ubifs-media.h b/mkfs.ubifs/ubifs-media.h index fe62d0e..a710589 100644 --- a/mkfs.ubifs/ubifs-media.h +++ b/mkfs.ubifs/ubifs-media.h @@ -374,6 +374,8 @@ enum { * * UBIFS_FLG_BIGLPT: if "big" LPT model is used if set * UBIFS_FLG_SPACE_FIXUP: first-mount "fixup" of free space within LEBs needed + * the free space fixup will be performed only by kernel + * releases 2.6.39 or greater. */ enum { UBIFS_FLG_BIGLPT = 0x02,