Message ID | 20180824170422.5783-3-peter.maydell@linaro.org |
---|---|
State | New |
Headers | show |
Series | Drop old_mmio accessor support | expand |
On 08/24/2018 10:04 AM, Peter Maydell wrote: > We've now removed the 'old_mmio' member from MemoryRegionOps, > so we can perform the copy as a simple struct copy rather > than having to do it via a memberwise copy. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/nvram/fw_cfg.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index d79a568f540..b3c9b066239 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -1109,12 +1109,7 @@ static void fw_cfg_mem_realize(DeviceState *dev, Error **errp) sysbus_init_mmio(sbd, &s->ctl_iomem); if (s->data_width > data_ops->valid.max_access_size) { - /* memberwise copy because the "old_mmio" member is const */ - s->wide_data_ops.read = data_ops->read; - s->wide_data_ops.write = data_ops->write; - s->wide_data_ops.endianness = data_ops->endianness; - s->wide_data_ops.valid = data_ops->valid; - s->wide_data_ops.impl = data_ops->impl; + s->wide_data_ops = *data_ops; s->wide_data_ops.valid.max_access_size = s->data_width; s->wide_data_ops.impl.max_access_size = s->data_width;
We've now removed the 'old_mmio' member from MemoryRegionOps, so we can perform the copy as a simple struct copy rather than having to do it via a memberwise copy. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/nvram/fw_cfg.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)