Patchwork [U-Boot,GIT,PULL] Please pull u-boot-mpc85xx.git

login
register
mail settings
Submitter Kumar Gala
Date May 18, 2011, 2:45 p.m.
Message ID <alpine.LFD.2.00.1105180943350.20926@right.am.freescale.net>
Download mbox
Permalink /patch/96176/
State Accepted
Delegated to: Kumar Gala
Headers show

Pull-request

git://git.denx.de/u-boot-mpc85xx.git master

Comments

Kumar Gala - May 18, 2011, 2:45 p.m.
The following changes since commit 0ea91423f47461bf7eaed2d4aff198076dd07fd5:

  Merge branch 'master' of git://git.denx.de/u-boot-arm (2011-05-18 14:31:56 +0200)

are available in the git repository at:

  git://git.denx.de/u-boot-mpc85xx.git master

Kumar Gala (1):
      powerpc/85xx: Add P2041 processor support

Mingkai Hu (1):
      powerpc/p2040: Add various p2040 specific information

Ramneek Mehresh (1):
      qoriq/p1_p2_rdb: Add Dual Role USB support macro for P1020RDB

Shaohui Xie (2):
      powerpc/85xx: Enable eSPI support on corenet ds boards
      powerpc/85xx: add support for env in MMC/SPI on corenet ds boards

 arch/powerpc/cpu/mpc85xx/Makefile         |    6 ++
 arch/powerpc/cpu/mpc85xx/p2040_ids.c      |  106 +++++++++++++++++++++++++++++
 arch/powerpc/cpu/mpc85xx/p2040_serdes.c   |   24 +++++++
 arch/powerpc/cpu/mpc8xxx/cpu.c            |    2 +
 arch/powerpc/include/asm/config_mpc85xx.h |   15 ++++
 arch/powerpc/include/asm/processor.h      |    2 +
 board/freescale/common/Makefile           |    2 +
 boards.cfg                                |    7 ++-
 include/configs/P1_P2_RDB.h               |    1 +
 include/configs/corenet_ds.h              |   40 +++++++++--
 10 files changed, 196 insertions(+), 9 deletions(-)
 create mode 100644 arch/powerpc/cpu/mpc85xx/p2040_ids.c
Wolfgang Denk - May 18, 2011, 9:17 p.m.
Dear Kumar Gala,

In message <alpine.LFD.2.00.1105180943350.20926@right.am.freescale.net> you wrote:
> The following changes since commit 0ea91423f47461bf7eaed2d4aff198076dd07fd5:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-arm (2011-05-18 14:31:56 +0200)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-mpc85xx.git master
> 
> Kumar Gala (1):
>       powerpc/85xx: Add P2041 processor support

Submitted 05/13.

> Mingkai Hu (1):
>       powerpc/p2040: Add various p2040 specific information
> 
> Ramneek Mehresh (1):
>       qoriq/p1_p2_rdb: Add Dual Role USB support macro for P1020RDB

Submitted 05/10

> Shaohui Xie (2):
>       powerpc/85xx: Enable eSPI support on corenet ds boards

Submitted 05/12

>       powerpc/85xx: add support for env in MMC/SPI on corenet ds boards

Submitted 05/12


Sorry - most of these patches were submitted about a month after the
merge window was closed, and they clearly add new features, i. e.
these are not bug fixes.  They will not go into this release.

Not pulled.

Please stick to the rules!


Best regards,

Wolfgang Denk
Kumar Gala - May 19, 2011, 4 a.m.
On May 18, 2011, at 4:17 PM, Wolfgang Denk wrote:

> Dear Kumar Gala,
> 
> In message <alpine.LFD.2.00.1105180943350.20926@right.am.freescale.net> you wrote:
>> The following changes since commit 0ea91423f47461bf7eaed2d4aff198076dd07fd5:
>> 
>>  Merge branch 'master' of git://git.denx.de/u-boot-arm (2011-05-18 14:31:56 +0200)
>> 
>> are available in the git repository at:
>> 
>>  git://git.denx.de/u-boot-mpc85xx.git master
>> 
>> Kumar Gala (1):
>>      powerpc/85xx: Add P2041 processor support
> 
> Submitted 05/13.
> 
>> Mingkai Hu (1):
>>      powerpc/p2040: Add various p2040 specific information
>> 
>> Ramneek Mehresh (1):
>>      qoriq/p1_p2_rdb: Add Dual Role USB support macro for P1020RDB
> 
> Submitted 05/10
> 
>> Shaohui Xie (2):
>>      powerpc/85xx: Enable eSPI support on corenet ds boards
> 
> Submitted 05/12
> 
>>      powerpc/85xx: add support for env in MMC/SPI on corenet ds boards
> 
> Submitted 05/12
> 
> 
> Sorry - most of these patches were submitted about a month after the
> merge window was closed, and they clearly add new features, i. e.
> these are not bug fixes.  They will not go into this release.
> 
> Not pulled.
> 
> Please stick to the rules!

Understood, however I would like to see the eSPI & MMC/SPI patches go into this release as it prevents introduction of a build target 'P4080DS_RAMBOOT_PBL' that we remove right away after the release.  As these two patches only impact a FSL specific board the risk is limited to the one board family.

- k
Wolfgang Denk - May 19, 2011, 5:19 a.m.
Dear Kumar Gala,

In message <6E487A2B-B7EA-474E-A8DB-0D5639391078@kernel.crashing.org> you wrote:
> 
> > Sorry - most of these patches were submitted about a month after the
> > merge window was closed, and they clearly add new features, i. e.
> > these are not bug fixes.  They will not go into this release.
> > 
> > Not pulled.
> > 
> > Please stick to the rules!
> 
> Understood, however I would like to see the eSPI & MMC/SPI patches go
> into this release as it prevents introduction of a build target
> 'P4080DS_RAMBOOT_PBL' that we remove right away after the release.  As
> these two patches only impact a FSL specific board the risk is limited
> to the one board family.

I can't parse that. "It prevents introduction of a build target
'P4080DS_RAMBOOT_PBL'' - but we already have that in mainline?
"that we remove right away after the release" - if you remove it after
the release, then it should be sufficient to add these patches after
right before the removal of this thing?

I don't consider this a bug fix.

Best regards,

Wolfgang Denk
Kumar Gala - May 19, 2011, 6:49 a.m.
On May 19, 2011, at 12:19 AM, Wolfgang Denk wrote:

> Dear Kumar Gala,
> 
> In message <6E487A2B-B7EA-474E-A8DB-0D5639391078@kernel.crashing.org> you wrote:
>> 
>>> Sorry - most of these patches were submitted about a month after the
>>> merge window was closed, and they clearly add new features, i. e.
>>> these are not bug fixes.  They will not go into this release.
>>> 
>>> Not pulled.
>>> 
>>> Please stick to the rules!
>> 
>> Understood, however I would like to see the eSPI & MMC/SPI patches go
>> into this release as it prevents introduction of a build target
>> 'P4080DS_RAMBOOT_PBL' that we remove right away after the release.  As
>> these two patches only impact a FSL specific board the risk is limited
>> to the one board family.
> 
> I can't parse that. "It prevents introduction of a build target
> 'P4080DS_RAMBOOT_PBL'' - but we already have that in mainline?
> "that we remove right away after the release" - if you remove it after
> the release, then it should be sufficient to add these patches after
> right before the removal of this thing?

I'm saying previous patches that went into this window added the build target P4080DS_RAMBOOT_PBL.  Rather than having this release add it and the next one remove, I'd prefer to just have these two patches applied for this release cycle to have the targets for _SPIFLASH and _SDCARD boot.

> I don't consider this a bug fix.

I know its not a bug fix.

- k