opal-prd: hservice: Enable hservice->wakeup() in BMC

Message ID 1535086109-4055-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com
State Superseded
Headers show
Series
  • opal-prd: hservice: Enable hservice->wakeup() in BMC
Related show

Checks

Context Check Description
snowpatch_ozlabs/make_check success Test make_check on branch master
snowpatch_ozlabs/apply_patch success master/apply_patch Successfully applied

Commit Message

Shilpasri G Bhat Aug. 24, 2018, 4:48 a.m.
HBRT has started to use host special wakeup register to do special
wakeup of the cores in idle states. So enable the hostservice
interface to do the same.

Fixes: 49999302251b("opal-prd: Add support for runtime OCC reset in ZZ")
Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
---
 external/opal-prd/opal-prd.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Vasant Hegde Aug. 31, 2018, 5:13 a.m. | #1
On 08/24/2018 10:18 AM, Shilpasri G Bhat wrote:
> HBRT has started to use host special wakeup register to do special
> wakeup of the cores in idle states. So enable the hostservice
> interface to do the same.
> 
> Fixes: 49999302251b("opal-prd: Add support for runtime OCC reset in ZZ")
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>

Looks good.

Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

-Vasant

> ---
>   external/opal-prd/opal-prd.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c
> index e3b4439..ecdd95c 100644
> --- a/external/opal-prd/opal-prd.c
> +++ b/external/opal-prd/opal-prd.c
> @@ -2196,9 +2196,6 @@ static int run_prd_daemon(struct opal_prd_ctx *ctx)
>   		hinterface.pnor_write = NULL;
>   	}
> 
> -	if (!is_fsp_system())
> -		hinterface.wakeup = NULL;
> -
>   	ipmi_init(ctx);
> 
>   	pr_debug("HBRT: calling hservices_init");
>

Patch

diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c
index e3b4439..ecdd95c 100644
--- a/external/opal-prd/opal-prd.c
+++ b/external/opal-prd/opal-prd.c
@@ -2196,9 +2196,6 @@  static int run_prd_daemon(struct opal_prd_ctx *ctx)
 		hinterface.pnor_write = NULL;
 	}
 
-	if (!is_fsp_system())
-		hinterface.wakeup = NULL;
-
 	ipmi_init(ctx);
 
 	pr_debug("HBRT: calling hservices_init");