Message ID | 20180823133540.12973-1-pbonzini@redhat.com |
---|---|
State | New |
Headers | show |
On 23 August 2018 at 14:35, Paolo Bonzini <pbonzini@redhat.com> wrote: > The following changes since commit 659b11e7a7239529cfdb4968418268ff9aa22d88: > > Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging (2018-08-21 11:36:15 +0100) > > are available in the Git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to f1d7650ffbcbbc3307b299d54a8c535023602175: > > KVM: cleanup unnecessary #ifdef KVM_CAP_... (2018-08-23 13:32:50 +0200) > > Four more patches gone... New compile warning on NetBSD: tests/libqtest.c: In function 'qtest_is_old_versioned_machine': tests/libqtest.c:1019:13: warning: array subscript has type 'char' [-Wchar-subscripts] if (!isdigit(*chr) && *chr != '.') { ^ Code should be using qemu_isdigit(). We don't enforce -Werror on NetBSD, though, so we could let this through and fix it up later... Test failure on x86-64 Linux (debug build): MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} gtester -k --verbose -m=qui ck tests/test-replication TEST: tests/test-replication... (pid=6535) /replication/primary/read: OK /replication/primary/write: OK /replication/primary/start: OK /replication/primary/stop: OK /replication/primary/do_checkpoint: OK /replication/primary/get_error_all: OK /replication/secondary/read: OK /replication/secondary/write: OK /replication/secondary/start: ** ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-replication.c:120:test_blk_write: assertion failed: (async_ret == 0) FAIL GTester: last random seed: R02Sb173bafaddab398fce3309452c295220 (pid=6688) /replication/secondary/stop: OK /replication/secondary/do_checkpoint: OK /replication/secondary/get_error_all: OK FAIL: tests/test-replication I'm just checking whether that fails consistently or if it's a random/ intermittent. thanks -- PMM
On 23/08/2018 18:16, Peter Maydell wrote: > > tests/libqtest.c: In function 'qtest_is_old_versioned_machine': > tests/libqtest.c:1019:13: warning: array subscript has type 'char' > [-Wchar-subscripts] > if (!isdigit(*chr) && *chr != '.') { > ^ > > Code should be using qemu_isdigit(). We don't enforce -Werror > on NetBSD, though, so we could let this through and fix it up > later... As you prefer. I can send a v4 too. > Test failure on x86-64 Linux (debug build): > > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > gtester -k --verbose -m=qui > ck tests/test-replication > TEST: tests/test-replication... (pid=6535) > /replication/primary/read: OK > /replication/primary/write: OK > /replication/primary/start: OK > /replication/primary/stop: OK > /replication/primary/do_checkpoint: OK > /replication/primary/get_error_all: OK > /replication/secondary/read: OK > /replication/secondary/write: OK > /replication/secondary/start: ** > ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-replication.c:120:test_blk_write: > assertion failed: (async_ret == 0) > FAIL > GTester: last random seed: R02Sb173bafaddab398fce3309452c295220 > (pid=6688) > /replication/secondary/stop: OK > /replication/secondary/do_checkpoint: OK > /replication/secondary/get_error_all: OK > FAIL: tests/test-replication > > I'm just checking whether that fails consistently or if it's a random/ > intermittent. That would be strange, since I'm not touching the block layer at all (not my turf!)... Paolo
On 23 August 2018 at 17:25, Paolo Bonzini <pbonzini@redhat.com> wrote: > On 23/08/2018 18:16, Peter Maydell wrote: >> >> tests/libqtest.c: In function 'qtest_is_old_versioned_machine': >> tests/libqtest.c:1019:13: warning: array subscript has type 'char' >> [-Wchar-subscripts] >> if (!isdigit(*chr) && *chr != '.') { >> ^ >> >> Code should be using qemu_isdigit(). We don't enforce -Werror >> on NetBSD, though, so we could let this through and fix it up >> later... > > As you prefer. I can send a v4 too. > >> Test failure on x86-64 Linux (debug build): >> I'm just checking whether that fails consistently or if it's a random/ >> intermittent. > > That would be strange, since I'm not touching the block layer at all > (not my turf!)... It does seem to be intermittent. If you're ok with doing a v4 for the isdigit thing that's probably the cleanest way to do it. thanks -- PMM