[6/6] tests: Remove test_rrm_beacon_req_table_rsne
diff mbox series

Message ID 1534949409-29505-1-git-send-email-andrei.otcheretianski@intel.com
State Superseded
Headers show
Series
  • Untitled series #61937
Related show

Commit Message

Otcheretianski, Andrei Aug. 22, 2018, 2:50 p.m. UTC
This test isn't relevant anymore as beacon report fragmentation is
supported.

Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
---
 tests/hwsim/test_rrm.py | 24 ------------------------
 1 file changed, 24 deletions(-)

Comments

Jouni Malinen Jan. 2, 2019, 2:28 p.m. UTC | #1
On Wed, Aug 22, 2018 at 05:50:09PM +0300, Andrei Otcheretianski wrote:
> This test isn't relevant anymore as beacon report fragmentation is
> supported.

Well, I would not call it irrelevant even if RSNE truncation is not
used. It would make sense to verify that RSNE is now reported in full
and instead of applying this patch, I'll modify
rrm_beacon_req_table_rsne to verify expected contents of RSNE to match
the changed wpa_supplicant implementation for beacon reporting.

Patch
diff mbox series

diff --git a/tests/hwsim/test_rrm.py b/tests/hwsim/test_rrm.py
index 611b444..41cd2e8 100644
--- a/tests/hwsim/test_rrm.py
+++ b/tests/hwsim/test_rrm.py
@@ -1174,30 +1174,6 @@  def test_rrm_beacon_req_table_truncated_subelem(dev, apdev):
         raise Exception("Unexpected beacon report response (truncated subelement)")
     hapd.dump_monitor()
 
-@remote_compatible
-def test_rrm_beacon_req_table_rsne(dev, apdev):
-    """Beacon request - beacon table mode - RSNE truncation"""
-    params = hostapd.wpa2_params(ssid="rrm-rsn", passphrase="12345678")
-    params["rrm_beacon_report"] = "1"
-    hapd = hostapd.add_ap(apdev[0], params)
-
-    dev[0].connect("rrm-rsn", psk="12345678", scan_freq="2412")
-    addr = dev[0].own_addr()
-
-    token = run_req_beacon(hapd, addr, "51000000000002ffffffffffff" + "020101" + "0a0130")
-    ev = hapd.wait_event(["BEACON-RESP-RX"], timeout=10)
-    if ev is None:
-        raise Exception("Beacon report response not received")
-    fields = ev.split(' ')
-    report = BeaconReport(binascii.unhexlify(fields[4]))
-    logger.info("Received beacon report: " + str(report))
-    if not report.frame_body:
-        raise Exception("Reported Frame Body subelement missing")
-    if len(report.frame_body) != 12 + 6:
-        raise Exception("Unexpected Reported Frame Body subelement length with Reporting Detail 1 and requested element RSNE")
-    if binascii.unhexlify("30040100000f") not in report.frame_body:
-        raise Exception("Truncated RSNE not found")
-
 def test_rrm_beacon_req_table_vht(dev, apdev):
     """Beacon request - beacon table mode - VHT"""
     clear_scan_cache(apdev[0])