| Message ID | 20180822095421.11765-4-quintela@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On 2018-08-22 11:54, Juan Quintela wrote: > Once there, untangle endianness-test and boot-serial-test. > > Signed-off-by: Juan Quintela <quintela@redhat.com> > > -- > > boot-serial-test don't depend on isa-testdev. Thanks Thomas. > > Signed-off-by: Juan Quintela <quintela@redhat.com> Please remove the duplicated Sob. > @@ -321,15 +321,15 @@ check-qtest-m68k-y = tests/boot-serial-test$(EXESUF) > > check-qtest-microblaze-y = tests/boot-serial-test$(EXESUF) > > -check-qtest-mips-y = tests/endianness-test$(EXESUF) > - > -check-qtest-mips64-y = tests/endianness-test$(EXESUF) > - > -check-qtest-mips64el-y = tests/endianness-test$(EXESUF) > - > check-qtest-moxie-y = tests/boot-serial-test$(EXESUF) > > -check-qtest-ppc-y = tests/endianness-test$(EXESUF) > +check-qtest-mips-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) > + > +check-qtest-mips64-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) > + > +check-qtest-mips64el-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) > + > +check-qtest-ppc-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) Maybe keep moxie after mips? So that they stay in alphabetical order? When you fixed the nits: Reviewed-by: Thomas Huth <thuth@redhat.com>
Thomas Huth <thuth@redhat.com> wrote: > On 2018-08-22 11:54, Juan Quintela wrote: >> Once there, untangle endianness-test and boot-serial-test. >> >> Signed-off-by: Juan Quintela <quintela@redhat.com> >> >> -- >> >> boot-serial-test don't depend on isa-testdev. Thanks Thomas. >> >> Signed-off-by: Juan Quintela <quintela@redhat.com> > > Please remove the duplicated Sob. > >> @@ -321,15 +321,15 @@ check-qtest-m68k-y = tests/boot-serial-test$(EXESUF) >> >> check-qtest-microblaze-y = tests/boot-serial-test$(EXESUF) >> >> -check-qtest-mips-y = tests/endianness-test$(EXESUF) >> - >> -check-qtest-mips64-y = tests/endianness-test$(EXESUF) >> - >> -check-qtest-mips64el-y = tests/endianness-test$(EXESUF) >> - >> check-qtest-moxie-y = tests/boot-serial-test$(EXESUF) >> >> -check-qtest-ppc-y = tests/endianness-test$(EXESUF) >> +check-qtest-mips-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) >> + >> +check-qtest-mips64-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) >> + >> +check-qtest-mips64el-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) >> + >> +check-qtest-ppc-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) > > Maybe keep moxie after mips? So that they stay in alphabetical order? > > When you fixed the nits: > > Reviewed-by: Thomas Huth <thuth@redhat.com> Done, thanks.
Thomas Huth <thuth@redhat.com> wrote: > On 2018-08-22 11:54, Juan Quintela wrote: >> Once there, untangle endianness-test and boot-serial-test. >> >> Signed-off-by: Juan Quintela <quintela@redhat.com> >> >> -- >> >> boot-serial-test don't depend on isa-testdev. Thanks Thomas. >> >> Signed-off-by: Juan Quintela <quintela@redhat.com> > > Please remove the duplicated Sob. Found the problem!!!! As the cool man that I am, I put the signed-off line with a hook. And I updated the hook to the last version in git upstream, to be, you know cool. And the new version don't check that the line is already there. SOB=$(git var GIT_COMMITTER_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') git interpret-trailers --in-place --trailer "$SOB" "$COMMIT_MSG_FILE" Will try to get it right. Later, Juan.
diff --git a/tests/Makefile.include b/tests/Makefile.include index a705793381..15296be246 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -248,7 +248,7 @@ gcov-files-pci-y += hw/misc/ivshmem.c check-qtest-pci-y += tests/megasas-test$(EXESUF) gcov-files-pci-y += hw/scsi/megasas.c -check-qtest-i386-y = tests/endianness-test$(EXESUF) +check-qtest-i386-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) check-qtest-i386-y += tests/fdc-test$(EXESUF) gcov-files-i386-y = hw/block/fdc.c check-qtest-i386-y += tests/ide-test$(EXESUF) @@ -321,15 +321,15 @@ check-qtest-m68k-y = tests/boot-serial-test$(EXESUF) check-qtest-microblaze-y = tests/boot-serial-test$(EXESUF) -check-qtest-mips-y = tests/endianness-test$(EXESUF) - -check-qtest-mips64-y = tests/endianness-test$(EXESUF) - -check-qtest-mips64el-y = tests/endianness-test$(EXESUF) - check-qtest-moxie-y = tests/boot-serial-test$(EXESUF) -check-qtest-ppc-y = tests/endianness-test$(EXESUF) +check-qtest-mips-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) + +check-qtest-mips64-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) + +check-qtest-mips64el-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) + +check-qtest-ppc-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) check-qtest-ppc-y += tests/boot-order-test$(EXESUF) check-qtest-ppc-y += tests/prom-env-test$(EXESUF) check-qtest-ppc-y += tests/drive_del-test$(EXESUF) @@ -360,16 +360,16 @@ check-qtest-ppc64-y += tests/numa-test$(EXESUF) check-qtest-ppc64-$(CONFIG_IVSHMEM) += tests/ivshmem-test$(EXESUF) check-qtest-ppc64-y += tests/cpu-plug-test$(EXESUF) -check-qtest-sh4-y = tests/endianness-test$(EXESUF) +check-qtest-sh4-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) -check-qtest-sh4eb-y = tests/endianness-test$(EXESUF) +check-qtest-sh4eb-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) check-qtest-sparc-y = tests/prom-env-test$(EXESUF) check-qtest-sparc-y += tests/m48t59-test$(EXESUF) gcov-files-sparc-y = hw/timer/m48t59.c check-qtest-sparc-y += tests/boot-serial-test$(EXESUF) -check-qtest-sparc64-y = tests/endianness-test$(EXESUF) +check-qtest-sparc64-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) check-qtest-sparc64-y += tests/prom-env-test$(EXESUF) check-qtest-sparc64-y += tests/boot-serial-test$(EXESUF)