[linux,dev-4.17,v3] hARM: dts: aspeed: romulus: Enable iio-hwmon-battery

Message ID 1534924048-51891-1-git-send-email-mine260309@gmail.com
State Accepted, archived
Headers show
Series
  • [linux,dev-4.17,v3] hARM: dts: aspeed: romulus: Enable iio-hwmon-battery
Related show

Commit Message

Lei YU Aug. 22, 2018, 7:47 a.m.
Add iio-hwmon-battery using adc channel 12 and enable adc to make
adc running. This channel is used to read RTC battery voltage.

Note with Romulus hardware design, it requires GPIOR3 to be pulled
high to read the voltage, otherwise the reading is 0.
When GPIOR3 is high, it consumes battery and impacts the battery life.
So it is left for user space to toggle the GPIO when trying to read the
voltage.

Signed-off-by: Lei YU <mine260309@gmail.com>
---
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Joel Stanley Oct. 21, 2018, 10:22 p.m. | #1
On Wed, 22 Aug 2018 at 17:17, Lei YU <mine260309@gmail.com> wrote:
>
> Add iio-hwmon-battery using adc channel 12 and enable adc to make
> adc running. This channel is used to read RTC battery voltage.
>
> Note with Romulus hardware design, it requires GPIOR3 to be pulled
> high to read the voltage, otherwise the reading is 0.
> When GPIOR3 is high, it consumes battery and impacts the battery life.
> So it is left for user space to toggle the GPIO when trying to read the
> voltage.
>
> Signed-off-by: Lei YU <mine260309@gmail.com>

For the mailing list record: this was applied to dev-4.18 some time ago.

Cheers,

Joel

Patch

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
index 9784a59a..cf59472 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
@@ -91,6 +91,11 @@ 
 			linux,code = <ASPEED_GPIO(Q, 7)>;
 		};
 	};
+
+	iio-hwmon-battery {
+		compatible = "iio-hwmon";
+		io-channels = <&adc 12>;
+	};
 };
 
 #include "ibm-power9-dual.dtsi"
@@ -311,3 +316,7 @@ 
 &vhub {
 	status = "okay";
 };
+
+&adc {
+	status = "okay";
+};