From patchwork Tue May 17 19:43:32 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jvrao X-Patchwork-Id: 96025 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C941FB6EEC for ; Wed, 18 May 2011 05:50:09 +1000 (EST) Received: from localhost ([::1]:49205 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMQHO-0003JK-Am for incoming@patchwork.ozlabs.org; Tue, 17 May 2011 15:50:06 -0400 Received: from eggs.gnu.org ([140.186.70.92]:34577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMQC1-0002Oc-AF for qemu-devel@nongnu.org; Tue, 17 May 2011 15:44:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMQBz-00022s-Nh for qemu-devel@nongnu.org; Tue, 17 May 2011 15:44:33 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:52442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMQBz-00022Y-Gc for qemu-devel@nongnu.org; Tue, 17 May 2011 15:44:31 -0400 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by e31.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p4HJS30t002437 for ; Tue, 17 May 2011 13:28:04 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p4HJiGqM183892 for ; Tue, 17 May 2011 13:44:19 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4HDhkmP017612 for ; Tue, 17 May 2011 07:43:46 -0600 Received: from oc6675851006.ibm.com (dyn9047029068.beaverton.ibm.com [9.47.29.68]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p4HDhZkL016491; Tue, 17 May 2011 07:43:45 -0600 From: "Venkateswararao Jujjuri (JV)" To: qemu-devel@nongnu.org Date: Tue, 17 May 2011 12:43:32 -0700 Message-Id: <1305661431-21289-7-git-send-email-jvrao@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1305661431-21289-1-git-send-email-jvrao@linux.vnet.ibm.com> References: <1305661431-21289-1-git-send-email-jvrao@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 32.97.110.149 Cc: aliguori@us.ibm.com, "Venkateswararao Jujjuri \(JV\)" , stefanha@linux.vnet.ibm.com Subject: [Qemu-devel] [V2 06/25] [virtio-9p] coroutines for readlink X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Venkateswararao Jujjuri " --- Makefile.objs | 2 +- hw/9pfs/cofs.c | 42 ++++++++++++++++++++++++++++++++++++++++++ hw/9pfs/virtio-9p-coth.h | 1 + hw/9pfs/virtio-9p.c | 27 ++++----------------------- hw/9pfs/virtio-9p.h | 3 ++- 5 files changed, 50 insertions(+), 25 deletions(-) create mode 100644 hw/9pfs/cofs.c diff --git a/Makefile.objs b/Makefile.objs index 96f6a24..36005bb 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -297,7 +297,7 @@ hw-obj-$(CONFIG_SOUND) += $(sound-obj-y) 9pfs-nested-$(CONFIG_VIRTFS) = virtio-9p.o virtio-9p-debug.o 9pfs-nested-$(CONFIG_VIRTFS) += virtio-9p-local.o virtio-9p-xattr.o 9pfs-nested-$(CONFIG_VIRTFS) += virtio-9p-xattr-user.o virtio-9p-posix-acl.o -9pfs-nested-$(CONFIG_VIRTFS) += virtio-9p-coth.o +9pfs-nested-$(CONFIG_VIRTFS) += virtio-9p-coth.o cofs.o hw-obj-$(CONFIG_REALLY_VIRTFS) += $(addprefix 9pfs/, $(9pfs-nested-y)) $(addprefix 9pfs/, $(9pfs-nested-y)): QEMU_CFLAGS+=$(GLIB_CFLAGS) diff --git a/hw/9pfs/cofs.c b/hw/9pfs/cofs.c new file mode 100644 index 0000000..6d94673 --- /dev/null +++ b/hw/9pfs/cofs.c @@ -0,0 +1,42 @@ + +/* + * Virtio 9p backend + * + * Copyright IBM, Corp. 2011 + * + * Authors: + * Aneesh Kumar K.V + * + * This work is licensed under the terms of the GNU GPL, version 2. See + * the COPYING file in the top-level directory. + * + */ + +#include "fsdev/qemu-fsdev.h" +#include "qemu-thread.h" +#include "qemu-coroutine.h" +#include "virtio-9p-coth.h" + +int v9fs_co_readlink(V9fsState *s, V9fsString *path, V9fsString *buf) +{ + int err; + ssize_t len; + V9fsString tbuf; + + tbuf.data = qemu_malloc(PATH_MAX); + v9fs_co_run_in_worker( + { + len = s->ops->readlink(&s->ctx, path->data, + tbuf.data, PATH_MAX - 1); + if (len > -1) { + tbuf.size = len; + tbuf.data[len] = 0; + err = 0; + } else { + err = -errno; + } + }); + buf->size = tbuf.size; + buf->data = tbuf.data; + return err; +} diff --git a/hw/9pfs/virtio-9p-coth.h b/hw/9pfs/virtio-9p-coth.h index 9388f9b..94c5147 100644 --- a/hw/9pfs/virtio-9p-coth.h +++ b/hw/9pfs/virtio-9p-coth.h @@ -56,4 +56,5 @@ typedef struct V9fsThPool { extern void co_run_in_worker_bh(void *); extern int v9fs_init_worker_threads(void); +extern int v9fs_co_readlink(V9fsState *, V9fsString *, V9fsString *); #endif diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index cc22a1f..25831c3 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virtio-9p.c @@ -82,23 +82,6 @@ static int v9fs_do_lstat(V9fsState *s, V9fsString *path, struct stat *stbuf) return s->ops->lstat(&s->ctx, path->data, stbuf); } -static int v9fs_do_readlink(V9fsState *s, V9fsString *path, V9fsString *buf, - ssize_t *len) -{ - int err; - buf->data = qemu_malloc(1024); - - *len = s->ops->readlink(&s->ctx, path->data, buf->data, 1024 - 1); - if (*len > -1) { - buf->size = *len; - buf->data[*len] = 0; - err = 0; - } else { - err = -errno; - } - return err; -} - static int v9fs_do_close(V9fsState *s, int fd) { return s->ops->close(&s->ctx, fd); @@ -299,7 +282,7 @@ static void v9fs_string_init(V9fsString *str) str->size = 0; } -static void v9fs_string_free(V9fsString *str) +void v9fs_string_free(V9fsString *str) { qemu_free(str->data); str->data = NULL; @@ -421,7 +404,7 @@ v9fs_string_sprintf(V9fsString *str, const char *fmt, ...) str->size = err; } -static void v9fs_string_copy(V9fsString *lhs, V9fsString *rhs) +void v9fs_string_copy(V9fsString *lhs, V9fsString *rhs) { v9fs_string_free(lhs); v9fs_string_sprintf(lhs, "%s", rhs->data); @@ -1057,8 +1040,7 @@ static int stat_to_v9stat(V9fsState *s, V9fsString *name, v9fs_string_null(&v9stat->extension); if (v9stat->mode & P9_STAT_MODE_SYMLINK) { - ssize_t symlink_len; - err = v9fs_do_readlink(s, name, &v9stat->extension, &symlink_len); + err = v9fs_co_readlink(s, name, &v9stat->extension); if (err < 0) { return err; } @@ -3591,7 +3573,6 @@ static void v9fs_readlink(void *opaque) int32_t fid; int err = 0; V9fsFidState *fidp; - ssize_t symlink_len; pdu_unmarshal(pdu, offset, "d", &fid); fidp = lookup_fid(pdu->s, fid); @@ -3601,7 +3582,7 @@ static void v9fs_readlink(void *opaque) } v9fs_string_init(&target); - err = v9fs_do_readlink(pdu->s, &fidp->path, &target, &symlink_len); + err = v9fs_co_readlink(pdu->s, &fidp->path, &target); if (err < 0) { goto out; } diff --git a/hw/9pfs/virtio-9p.h b/hw/9pfs/virtio-9p.h index e95b63d..c6f2649 100644 --- a/hw/9pfs/virtio-9p.h +++ b/hw/9pfs/virtio-9p.h @@ -505,5 +505,6 @@ static inline size_t do_pdu_unpack(void *dst, struct iovec *sg, int sg_count, } extern void handle_9p_output(VirtIODevice *vdev, VirtQueue *vq); - +extern void v9fs_string_copy(V9fsString *lhs, V9fsString *rhs); +extern void v9fs_string_free(V9fsString *str); #endif