Message ID | 20180820153811.13353-1-colin.king@canonical.com |
---|---|
State | Accepted |
Headers | show |
Series | snapcraft: add missing stage packages | expand |
On 2018-08-20 08:38 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > This includes some missing stage packages > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > snapcraft.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/snapcraft.yaml b/snapcraft.yaml > index 7b36b314..30d42b1b 100644 > --- a/snapcraft.yaml > +++ b/snapcraft.yaml > @@ -10,6 +10,9 @@ parts: > source: git://kernel.ubuntu.com/hwe/fwts > stage-packages: > - libfdt1 > + - libjson-c3 > + - libbsd0 > + - libpci3 > build-packages: > - gcc > - make > Looks good. Do we need to update README and perhaps for fedora too? Acked-by: Alex Hung <alex.hung@canonical.com>
On 08/20/2018 11:38 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > This includes some missing stage packages > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > snapcraft.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/snapcraft.yaml b/snapcraft.yaml > index 7b36b314..30d42b1b 100644 > --- a/snapcraft.yaml > +++ b/snapcraft.yaml > @@ -10,6 +10,9 @@ parts: > source: git://kernel.ubuntu.com/hwe/fwts > stage-packages: > - libfdt1 > + - libjson-c3 > + - libbsd0 > + - libpci3 > build-packages: > - gcc > - make Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/snapcraft.yaml b/snapcraft.yaml index 7b36b314..30d42b1b 100644 --- a/snapcraft.yaml +++ b/snapcraft.yaml @@ -10,6 +10,9 @@ parts: source: git://kernel.ubuntu.com/hwe/fwts stage-packages: - libfdt1 + - libjson-c3 + - libbsd0 + - libpci3 build-packages: - gcc - make