diff mbox series

[05/18] perl-x10: new package

Message ID 20180820115519.24046-6-chrismcc@gmail.com
State Accepted
Headers show
Series perl modules again | expand

Commit Message

Christopher McCrory Aug. 20, 2018, 11:55 a.m. UTC 
Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
 DEVELOPERS                     |  1 +
 package/Config.in              |  1 +
 package/perl-x10/Config.in     | 13 +++++++++++++
 package/perl-x10/perl-x10.hash |  6 ++++++
 package/perl-x10/perl-x10.mk   | 14 ++++++++++++++
 5 files changed, 35 insertions(+)
 create mode 100644 package/perl-x10/Config.in
 create mode 100644 package/perl-x10/perl-x10.hash
 create mode 100644 package/perl-x10/perl-x10.mk

Comments

Francois Perrad Aug. 21, 2018, 6:23 a.m. UTC | #1 
2018-08-20 13:55 GMT+02:00 Christopher McCrory <chrismcc@gmail.com>:

> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
>

Acked-by: Francois Perrad <francois.perrad@gadz.org>
but depends on perl-time-parsedate


> ---
>  DEVELOPERS                     |  1 +
>  package/Config.in              |  1 +
>  package/perl-x10/Config.in     | 13 +++++++++++++
>  package/perl-x10/perl-x10.hash |  6 ++++++
>  package/perl-x10/perl-x10.mk   | 14 ++++++++++++++
>  5 files changed, 35 insertions(+)
>  create mode 100644 package/perl-x10/Config.in
>  create mode 100644 package/perl-x10/perl-x10.hash
>  create mode 100644 package/perl-x10/perl-x10.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 105fae199c..410d01b02b 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -506,6 +506,7 @@ F:  package/perl-sub-install/
>  F:     package/perl-sys-meminfo/
>  F:     package/perl-sys-mmap/
>  F:     package/perl-time-parsedate/
> +F:     package/perl-x10/
>
>  N:     Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
>  F:     package/audit/
> diff --git a/package/Config.in b/package/Config.in
> index 7629cf6c46..c083f4e1bd 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -737,6 +737,7 @@ menu "Perl libraries/modules"
>         source "package/perl-try-tiny/Config.in"
>         source "package/perl-uri/Config.in"
>         source "package/perl-www-robotrules/Config.in"
> +       source "package/perl-x10/Config.in"
>         source "package/perl-xml-libxml/Config.in"
>         source "package/perl-xml-namespacesupport/Config.in"
>         source "package/perl-xml-sax/Config.in"
> diff --git a/package/perl-x10/Config.in b/package/perl-x10/Config.in
> new file mode 100644
> index 0000000000..984a561b05
> --- /dev/null
> +++ b/package/perl-x10/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_PERL_X10
> +       bool "perl-x10"
> +       depends on !BR2_STATIC_LIBS
> +       select BR2_PACKAGE_PERL_ASTRO_SUNTIME
> +       select BR2_PACKAGE_PERL_DEVICE_SERIALPORT
> +       select BR2_PACKAGE_PERL_TIME_PARSEDATE
> +       help
> +         creates a server used to receive events from an x10 client
> +
> +         https://metacpan.org/release/X10
> +
> +comment "perl-x10 needs a toolchain w/ dynamic library"
> +       depends on BR2_STATIC_LIBS
> diff --git a/package/perl-x10/perl-x10.hash b/package/perl-x10/perl-x10.
> hash
> new file mode 100644
> index 0000000000..5411390e3e
> --- /dev/null
> +++ b/package/perl-x10/perl-x10.hash
> @@ -0,0 +1,6 @@
> +# retrieved by scancpan from http://cpan.metacpan.org/
> +md5    20dcca2dfb978bfed3043276aa3481e5 X10-0.04.tar.gz
> +sha256 3dcee9d95614b2db70de608e933d42817f93fccd5b1f2f782b0846af487d9134
> X10-0.04.tar.gz
> +
> +# computed by scancpan
> +sha256 e6f320afa82517d663be348dd2515ecb1454a7c851ba5590f13aca01d219be80
> README
> diff --git a/package/perl-x10/perl-x10.mk b/package/perl-x10/perl-x10.mk
> new file mode 100644
> index 0000000000..8f091b9509
> --- /dev/null
> +++ b/package/perl-x10/perl-x10.mk
> @@ -0,0 +1,14 @@
> +###########################################################
> #####################
> +#
> +# perl-x10
> +#
> +###########################################################
> #####################
> +
> +PERL_X10_VERSION = 0.04
> +PERL_X10_SOURCE = X10-$(PERL_X10_VERSION).tar.gz
> +PERL_X10_SITE = $(BR2_CPAN_MIRROR)/authors/id/R/RO/ROBF
> +PERL_X10_DEPENDENCIES = perl-astro-suntime perl-device-serialport
> perl-time-parsedate
> +PERL_X10_LICENSE = GPL-3.0
> +PERL_X10_LICENSE_FILES = README
> +
> +$(eval $(perl-package))
> --
> 2.14.4
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2018-08-20 13:55 GMT+02:00 Christopher McCrory <span dir="ltr">&lt;<a href="mailto:chrismcc@gmail.com" target="_blank">chrismcc@gmail.com</a>&gt;</span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Christopher McCrory &lt;<a href="mailto:chrismcc@gmail.com">chrismcc@gmail.com</a>&gt;<br></blockquote><div><br></div><div>Acked-by: Francois Perrad &lt;<a href="mailto:francois.perrad@gadz.org">francois.perrad@gadz.org</a>&gt;</div><div>but depends on perl-time-parsedate<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
 DEVELOPERS                     |  1 +<br>
 package/Config.in              |  1 +<br>
 package/perl-x10/Config.in     | 13 +++++++++++++<br>
 package/perl-x10/perl-x10.hash |  6 ++++++<br>
 package/perl-x10/<a href="http://perl-x10.mk" rel="noreferrer" target="_blank">perl-x10.mk</a>   | 14 ++++++++++++++<br>
 5 files changed, 35 insertions(+)<br>
 create mode 100644 package/perl-x10/Config.in<br>
 create mode 100644 package/perl-x10/perl-x10.hash<br>
 create mode 100644 package/perl-x10/<a href="http://perl-x10.mk" rel="noreferrer" target="_blank">perl-x10.mk</a><br>
<br>
diff --git a/DEVELOPERS b/DEVELOPERS<br>
index 105fae199c..410d01b02b 100644<br>
--- a/DEVELOPERS<br>
+++ b/DEVELOPERS<br>
@@ -506,6 +506,7 @@ F:  package/perl-sub-install/<br>
 F:     package/perl-sys-meminfo/<br>
 F:     package/perl-sys-mmap/<br>
 F:     package/perl-time-parsedate/<br>
+F:     package/perl-x10/<br>
<br>
 N:     Clayton Shotwell &lt;<a href="mailto:clayton.shotwell@rockwellcollins.com">clayton.shotwell@<wbr>rockwellcollins.com</a>&gt;<br>
 F:     package/audit/<br>
diff --git a/package/Config.in b/package/Config.in<br>
index 7629cf6c46..c083f4e1bd 100644<br>
--- a/package/Config.in<br>
+++ b/package/Config.in<br>
@@ -737,6 +737,7 @@ menu &quot;Perl libraries/modules&quot;<br>
        source &quot;package/perl-try-tiny/Config.<wbr>in&quot;<br>
        source &quot;package/perl-uri/Config.in&quot;<br>
        source &quot;package/perl-www-robotrules/<wbr>Config.in&quot;<br>
+       source &quot;package/perl-x10/Config.in&quot;<br>
        source &quot;package/perl-xml-libxml/<wbr>Config.in&quot;<br>
        source &quot;package/perl-xml-<wbr>namespacesupport/Config.in&quot;<br>
        source &quot;package/perl-xml-sax/Config.<wbr>in&quot;<br>
diff --git a/package/perl-x10/Config.in b/package/perl-x10/Config.in<br>
new file mode 100644<br>
index 0000000000..984a561b05<br>
--- /dev/null<br>
+++ b/package/perl-x10/Config.in<br>
@@ -0,0 +1,13 @@<br>
+config BR2_PACKAGE_PERL_X10<br>
+       bool &quot;perl-x10&quot;<br>
+       depends on !BR2_STATIC_LIBS<br>
+       select BR2_PACKAGE_PERL_ASTRO_SUNTIME<br>
+       select BR2_PACKAGE_PERL_DEVICE_<wbr>SERIALPORT<br>
+       select BR2_PACKAGE_PERL_TIME_<wbr>PARSEDATE<br>
+       help<br>
+         creates a server used to receive events from an x10 client<br>
+<br>
+         <a href="https://metacpan.org/release/X10" rel="noreferrer" target="_blank">https://metacpan.org/release/<wbr>X10</a><br>
+<br>
+comment &quot;perl-x10 needs a toolchain w/ dynamic library&quot;<br>
+       depends on BR2_STATIC_LIBS<br>
diff --git a/package/perl-x10/perl-x10.<wbr>hash b/package/perl-x10/perl-x10.<wbr>hash<br>
new file mode 100644<br>
index 0000000000..5411390e3e<br>
--- /dev/null<br>
+++ b/package/perl-x10/perl-x10.<wbr>hash<br>
@@ -0,0 +1,6 @@<br>
+# retrieved by scancpan from <a href="http://cpan.metacpan.org/" rel="noreferrer" target="_blank">http://cpan.metacpan.org/</a><br>
+md5    20dcca2dfb978bfed3043276aa3481<wbr>e5 X10-0.04.tar.gz<br>
+sha256 3dcee9d95614b2db70de608e933d42<wbr>817f93fccd5b1f2f782b0846af487d<wbr>9134 X10-0.04.tar.gz<br>
+<br>
+# computed by scancpan<br>
+sha256 e6f320afa82517d663be348dd2515e<wbr>cb1454a7c851ba5590f13aca01d219<wbr>be80 README<br>
diff --git a/package/perl-x10/<a href="http://perl-x10.mk" rel="noreferrer" target="_blank">perl-x10.mk</a> b/package/perl-x10/<a href="http://perl-x10.mk" rel="noreferrer" target="_blank">perl-x10.mk</a><br>
new file mode 100644<br>
index 0000000000..8f091b9509<br>
--- /dev/null<br>
+++ b/package/perl-x10/<a href="http://perl-x10.mk" rel="noreferrer" target="_blank">perl-x10.mk</a><br>
@@ -0,0 +1,14 @@<br>
+#############################<wbr>##############################<wbr>#####################<br>
+#<br>
+# perl-x10<br>
+#<br>
+#############################<wbr>##############################<wbr>#####################<br>
+<br>
+PERL_X10_VERSION = 0.04<br>
+PERL_X10_SOURCE = X10-$(PERL_X10_VERSION).tar.gz<br>
+PERL_X10_SITE = $(BR2_CPAN_MIRROR)/authors/id/<wbr>R/RO/ROBF<br>
+PERL_X10_DEPENDENCIES = perl-astro-suntime perl-device-serialport perl-time-parsedate<br>
+PERL_X10_LICENSE = GPL-3.0<br>
+PERL_X10_LICENSE_FILES = README<br>
+<br>
+$(eval $(perl-package))<br>
<span class="gmail-HOEnZb"><font color="#888888">-- <br>
2.14.4<br>
<br>
______________________________<wbr>_________________<br>
buildroot mailing list<br>
<a href="mailto:buildroot@busybox.net">buildroot@busybox.net</a><br>
<a href="http://lists.busybox.net/mailman/listinfo/buildroot" rel="noreferrer" target="_blank">http://lists.busybox.net/<wbr>mailman/listinfo/buildroot</a><br>
</font></span></blockquote></div><br></div></div>
Thomas Petazzoni Sept. 12, 2018, 8:44 p.m. UTC | #2 
Hello Christopher,

On Mon, 20 Aug 2018 04:55:06 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
>  DEVELOPERS                     |  1 +
>  package/Config.in              |  1 +
>  package/perl-x10/Config.in     | 13 +++++++++++++
>  package/perl-x10/perl-x10.hash |  6 ++++++
>  package/perl-x10/perl-x10.mk   | 14 ++++++++++++++
>  5 files changed, 35 insertions(+)
>  create mode 100644 package/perl-x10/Config.in
>  create mode 100644 package/perl-x10/perl-x10.hash
>  create mode 100644 package/perl-x10/perl-x10.mk

I have applied your patch, but I have a few questions. I have also
added François in Cc, he can probably help.

> diff --git a/package/perl-x10/Config.in b/package/perl-x10/Config.in
> new file mode 100644
> index 0000000000..984a561b05
> --- /dev/null
> +++ b/package/perl-x10/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_PERL_X10
> +	bool "perl-x10"
> +	depends on !BR2_STATIC_LIBS

Why do we have this dependency ? It seems to be a pure Perl module,
what makes it require dynamic library support ?

> +PERL_X10_VERSION = 0.04
> +PERL_X10_SOURCE = X10-$(PERL_X10_VERSION).tar.gz
> +PERL_X10_SITE = $(BR2_CPAN_MIRROR)/authors/id/R/RO/ROBF
> +PERL_X10_DEPENDENCIES = perl-astro-suntime perl-device-serialport perl-time-parsedate

Are these really build-time dependencies ?

Thanks!

Thomas
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 105fae199c..410d01b02b 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -506,6 +506,7 @@  F:	package/perl-sub-install/
 F:	package/perl-sys-meminfo/
 F:	package/perl-sys-mmap/
 F:	package/perl-time-parsedate/
+F:	package/perl-x10/
 
 N:	Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
 F:	package/audit/
diff --git a/package/Config.in b/package/Config.in
index 7629cf6c46..c083f4e1bd 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -737,6 +737,7 @@  menu "Perl libraries/modules"
 	source "package/perl-try-tiny/Config.in"
 	source "package/perl-uri/Config.in"
 	source "package/perl-www-robotrules/Config.in"
+	source "package/perl-x10/Config.in"
 	source "package/perl-xml-libxml/Config.in"
 	source "package/perl-xml-namespacesupport/Config.in"
 	source "package/perl-xml-sax/Config.in"
diff --git a/package/perl-x10/Config.in b/package/perl-x10/Config.in
new file mode 100644
index 0000000000..984a561b05
--- /dev/null
+++ b/package/perl-x10/Config.in
@@ -0,0 +1,13 @@ 
+config BR2_PACKAGE_PERL_X10
+	bool "perl-x10"
+	depends on !BR2_STATIC_LIBS
+	select BR2_PACKAGE_PERL_ASTRO_SUNTIME
+	select BR2_PACKAGE_PERL_DEVICE_SERIALPORT
+	select BR2_PACKAGE_PERL_TIME_PARSEDATE
+	help
+	  creates a server used to receive events from an x10 client
+
+	  https://metacpan.org/release/X10
+
+comment "perl-x10 needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
diff --git a/package/perl-x10/perl-x10.hash b/package/perl-x10/perl-x10.hash
new file mode 100644
index 0000000000..5411390e3e
--- /dev/null
+++ b/package/perl-x10/perl-x10.hash
@@ -0,0 +1,6 @@ 
+# retrieved by scancpan from http://cpan.metacpan.org/
+md5    20dcca2dfb978bfed3043276aa3481e5 X10-0.04.tar.gz
+sha256 3dcee9d95614b2db70de608e933d42817f93fccd5b1f2f782b0846af487d9134 X10-0.04.tar.gz
+
+# computed by scancpan
+sha256 e6f320afa82517d663be348dd2515ecb1454a7c851ba5590f13aca01d219be80 README
diff --git a/package/perl-x10/perl-x10.mk b/package/perl-x10/perl-x10.mk
new file mode 100644
index 0000000000..8f091b9509
--- /dev/null
+++ b/package/perl-x10/perl-x10.mk
@@ -0,0 +1,14 @@ 
+################################################################################
+#
+# perl-x10
+#
+################################################################################
+
+PERL_X10_VERSION = 0.04
+PERL_X10_SOURCE = X10-$(PERL_X10_VERSION).tar.gz
+PERL_X10_SITE = $(BR2_CPAN_MIRROR)/authors/id/R/RO/ROBF
+PERL_X10_DEPENDENCIES = perl-astro-suntime perl-device-serialport perl-time-parsedate
+PERL_X10_LICENSE = GPL-3.0
+PERL_X10_LICENSE_FILES = README
+
+$(eval $(perl-package))