diff mbox series

[06/18] perl-sys-cpu: new package

Message ID 20180820115519.24046-7-chrismcc@gmail.com
State Accepted
Headers show
Series perl modules again | expand

Commit Message

Christopher McCrory Aug. 20, 2018, 11:55 a.m. UTC 
Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
 DEVELOPERS                             |  1 +
 package/Config.in                      |  1 +
 package/perl-sys-cpu/Config.in         |  5 +++++
 package/perl-sys-cpu/perl-sys-cpu.hash |  2 ++
 package/perl-sys-cpu/perl-sys-cpu.mk   | 13 +++++++++++++
 5 files changed, 22 insertions(+)
 create mode 100644 package/perl-sys-cpu/Config.in
 create mode 100644 package/perl-sys-cpu/perl-sys-cpu.hash
 create mode 100644 package/perl-sys-cpu/perl-sys-cpu.mk

Comments

Francois Perrad Aug. 21, 2018, 6:35 a.m. UTC | #1 
2018-08-20 13:55 GMT+02:00 Christopher McCrory <chrismcc@gmail.com>:

> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
>

Acked-by: Francois Perrad <francois.perrad@gadz.org>


> ---
>  DEVELOPERS                             |  1 +
>  package/Config.in                      |  1 +
>  package/perl-sys-cpu/Config.in         |  5 +++++
>  package/perl-sys-cpu/perl-sys-cpu.hash |  2 ++
>  package/perl-sys-cpu/perl-sys-cpu.mk   | 13 +++++++++++++
>  5 files changed, 22 insertions(+)
>  create mode 100644 package/perl-sys-cpu/Config.in
>  create mode 100644 package/perl-sys-cpu/perl-sys-cpu.hash
>  create mode 100644 package/perl-sys-cpu/perl-sys-cpu.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 410d01b02b..70879360f2 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -503,6 +503,7 @@ F:  package/perl-module-runtime/
>  F:     package/perl-number-bytes-human/
>  F:     package/perl-params-util/
>  F:     package/perl-sub-install/
> +F:     package/perl-sys-cpu/
>  F:     package/perl-sys-meminfo/
>  F:     package/perl-sys-mmap/
>  F:     package/perl-time-parsedate/
> diff --git a/package/Config.in b/package/Config.in
> index c083f4e1bd..fcb67b7617 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -729,6 +729,7 @@ menu "Perl libraries/modules"
>         source "package/perl-params-util/Config.in"
>         source "package/perl-path-tiny/Config.in"
>         source "package/perl-sub-install/Config.in"
> +       source "package/perl-sys-cpu/Config.in"
>         source "package/perl-sys-meminfo/Config.in"
>         source "package/perl-sys-mmap/Config.in"
>         source "package/perl-time-hires/Config.in"
> diff --git a/package/perl-sys-cpu/Config.in b/package/perl-sys-cpu/Config.
> in
> new file mode 100644
> index 0000000000..d5fff5b849
> --- /dev/null
> +++ b/package/perl-sys-cpu/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_PERL_SYS_CPU
> +       bool "perl-sys-cpu"
> +       help
> +         perl-sys-cpu
> +
> diff --git a/package/perl-sys-cpu/perl-sys-cpu.hash
> b/package/perl-sys-cpu/perl-sys-cpu.hash
> new file mode 100644
> index 0000000000..0977606b1a
> --- /dev/null
> +++ b/package/perl-sys-cpu/perl-sys-cpu.hash
> @@ -0,0 +1,2 @@
> +# locally computed
> +sha256 ca0ec47ab24070e3040e5075337cfc69721362d9bef50f6992072efe644d4d26
> Sys-CPU-0.52.tar.gz
> diff --git a/package/perl-sys-cpu/perl-sys-cpu.mk b/package/perl-sys-cpu/
> perl-sys-cpu.mk
> new file mode 100644
> index 0000000000..efc9ee814b
> --- /dev/null
> +++ b/package/perl-sys-cpu/perl-sys-cpu.mk
> @@ -0,0 +1,13 @@
> +###########################################################
> #####################
> +#
> +# perl-sys-cpu
> +#
> +###########################################################
> #####################
> +
> +PERL_SYS_CPU_VERSION = 0.52
> +PERL_SYS_CPU_SOURCE = Sys-CPU-$(PERL_SYS_CPU_VERSION).tar.gz
> +PERL_SYS_CPU_SITE = $(BR2_CPAN_MIRROR)/authors/id/M/MK/MKODERER
> +PERL_SYS_CPU_LICENSE = Artistic or GPL-1.0+ # as stated in README file
> +PERL_SYS_CPU_LICENSE_FILES = README
> +
> +$(eval $(perl-package))
> --
> 2.14.4
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2018-08-20 13:55 GMT+02:00 Christopher McCrory <span dir="ltr">&lt;<a href="mailto:chrismcc@gmail.com" target="_blank">chrismcc@gmail.com</a>&gt;</span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Christopher McCrory &lt;<a href="mailto:chrismcc@gmail.com">chrismcc@gmail.com</a>&gt;<br></blockquote><div><br></div><div>Acked-by: Francois Perrad &lt;<a href="mailto:francois.perrad@gadz.org">francois.perrad@gadz.org</a>&gt;<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
 DEVELOPERS                             |  1 +<br>
 package/Config.in                      |  1 +<br>
 package/perl-sys-cpu/Config.in         |  5 +++++<br>
 package/perl-sys-cpu/perl-sys-<wbr>cpu.hash |  2 ++<br>
 package/perl-sys-cpu/<a href="http://perl-sys-cpu.mk" rel="noreferrer" target="_blank">perl-sys-<wbr>cpu.mk</a>   | 13 +++++++++++++<br>
 5 files changed, 22 insertions(+)<br>
 create mode 100644 package/perl-sys-cpu/Config.in<br>
 create mode 100644 package/perl-sys-cpu/perl-sys-<wbr>cpu.hash<br>
 create mode 100644 package/perl-sys-cpu/<a href="http://perl-sys-cpu.mk" rel="noreferrer" target="_blank">perl-sys-<wbr>cpu.mk</a><br>
<br>
diff --git a/DEVELOPERS b/DEVELOPERS<br>
index 410d01b02b..70879360f2 100644<br>
--- a/DEVELOPERS<br>
+++ b/DEVELOPERS<br>
@@ -503,6 +503,7 @@ F:  package/perl-module-runtime/<br>
 F:     package/perl-number-bytes-<wbr>human/<br>
 F:     package/perl-params-util/<br>
 F:     package/perl-sub-install/<br>
+F:     package/perl-sys-cpu/<br>
 F:     package/perl-sys-meminfo/<br>
 F:     package/perl-sys-mmap/<br>
 F:     package/perl-time-parsedate/<br>
diff --git a/package/Config.in b/package/Config.in<br>
index c083f4e1bd..fcb67b7617 100644<br>
--- a/package/Config.in<br>
+++ b/package/Config.in<br>
@@ -729,6 +729,7 @@ menu &quot;Perl libraries/modules&quot;<br>
        source &quot;package/perl-params-util/<wbr>Config.in&quot;<br>
        source &quot;package/perl-path-tiny/<wbr>Config.in&quot;<br>
        source &quot;package/perl-sub-install/<wbr>Config.in&quot;<br>
+       source &quot;package/perl-sys-cpu/Config.<wbr>in&quot;<br>
        source &quot;package/perl-sys-meminfo/<wbr>Config.in&quot;<br>
        source &quot;package/perl-sys-mmap/Config.<wbr>in&quot;<br>
        source &quot;package/perl-time-hires/<wbr>Config.in&quot;<br>
diff --git a/package/perl-sys-cpu/Config.<wbr>in b/package/perl-sys-cpu/Config.<wbr>in<br>
new file mode 100644<br>
index 0000000000..d5fff5b849<br>
--- /dev/null<br>
+++ b/package/perl-sys-cpu/Config.<wbr>in<br>
@@ -0,0 +1,5 @@<br>
+config BR2_PACKAGE_PERL_SYS_CPU<br>
+       bool &quot;perl-sys-cpu&quot;<br>
+       help<br>
+         perl-sys-cpu<br>
+<br>
diff --git a/package/perl-sys-cpu/perl-<wbr>sys-cpu.hash b/package/perl-sys-cpu/perl-<wbr>sys-cpu.hash<br>
new file mode 100644<br>
index 0000000000..0977606b1a<br>
--- /dev/null<br>
+++ b/package/perl-sys-cpu/perl-<wbr>sys-cpu.hash<br>
@@ -0,0 +1,2 @@<br>
+# locally computed<br>
+sha256 ca0ec47ab24070e3040e5075337cfc<wbr>69721362d9bef50f6992072efe644d<wbr>4d26  Sys-CPU-0.52.tar.gz<br>
diff --git a/package/perl-sys-cpu/<a href="http://perl-sys-cpu.mk" rel="noreferrer" target="_blank">perl-<wbr>sys-cpu.mk</a> b/package/perl-sys-cpu/<a href="http://perl-sys-cpu.mk" rel="noreferrer" target="_blank">perl-<wbr>sys-cpu.mk</a><br>
new file mode 100644<br>
index 0000000000..efc9ee814b<br>
--- /dev/null<br>
+++ b/package/perl-sys-cpu/<a href="http://perl-sys-cpu.mk" rel="noreferrer" target="_blank">perl-<wbr>sys-cpu.mk</a><br>
@@ -0,0 +1,13 @@<br>
+#############################<wbr>##############################<wbr>#####################<br>
+#<br>
+# perl-sys-cpu<br>
+#<br>
+#############################<wbr>##############################<wbr>#####################<br>
+<br>
+PERL_SYS_CPU_VERSION = 0.52<br>
+PERL_SYS_CPU_SOURCE = Sys-CPU-$(PERL_SYS_CPU_<wbr>VERSION).tar.gz<br>
+PERL_SYS_CPU_SITE = $(BR2_CPAN_MIRROR)/authors/id/<wbr>M/MK/MKODERER<br>
+PERL_SYS_CPU_LICENSE = Artistic or GPL-1.0+ # as stated in README file<br>
+PERL_SYS_CPU_LICENSE_FILES = README<br>
+<br>
+$(eval $(perl-package))<br>
<span class="gmail-HOEnZb"><font color="#888888">-- <br>
2.14.4<br>
<br>
______________________________<wbr>_________________<br>
buildroot mailing list<br>
<a href="mailto:buildroot@busybox.net">buildroot@busybox.net</a><br>
<a href="http://lists.busybox.net/mailman/listinfo/buildroot" rel="noreferrer" target="_blank">http://lists.busybox.net/<wbr>mailman/listinfo/buildroot</a><br>
</font></span></blockquote></div><br></div></div>
Thomas Petazzoni Sept. 12, 2018, 8:53 p.m. UTC | #2 
Hello,

On Mon, 20 Aug 2018 04:55:07 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>

I've applied, but I have a number of questions/suggestions again:

 (1) This package builds some native code (CPU.xs), but it doesn't have
     the !BR2_STATIC_LIBS dependency. Is this expected ?

 (2) The README file says "For more details, see the full text of the
     licenses in the directory LICENSES", but there is no such
     directory. Could you report this upstream?

 (3) https://github.com/mzsanford/perl-sys-cpu is a Github repo with
     slightly more recent version. The name of the author "mzsanford"
     is the same as the one listed at
     https://metacpan.org/pod/release/MKODERER/Sys-CPU-0.52/CPU.pm.
     Maybe you should contact the upstream author to report (2) and ask
     to update CPAN with the latest version of the module ?

Thanks!

Thomas
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 410d01b02b..70879360f2 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -503,6 +503,7 @@  F:	package/perl-module-runtime/
 F:	package/perl-number-bytes-human/
 F:	package/perl-params-util/
 F:	package/perl-sub-install/
+F:	package/perl-sys-cpu/
 F:	package/perl-sys-meminfo/
 F:	package/perl-sys-mmap/
 F:	package/perl-time-parsedate/
diff --git a/package/Config.in b/package/Config.in
index c083f4e1bd..fcb67b7617 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -729,6 +729,7 @@  menu "Perl libraries/modules"
 	source "package/perl-params-util/Config.in"
 	source "package/perl-path-tiny/Config.in"
 	source "package/perl-sub-install/Config.in"
+	source "package/perl-sys-cpu/Config.in"
 	source "package/perl-sys-meminfo/Config.in"
 	source "package/perl-sys-mmap/Config.in"
 	source "package/perl-time-hires/Config.in"
diff --git a/package/perl-sys-cpu/Config.in b/package/perl-sys-cpu/Config.in
new file mode 100644
index 0000000000..d5fff5b849
--- /dev/null
+++ b/package/perl-sys-cpu/Config.in
@@ -0,0 +1,5 @@ 
+config BR2_PACKAGE_PERL_SYS_CPU
+	bool "perl-sys-cpu"
+	help
+	  perl-sys-cpu
+
diff --git a/package/perl-sys-cpu/perl-sys-cpu.hash b/package/perl-sys-cpu/perl-sys-cpu.hash
new file mode 100644
index 0000000000..0977606b1a
--- /dev/null
+++ b/package/perl-sys-cpu/perl-sys-cpu.hash
@@ -0,0 +1,2 @@ 
+# locally computed
+sha256 ca0ec47ab24070e3040e5075337cfc69721362d9bef50f6992072efe644d4d26  Sys-CPU-0.52.tar.gz
diff --git a/package/perl-sys-cpu/perl-sys-cpu.mk b/package/perl-sys-cpu/perl-sys-cpu.mk
new file mode 100644
index 0000000000..efc9ee814b
--- /dev/null
+++ b/package/perl-sys-cpu/perl-sys-cpu.mk
@@ -0,0 +1,13 @@ 
+################################################################################
+#
+# perl-sys-cpu
+#
+################################################################################
+
+PERL_SYS_CPU_VERSION = 0.52
+PERL_SYS_CPU_SOURCE = Sys-CPU-$(PERL_SYS_CPU_VERSION).tar.gz
+PERL_SYS_CPU_SITE = $(BR2_CPAN_MIRROR)/authors/id/M/MK/MKODERER
+PERL_SYS_CPU_LICENSE = Artistic or GPL-1.0+ # as stated in README file
+PERL_SYS_CPU_LICENSE_FILES = README
+
+$(eval $(perl-package))