| Message ID | 1534757013-4524-2-git-send-email-avienamo@nvidia.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Tegra SDHCI rerun pad calibration periodically | expand |
On 20/08/18 12:23, Aapo Vienamo wrote: > Allow SDHCI drivers to hook code before and after sdhci_request() by > making it externally visible. > > Signed-off-by: Aapo Vienamo <avienamo@nvidia.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci.c | 3 ++- > drivers/mmc/host/sdhci.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index da47f7b..1e0c0a6 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1636,7 +1636,7 @@ EXPORT_SYMBOL_GPL(sdhci_set_power); > * * > \*****************************************************************************/ > > -static void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq) > +void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq) > { > struct sdhci_host *host; > int present; > @@ -1675,6 +1675,7 @@ static void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq) > mmiowb(); > spin_unlock_irqrestore(&host->lock, flags); > } > +EXPORT_SYMBOL_GPL(sdhci_request); > > void sdhci_set_bus_width(struct sdhci_host *host, int width) > { > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index cc963a5..73c4744 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -729,6 +729,7 @@ void sdhci_set_power(struct sdhci_host *host, unsigned char mode, > unsigned short vdd); > void sdhci_set_power_noreg(struct sdhci_host *host, unsigned char mode, > unsigned short vdd); > +void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq); > void sdhci_set_bus_width(struct sdhci_host *host, int width); > void sdhci_reset(struct sdhci_host *host, u8 mask); > void sdhci_set_uhs_signaling(struct sdhci_host *host, unsigned timing); >
On 20 August 2018 at 11:23, Aapo Vienamo <avienamo@nvidia.com> wrote: > Allow SDHCI drivers to hook code before and after sdhci_request() by > making it externally visible. > > Signed-off-by: Aapo Vienamo <avienamo@nvidia.com> This one happens to be useful for other variants but Tegras, hence I have applied this one for next. Thanks! Thierry, you may thus drop this one from your PR. Also, you should probably base your pull request on top of my next branch, as I have already started to queue up some changes for sdhci. Kind regards Uffe > --- > drivers/mmc/host/sdhci.c | 3 ++- > drivers/mmc/host/sdhci.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index da47f7b..1e0c0a6 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1636,7 +1636,7 @@ EXPORT_SYMBOL_GPL(sdhci_set_power); > * * > \*****************************************************************************/ > > -static void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq) > +void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq) > { > struct sdhci_host *host; > int present; > @@ -1675,6 +1675,7 @@ static void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq) > mmiowb(); > spin_unlock_irqrestore(&host->lock, flags); > } > +EXPORT_SYMBOL_GPL(sdhci_request); > > void sdhci_set_bus_width(struct sdhci_host *host, int width) > { > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index cc963a5..73c4744 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -729,6 +729,7 @@ void sdhci_set_power(struct sdhci_host *host, unsigned char mode, > unsigned short vdd); > void sdhci_set_power_noreg(struct sdhci_host *host, unsigned char mode, > unsigned short vdd); > +void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq); > void sdhci_set_bus_width(struct sdhci_host *host, int width); > void sdhci_reset(struct sdhci_host *host, u8 mask); > void sdhci_set_uhs_signaling(struct sdhci_host *host, unsigned timing); > -- > 2.7.4 >
On Mon, Aug 27, 2018 at 12:07:08PM +0200, Ulf Hansson wrote: > On 20 August 2018 at 11:23, Aapo Vienamo <avienamo@nvidia.com> wrote: > > Allow SDHCI drivers to hook code before and after sdhci_request() by > > making it externally visible. > > > > Signed-off-by: Aapo Vienamo <avienamo@nvidia.com> > > This one happens to be useful for other variants but Tegras, hence I > have applied this one for next. Thanks! > > Thierry, you may thus drop this one from your PR. Also, you should > probably base your pull request on top of my next branch, as I have > already started to queue up some changes for sdhci. Will do that, thanks. Thierry
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index da47f7b..1e0c0a6 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1636,7 +1636,7 @@ EXPORT_SYMBOL_GPL(sdhci_set_power); * * \*****************************************************************************/ -static void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq) +void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq) { struct sdhci_host *host; int present; @@ -1675,6 +1675,7 @@ static void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq) mmiowb(); spin_unlock_irqrestore(&host->lock, flags); } +EXPORT_SYMBOL_GPL(sdhci_request); void sdhci_set_bus_width(struct sdhci_host *host, int width) { diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index cc963a5..73c4744 100644 --- a/drivers/mmc/host/sdhci.h +++ b/drivers/mmc/host/sdhci.h @@ -729,6 +729,7 @@ void sdhci_set_power(struct sdhci_host *host, unsigned char mode, unsigned short vdd); void sdhci_set_power_noreg(struct sdhci_host *host, unsigned char mode, unsigned short vdd); +void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq); void sdhci_set_bus_width(struct sdhci_host *host, int width); void sdhci_reset(struct sdhci_host *host, u8 mask); void sdhci_set_uhs_signaling(struct sdhci_host *host, unsigned timing);
Allow SDHCI drivers to hook code before and after sdhci_request() by making it externally visible. Signed-off-by: Aapo Vienamo <avienamo@nvidia.com> --- drivers/mmc/host/sdhci.c | 3 ++- drivers/mmc/host/sdhci.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-)