From patchwork Tue May 17 11:00:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 95914 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1F936B6EF1 for ; Tue, 17 May 2011 21:07:04 +1000 (EST) Received: from localhost ([::1]:37431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMI7B-0003gE-4v for incoming@patchwork.ozlabs.org; Tue, 17 May 2011 07:07:01 -0400 Received: from eggs.gnu.org ([140.186.70.92]:40299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMI31-0005dU-IK for qemu-devel@nongnu.org; Tue, 17 May 2011 07:03:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMI2J-00052C-UY for qemu-devel@nongnu.org; Tue, 17 May 2011 07:02:43 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:62390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMI2J-0004zX-PC for qemu-devel@nongnu.org; Tue, 17 May 2011 07:01:59 -0400 Received: by mail-iy0-f173.google.com with SMTP id 10so365615iym.4 for ; Tue, 17 May 2011 04:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:from:to:subject:date:message-id:x-mailer :in-reply-to:references; bh=eT5zHpVcywxHvj9rM+tPO+P8jmaqmbAd2fmEkCjIQv8=; b=CwntZXoJKxIodVg+t79wGWWMBito70yvB58bTzWB7F4vOYLxV99wQSn1XLaBV3gWA7 ldAh4Z/QNXa7uVlNpbwZhdTKe+455V+am2tUFniHDz6oO6jpQtBna8id6XVkIk5Ze7uv yXNxdmEdyhu4UwgZW+sbXAsGsIPM+E/FLYR+s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; b=p1347jyLr9Ie8fI+9TH7tZZt3Mm3FN/Uacuao/F2vaj6e/XxC5xXuB7AGt/4aGF5xl uwXHrhBRGrfzkNOVWYTxAlI8FDwka686SilRNkJm9vB8cCwh4ruy4pm27gsPQxSb9wtd YvAp7NqQnmtTbuCKJEnK1qK6+KYI+XuWcMgT4= Received: by 10.42.1.82 with SMTP id 18mr531092icf.274.1305630119430; Tue, 17 May 2011 04:01:59 -0700 (PDT) Received: from localhost.localdomain (93-34-184-88.ip51.fastwebnet.it [93.34.184.88]) by mx.google.com with ESMTPS id c16sm211390ibe.41.2011.05.17.04.01.57 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 17 May 2011 04:01:58 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 17 May 2011 13:00:57 +0200 Message-Id: <1305630067-2119-12-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1305630067-2119-1-git-send-email-pbonzini@redhat.com> References: <1305630067-2119-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.210.173 Subject: [Qemu-devel] [PATCH v3 11/21] scsi: use scsi_req_complete X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Paolo Bonzini Reviewed-by: Christoph Hellwig --- hw/scsi-generic.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index 5bfbb8a..e1f8a8a 100644 --- a/hw/scsi-generic.c +++ b/hw/scsi-generic.c @@ -288,7 +288,6 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *cmd) { SCSIGenericState *s = DO_UPCAST(SCSIGenericState, qdev, req->dev); SCSIGenericReq *r = DO_UPCAST(SCSIGenericReq, req, req); - SCSIBus *bus; int ret; scsi_req_enqueue(req); @@ -305,8 +304,8 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *cmd) s->sensebuf[6] = 0x00; s->senselen = 7; s->driver_status = SG_ERR_DRIVER_SENSE; - bus = scsi_bus_from_device(&s->qdev); - bus->ops.complete(req, SCSI_REASON_DONE, CHECK_CONDITION); + r->req.status = CHECK_CONDITION; + scsi_req_complete(&r->req); return 0; }