Message ID | 20081119133408.GE26308@kernel.dk (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers | show |
Hi Jens, On Wed, 19 Nov 2008 14:34:09 +0100 Jens Axboe <jens.axboe@oracle.com> wrote: > > Are you removing devices or modules? We have a bug there it seems, does > this help? This is early in boot (we are waiting for the root device while running on the initramfs) so there could well be modules being unloaded. That patch makes the problem go away.
On Thu, Nov 20 2008, Stephen Rothwell wrote: > Hi Jens, > > On Wed, 19 Nov 2008 14:34:09 +0100 Jens Axboe <jens.axboe@oracle.com> wrote: > > > > Are you removing devices or modules? We have a bug there it seems, does > > this help? > > This is early in boot (we are waiting for the root device while running > on the initramfs) so there could well be modules being unloaded. > > That patch makes the problem go away. Excellent, since it was an apparent but, I already updated the original patch with this hunk. Thanks a lot for your bisection work, Stephen!
diff --git a/block/blk-core.c b/block/blk-core.c index 04267d6..44f547c 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -391,6 +391,7 @@ EXPORT_SYMBOL(blk_stop_queue); void blk_sync_queue(struct request_queue *q) { del_timer_sync(&q->unplug_timer); + del_timer_sync(&q->timeout); kblockd_flush_work(&q->unplug_work); } EXPORT_SYMBOL(blk_sync_queue);