docker: Update to Ubuntu 18.04 LTS
diff mbox series

Message ID 20180817053932.8652-1-joel@jms.id.au
State Accepted
Headers show
Series
  • docker: Update to Ubuntu 18.04 LTS
Related show

Commit Message

Joel Stanley Aug. 17, 2018, 5:39 a.m. UTC
Ubuntu 17.10 was end of life in July. Update to the latest LTS.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
I ran this through travis last night and it passed on both ppc64le and
amd64 builders. I don't have an arm64 machine to test that architecture.

 docker/builder-include | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Geoff Levand Aug. 17, 2018, 3:48 p.m. UTC | #1
Hi Joel,

On 08/16/2018 10:39 PM, Joel Stanley wrote:
> Ubuntu 17.10 was end of life in July. Update to the latest LTS.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> I ran this through travis last night and it passed on both ppc64le and
> amd64 builders. I don't have an arm64 machine to test that architecture.
> 
>  docker/builder-include | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/docker/builder-include b/docker/builder-include
> index 585be2656df6..783f0101dbd2 100644
> --- a/docker/builder-include
> +++ b/docker/builder-include
> @@ -23,9 +23,9 @@ docker_from() {
>  	local a="$(arch)"
>  
>  	case "${a}" in
> -		amd64) echo "ubuntu:17.10" ;;
> -		arm64) echo "arm64v8/ubuntu:17.10" ;;
> -		ppc64le) echo "ppc64le/ubuntu:17.10" ;;
> +		amd64) echo "ubuntu:18.04" ;;
> +		arm64) echo "arm64v8/ubuntu:18.04" ;;
> +		ppc64le) echo "ppc64le/ubuntu:18.04" ;;
>  		*)
>  			echo "${name}: ERROR: Unknown arch ${a}" >&2
>  			exit 1
> 

Please increment the docker image tag also:

-: ${VERSION:="3"}
+: ${VERSION:="4"}

-Geoff
Samuel Mendoza-Jonas Aug. 28, 2018, 7:01 a.m. UTC | #2
On Fri, 2018-08-17 at 15:09 +0930, Joel Stanley wrote:
> Ubuntu 17.10 was end of life in July. Update to the latest LTS.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> I ran this through travis last night and it passed on both ppc64le and
> amd64 builders. I don't have an arm64 machine to test that architecture.

Thanks, merged as 8789ca23 (and I bumped the tag number).

> 
>  docker/builder-include | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/docker/builder-include b/docker/builder-include
> index 585be2656df6..783f0101dbd2 100644
> --- a/docker/builder-include
> +++ b/docker/builder-include
> @@ -23,9 +23,9 @@ docker_from() {
>  	local a="$(arch)"
>  
>  	case "${a}" in
> -		amd64) echo "ubuntu:17.10" ;;
> -		arm64) echo "arm64v8/ubuntu:17.10" ;;
> -		ppc64le) echo "ppc64le/ubuntu:17.10" ;;
> +		amd64) echo "ubuntu:18.04" ;;
> +		arm64) echo "arm64v8/ubuntu:18.04" ;;
> +		ppc64le) echo "ppc64le/ubuntu:18.04" ;;
>  		*)
>  			echo "${name}: ERROR: Unknown arch ${a}" >&2
>  			exit 1

Patch
diff mbox series

diff --git a/docker/builder-include b/docker/builder-include
index 585be2656df6..783f0101dbd2 100644
--- a/docker/builder-include
+++ b/docker/builder-include
@@ -23,9 +23,9 @@  docker_from() {
 	local a="$(arch)"
 
 	case "${a}" in
-		amd64) echo "ubuntu:17.10" ;;
-		arm64) echo "arm64v8/ubuntu:17.10" ;;
-		ppc64le) echo "ppc64le/ubuntu:17.10" ;;
+		amd64) echo "ubuntu:18.04" ;;
+		arm64) echo "arm64v8/ubuntu:18.04" ;;
+		ppc64le) echo "ppc64le/ubuntu:18.04" ;;
 		*)
 			echo "${name}: ERROR: Unknown arch ${a}" >&2
 			exit 1