From patchwork Mon May 16 20:37:39 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 95833 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6A9E9B6EED for ; Tue, 17 May 2011 06:38:14 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755725Ab1EPUiI (ORCPT ); Mon, 16 May 2011 16:38:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31467 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755484Ab1EPUiH (ORCPT ); Mon, 16 May 2011 16:38:07 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4GKbSJl002156 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 May 2011 16:37:29 -0400 Received: from redhat.com (vpn-201-150.tlv.redhat.com [10.35.201.150]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4GKbPBr020387; Mon, 16 May 2011 16:37:26 -0400 Date: Mon, 16 May 2011 23:37:39 +0300 From: "Michael S. Tsirkin" To: David Miller Cc: mirq-linux@rere.qmqm.pl, netdev@vger.kernel.org, herbert@gondor.hengli.com.au, bhutchings@solarflare.com Subject: Re: [PATCH] net: Change netdev_fix_features messages loglevel Message-ID: <20110516203739.GC18148@redhat.com> References: <20110516131757.ED57E13A6A@rere.qmqm.pl> <20110516.151434.829498612745581899.davem@davemloft.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110516.151434.829498612745581899.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, May 16, 2011 at 03:14:34PM -0400, David Miller wrote: > From: Michał Mirosław > Date: Mon, 16 May 2011 15:17:57 +0200 (CEST) > > > Those reduced to DEBUG can possibly be triggered by unprivileged processes > > and are nothing exceptional. Illegal checksum combinations can only be > > caused by driver bug, so promote those messages to WARN. > > > > Since GSO without SG will now only cause DEBUG message from > > netdev_fix_features(), remove the workaround from register_netdevice(). > > > > Signed-off-by: Michał Mirosław > > Applied, thanks. Cool, how about we make 'Features changed' debug as well? This way userspace can't fill up the log just by tweaking tun features with an ioctl. Untested, but you get the message. Signed-off-by: Michael S. Tsirkin diff --git a/net/core/dev.c b/net/core/dev.c index 3ed09f8..538a1fe 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -5270,7 +5270,7 @@ int __netdev_update_features(struct net_device *dev) if (dev->features == features) return 0; - netdev_info(dev, "Features changed: 0x%08x -> 0x%08x\n", + netdev_dbg(dev, "Features changed: 0x%08x -> 0x%08x\n", dev->features, features); if (dev->netdev_ops->ndo_set_features)