| Message ID | 1534340948-24093-1-git-send-email-adouglas@cadence.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | Add MSI-X support for cadence EP driver | expand |
Hi, On Wednesday 15 August 2018 07:19 PM, Alan Douglas wrote: > Add set_msix and get_msix functions to driver, and handle > PCI_EPC_IRQ_MSIX request in raise_irq. BAR5 is used for > the MSI-X vectors. > > Signed-off-by: Alan Douglas <adouglas@cadence.com> > --- > drivers/pci/controller/pcie-cadence-ep.c | 107 ++++++++++++++++++++++++++++++- > drivers/pci/controller/pcie-cadence.h | 1 + > 2 files changed, 107 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c > index 1248d75..259b9a6 100644 > --- a/drivers/pci/controller/pcie-cadence-ep.c > +++ b/drivers/pci/controller/pcie-cadence-ep.c > @@ -16,6 +16,7 @@ > #define CDNS_PCIE_EP_MIN_APERTURE 128 /* 128 bytes */ > #define CDNS_PCIE_EP_IRQ_PCI_ADDR_NONE 0x1 > #define CDNS_PCIE_EP_IRQ_PCI_ADDR_LEGACY 0x3 > +#define CDNS_PCIE_EP_MSIX_BAR 0x5 > > /** > * struct cdns_pcie_ep - private data for this PCIe endpoint controller driver > @@ -255,6 +256,43 @@ static int cdns_pcie_ep_get_msi(struct pci_epc *epc, u8 fn) > return mme; > } > > +static int cdns_pcie_ep_get_msix(struct pci_epc *epc, u8 func_no) > +{ > + struct cdns_pcie_ep *ep = epc_get_drvdata(epc); > + struct cdns_pcie *pcie = &ep->pcie; > + u32 cap = CDNS_PCIE_EP_FUNC_MSIX_CAP_OFFSET; > + u32 val, reg; > + > + reg = cap + PCI_MSIX_FLAGS; > + val = cdns_pcie_ep_fn_readw(pcie, func_no, reg); > + if (!(val & PCI_MSIX_FLAGS_ENABLE)) > + return -EINVAL; > + > + val &= PCI_MSIX_FLAGS_QSIZE; > + > + return val; > +} > + > +static int cdns_pcie_ep_set_msix(struct pci_epc *epc, u8 fn, u16 interrupts) > +{ > + struct cdns_pcie_ep *ep = epc_get_drvdata(epc); > + struct cdns_pcie *pcie = &ep->pcie; > + u32 cap = CDNS_PCIE_EP_FUNC_MSIX_CAP_OFFSET; > + u32 val, reg; > + > + reg = cap + PCI_MSIX_FLAGS; > + val = cdns_pcie_ep_fn_readw(pcie, fn, reg); > + val &= ~PCI_MSIX_FLAGS_QSIZE; > + val |= interrupts; > + cdns_pcie_ep_fn_writew(pcie, fn, reg, val); > + /* Set MSIX BAR and offset */ > + cdns_pcie_ep_fn_writel(pcie, fn, 0xb4, CDNS_PCIE_EP_MSIX_BAR); Please add a macro for MSIX table offset. I think it relies on endpoint function driver to invoke set_bar for BAR5? It's possible a function driver can invoke set_msix without set_bar. > + /* Set PBA BAR and offset. BAR must match MSIX BAR */ > + cdns_pcie_ep_fn_writel(pcie, fn, 0xb8, 0x10000 | CDNS_PCIE_EP_MSIX_BAR); Here too add a macro for PBA. How did you get the 0x10000? Thanks Kishon
Hi, On 04 September 2018 05:46, Kishon Vijay Abraham I wrote: > On Wednesday 15 August 2018 07:19 PM, Alan Douglas wrote: > > Add set_msix and get_msix functions to driver, and handle > > PCI_EPC_IRQ_MSIX request in raise_irq. BAR5 is used for > > the MSI-X vectors. > > > > Signed-off-by: Alan Douglas <adouglas@cadence.com> > > --- > > drivers/pci/controller/pcie-cadence-ep.c | 107 ++++++++++++++++++++++++++++++- > > drivers/pci/controller/pcie-cadence.h | 1 + > > 2 files changed, 107 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c > > index 1248d75..259b9a6 100644 > > --- a/drivers/pci/controller/pcie-cadence-ep.c > > +++ b/drivers/pci/controller/pcie-cadence-ep.c > > @@ -16,6 +16,7 @@ > > #define CDNS_PCIE_EP_MIN_APERTURE 128 /* 128 bytes */ > > #define CDNS_PCIE_EP_IRQ_PCI_ADDR_NONE 0x1 > > #define CDNS_PCIE_EP_IRQ_PCI_ADDR_LEGACY 0x3 > > +#define CDNS_PCIE_EP_MSIX_BAR 0x5 > > > > /** > > * struct cdns_pcie_ep - private data for this PCIe endpoint controller driver > > @@ -255,6 +256,43 @@ static int cdns_pcie_ep_get_msi(struct pci_epc *epc, u8 fn) > > return mme; > > } > > > > +static int cdns_pcie_ep_get_msix(struct pci_epc *epc, u8 func_no) > > +{ > > + struct cdns_pcie_ep *ep = epc_get_drvdata(epc); > > + struct cdns_pcie *pcie = &ep->pcie; > > + u32 cap = CDNS_PCIE_EP_FUNC_MSIX_CAP_OFFSET; > > + u32 val, reg; > > + > > + reg = cap + PCI_MSIX_FLAGS; > > + val = cdns_pcie_ep_fn_readw(pcie, func_no, reg); > > + if (!(val & PCI_MSIX_FLAGS_ENABLE)) > > + return -EINVAL; > > + > > + val &= PCI_MSIX_FLAGS_QSIZE; > > + > > + return val; > > +} > > + > > +static int cdns_pcie_ep_set_msix(struct pci_epc *epc, u8 fn, u16 interrupts) > > +{ > > + struct cdns_pcie_ep *ep = epc_get_drvdata(epc); > > + struct cdns_pcie *pcie = &ep->pcie; > > + u32 cap = CDNS_PCIE_EP_FUNC_MSIX_CAP_OFFSET; > > + u32 val, reg; > > + > > + reg = cap + PCI_MSIX_FLAGS; > > + val = cdns_pcie_ep_fn_readw(pcie, fn, reg); > > + val &= ~PCI_MSIX_FLAGS_QSIZE; > > + val |= interrupts; > > + cdns_pcie_ep_fn_writew(pcie, fn, reg, val); > > + /* Set MSIX BAR and offset */ > > + cdns_pcie_ep_fn_writel(pcie, fn, 0xb4, CDNS_PCIE_EP_MSIX_BAR); > > Please add a macro for MSIX table offset. > I think it relies on endpoint function driver to invoke set_bar for > BAR5? It's possible a function driver can invoke set_msix without set_bar. > I'll add a macro for MSIX table offset. Yes, it relies on the BAR being set up already. I'll add code to check BAR exists and is large enough, and create it if not. > > + /* Set PBA BAR and offset. BAR must match MSIX BAR */ > > + cdns_pcie_ep_fn_writel(pcie, fn, 0xb8, 0x10000 | CDNS_PCIE_EP_MSIX_BAR); > > Here too add a macro for PBA. > How did you get the 0x10000? I'll add a macro for PBA. The 0x10000 (32*2048) is to allow space in the BAR for 2048 MSI-X vectors beneath the PBA. Actually, I could change this to 32*interrupts so that the BAR size can be minimized depending on the number of MSI-X programmed. Thanks for your comments, Alan
On Tue, Sep 04, 2018 at 09:32:56AM +0000, Alan Douglas wrote: > Hi, > On 04 September 2018 05:46, Kishon Vijay Abraham I wrote: > > On Wednesday 15 August 2018 07:19 PM, Alan Douglas wrote: > > > Add set_msix and get_msix functions to driver, and handle > > > PCI_EPC_IRQ_MSIX request in raise_irq. BAR5 is used for > > > the MSI-X vectors. > > > > > > Signed-off-by: Alan Douglas <adouglas@cadence.com> > > > --- > > > drivers/pci/controller/pcie-cadence-ep.c | 107 ++++++++++++++++++++++++++++++- > > > drivers/pci/controller/pcie-cadence.h | 1 + > > > 2 files changed, 107 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c > > > index 1248d75..259b9a6 100644 > > > --- a/drivers/pci/controller/pcie-cadence-ep.c > > > +++ b/drivers/pci/controller/pcie-cadence-ep.c > > > @@ -16,6 +16,7 @@ > > > #define CDNS_PCIE_EP_MIN_APERTURE 128 /* 128 bytes */ > > > #define CDNS_PCIE_EP_IRQ_PCI_ADDR_NONE 0x1 > > > #define CDNS_PCIE_EP_IRQ_PCI_ADDR_LEGACY 0x3 > > > +#define CDNS_PCIE_EP_MSIX_BAR 0x5 > > > > > > /** > > > * struct cdns_pcie_ep - private data for this PCIe endpoint controller driver > > > @@ -255,6 +256,43 @@ static int cdns_pcie_ep_get_msi(struct pci_epc *epc, u8 fn) > > > return mme; > > > } > > > > > > +static int cdns_pcie_ep_get_msix(struct pci_epc *epc, u8 func_no) > > > +{ > > > + struct cdns_pcie_ep *ep = epc_get_drvdata(epc); > > > + struct cdns_pcie *pcie = &ep->pcie; > > > + u32 cap = CDNS_PCIE_EP_FUNC_MSIX_CAP_OFFSET; > > > + u32 val, reg; > > > + > > > + reg = cap + PCI_MSIX_FLAGS; > > > + val = cdns_pcie_ep_fn_readw(pcie, func_no, reg); > > > + if (!(val & PCI_MSIX_FLAGS_ENABLE)) > > > + return -EINVAL; > > > + > > > + val &= PCI_MSIX_FLAGS_QSIZE; > > > + > > > + return val; > > > +} > > > + > > > +static int cdns_pcie_ep_set_msix(struct pci_epc *epc, u8 fn, u16 interrupts) > > > +{ > > > + struct cdns_pcie_ep *ep = epc_get_drvdata(epc); > > > + struct cdns_pcie *pcie = &ep->pcie; > > > + u32 cap = CDNS_PCIE_EP_FUNC_MSIX_CAP_OFFSET; > > > + u32 val, reg; > > > + > > > + reg = cap + PCI_MSIX_FLAGS; > > > + val = cdns_pcie_ep_fn_readw(pcie, fn, reg); > > > + val &= ~PCI_MSIX_FLAGS_QSIZE; > > > + val |= interrupts; > > > + cdns_pcie_ep_fn_writew(pcie, fn, reg, val); > > > + /* Set MSIX BAR and offset */ > > > + cdns_pcie_ep_fn_writel(pcie, fn, 0xb4, CDNS_PCIE_EP_MSIX_BAR); > > > > Please add a macro for MSIX table offset. > > I think it relies on endpoint function driver to invoke set_bar for > > BAR5? It's possible a function driver can invoke set_msix without set_bar. > > > I'll add a macro for MSIX table offset. > Yes, it relies on the BAR being set up already. I'll add code to check BAR > exists and is large enough, and create it if not. > > > > + /* Set PBA BAR and offset. BAR must match MSIX BAR */ > > > + cdns_pcie_ep_fn_writel(pcie, fn, 0xb8, 0x10000 | CDNS_PCIE_EP_MSIX_BAR); > > > > Here too add a macro for PBA. > > How did you get the 0x10000? > I'll add a macro for PBA. > The 0x10000 (32*2048) is to allow space in the BAR for 2048 MSI-X vectors beneath > the PBA. Actually, I could change this to 32*interrupts so that the BAR size can be > minimized depending on the number of MSI-X programmed. > > Thanks for your comments, > Alan Hi Alan, should I expect a v3 for this series to address Kishon's comments ? Please let me know, the previous fixes look OK to me. Thanks, Lorenzo
Hi Lorenzo, On 17 September 2018 16:26 Lorenzo Pieralisi wrote: > On Tue, Sep 04, 2018 at 09:32:56AM +0000, Alan Douglas wrote: > > Hi, > > On 04 September 2018 05:46, Kishon Vijay Abraham I wrote: > > > On Wednesday 15 August 2018 07:19 PM, Alan Douglas wrote: > > > > Add set_msix and get_msix functions to driver, and handle > > > > PCI_EPC_IRQ_MSIX request in raise_irq. BAR5 is used for > > > > the MSI-X vectors. > > > > > > > > Signed-off-by: Alan Douglas <adouglas@cadence.com> > > > > --- > > > > drivers/pci/controller/pcie-cadence-ep.c | 107 ++++++++++++++++++++++++++++++- > > > > drivers/pci/controller/pcie-cadence.h | 1 + > > > > 2 files changed, 107 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c > > > > index 1248d75..259b9a6 100644 > > > > --- a/drivers/pci/controller/pcie-cadence-ep.c > > > > +++ b/drivers/pci/controller/pcie-cadence-ep.c > > > > @@ -16,6 +16,7 @@ > > > > #define CDNS_PCIE_EP_MIN_APERTURE 128 /* 128 bytes */ > > > > #define CDNS_PCIE_EP_IRQ_PCI_ADDR_NONE 0x1 > > > > #define CDNS_PCIE_EP_IRQ_PCI_ADDR_LEGACY 0x3 > > > > +#define CDNS_PCIE_EP_MSIX_BAR 0x5 > > > > > > > > /** > > > > * struct cdns_pcie_ep - private data for this PCIe endpoint controller driver > > > > @@ -255,6 +256,43 @@ static int cdns_pcie_ep_get_msi(struct pci_epc *epc, u8 fn) > > > > return mme; > > > > } > > > > > > > > +static int cdns_pcie_ep_get_msix(struct pci_epc *epc, u8 func_no) > > > > +{ > > > > + struct cdns_pcie_ep *ep = epc_get_drvdata(epc); > > > > + struct cdns_pcie *pcie = &ep->pcie; > > > > + u32 cap = CDNS_PCIE_EP_FUNC_MSIX_CAP_OFFSET; > > > > + u32 val, reg; > > > > + > > > > + reg = cap + PCI_MSIX_FLAGS; > > > > + val = cdns_pcie_ep_fn_readw(pcie, func_no, reg); > > > > + if (!(val & PCI_MSIX_FLAGS_ENABLE)) > > > > + return -EINVAL; > > > > + > > > > + val &= PCI_MSIX_FLAGS_QSIZE; > > > > + > > > > + return val; > > > > +} > > > > + > > > > +static int cdns_pcie_ep_set_msix(struct pci_epc *epc, u8 fn, u16 interrupts) > > > > +{ > > > > + struct cdns_pcie_ep *ep = epc_get_drvdata(epc); > > > > + struct cdns_pcie *pcie = &ep->pcie; > > > > + u32 cap = CDNS_PCIE_EP_FUNC_MSIX_CAP_OFFSET; > > > > + u32 val, reg; > > > > + > > > > + reg = cap + PCI_MSIX_FLAGS; > > > > + val = cdns_pcie_ep_fn_readw(pcie, fn, reg); > > > > + val &= ~PCI_MSIX_FLAGS_QSIZE; > > > > + val |= interrupts; > > > > + cdns_pcie_ep_fn_writew(pcie, fn, reg, val); > > > > + /* Set MSIX BAR and offset */ > > > > + cdns_pcie_ep_fn_writel(pcie, fn, 0xb4, CDNS_PCIE_EP_MSIX_BAR); > > > > > > Please add a macro for MSIX table offset. > > > I think it relies on endpoint function driver to invoke set_bar for > > > BAR5? It's possible a function driver can invoke set_msix without set_bar. > > > > > I'll add a macro for MSIX table offset. > > Yes, it relies on the BAR being set up already. I'll add code to check BAR > > exists and is large enough, and create it if not. > > > > > > + /* Set PBA BAR and offset. BAR must match MSIX BAR */ > > > > + cdns_pcie_ep_fn_writel(pcie, fn, 0xb8, 0x10000 | CDNS_PCIE_EP_MSIX_BAR); > > > > > > Here too add a macro for PBA. > > > How did you get the 0x10000? > > I'll add a macro for PBA. > > The 0x10000 (32*2048) is to allow space in the BAR for 2048 MSI-X vectors beneath > > the PBA. Actually, I could change this to 32*interrupts so that the BAR size can be > > minimized depending on the number of MSI-X programmed. > > > > Thanks for your comments, > > Alan > > Hi Alan, > > should I expect a v3 for this series to address Kishon's comments ? > Please let me know, the previous fixes look OK to me. > I'm preparing a v3 which will check that the BAR to be used for MSI-X has been set up, and will return -EINVAL if not. I couldn't find a suitable way to allocate the BAR inside the set_msix function. It will also address Kishon's other comments. I expect to send it tomorrow, just back from holiday today. Regards, Alan
diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c index 1248d75..259b9a6 100644 --- a/drivers/pci/controller/pcie-cadence-ep.c +++ b/drivers/pci/controller/pcie-cadence-ep.c @@ -16,6 +16,7 @@ #define CDNS_PCIE_EP_MIN_APERTURE 128 /* 128 bytes */ #define CDNS_PCIE_EP_IRQ_PCI_ADDR_NONE 0x1 #define CDNS_PCIE_EP_IRQ_PCI_ADDR_LEGACY 0x3 +#define CDNS_PCIE_EP_MSIX_BAR 0x5 /** * struct cdns_pcie_ep - private data for this PCIe endpoint controller driver @@ -255,6 +256,43 @@ static int cdns_pcie_ep_get_msi(struct pci_epc *epc, u8 fn) return mme; } +static int cdns_pcie_ep_get_msix(struct pci_epc *epc, u8 func_no) +{ + struct cdns_pcie_ep *ep = epc_get_drvdata(epc); + struct cdns_pcie *pcie = &ep->pcie; + u32 cap = CDNS_PCIE_EP_FUNC_MSIX_CAP_OFFSET; + u32 val, reg; + + reg = cap + PCI_MSIX_FLAGS; + val = cdns_pcie_ep_fn_readw(pcie, func_no, reg); + if (!(val & PCI_MSIX_FLAGS_ENABLE)) + return -EINVAL; + + val &= PCI_MSIX_FLAGS_QSIZE; + + return val; +} + +static int cdns_pcie_ep_set_msix(struct pci_epc *epc, u8 fn, u16 interrupts) +{ + struct cdns_pcie_ep *ep = epc_get_drvdata(epc); + struct cdns_pcie *pcie = &ep->pcie; + u32 cap = CDNS_PCIE_EP_FUNC_MSIX_CAP_OFFSET; + u32 val, reg; + + reg = cap + PCI_MSIX_FLAGS; + val = cdns_pcie_ep_fn_readw(pcie, fn, reg); + val &= ~PCI_MSIX_FLAGS_QSIZE; + val |= interrupts; + cdns_pcie_ep_fn_writew(pcie, fn, reg, val); + /* Set MSIX BAR and offset */ + cdns_pcie_ep_fn_writel(pcie, fn, 0xb4, CDNS_PCIE_EP_MSIX_BAR); + /* Set PBA BAR and offset. BAR must match MSIX BAR */ + cdns_pcie_ep_fn_writel(pcie, fn, 0xb8, 0x10000 | CDNS_PCIE_EP_MSIX_BAR); + + return 0; +} + static void cdns_pcie_ep_assert_intx(struct cdns_pcie_ep *ep, u8 fn, u8 intx, bool is_asserted) { @@ -366,8 +404,69 @@ static int cdns_pcie_ep_send_msi_irq(struct cdns_pcie_ep *ep, u8 fn, return 0; } +static int cdns_pcie_ep_send_msix_irq(struct cdns_pcie_ep *ep, u8 fn, + u16 interrupt_num) +{ + struct cdns_pcie *pcie = &ep->pcie; + u32 cap = CDNS_PCIE_EP_FUNC_MSIX_CAP_OFFSET; + u16 flags; + u64 pci_addr_mask = 0xff; + u16 tbl_offset = 0; + u32 bar_addr_upper, bar_addr_lower; + u32 msg_addr_upper, msg_addr_lower; + u32 msg_data; + u64 tbl_addr, msg_addr; + void __iomem *msix_tbl; + + /* Check whether the MSI-X feature has been enabled by the PCI host. */ + flags = cdns_pcie_ep_fn_readw(pcie, fn, cap + PCI_MSIX_FLAGS); + if (!(flags & PCI_MSIX_FLAGS_ENABLE)) + return -EINVAL; + /* We want local address, not address on host. Table is at offset 0 */ + bar_addr_lower = cdns_pcie_readl(pcie, + CDNS_PCIE_AT_IB_EP_FUNC_BAR_ADDR0(fn, CDNS_PCIE_EP_MSIX_BAR)); + bar_addr_upper = cdns_pcie_readl(pcie, + CDNS_PCIE_AT_IB_EP_FUNC_BAR_ADDR1(fn, CDNS_PCIE_EP_MSIX_BAR)); + + tbl_addr = ((u64)bar_addr_upper) << 32 | bar_addr_lower; + tbl_addr += (tbl_offset + ((interrupt_num - 1) * PCI_MSIX_ENTRY_SIZE)); + tbl_addr &= PCI_BASE_ADDRESS_MEM_MASK; + msix_tbl = phys_to_virt(tbl_addr); + if (!msix_tbl) + return -EINVAL; + + msg_addr_lower = readl(msix_tbl + PCI_MSIX_ENTRY_LOWER_ADDR); + msg_addr_upper = readl(msix_tbl + PCI_MSIX_ENTRY_UPPER_ADDR); + msg_addr = ((u64)msg_addr_upper) << 32 | msg_addr_lower; + + msg_data = readl(msix_tbl + PCI_MSIX_ENTRY_VECTOR_CTRL); + if (msg_data & 0x1) + return -EINVAL; + + msg_data = readl(msix_tbl + PCI_MSIX_ENTRY_DATA); + + iounmap(msix_tbl); + + /* Set the outbound region if needed. */ + if (unlikely(ep->irq_pci_addr != (msg_addr & ~pci_addr_mask) || + ep->irq_pci_fn != fn)) { + /* First region was reserved for IRQ writes. */ + cdns_pcie_set_outbound_region(pcie, fn, 0, + false, + ep->irq_phys_addr, + msg_addr & ~pci_addr_mask, + pci_addr_mask + 1); + ep->irq_pci_addr = (msg_addr & ~pci_addr_mask); + ep->irq_pci_fn = fn; + } + writel(msg_data, ep->irq_cpu_addr + (msg_addr & pci_addr_mask)); + + return 0; +} + static int cdns_pcie_ep_raise_irq(struct pci_epc *epc, u8 fn, - enum pci_epc_irq_type type, u8 interrupt_num) + enum pci_epc_irq_type type, + u16 interrupt_num) { struct cdns_pcie_ep *ep = epc_get_drvdata(epc); u32 link_status; @@ -384,6 +483,9 @@ static int cdns_pcie_ep_raise_irq(struct pci_epc *epc, u8 fn, case PCI_EPC_IRQ_MSI: return cdns_pcie_ep_send_msi_irq(ep, fn, interrupt_num); + case PCI_EPC_IRQ_MSIX: + return cdns_pcie_ep_send_msix_irq(ep, fn, interrupt_num); + default: break; } @@ -430,6 +532,8 @@ static int cdns_pcie_ep_start(struct pci_epc *epc) .unmap_addr = cdns_pcie_ep_unmap_addr, .set_msi = cdns_pcie_ep_set_msi, .get_msi = cdns_pcie_ep_get_msi, + .set_msix = cdns_pcie_ep_set_msix, + .get_msix = cdns_pcie_ep_get_msix, .raise_irq = cdns_pcie_ep_raise_irq, .start = cdns_pcie_ep_start, }; @@ -501,6 +605,7 @@ static int cdns_pcie_ep_probe(struct platform_device *pdev) } epc_set_drvdata(epc, ep); + epc->features |= EPC_FEATURE_MSIX_AVAILABLE; if (of_property_read_u8(np, "max-functions", &epc->max_functions) < 0) epc->max_functions = 1; diff --git a/drivers/pci/controller/pcie-cadence.h b/drivers/pci/controller/pcie-cadence.h index 4bb2733..bd83b5b 100644 --- a/drivers/pci/controller/pcie-cadence.h +++ b/drivers/pci/controller/pcie-cadence.h @@ -93,6 +93,7 @@ #define CDNS_PCIE_EP_FUNC_BASE(fn) (((fn) << 12) & GENMASK(19, 12)) #define CDNS_PCIE_EP_FUNC_MSI_CAP_OFFSET 0x90 +#define CDNS_PCIE_EP_FUNC_MSIX_CAP_OFFSET 0xb0 /* * Root Port Registers (PCI configuration space for the root port function)
Add set_msix and get_msix functions to driver, and handle PCI_EPC_IRQ_MSIX request in raise_irq. BAR5 is used for the MSI-X vectors. Signed-off-by: Alan Douglas <adouglas@cadence.com> --- drivers/pci/controller/pcie-cadence-ep.c | 107 ++++++++++++++++++++++++++++++- drivers/pci/controller/pcie-cadence.h | 1 + 2 files changed, 107 insertions(+), 1 deletion(-)