| Message ID | 20180815095731.7282-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | lib/src/fwts_acpi_tables: remove shadowed pointer ptr | expand |
On 2018-08-15 02:57 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Pointer 'ptr' can be removed as it is a shadow of a previously > declared pointer with the same name and we don't need another > copy of one of the same name. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_acpi_tables.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c > index f28ed60a..ccf0a7b1 100644 > --- a/src/lib/src/fwts_acpi_tables.c > +++ b/src/lib/src/fwts_acpi_tables.c > @@ -595,7 +595,6 @@ static uint8_t *fwts_acpi_load_table_from_acpidump( > */ > while (fgets(buffer, sizeof(buffer), fp) ) { > uint8_t *new_tmp; > - char *ptr; > int n; > > /* Get offset */ > Acked-by: Alex Hung <alex.hung@canonical.com>
On 08/15/2018 05:57 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Pointer 'ptr' can be removed as it is a shadow of a previously > declared pointer with the same name and we don't need another > copy of one of the same name. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_acpi_tables.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c > index f28ed60a..ccf0a7b1 100644 > --- a/src/lib/src/fwts_acpi_tables.c > +++ b/src/lib/src/fwts_acpi_tables.c > @@ -595,7 +595,6 @@ static uint8_t *fwts_acpi_load_table_from_acpidump( > */ > while (fgets(buffer, sizeof(buffer), fp) ) { > uint8_t *new_tmp; > - char *ptr; > int n; > > /* Get offset */ Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c index f28ed60a..ccf0a7b1 100644 --- a/src/lib/src/fwts_acpi_tables.c +++ b/src/lib/src/fwts_acpi_tables.c @@ -595,7 +595,6 @@ static uint8_t *fwts_acpi_load_table_from_acpidump( */ while (fgets(buffer, sizeof(buffer), fp) ) { uint8_t *new_tmp; - char *ptr; int n; /* Get offset */