[5/5] orangefs: cache NULL when both default_acl and acl are NULL

Message ID 20180814141634.5471-5-cgxu519@gmx.com
State Superseded
Headers show
  • [1/5] ext2: cache NULL when both default_acl and acl are NULL
Related show

Commit Message

cgxu519 Aug. 14, 2018, 2:16 p.m.
default_acl and acl of newly created inode will be initiated
as ACL_NOT_CACHED in vfs function inode_init_always() and later
will be updated by calling xxx_init_acl() in specific filesystems.
Howerver, when default_acl and acl are NULL then they keep the value
of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl
in this case.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
 fs/orangefs/acl.c | 3 +++
 1 file changed, 3 insertions(+)


diff --git a/fs/orangefs/acl.c b/fs/orangefs/acl.c
index 10587413b20e..e3b043a263bc 100644
--- a/fs/orangefs/acl.c
+++ b/fs/orangefs/acl.c
@@ -175,6 +175,9 @@  int orangefs_init_acl(struct inode *inode, struct inode *dir)
+	if (!default_acl && !acl)
+		cache_no_acl(inode);
 	/* If mode of the inode was changed, then do a forcible ->setattr */
 	if (mode != inode->i_mode) {
 		memset(&iattr, 0, sizeof iattr);