[2/5] ext4: cache NULL when both default_acl and acl are NULL

Message ID 20180814141634.5471-2-cgxu519@gmx.com
State Superseded
Headers show
  • [1/5] ext2: cache NULL when both default_acl and acl are NULL
Related show

Commit Message

cgxu519 Aug. 14, 2018, 2:16 p.m.
default_acl and acl of newly created inode will be initiated
as ACL_NOT_CACHED in vfs function inode_init_always() and later
will be updated by calling xxx_init_acl() in specific filesystems.
Howerver, when default_acl and acl are NULL then they keep the value
of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl
in this case.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
 fs/ext4/acl.c | 3 +++
 1 file changed, 3 insertions(+)


diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c
index fb50f9aa6ead..69a01d28356d 100644
--- a/fs/ext4/acl.c
+++ b/fs/ext4/acl.c
@@ -291,5 +291,8 @@  ext4_init_acl(handle_t *handle, struct inode *inode, struct inode *dir)
 					       acl, XATTR_CREATE);
+	if (!default_acl && !acl)
+		cache_no_acl(inode);
 	return error;