Patchwork qed: support for growing images

login
register
mail settings
Submitter Stefan Hajnoczi
Date May 16, 2011, 12:56 p.m.
Message ID <1305550613-3567-1-git-send-email-stefanha@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/95741/
State New
Headers show

Comments

Stefan Hajnoczi - May 16, 2011, 12:56 p.m.
The .bdrv_truncate() operation resizes images and growing is easy to
implement in QED.  Simply check that the new size is valid and then
update the image_size header field to reflect the new size.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 block/qed.c |   22 +++++++++++++++++++++-
 1 files changed, 21 insertions(+), 1 deletions(-)
Kevin Wolf - May 18, 2011, 12:29 p.m.
Am 16.05.2011 14:56, schrieb Stefan Hajnoczi:
> The .bdrv_truncate() operation resizes images and growing is easy to
> implement in QED.  Simply check that the new size is valid and then
> update the image_size header field to reflect the new size.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Thanks, applied to the block branch.

Kevin

Patch

diff --git a/block/qed.c b/block/qed.c
index c8c5930..bfb49d9 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -1233,7 +1233,27 @@  static BlockDriverAIOCB *bdrv_qed_aio_flush(BlockDriverState *bs,
 
 static int bdrv_qed_truncate(BlockDriverState *bs, int64_t offset)
 {
-    return -ENOTSUP;
+    BDRVQEDState *s = bs->opaque;
+    uint64_t old_image_size;
+    int ret;
+
+    if (!qed_is_image_size_valid(offset, s->header.cluster_size,
+                                 s->header.table_size)) {
+        return -EINVAL;
+    }
+
+    /* Shrinking is currently not supported */
+    if ((uint64_t)offset < s->header.image_size) {
+        return -ENOTSUP;
+    }
+
+    old_image_size = s->header.image_size;
+    s->header.image_size = offset;
+    ret = qed_write_header_sync(s);
+    if (ret < 0) {
+        s->header.image_size = old_image_size;
+    }
+    return ret;
 }
 
 static int64_t bdrv_qed_getlength(BlockDriverState *bs)