From patchwork Mon May 16 11:33:02 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Abort on attempts to load out-of-range ROMs Date: Mon, 16 May 2011 01:33:02 -0000 From: Ben Leslie X-Patchwork-Id: 95710 Message-Id: To: qemu-devel Developers Abort on attempts to load out-of-range ROMs Change ROM loading behaviour so that attempts to load ROMs that fall outside valid memory ranges causing an abort with a useful error message, rather than silently ignoring the problem. Signed-off-by: Ben Leslie --- exec.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) unsigned long addr1; addr1 = (pd & TARGET_PAGE_MASK) + (addr & ~TARGET_PAGE_MASK); diff --git a/exec.c b/exec.c index a718d74..af1b6a2 100644 --- a/exec.c +++ b/exec.c @@ -3838,7 +3838,7 @@ void cpu_physical_memory_write_rom(target_phys_addr_t addr, if ((pd & ~TARGET_PAGE_MASK) != IO_MEM_RAM && (pd & ~TARGET_PAGE_MASK) != IO_MEM_ROM && !(pd & IO_MEM_ROMD)) { - /* do nothing */ + cpu_abort(first_cpu, "Attempting to load malformed ROM at address: 0x%x\n", addr); } else {