diff mbox series

[v2] pinctrl: qcom: Add sdm660 pinctrl driver

Message ID 20180812142413.20856-1-ctatlor97@gmail.com
State New
Headers show
Series [v2] pinctrl: qcom: Add sdm660 pinctrl driver | expand

Commit Message

Craig Tatlor Aug. 12, 2018, 2:24 p.m. UTC
Add initial pinctrl driver to support pin configuration with
pinctrl framework for sdm660.
Based off CAF implementation.

Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
---

Changes from v1:
  Adds gpio-ranges property to bindings


 .../bindings/pinctrl/qcom,sdm660-pinctrl.txt  |  202 +++
 drivers/pinctrl/qcom/Kconfig                  |   10 +
 drivers/pinctrl/qcom/Makefile                 |    1 +
 drivers/pinctrl/qcom/pinctrl-sdm660.c         | 1451 +++++++++++++++++
 4 files changed, 1663 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
 create mode 100644 drivers/pinctrl/qcom/pinctrl-sdm660.c

Comments

Michal Vokáč Aug. 13, 2018, 7:24 a.m. UTC | #1
Hi Craig,
On 12.8.2018 16:24, Craig Tatlor wrote:
> Add initial pinctrl driver to support pin configuration with
> pinctrl framework for sdm660.
> Based off CAF implementation.
> 
> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
> ---

The documentation portion should be a separate patch.
Please refer to Documentation/devicetree/bindings/submitting-patches.txt

It is easier for DT maintainers to review just the relevant part.
The binding patches are also rebased to a separate tree as they are not
Linux specific and can be re-used in other OSes

Best regards,
Michal

> Changes from v1:
>    Adds gpio-ranges property to bindings
> 
> 
>   .../bindings/pinctrl/qcom,sdm660-pinctrl.txt  |  202 +++
>   drivers/pinctrl/qcom/Kconfig                  |   10 +
>   drivers/pinctrl/qcom/Makefile                 |    1 +
>   drivers/pinctrl/qcom/pinctrl-sdm660.c         | 1451 +++++++++++++++++
>   4 files changed, 1663 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>   create mode 100644 drivers/pinctrl/qcom/pinctrl-sdm660.c
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
> new file mode 100644
> index 000000000000..801960ad2112
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
> @@ -0,0 +1,202 @@
> +Qualcomm Technologies, Inc. SDM660 TLMM block
> +
> +This binding describes the Top Level Mode Multiplexer block found in the
> +SDM660 platform.
> +
> +- compatible:
> +	Usage: required
> +	Value type: <string>
> +	Definition: must be "qcom,sdm660-pinctrl"
> +
> +- reg:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: the base address and size of the TLMM register space.
> +
> +- interrupts:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: should specify the TLMM summary IRQ.
> +
> +- interrupt-controller:
> +	Usage: required
> +	Value type: <none>
> +	Definition: identifies this node as an interrupt controller
> +
> +- #interrupt-cells:
> +	Usage: required
> +	Value type: <u32>
> +	Definition: must be 2. Specifying the pin number and flags, as defined
> +		    in <dt-bindings/interrupt-controller/irq.h>
> +
> +- gpio-controller:
> +	Usage: required
> +	Value type: <none>
> +	Definition: identifies this node as a gpio controller
> +
> +- gpio-ranges:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: Specifies the mapping between gpio controller and
> +		    pin-controller pins.
> +
> +- #gpio-cells:
> +	Usage: required
> +	Value type: <u32>
> +	Definition: must be 2. Specifying the pin number and flags, as defined
> +		    in <dt-bindings/gpio/gpio.h>
> +
> +Please refer to ../gpio/gpio.txt and ../interrupt-controller/interrupts.txt for
> +a general description of GPIO and interrupt bindings.
> +
> +Please refer to pinctrl-bindings.txt in this directory for details of the
> +common pinctrl bindings used by client devices, including the meaning of the
> +phrase "pin configuration node".
> +
> +The pin configuration nodes act as a container for an arbitrary number of
> +subnodes. Each of these subnodes represents some desired configuration for a
> +pin, a group, or a list of pins or groups. This configuration can include the
> +mux function to select on those pin(s)/group(s), and various pin configuration
> +parameters, such as pull-up, drive strength, etc.
> +
> +
> +PIN CONFIGURATION NODES:
> +
> +The name of each subnode is not important; all subnodes should be enumerated
> +and processed purely based on their content.
> +
> +Each subnode only affects those parameters that are explicitly listed. In
> +other words, a subnode that lists a mux function but no pin configuration
> +parameters implies no information about any pin configuration parameters.
> +Similarly, a pin subnode that describes a pullup parameter implies no
> +information about e.g. the mux function.
> +
> +
> +The following generic properties as defined in pinctrl-bindings.txt are valid
> +to specify in a pin configuration subnode:
> +
> +- pins:
> +	Usage: required
> +	Value type: <string-array>
> +	Definition: List of gpio pins affected by the properties specified in
> +		    this subnode.  Valid pins are:
> +		    gpio0-gpio113,
> +		        Supports mux, bias and drive-strength
> +		    sdc1_clk, sdc1_cmd, sdc1_data sdc2_clk, sdc2_cmd, sdc2_data sdc1_rclk,
> +		        Supports bias and drive-strength
> +
> +- function:
> +	Usage: required
> +	Value type: <string>
> +	Definition: Specify the alternative function to be configured for the
> +		    specified pins. Functions are only valid for gpio pins.
> +		    Valid values are:
> +
> +		    blsp_uart1, blsp_spi1, blsp_i2c1, blsp_uim1, atest_tsens,
> +		    bimc_dte1, dac_calib0, blsp_spi8, blsp_uart8, blsp_uim8,
> +		    qdss_cti_trig_out_b, bimc_dte0, dac_calib1, qdss_cti_trig_in_b,
> +		    dac_calib2, atest_tsens2, atest_usb1, blsp_spi10, blsp_uart10,
> +		    blsp_uim10, atest_bbrx1, atest_usb13, atest_bbrx0, atest_usb12,
> +		    mdp_vsync, edp_lcd, blsp_i2c10, atest_gpsadc1, atest_usb11,
> +		    atest_gpsadc0, edp_hot, atest_usb10, m_voc, dac_gpio, atest_char,
> +		    cam_mclk, pll_bypassnl, qdss_stm7, blsp_i2c8, qdss_tracedata_b,
> +		    pll_reset, qdss_stm6, qdss_stm5, qdss_stm4, atest_usb2, cci_i2c,
> +		    qdss_stm3, dac_calib3, atest_usb23, atest_char3, dac_calib4,
> +		    qdss_stm2, atest_usb22, atest_char2, qdss_stm1, dac_calib5,
> +		    atest_usb21, atest_char1, dbg_out, qdss_stm0, dac_calib6,
> +		    atest_usb20, atest_char0, dac_calib10, qdss_stm10,
> +		    qdss_cti_trig_in_a, cci_timer4, blsp_spi6, blsp_uart6, blsp_uim6,
> +		    blsp2_spi, qdss_stm9, qdss_cti_trig_out_a, dac_calib11,
> +		    qdss_stm8, cci_timer0, qdss_stm13, dac_calib7, cci_timer1,
> +		    qdss_stm12, dac_calib8, cci_timer2, blsp1_spi, qdss_stm11,
> +		    dac_calib9, cci_timer3, cci_async, dac_calib12, blsp_i2c6,
> +		    qdss_tracectl_a, dac_calib13, qdss_traceclk_a, dac_calib14,
> +		    dac_calib15, hdmi_rcv, dac_calib16, hdmi_cec, pwr_modem,
> +		    dac_calib17, hdmi_ddc, pwr_nav, dac_calib18, pwr_crypto,
> +		    dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0,
> +		    dac_calib22, dac_calib23, dac_calib24, tsif1_sync, dac_calib25,
> +		    sd_write, tsif1_error, blsp_spi2, blsp_uart2, blsp_uim2,
> +		    qdss_cti, blsp_i2c2, blsp_spi3, blsp_uart3, blsp_uim3, blsp_i2c3,
> +		    uim3, blsp_spi9, blsp_uart9, blsp_uim9, blsp10_spi, blsp_i2c9,
> +		    blsp_spi7, blsp_uart7, blsp_uim7, qdss_tracedata_a, blsp_i2c7,
> +		    qua_mi2s, gcc_gp1_clk_a, ssc_irq, uim4, blsp_spi11, blsp_uart11,
> +		    blsp_uim11, gcc_gp2_clk_a, gcc_gp3_clk_a, blsp_i2c11, cri_trng0,
> +		    cri_trng1, cri_trng, qdss_stm18, pri_mi2s, qdss_stm17, blsp_spi4,
> +		    blsp_uart4, blsp_uim4, qdss_stm16, qdss_stm15, blsp_i2c4,
> +		    qdss_stm14, dac_calib26, spkr_i2s, audio_ref, lpass_slimbus,
> +		    isense_dbg, tsense_pwm1, tsense_pwm2, btfm_slimbus, ter_mi2s,
> +		    qdss_stm22, qdss_stm21, qdss_stm20, qdss_stm19, gcc_gp1_clk_b,
> +		    sec_mi2s, blsp_spi5, blsp_uart5, blsp_uim5, gcc_gp2_clk_b,
> +		    gcc_gp3_clk_b, blsp_i2c5, blsp_spi12, blsp_uart12, blsp_uim12,
> +		    qdss_stm25, qdss_stm31, blsp_i2c12, qdss_stm30, qdss_stm29,
> +		    tsif1_clk, qdss_stm28, tsif1_en, tsif1_data, sdc4_cmd, qdss_stm27,
> +		    qdss_traceclk_b, tsif2_error, sdc43, vfr_1, qdss_stm26, tsif2_clk,
> +		    sdc4_clk, qdss_stm24, tsif2_en, sdc42, qdss_stm23, qdss_tracectl_b,
> +		    sd_card, tsif2_data, sdc41, tsif2_sync, sdc40, mdp_vsync_p_b,
> +		    ldo_en, mdp_vsync_s_b, ldo_update, blsp11_uart_tx_b, blsp11_uart_rx_b,
> +		    blsp11_i2c_sda_b, prng_rosc, blsp11_i2c_scl_b, uim2, uim1, uim_batt,
> +		    pci_e2, pa_indicator, adsp_ext, ddr_bist, qdss_tracedata_11,
> +		    qdss_tracedata_12, modem_tsync, nav_dr, nav_pps, pci_e1, gsm_tx,
> +		    qspi_cs, ssbi2, ssbi1, mss_lte, qspi_clk, qspi0, qspi1, qspi2, qspi3,
> +		    gpio
> +
> +- bias-disable:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins should be configued as no pull.
> +
> +- bias-pull-down:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins should be configued as pull down.
> +
> +- bias-pull-up:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins should be configued as pull up.
> +
> +- output-high:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins are configured in output mode, driven
> +		    high.
> +		    Not valid for sdc pins.
> +
> +- output-low:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins are configured in output mode, driven
> +		    low.
> +		    Not valid for sdc pins.
> +
> +- drive-strength:
> +	Usage: optional
> +	Value type: <u32>
> +	Definition: Selects the drive strength for the specified pins, in mA.
> +		    Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16
> +
> +Example:
> +
> +	tlmm: pinctrl@1010000 {
> +		compatible = "qcom,sdm660-pinctrl";
> +		reg = <0x1010000 0x300000>;
> +		interrupts = <0 208 0>;
> +		gpio-controller;
> +		gpio-ranges = <&tlmm 0 0 114>;
> +		#gpio-cells = <2>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +
> +		uart_console_active: uart_console_active {
> +			mux {
> +				pins = "gpio4", "gpio5";
> +				function = "blsp_uart8";
> +			};
> +
> +			config {
> +				pins = "gpio4", "gpio5";
> +				drive-strength = <2>;
> +				bias-disable;
> +			};
> +		};
> +	};
> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
> index 195492033075..091beadb8a1c 100644
> --- a/drivers/pinctrl/qcom/Kconfig
> +++ b/drivers/pinctrl/qcom/Kconfig
> @@ -147,6 +147,16 @@ config PINCTRL_QCOM_SSBI_PMIC
>            which are using SSBI for communication with SoC. Example PMIC's
>            devices are pm8058 and pm8921.
>   
> +config PINCTRL_SDM660
> +       tristate "Qualcomm Technologies Inc SDM660 pin controller driver"
> +       depends on GPIOLIB && OF
> +       select PINCTRL_MSM
> +       help
> +         This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> +         Qualcomm Technologies Inc TLMM block found on the Qualcomm
> +         Technologies Inc SDM660 platform.
> +
> +
>   config PINCTRL_SDM845
>          tristate "Qualcomm Technologies Inc SDM845 pin controller driver"
>          depends on GPIOLIB && OF
> diff --git a/drivers/pinctrl/qcom/Makefile b/drivers/pinctrl/qcom/Makefile
> index 0c6f3ddc296d..9b08808a2f1c 100644
> --- a/drivers/pinctrl/qcom/Makefile
> +++ b/drivers/pinctrl/qcom/Makefile
> @@ -19,4 +19,5 @@ obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-gpio.o
>   obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-mpp.o
>   obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-gpio.o
>   obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-mpp.o
> +obj-$(CONFIG_PINCTRL_SDM660)   += pinctrl-sdm660.o
>   obj-$(CONFIG_PINCTRL_SDM845) += pinctrl-sdm845.o
> diff --git a/drivers/pinctrl/qcom/pinctrl-sdm660.c b/drivers/pinctrl/qcom/pinctrl-sdm660.c
> new file mode 100644
> index 000000000000..ded56111f168
> --- /dev/null
> +++ b/drivers/pinctrl/qcom/pinctrl-sdm660.c
> @@ -0,0 +1,1451 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2018, Craig Tatlor.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/pinctrl/pinctrl.h>
> +
> +#include "pinctrl-msm.h"
> +
> +#define NORTH	0x00900000
> +#define CENTER	0x00500000
> +#define SOUTH	0x00100000
> +#define REG_SIZE 0x1000
> +
> +#define FUNCTION(fname)					\
> +	[msm_mux_##fname] = {		                \
> +		.name = #fname,				\
> +		.groups = fname##_groups,               \
> +		.ngroups = ARRAY_SIZE(fname##_groups),	\
> +	}
> +
> +
> +#define PINGROUP(id, base, f1, f2, f3, f4, f5, f6, f7, f8, f9)	\
> +	{					        \
> +		.name = "gpio" #id,			\
> +		.pins = gpio##id##_pins,		\
> +		.npins = (unsigned)ARRAY_SIZE(gpio##id##_pins),	\
> +		.funcs = (int[]){			\
> +			msm_mux_gpio, /* gpio mode */	\
> +			msm_mux_##f1,			\
> +			msm_mux_##f2,			\
> +			msm_mux_##f3,			\
> +			msm_mux_##f4,			\
> +			msm_mux_##f5,			\
> +			msm_mux_##f6,			\
> +			msm_mux_##f7,			\
> +			msm_mux_##f8,			\
> +			msm_mux_##f9			\
> +		},				        \
> +		.nfuncs = 10,				\
> +		.ctl_reg = base + REG_SIZE * id,	\
> +		.io_reg = base + 0x4 + REG_SIZE * id,		\
> +		.intr_cfg_reg = base + 0x8 + REG_SIZE * id,		\
> +		.intr_status_reg = base + 0xc + REG_SIZE * id,	\
> +		.intr_target_reg = base + 0x8 + REG_SIZE * id,	\
> +		.mux_bit = 2,			\
> +		.pull_bit = 0,			\
> +		.drv_bit = 6,			\
> +		.oe_bit = 9,			\
> +		.in_bit = 0,			\
> +		.out_bit = 1,			\
> +		.intr_enable_bit = 0,		\
> +		.intr_status_bit = 0,		\
> +		.intr_target_bit = 5,		\
> +		.intr_target_kpss_val = 3,	\
> +		.intr_raw_status_bit = 4,	\
> +		.intr_polarity_bit = 1,		\
> +		.intr_detection_bit = 2,	\
> +		.intr_detection_width = 2,	\
> +	}
> +
> +#define SDC_QDSD_PINGROUP(pg_name, ctl, pull, drv)	\
> +	{					        \
> +		.name = #pg_name,			\
> +		.pins = pg_name##_pins,			\
> +		.npins = (unsigned)ARRAY_SIZE(pg_name##_pins),	\
> +		.ctl_reg = ctl,				\
> +		.io_reg = 0,				\
> +		.intr_cfg_reg = 0,			\
> +		.intr_status_reg = 0,			\
> +		.intr_target_reg = 0,			\
> +		.mux_bit = -1,				\
> +		.pull_bit = pull,			\
> +		.drv_bit = drv,				\
> +		.oe_bit = -1,				\
> +		.in_bit = -1,				\
> +		.out_bit = -1,				\
> +		.intr_enable_bit = -1,			\
> +		.intr_status_bit = -1,			\
> +		.intr_target_bit = -1,			\
> +		.intr_raw_status_bit = -1,		\
> +		.intr_polarity_bit = -1,		\
> +		.intr_detection_bit = -1,		\
> +		.intr_detection_width = -1,		\
> +	}
> +
> +static const struct pinctrl_pin_desc sdm660_pins[] = {
> +	PINCTRL_PIN(0, "GPIO_0"),
> +	PINCTRL_PIN(1, "GPIO_1"),
> +	PINCTRL_PIN(2, "GPIO_2"),
> +	PINCTRL_PIN(3, "GPIO_3"),
> +	PINCTRL_PIN(4, "GPIO_4"),
> +	PINCTRL_PIN(5, "GPIO_5"),
> +	PINCTRL_PIN(6, "GPIO_6"),
> +	PINCTRL_PIN(7, "GPIO_7"),
> +	PINCTRL_PIN(8, "GPIO_8"),
> +	PINCTRL_PIN(9, "GPIO_9"),
> +	PINCTRL_PIN(10, "GPIO_10"),
> +	PINCTRL_PIN(11, "GPIO_11"),
> +	PINCTRL_PIN(12, "GPIO_12"),
> +	PINCTRL_PIN(13, "GPIO_13"),
> +	PINCTRL_PIN(14, "GPIO_14"),
> +	PINCTRL_PIN(15, "GPIO_15"),
> +	PINCTRL_PIN(16, "GPIO_16"),
> +	PINCTRL_PIN(17, "GPIO_17"),
> +	PINCTRL_PIN(18, "GPIO_18"),
> +	PINCTRL_PIN(19, "GPIO_19"),
> +	PINCTRL_PIN(20, "GPIO_20"),
> +	PINCTRL_PIN(21, "GPIO_21"),
> +	PINCTRL_PIN(22, "GPIO_22"),
> +	PINCTRL_PIN(23, "GPIO_23"),
> +	PINCTRL_PIN(24, "GPIO_24"),
> +	PINCTRL_PIN(25, "GPIO_25"),
> +	PINCTRL_PIN(26, "GPIO_26"),
> +	PINCTRL_PIN(27, "GPIO_27"),
> +	PINCTRL_PIN(28, "GPIO_28"),
> +	PINCTRL_PIN(29, "GPIO_29"),
> +	PINCTRL_PIN(30, "GPIO_30"),
> +	PINCTRL_PIN(31, "GPIO_31"),
> +	PINCTRL_PIN(32, "GPIO_32"),
> +	PINCTRL_PIN(33, "GPIO_33"),
> +	PINCTRL_PIN(34, "GPIO_34"),
> +	PINCTRL_PIN(35, "GPIO_35"),
> +	PINCTRL_PIN(36, "GPIO_36"),
> +	PINCTRL_PIN(37, "GPIO_37"),
> +	PINCTRL_PIN(38, "GPIO_38"),
> +	PINCTRL_PIN(39, "GPIO_39"),
> +	PINCTRL_PIN(40, "GPIO_40"),
> +	PINCTRL_PIN(41, "GPIO_41"),
> +	PINCTRL_PIN(42, "GPIO_42"),
> +	PINCTRL_PIN(43, "GPIO_43"),
> +	PINCTRL_PIN(44, "GPIO_44"),
> +	PINCTRL_PIN(45, "GPIO_45"),
> +	PINCTRL_PIN(46, "GPIO_46"),
> +	PINCTRL_PIN(47, "GPIO_47"),
> +	PINCTRL_PIN(48, "GPIO_48"),
> +	PINCTRL_PIN(49, "GPIO_49"),
> +	PINCTRL_PIN(50, "GPIO_50"),
> +	PINCTRL_PIN(51, "GPIO_51"),
> +	PINCTRL_PIN(52, "GPIO_52"),
> +	PINCTRL_PIN(53, "GPIO_53"),
> +	PINCTRL_PIN(54, "GPIO_54"),
> +	PINCTRL_PIN(55, "GPIO_55"),
> +	PINCTRL_PIN(56, "GPIO_56"),
> +	PINCTRL_PIN(57, "GPIO_57"),
> +	PINCTRL_PIN(58, "GPIO_58"),
> +	PINCTRL_PIN(59, "GPIO_59"),
> +	PINCTRL_PIN(60, "GPIO_60"),
> +	PINCTRL_PIN(61, "GPIO_61"),
> +	PINCTRL_PIN(62, "GPIO_62"),
> +	PINCTRL_PIN(63, "GPIO_63"),
> +	PINCTRL_PIN(64, "GPIO_64"),
> +	PINCTRL_PIN(65, "GPIO_65"),
> +	PINCTRL_PIN(66, "GPIO_66"),
> +	PINCTRL_PIN(67, "GPIO_67"),
> +	PINCTRL_PIN(68, "GPIO_68"),
> +	PINCTRL_PIN(69, "GPIO_69"),
> +	PINCTRL_PIN(70, "GPIO_70"),
> +	PINCTRL_PIN(71, "GPIO_71"),
> +	PINCTRL_PIN(72, "GPIO_72"),
> +	PINCTRL_PIN(73, "GPIO_73"),
> +	PINCTRL_PIN(74, "GPIO_74"),
> +	PINCTRL_PIN(75, "GPIO_75"),
> +	PINCTRL_PIN(76, "GPIO_76"),
> +	PINCTRL_PIN(77, "GPIO_77"),
> +	PINCTRL_PIN(78, "GPIO_78"),
> +	PINCTRL_PIN(79, "GPIO_79"),
> +	PINCTRL_PIN(80, "GPIO_80"),
> +	PINCTRL_PIN(81, "GPIO_81"),
> +	PINCTRL_PIN(82, "GPIO_82"),
> +	PINCTRL_PIN(83, "GPIO_83"),
> +	PINCTRL_PIN(84, "GPIO_84"),
> +	PINCTRL_PIN(85, "GPIO_85"),
> +	PINCTRL_PIN(86, "GPIO_86"),
> +	PINCTRL_PIN(87, "GPIO_87"),
> +	PINCTRL_PIN(88, "GPIO_88"),
> +	PINCTRL_PIN(89, "GPIO_89"),
> +	PINCTRL_PIN(90, "GPIO_90"),
> +	PINCTRL_PIN(91, "GPIO_91"),
> +	PINCTRL_PIN(92, "GPIO_92"),
> +	PINCTRL_PIN(93, "GPIO_93"),
> +	PINCTRL_PIN(94, "GPIO_94"),
> +	PINCTRL_PIN(95, "GPIO_95"),
> +	PINCTRL_PIN(96, "GPIO_96"),
> +	PINCTRL_PIN(97, "GPIO_97"),
> +	PINCTRL_PIN(98, "GPIO_98"),
> +	PINCTRL_PIN(99, "GPIO_99"),
> +	PINCTRL_PIN(100, "GPIO_100"),
> +	PINCTRL_PIN(101, "GPIO_101"),
> +	PINCTRL_PIN(102, "GPIO_102"),
> +	PINCTRL_PIN(103, "GPIO_103"),
> +	PINCTRL_PIN(104, "GPIO_104"),
> +	PINCTRL_PIN(105, "GPIO_105"),
> +	PINCTRL_PIN(106, "GPIO_106"),
> +	PINCTRL_PIN(107, "GPIO_107"),
> +	PINCTRL_PIN(108, "GPIO_108"),
> +	PINCTRL_PIN(109, "GPIO_109"),
> +	PINCTRL_PIN(110, "GPIO_110"),
> +	PINCTRL_PIN(111, "GPIO_111"),
> +	PINCTRL_PIN(112, "GPIO_112"),
> +	PINCTRL_PIN(113, "GPIO_113"),
> +	PINCTRL_PIN(114, "SDC1_CLK"),
> +	PINCTRL_PIN(115, "SDC1_CMD"),
> +	PINCTRL_PIN(116, "SDC1_DATA"),
> +	PINCTRL_PIN(117, "SDC2_CLK"),
> +	PINCTRL_PIN(118, "SDC2_CMD"),
> +	PINCTRL_PIN(119, "SDC2_DATA"),
> +	PINCTRL_PIN(120, "SDC1_RCLK"),
> +};
> +
> +#define DECLARE_MSM_GPIO_PINS(pin) \
> +	static const unsigned int gpio##pin##_pins[] = { pin }
> +DECLARE_MSM_GPIO_PINS(0);
> +DECLARE_MSM_GPIO_PINS(1);
> +DECLARE_MSM_GPIO_PINS(2);
> +DECLARE_MSM_GPIO_PINS(3);
> +DECLARE_MSM_GPIO_PINS(4);
> +DECLARE_MSM_GPIO_PINS(5);
> +DECLARE_MSM_GPIO_PINS(6);
> +DECLARE_MSM_GPIO_PINS(7);
> +DECLARE_MSM_GPIO_PINS(8);
> +DECLARE_MSM_GPIO_PINS(9);
> +DECLARE_MSM_GPIO_PINS(10);
> +DECLARE_MSM_GPIO_PINS(11);
> +DECLARE_MSM_GPIO_PINS(12);
> +DECLARE_MSM_GPIO_PINS(13);
> +DECLARE_MSM_GPIO_PINS(14);
> +DECLARE_MSM_GPIO_PINS(15);
> +DECLARE_MSM_GPIO_PINS(16);
> +DECLARE_MSM_GPIO_PINS(17);
> +DECLARE_MSM_GPIO_PINS(18);
> +DECLARE_MSM_GPIO_PINS(19);
> +DECLARE_MSM_GPIO_PINS(20);
> +DECLARE_MSM_GPIO_PINS(21);
> +DECLARE_MSM_GPIO_PINS(22);
> +DECLARE_MSM_GPIO_PINS(23);
> +DECLARE_MSM_GPIO_PINS(24);
> +DECLARE_MSM_GPIO_PINS(25);
> +DECLARE_MSM_GPIO_PINS(26);
> +DECLARE_MSM_GPIO_PINS(27);
> +DECLARE_MSM_GPIO_PINS(28);
> +DECLARE_MSM_GPIO_PINS(29);
> +DECLARE_MSM_GPIO_PINS(30);
> +DECLARE_MSM_GPIO_PINS(31);
> +DECLARE_MSM_GPIO_PINS(32);
> +DECLARE_MSM_GPIO_PINS(33);
> +DECLARE_MSM_GPIO_PINS(34);
> +DECLARE_MSM_GPIO_PINS(35);
> +DECLARE_MSM_GPIO_PINS(36);
> +DECLARE_MSM_GPIO_PINS(37);
> +DECLARE_MSM_GPIO_PINS(38);
> +DECLARE_MSM_GPIO_PINS(39);
> +DECLARE_MSM_GPIO_PINS(40);
> +DECLARE_MSM_GPIO_PINS(41);
> +DECLARE_MSM_GPIO_PINS(42);
> +DECLARE_MSM_GPIO_PINS(43);
> +DECLARE_MSM_GPIO_PINS(44);
> +DECLARE_MSM_GPIO_PINS(45);
> +DECLARE_MSM_GPIO_PINS(46);
> +DECLARE_MSM_GPIO_PINS(47);
> +DECLARE_MSM_GPIO_PINS(48);
> +DECLARE_MSM_GPIO_PINS(49);
> +DECLARE_MSM_GPIO_PINS(50);
> +DECLARE_MSM_GPIO_PINS(51);
> +DECLARE_MSM_GPIO_PINS(52);
> +DECLARE_MSM_GPIO_PINS(53);
> +DECLARE_MSM_GPIO_PINS(54);
> +DECLARE_MSM_GPIO_PINS(55);
> +DECLARE_MSM_GPIO_PINS(56);
> +DECLARE_MSM_GPIO_PINS(57);
> +DECLARE_MSM_GPIO_PINS(58);
> +DECLARE_MSM_GPIO_PINS(59);
> +DECLARE_MSM_GPIO_PINS(60);
> +DECLARE_MSM_GPIO_PINS(61);
> +DECLARE_MSM_GPIO_PINS(62);
> +DECLARE_MSM_GPIO_PINS(63);
> +DECLARE_MSM_GPIO_PINS(64);
> +DECLARE_MSM_GPIO_PINS(65);
> +DECLARE_MSM_GPIO_PINS(66);
> +DECLARE_MSM_GPIO_PINS(67);
> +DECLARE_MSM_GPIO_PINS(68);
> +DECLARE_MSM_GPIO_PINS(69);
> +DECLARE_MSM_GPIO_PINS(70);
> +DECLARE_MSM_GPIO_PINS(71);
> +DECLARE_MSM_GPIO_PINS(72);
> +DECLARE_MSM_GPIO_PINS(73);
> +DECLARE_MSM_GPIO_PINS(74);
> +DECLARE_MSM_GPIO_PINS(75);
> +DECLARE_MSM_GPIO_PINS(76);
> +DECLARE_MSM_GPIO_PINS(77);
> +DECLARE_MSM_GPIO_PINS(78);
> +DECLARE_MSM_GPIO_PINS(79);
> +DECLARE_MSM_GPIO_PINS(80);
> +DECLARE_MSM_GPIO_PINS(81);
> +DECLARE_MSM_GPIO_PINS(82);
> +DECLARE_MSM_GPIO_PINS(83);
> +DECLARE_MSM_GPIO_PINS(84);
> +DECLARE_MSM_GPIO_PINS(85);
> +DECLARE_MSM_GPIO_PINS(86);
> +DECLARE_MSM_GPIO_PINS(87);
> +DECLARE_MSM_GPIO_PINS(88);
> +DECLARE_MSM_GPIO_PINS(89);
> +DECLARE_MSM_GPIO_PINS(90);
> +DECLARE_MSM_GPIO_PINS(91);
> +DECLARE_MSM_GPIO_PINS(92);
> +DECLARE_MSM_GPIO_PINS(93);
> +DECLARE_MSM_GPIO_PINS(94);
> +DECLARE_MSM_GPIO_PINS(95);
> +DECLARE_MSM_GPIO_PINS(96);
> +DECLARE_MSM_GPIO_PINS(97);
> +DECLARE_MSM_GPIO_PINS(98);
> +DECLARE_MSM_GPIO_PINS(99);
> +DECLARE_MSM_GPIO_PINS(100);
> +DECLARE_MSM_GPIO_PINS(101);
> +DECLARE_MSM_GPIO_PINS(102);
> +DECLARE_MSM_GPIO_PINS(103);
> +DECLARE_MSM_GPIO_PINS(104);
> +DECLARE_MSM_GPIO_PINS(105);
> +DECLARE_MSM_GPIO_PINS(106);
> +DECLARE_MSM_GPIO_PINS(107);
> +DECLARE_MSM_GPIO_PINS(108);
> +DECLARE_MSM_GPIO_PINS(109);
> +DECLARE_MSM_GPIO_PINS(110);
> +DECLARE_MSM_GPIO_PINS(111);
> +DECLARE_MSM_GPIO_PINS(112);
> +DECLARE_MSM_GPIO_PINS(113);
> +
> +static const unsigned int sdc1_clk_pins[] = { 114 };
> +static const unsigned int sdc1_cmd_pins[] = { 115 };
> +static const unsigned int sdc1_data_pins[] = { 116 };
> +static const unsigned int sdc2_clk_pins[] = { 117 };
> +static const unsigned int sdc2_cmd_pins[] = { 118 };
> +static const unsigned int sdc2_data_pins[] = { 119 };
> +static const unsigned int sdc1_rclk_pins[] = { 120 };
> +
> +enum sdm660_functions {
> +	msm_mux_blsp_spi1,
> +	msm_mux_gpio,
> +	msm_mux_blsp_uim1,
> +	msm_mux_tgu_ch0,
> +	msm_mux_qdss_gpio4,
> +	msm_mux_atest_gpsadc1,
> +	msm_mux_blsp_uart1,
> +	msm_mux_phase_flag14,
> +	msm_mux_blsp_i2c2,
> +	msm_mux_phase_flag31,
> +	msm_mux_blsp_spi3,
> +	msm_mux_blsp_spi3_cs1,
> +	msm_mux_blsp_spi3_cs2,
> +	msm_mux_wlan1_adc1,
> +	msm_mux_atest_usb13,
> +	msm_mux_tgu_ch1,
> +	msm_mux_qdss_gpio5,
> +	msm_mux_atest_gpsadc0,
> +	msm_mux_blsp_i2c1,
> +	msm_mux_ddr_bist,
> +	msm_mux_atest_tsens2,
> +	msm_mux_atest_usb1,
> +	msm_mux_blsp_spi2,
> +	msm_mux_blsp_uim2,
> +	msm_mux_phase_flag3,
> +	msm_mux_bimc_dte1,
> +	msm_mux_wlan1_adc0,
> +	msm_mux_atest_usb12,
> +	msm_mux_bimc_dte0,
> +	msm_mux_blsp_i2c3,
> +	msm_mux_wlan2_adc1,
> +	msm_mux_atest_usb11,
> +	msm_mux_dbg_out,
> +	msm_mux_wlan2_adc0,
> +	msm_mux_atest_usb10,
> +	msm_mux_blsp_spi4,
> +	msm_mux_pri_mi2s,
> +	msm_mux_phase_flag26,
> +	msm_mux_qdss_cti0_a,
> +	msm_mux_qdss_cti0_b,
> +	msm_mux_qdss_cti1_a,
> +	msm_mux_qdss_cti1_b,
> +	msm_mux_pri_mi2s_ws,
> +	msm_mux_phase_flag27,
> +	msm_mux_blsp_i2c4,
> +	msm_mux_phase_flag28,
> +	msm_mux_blsp_uart5,
> +	msm_mux_blsp_spi5,
> +	msm_mux_blsp_uim5,
> +	msm_mux_phase_flag5,
> +	msm_mux_blsp_i2c5,
> +	msm_mux_blsp_spi6,
> +	msm_mux_blsp_uart2,
> +	msm_mux_blsp_uim6,
> +	msm_mux_phase_flag11,
> +	msm_mux_vsense_data0,
> +	msm_mux_blsp_i2c6,
> +	msm_mux_phase_flag12,
> +	msm_mux_vsense_data1,
> +	msm_mux_phase_flag13,
> +	msm_mux_vsense_mode,
> +	msm_mux_blsp_spi7,
> +	msm_mux_blsp_uart6_a,
> +	msm_mux_blsp_uart6_b,
> +	msm_mux_sec_mi2s,
> +	msm_mux_sndwire_clk,
> +	msm_mux_phase_flag17,
> +	msm_mux_vsense_clkout,
> +	msm_mux_sndwire_data,
> +	msm_mux_phase_flag18,
> +	msm_mux_blsp_i2c7,
> +	msm_mux_phase_flag19,
> +	msm_mux_vfr_1,
> +	msm_mux_phase_flag20,
> +	msm_mux_blsp_spi8_cs1,
> +	msm_mux_blsp_spi8_cs2,
> +	msm_mux_m_voc,
> +	msm_mux_phase_flag21,
> +	msm_mux_phase_flag22,
> +	msm_mux_blsp_i2c8_a,
> +	msm_mux_blsp_i2c8_b,
> +	msm_mux_phase_flag23,
> +	msm_mux_pwr_modem,
> +	msm_mux_phase_flag24,
> +	msm_mux_qdss_gpio,
> +	msm_mux_cam_mclk,
> +	msm_mux_pwr_nav,
> +	msm_mux_qdss_gpio0,
> +	msm_mux_qspi_data0,
> +	msm_mux_pwr_crypto,
> +	msm_mux_qdss_gpio1,
> +	msm_mux_qspi_data1,
> +	msm_mux_agera_pll,
> +	msm_mux_qdss_gpio2,
> +	msm_mux_qspi_data2,
> +	msm_mux_jitter_bist,
> +	msm_mux_qdss_gpio3,
> +	msm_mux_qdss_gpio7,
> +	msm_mux_mdss_vsync0,
> +	msm_mux_mdss_vsync1,
> +	msm_mux_mdss_vsync2,
> +	msm_mux_mdss_vsync3,
> +	msm_mux_qdss_gpio9,
> +	msm_mux_atest_usb2,
> +	msm_mux_cci_i2c,
> +	msm_mux_pll_bypassnl,
> +	msm_mux_atest_tsens,
> +	msm_mux_atest_usb21,
> +	msm_mux_pll_reset,
> +	msm_mux_atest_usb23,
> +	msm_mux_qdss_gpio6,
> +	msm_mux_qspi_cs,
> +	msm_mux_qdss_gpio10,
> +	msm_mux_qdss_gpio11,
> +	msm_mux_cci_async,
> +	msm_mux_qdss_gpio12,
> +	msm_mux_qdss_gpio13,
> +	msm_mux_qspi_clk,
> +	msm_mux_phase_flag30,
> +	msm_mux_qdss_gpio14,
> +	msm_mux_qspi_resetn,
> +	msm_mux_phase_flag1,
> +	msm_mux_qdss_gpio15,
> +	msm_mux_phase_flag2,
> +	msm_mux_phase_flag9,
> +	msm_mux_qspi_data3,
> +	msm_mux_phase_flag15,
> +	msm_mux_qdss_gpio8,
> +	msm_mux_phase_flag16,
> +	msm_mux_phase_flag6,
> +	msm_mux_phase_flag29,
> +	msm_mux_phase_flag25,
> +	msm_mux_phase_flag10,
> +	msm_mux_atest_usb20,
> +	msm_mux_gcc_gp1,
> +	msm_mux_phase_flag4,
> +	msm_mux_atest_usb22,
> +	msm_mux_gcc_gp2,
> +	msm_mux_atest_char,
> +	msm_mux_mdp_vsync,
> +	msm_mux_gcc_gp3,
> +	msm_mux_atest_char3,
> +	msm_mux_cri_trng0,
> +	msm_mux_atest_char2,
> +	msm_mux_cri_trng1,
> +	msm_mux_atest_char1,
> +	msm_mux_audio_ref,
> +	msm_mux_cri_trng,
> +	msm_mux_atest_char0,
> +	msm_mux_blsp_spi8_a,
> +	msm_mux_blsp_spi8_b,
> +	msm_mux_sp_cmu,
> +	msm_mux_nav_pps_a,
> +	msm_mux_nav_pps_b,
> +	msm_mux_nav_pps_c,
> +	msm_mux_gps_tx_a,
> +	msm_mux_gps_tx_b,
> +	msm_mux_gps_tx_c,
> +	msm_mux_adsp_ext,
> +	msm_mux_ssc_irq,
> +	msm_mux_isense_dbg,
> +	msm_mux_phase_flag0,
> +	msm_mux_phase_flag7,
> +	msm_mux_phase_flag8,
> +	msm_mux_tsense_pwm1,
> +	msm_mux_tsense_pwm2,
> +	msm_mux_mss_lte,
> +	msm_mux_uim2_data,
> +	msm_mux_uim2_clk,
> +	msm_mux_uim2_reset,
> +	msm_mux_uim2_present,
> +	msm_mux_uim1_data,
> +	msm_mux_uim1_clk,
> +	msm_mux_uim1_reset,
> +	msm_mux_uim1_present,
> +	msm_mux_uim_batt,
> +	msm_mux_pa_indicator,
> +	msm_mux_ldo_en,
> +	msm_mux_ldo_update,
> +	msm_mux_qlink_request,
> +	msm_mux_qlink_enable,
> +	msm_mux_prng_rosc,
> +	msm_mux__,
> +};
> +
> +static const char * const gpio_groups[] = {
> +	"gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
> +	"gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
> +	"gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
> +	"gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
> +	"gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
> +	"gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
> +	"gpio43", "gpio44", "gpio45", "gpio46", "gpio47", "gpio48", "gpio49",
> +	"gpio50", "gpio51", "gpio52", "gpio53", "gpio54", "gpio55", "gpio56",
> +	"gpio57", "gpio58", "gpio59", "gpio60", "gpio61", "gpio62", "gpio63",
> +	"gpio64", "gpio65", "gpio66", "gpio67", "gpio68", "gpio69", "gpio70",
> +	"gpio71", "gpio72", "gpio73", "gpio74", "gpio75", "gpio76", "gpio77",
> +	"gpio78", "gpio79", "gpio80", "gpio81", "gpio82", "gpio83", "gpio84",
> +	"gpio85", "gpio86", "gpio87", "gpio88", "gpio89", "gpio90", "gpio91",
> +	"gpio92", "gpio93", "gpio94", "gpio95", "gpio96", "gpio97", "gpio98",
> +	"gpio99", "gpio100", "gpio101", "gpio102", "gpio103", "gpio104",
> +	"gpio105", "gpio106", "gpio107", "gpio108", "gpio109", "gpio110",
> +	"gpio111", "gpio112", "gpio113",
> +};
> +static const char * const blsp_spi1_groups[] = {
> +	"gpio0", "gpio1", "gpio2", "gpio3", "gpio46",
> +};
> +static const char * const blsp_uim1_groups[] = {
> +	"gpio0", "gpio1",
> +};
> +static const char * const tgu_ch0_groups[] = {
> +	"gpio0",
> +};
> +static const char * const qdss_gpio4_groups[] = {
> +	"gpio0", "gpio36",
> +};
> +static const char * const atest_gpsadc1_groups[] = {
> +	"gpio0",
> +};
> +static const char * const blsp_uart1_groups[] = {
> +	"gpio0", "gpio1", "gpio2", "gpio3",
> +};
> +static const char * const phase_flag14_groups[] = {
> +	"gpio5",
> +};
> +static const char * const blsp_i2c2_groups[] = {
> +	"gpio6", "gpio7",
> +};
> +static const char * const phase_flag31_groups[] = {
> +	"gpio6",
> +};
> +static const char * const blsp_spi3_groups[] = {
> +	"gpio8", "gpio9", "gpio10", "gpio11",
> +};
> +static const char * const blsp_spi3_cs1_groups[] = {
> +	"gpio30",
> +};
> +static const char * const blsp_spi3_cs2_groups[] = {
> +	"gpio65",
> +};
> +static const char * const wlan1_adc1_groups[] = {
> +	"gpio8",
> +};
> +static const char * const atest_usb13_groups[] = {
> +	"gpio8",
> +};
> +static const char * const tgu_ch1_groups[] = {
> +	"gpio1",
> +};
> +static const char * const qdss_gpio5_groups[] = {
> +	"gpio1", "gpio37",
> +};
> +static const char * const atest_gpsadc0_groups[] = {
> +	"gpio1",
> +};
> +static const char * const blsp_i2c1_groups[] = {
> +	"gpio2", "gpio3",
> +};
> +static const char * const ddr_bist_groups[] = {
> +	"gpio3", "gpio8", "gpio9", "gpio10",
> +};
> +static const char * const atest_tsens2_groups[] = {
> +	"gpio3",
> +};
> +static const char * const atest_usb1_groups[] = {
> +	"gpio3",
> +};
> +static const char * const blsp_spi2_groups[] = {
> +	"gpio4", "gpio5", "gpio6", "gpio7",
> +};
> +static const char * const blsp_uim2_groups[] = {
> +	"gpio4", "gpio5",
> +};
> +static const char * const phase_flag3_groups[] = {
> +	"gpio4",
> +};
> +static const char * const bimc_dte1_groups[] = {
> +	"gpio8", "gpio10",
> +};
> +static const char * const wlan1_adc0_groups[] = {
> +	"gpio9",
> +};
> +static const char * const atest_usb12_groups[] = {
> +	"gpio9",
> +};
> +static const char * const bimc_dte0_groups[] = {
> +	"gpio9", "gpio11",
> +};
> +static const char * const blsp_i2c3_groups[] = {
> +	"gpio10", "gpio11",
> +};
> +static const char * const wlan2_adc1_groups[] = {
> +	"gpio10",
> +};
> +static const char * const atest_usb11_groups[] = {
> +	"gpio10",
> +};
> +static const char * const dbg_out_groups[] = {
> +	"gpio11",
> +};
> +static const char * const wlan2_adc0_groups[] = {
> +	"gpio11",
> +};
> +static const char * const atest_usb10_groups[] = {
> +	"gpio11",
> +};
> +static const char * const RCM_MARKER_groups[] = {
> +	"gpio12", "gpio13",
> +};
> +static const char * const blsp_spi4_groups[] = {
> +	"gpio12", "gpio13", "gpio14", "gpio15",
> +};
> +static const char * const pri_mi2s_groups[] = {
> +	"gpio12", "gpio14", "gpio15", "gpio61",
> +};
> +static const char * const phase_flag26_groups[] = {
> +	"gpio12",
> +};
> +static const char * const qdss_cti0_a_groups[] = {
> +	"gpio49", "gpio50",
> +};
> +static const char * const qdss_cti0_b_groups[] = {
> +	"gpio13", "gpio21",
> +};
> +static const char * const qdss_cti1_a_groups[] = {
> +	"gpio53", "gpio55",
> +};
> +static const char * const qdss_cti1_b_groups[] = {
> +	"gpio12", "gpio66",
> +};
> +static const char * const pri_mi2s_ws_groups[] = {
> +	"gpio13",
> +};
> +static const char * const phase_flag27_groups[] = {
> +	"gpio13",
> +};
> +static const char * const blsp_i2c4_groups[] = {
> +	"gpio14", "gpio15",
> +};
> +static const char * const phase_flag28_groups[] = {
> +	"gpio14",
> +};
> +static const char * const blsp_uart5_groups[] = {
> +	"gpio16", "gpio17", "gpio18", "gpio19",
> +};
> +static const char * const blsp_spi5_groups[] = {
> +	"gpio16", "gpio17", "gpio18", "gpio19",
> +};
> +static const char * const blsp_uim5_groups[] = {
> +	"gpio16", "gpio17",
> +};
> +static const char * const phase_flag5_groups[] = {
> +	"gpio17",
> +};
> +static const char * const blsp_i2c5_groups[] = {
> +	"gpio18", "gpio19",
> +};
> +static const char * const blsp_spi6_groups[] = {
> +	"gpio49", "gpio52", "gpio22", "gpio23",
> +};
> +static const char * const blsp_uart2_groups[] = {
> +	"gpio4", "gpio5", "gpio6", "gpio7",
> +};
> +static const char * const blsp_uim6_groups[] = {
> +	"gpio20", "gpio21",
> +};
> +static const char * const phase_flag11_groups[] = {
> +	"gpio21",
> +};
> +static const char * const vsense_data0_groups[] = {
> +	"gpio21",
> +};
> +static const char * const blsp_i2c6_groups[] = {
> +	"gpio22", "gpio23",
> +};
> +static const char * const phase_flag12_groups[] = {
> +	"gpio22",
> +};
> +static const char * const vsense_data1_groups[] = {
> +	"gpio22",
> +};
> +static const char * const phase_flag13_groups[] = {
> +	"gpio23",
> +};
> +static const char * const vsense_mode_groups[] = {
> +	"gpio23",
> +};
> +static const char * const blsp_spi7_groups[] = {
> +	"gpio24", "gpio25", "gpio26", "gpio27",
> +};
> +static const char * const blsp_uart6_a_groups[] = {
> +	"gpio24", "gpio25", "gpio26", "gpio27",
> +};
> +static const char * const blsp_uart6_b_groups[] = {
> +	"gpio28", "gpio29", "gpio30", "gpio31",
> +};
> +static const char * const sec_mi2s_groups[] = {
> +	"gpio24", "gpio25", "gpio26", "gpio27", "gpio62",
> +};
> +static const char * const sndwire_clk_groups[] = {
> +	"gpio24",
> +};
> +static const char * const phase_flag17_groups[] = {
> +	"gpio24",
> +};
> +static const char * const vsense_clkout_groups[] = {
> +	"gpio24",
> +};
> +static const char * const sndwire_data_groups[] = {
> +	"gpio25",
> +};
> +static const char * const phase_flag18_groups[] = {
> +	"gpio25",
> +};
> +static const char * const blsp_i2c7_groups[] = {
> +	"gpio26", "gpio27",
> +};
> +static const char * const phase_flag19_groups[] = {
> +	"gpio26",
> +};
> +static const char * const vfr_1_groups[] = {
> +	"gpio27",
> +};
> +static const char * const phase_flag20_groups[] = {
> +	"gpio27",
> +};
> +static const char * const NFC_INT_groups[] = {
> +	"gpio28",
> +};
> +static const char * const blsp_spi8_a_groups[] = {
> +	"gpio28", "gpio29", "gpio30", "gpio31",
> +};
> +static const char * const blsp_spi8_b_groups[] = {
> +	"gpio40", "gpio41", "gpio44", "gpio52",
> +};
> +static const char * const m_voc_groups[] = {
> +	"gpio28",
> +};
> +static const char * const phase_flag21_groups[] = {
> +	"gpio28",
> +};
> +static const char * const phase_flag22_groups[] = {
> +	"gpio29",
> +};
> +static const char * const blsp_i2c8_a_groups[] = {
> +	"gpio30", "gpio31",
> +};
> +static const char * const blsp_i2c8_b_groups[] = {
> +	"gpio44", "gpio52",
> +};
> +static const char * const phase_flag23_groups[] = {
> +	"gpio30",
> +};
> +static const char * const NFC_ESE_groups[] = {
> +	"gpio31",
> +};
> +static const char * const pwr_modem_groups[] = {
> +	"gpio31",
> +};
> +static const char * const phase_flag24_groups[] = {
> +	"gpio31",
> +};
> +static const char * const qdss_gpio_groups[] = {
> +	"gpio31", "gpio52", "gpio68", "gpio69",
> +};
> +static const char * const cam_mclk_groups[] = {
> +	"gpio32", "gpio33", "gpio34", "gpio35",
> +};
> +static const char * const pwr_nav_groups[] = {
> +	"gpio32",
> +};
> +static const char * const qdss_gpio0_groups[] = {
> +	"gpio32", "gpio67",
> +};
> +static const char * const qspi_data0_groups[] = {
> +	"gpio33",
> +};
> +static const char * const pwr_crypto_groups[] = {
> +	"gpio33",
> +};
> +static const char * const qdss_gpio1_groups[] = {
> +	"gpio33", "gpio63",
> +};
> +static const char * const qspi_data1_groups[] = {
> +	"gpio34",
> +};
> +static const char * const agera_pll_groups[] = {
> +	"gpio34", "gpio36",
> +};
> +static const char * const qdss_gpio2_groups[] = {
> +	"gpio34", "gpio64",
> +};
> +static const char * const qspi_data2_groups[] = {
> +	"gpio35",
> +};
> +static const char * const jitter_bist_groups[] = {
> +	"gpio35",
> +};
> +static const char * const qdss_gpio3_groups[] = {
> +	"gpio35", "gpio56",
> +};
> +static const char * const qdss_gpio7_groups[] = {
> +	"gpio39", "gpio71",
> +};
> +static const char * const mdss_vsync0_groups[] = {
> +	"gpio42",
> +};
> +static const char * const mdss_vsync1_groups[] = {
> +	"gpio42",
> +};
> +static const char * const mdss_vsync2_groups[] = {
> +	"gpio42",
> +};
> +static const char * const mdss_vsync3_groups[] = {
> +	"gpio42",
> +};
> +static const char * const qdss_gpio9_groups[] = {
> +	"gpio42", "gpio76",
> +};
> +static const char * const atest_usb2_groups[] = {
> +	"gpio35",
> +};
> +static const char * const cci_i2c_groups[] = {
> +	"gpio36", "gpio37", "gpio38", "gpio39",
> +};
> +static const char * const pll_bypassnl_groups[] = {
> +	"gpio36",
> +};
> +static const char * const atest_tsens_groups[] = {
> +	"gpio36",
> +};
> +static const char * const atest_usb21_groups[] = {
> +	"gpio36",
> +};
> +static const char * const pll_reset_groups[] = {
> +	"gpio37",
> +};
> +static const char * const atest_usb23_groups[] = {
> +	"gpio37",
> +};
> +static const char * const qdss_gpio6_groups[] = {
> +	"gpio38", "gpio70",
> +};
> +static const char * const qspi_cs_groups[] = {
> +	"gpio43", "gpio50",
> +};
> +static const char * const qdss_gpio10_groups[] = {
> +	"gpio43", "gpio77",
> +};
> +static const char * const qdss_gpio11_groups[] = {
> +	"gpio44", "gpio79",
> +};
> +static const char * const cci_async_groups[] = {
> +	"gpio45",
> +};
> +static const char * const qdss_gpio12_groups[] = {
> +	"gpio45", "gpio80",
> +};
> +static const char * const qdss_gpio13_groups[] = {
> +	"gpio46", "gpio78",
> +};
> +static const char * const qspi_clk_groups[] = {
> +	"gpio47",
> +};
> +static const char * const phase_flag30_groups[] = {
> +	"gpio47",
> +};
> +static const char * const qdss_gpio14_groups[] = {
> +	"gpio47", "gpio72",
> +};
> +static const char * const qspi_resetn_groups[] = {
> +	"gpio48",
> +};
> +static const char * const phase_flag1_groups[] = {
> +	"gpio48",
> +};
> +static const char * const qdss_gpio15_groups[] = {
> +	"gpio48", "gpio73",
> +};
> +static const char * const phase_flag2_groups[] = {
> +	"gpio49",
> +};
> +static const char * const phase_flag9_groups[] = {
> +	"gpio50",
> +};
> +static const char * const qspi_data3_groups[] = {
> +	"gpio51",
> +};
> +static const char * const phase_flag15_groups[] = {
> +	"gpio51",
> +};
> +static const char * const qdss_gpio8_groups[] = {
> +	"gpio51", "gpio75",
> +};
> +static const char * const phase_flag16_groups[] = {
> +	"gpio52",
> +};
> +static const char * const phase_flag6_groups[] = {
> +	"gpio53",
> +};
> +static const char * const phase_flag29_groups[] = {
> +	"gpio54",
> +};
> +static const char * const phase_flag25_groups[] = {
> +	"gpio55",
> +};
> +static const char * const phase_flag10_groups[] = {
> +	"gpio56",
> +};
> +static const char * const atest_usb20_groups[] = {
> +	"gpio56",
> +};
> +static const char * const gcc_gp1_groups[] = {
> +	"gpio57", "gpio78",
> +};
> +static const char * const phase_flag4_groups[] = {
> +	"gpio57",
> +};
> +static const char * const atest_usb22_groups[] = {
> +	"gpio57",
> +};
> +static const char * const gcc_gp2_groups[] = {
> +	"gpio58", "gpio81",
> +};
> +static const char * const atest_char_groups[] = {
> +	"gpio58",
> +};
> +static const char * const mdp_vsync_groups[] = {
> +	"gpio59", "gpio74",
> +};
> +static const char * const gcc_gp3_groups[] = {
> +	"gpio59", "gpio82",
> +};
> +static const char * const atest_char3_groups[] = {
> +	"gpio59",
> +};
> +static const char * const cri_trng0_groups[] = {
> +	"gpio60",
> +};
> +static const char * const atest_char2_groups[] = {
> +	"gpio60",
> +};
> +static const char * const cri_trng1_groups[] = {
> +	"gpio61",
> +};
> +static const char * const atest_char1_groups[] = {
> +	"gpio61",
> +};
> +static const char * const audio_ref_groups[] = {
> +	"gpio62",
> +};
> +static const char * const cri_trng_groups[] = {
> +	"gpio62",
> +};
> +static const char * const atest_char0_groups[] = {
> +	"gpio62",
> +};
> +static const char * const blsp_spi8_cs1_groups[] = {
> +	"gpio64",
> +};
> +static const char * const blsp_spi8_cs2_groups[] = {
> +	"gpio76",
> +};
> +static const char * const sp_cmu_groups[] = {
> +	"gpio64",
> +};
> +static const char * const nav_pps_a_groups[] = {
> +	"gpio65",
> +};
> +static const char * const nav_pps_b_groups[] = {
> +	"gpio98",
> +};
> +static const char * const nav_pps_c_groups[] = {
> +	"gpio80",
> +};
> +static const char * const gps_tx_a_groups[] = {
> +	"gpio65",
> +};
> +static const char * const gps_tx_b_groups[] = {
> +	"gpio98",
> +};
> +static const char * const gps_tx_c_groups[] = {
> +	"gpio80",
> +};
> +static const char * const adsp_ext_groups[] = {
> +	"gpio65",
> +};
> +static const char * const ssc_irq_groups[] = {
> +	"gpio67", "gpio68", "gpio69", "gpio70", "gpio71", "gpio72", "gpio74",
> +	"gpio75", "gpio76",
> +};
> +static const char * const isense_dbg_groups[] = {
> +	"gpio68",
> +};
> +static const char * const phase_flag0_groups[] = {
> +	"gpio68",
> +};
> +static const char * const phase_flag7_groups[] = {
> +	"gpio69",
> +};
> +static const char * const phase_flag8_groups[] = {
> +	"gpio70",
> +};
> +static const char * const tsense_pwm1_groups[] = {
> +	"gpio71",
> +};
> +static const char * const tsense_pwm2_groups[] = {
> +	"gpio71",
> +};
> +static const char * const mss_lte_groups[] = {
> +	"gpio81", "gpio82",
> +};
> +static const char * const uim2_data_groups[] = {
> +	"gpio83",
> +};
> +static const char * const uim2_clk_groups[] = {
> +	"gpio84",
> +};
> +static const char * const uim2_reset_groups[] = {
> +	"gpio85",
> +};
> +static const char * const uim2_present_groups[] = {
> +	"gpio86",
> +};
> +static const char * const uim1_data_groups[] = {
> +	"gpio87",
> +};
> +static const char * const uim1_clk_groups[] = {
> +	"gpio88",
> +};
> +static const char * const uim1_reset_groups[] = {
> +	"gpio89",
> +};
> +static const char * const uim1_present_groups[] = {
> +	"gpio90",
> +};
> +static const char * const uim_batt_groups[] = {
> +	"gpio91",
> +};
> +static const char * const pa_indicator_groups[] = {
> +	"gpio92",
> +};
> +static const char * const ldo_en_groups[] = {
> +	"gpio97",
> +};
> +static const char * const ldo_update_groups[] = {
> +	"gpio98",
> +};
> +static const char * const qlink_request_groups[] = {
> +	"gpio99",
> +};
> +static const char * const qlink_enable_groups[] = {
> +	"gpio100",
> +};
> +static const char * const prng_rosc_groups[] = {
> +	"gpio102",
> +};
> +
> +static const struct msm_function sdm660_functions[] = {
> +	FUNCTION(blsp_spi1),
> +	FUNCTION(gpio),
> +	FUNCTION(blsp_uim1),
> +	FUNCTION(tgu_ch0),
> +	FUNCTION(qdss_gpio4),
> +	FUNCTION(atest_gpsadc1),
> +	FUNCTION(blsp_uart1),
> +	FUNCTION(phase_flag14),
> +	FUNCTION(blsp_i2c2),
> +	FUNCTION(phase_flag31),
> +	FUNCTION(blsp_spi3),
> +	FUNCTION(blsp_spi3_cs1),
> +	FUNCTION(blsp_spi3_cs2),
> +	FUNCTION(wlan1_adc1),
> +	FUNCTION(atest_usb13),
> +	FUNCTION(tgu_ch1),
> +	FUNCTION(qdss_gpio5),
> +	FUNCTION(atest_gpsadc0),
> +	FUNCTION(blsp_i2c1),
> +	FUNCTION(ddr_bist),
> +	FUNCTION(atest_tsens2),
> +	FUNCTION(atest_usb1),
> +	FUNCTION(blsp_spi2),
> +	FUNCTION(blsp_uim2),
> +	FUNCTION(phase_flag3),
> +	FUNCTION(bimc_dte1),
> +	FUNCTION(wlan1_adc0),
> +	FUNCTION(atest_usb12),
> +	FUNCTION(bimc_dte0),
> +	FUNCTION(blsp_i2c3),
> +	FUNCTION(wlan2_adc1),
> +	FUNCTION(atest_usb11),
> +	FUNCTION(dbg_out),
> +	FUNCTION(wlan2_adc0),
> +	FUNCTION(atest_usb10),
> +	FUNCTION(blsp_spi4),
> +	FUNCTION(pri_mi2s),
> +	FUNCTION(phase_flag26),
> +	FUNCTION(qdss_cti0_a),
> +	FUNCTION(qdss_cti0_b),
> +	FUNCTION(qdss_cti1_a),
> +	FUNCTION(qdss_cti1_b),
> +	FUNCTION(pri_mi2s_ws),
> +	FUNCTION(phase_flag27),
> +	FUNCTION(blsp_i2c4),
> +	FUNCTION(phase_flag28),
> +	FUNCTION(blsp_uart5),
> +	FUNCTION(blsp_spi5),
> +	FUNCTION(blsp_uim5),
> +	FUNCTION(phase_flag5),
> +	FUNCTION(blsp_i2c5),
> +	FUNCTION(blsp_spi6),
> +	FUNCTION(blsp_uart2),
> +	FUNCTION(blsp_uim6),
> +	FUNCTION(phase_flag11),
> +	FUNCTION(vsense_data0),
> +	FUNCTION(blsp_i2c6),
> +	FUNCTION(phase_flag12),
> +	FUNCTION(vsense_data1),
> +	FUNCTION(phase_flag13),
> +	FUNCTION(vsense_mode),
> +	FUNCTION(blsp_spi7),
> +	FUNCTION(blsp_uart6_a),
> +	FUNCTION(blsp_uart6_b),
> +	FUNCTION(sec_mi2s),
> +	FUNCTION(sndwire_clk),
> +	FUNCTION(phase_flag17),
> +	FUNCTION(vsense_clkout),
> +	FUNCTION(sndwire_data),
> +	FUNCTION(phase_flag18),
> +	FUNCTION(blsp_i2c7),
> +	FUNCTION(phase_flag19),
> +	FUNCTION(vfr_1),
> +	FUNCTION(phase_flag20),
> +	FUNCTION(blsp_spi8_cs1),
> +	FUNCTION(blsp_spi8_cs2),
> +	FUNCTION(m_voc),
> +	FUNCTION(phase_flag21),
> +	FUNCTION(phase_flag22),
> +	FUNCTION(blsp_i2c8_a),
> +	FUNCTION(blsp_i2c8_b),
> +	FUNCTION(phase_flag23),
> +	FUNCTION(pwr_modem),
> +	FUNCTION(phase_flag24),
> +	FUNCTION(qdss_gpio),
> +	FUNCTION(cam_mclk),
> +	FUNCTION(pwr_nav),
> +	FUNCTION(qdss_gpio0),
> +	FUNCTION(qspi_data0),
> +	FUNCTION(pwr_crypto),
> +	FUNCTION(qdss_gpio1),
> +	FUNCTION(qspi_data1),
> +	FUNCTION(agera_pll),
> +	FUNCTION(qdss_gpio2),
> +	FUNCTION(qspi_data2),
> +	FUNCTION(jitter_bist),
> +	FUNCTION(qdss_gpio3),
> +	FUNCTION(qdss_gpio7),
> +	FUNCTION(mdss_vsync0),
> +	FUNCTION(mdss_vsync1),
> +	FUNCTION(mdss_vsync2),
> +	FUNCTION(mdss_vsync3),
> +	FUNCTION(qdss_gpio9),
> +	FUNCTION(atest_usb2),
> +	FUNCTION(cci_i2c),
> +	FUNCTION(pll_bypassnl),
> +	FUNCTION(atest_tsens),
> +	FUNCTION(atest_usb21),
> +	FUNCTION(pll_reset),
> +	FUNCTION(atest_usb23),
> +	FUNCTION(qdss_gpio6),
> +	FUNCTION(qspi_cs),
> +	FUNCTION(qdss_gpio10),
> +	FUNCTION(qdss_gpio11),
> +	FUNCTION(cci_async),
> +	FUNCTION(qdss_gpio12),
> +	FUNCTION(qdss_gpio13),
> +	FUNCTION(qspi_clk),
> +	FUNCTION(phase_flag30),
> +	FUNCTION(qdss_gpio14),
> +	FUNCTION(qspi_resetn),
> +	FUNCTION(phase_flag1),
> +	FUNCTION(qdss_gpio15),
> +	FUNCTION(phase_flag2),
> +	FUNCTION(phase_flag9),
> +	FUNCTION(qspi_data3),
> +	FUNCTION(phase_flag15),
> +	FUNCTION(qdss_gpio8),
> +	FUNCTION(phase_flag16),
> +	FUNCTION(phase_flag6),
> +	FUNCTION(phase_flag29),
> +	FUNCTION(phase_flag25),
> +	FUNCTION(phase_flag10),
> +	FUNCTION(atest_usb20),
> +	FUNCTION(gcc_gp1),
> +	FUNCTION(phase_flag4),
> +	FUNCTION(atest_usb22),
> +	FUNCTION(gcc_gp2),
> +	FUNCTION(atest_char),
> +	FUNCTION(mdp_vsync),
> +	FUNCTION(gcc_gp3),
> +	FUNCTION(atest_char3),
> +	FUNCTION(cri_trng0),
> +	FUNCTION(atest_char2),
> +	FUNCTION(cri_trng1),
> +	FUNCTION(atest_char1),
> +	FUNCTION(audio_ref),
> +	FUNCTION(cri_trng),
> +	FUNCTION(atest_char0),
> +	FUNCTION(blsp_spi8_a),
> +	FUNCTION(blsp_spi8_b),
> +	FUNCTION(sp_cmu),
> +	FUNCTION(nav_pps_a),
> +	FUNCTION(nav_pps_b),
> +	FUNCTION(nav_pps_c),
> +	FUNCTION(gps_tx_a),
> +	FUNCTION(gps_tx_b),
> +	FUNCTION(gps_tx_c),
> +	FUNCTION(adsp_ext),
> +	FUNCTION(ssc_irq),
> +	FUNCTION(isense_dbg),
> +	FUNCTION(phase_flag0),
> +	FUNCTION(phase_flag7),
> +	FUNCTION(phase_flag8),
> +	FUNCTION(tsense_pwm1),
> +	FUNCTION(tsense_pwm2),
> +	FUNCTION(mss_lte),
> +	FUNCTION(uim2_data),
> +	FUNCTION(uim2_clk),
> +	FUNCTION(uim2_reset),
> +	FUNCTION(uim2_present),
> +	FUNCTION(uim1_data),
> +	FUNCTION(uim1_clk),
> +	FUNCTION(uim1_reset),
> +	FUNCTION(uim1_present),
> +	FUNCTION(uim_batt),
> +	FUNCTION(pa_indicator),
> +	FUNCTION(ldo_en),
> +	FUNCTION(ldo_update),
> +	FUNCTION(qlink_request),
> +	FUNCTION(qlink_enable),
> +	FUNCTION(prng_rosc),
> +};
> +
> +static const struct msm_pingroup sdm660_groups[] = {
> +	PINGROUP(0, SOUTH, blsp_spi1, blsp_uart1, blsp_uim1, tgu_ch0, _, _, qdss_gpio4, atest_gpsadc1, _),
> +	PINGROUP(1, SOUTH, blsp_spi1, blsp_uart1, blsp_uim1, tgu_ch1, _, _, qdss_gpio5, atest_gpsadc0, _),
> +	PINGROUP(2, SOUTH, blsp_spi1, blsp_uart1, blsp_i2c1, _, _, _, _, _, _),
> +	PINGROUP(3, SOUTH, blsp_spi1, blsp_uart1, blsp_i2c1, ddr_bist, _, _, atest_tsens2, atest_usb1, _),
> +	PINGROUP(4, NORTH, blsp_spi2, blsp_uim2, blsp_uart2, phase_flag3, _, _, _, _, _),
> +	PINGROUP(5, SOUTH, blsp_spi2, blsp_uim2, blsp_uart2, phase_flag14, _, _, _, _, _),
> +	PINGROUP(6, SOUTH, blsp_spi2, blsp_i2c2, blsp_uart2, phase_flag31, _, _, _, _, _),
> +	PINGROUP(7, SOUTH, blsp_spi2, blsp_i2c2, blsp_uart2, _, _, _, _, _, _),
> +	PINGROUP(8, NORTH, blsp_spi3, ddr_bist, _, _, _, wlan1_adc1, atest_usb13, bimc_dte1, _),
> +	PINGROUP(9, NORTH, blsp_spi3, ddr_bist, _, _, _, wlan1_adc0, atest_usb12, bimc_dte0, _),
> +	PINGROUP(10, NORTH, blsp_spi3, blsp_i2c3, ddr_bist, _, _, wlan2_adc1, atest_usb11, bimc_dte1, _),
> +	PINGROUP(11, NORTH, blsp_spi3, blsp_i2c3, _, dbg_out, wlan2_adc0, atest_usb10, bimc_dte0, _, _),
> +	PINGROUP(12, NORTH, blsp_spi4, pri_mi2s, _, phase_flag26, qdss_cti1_b, _, _, _, _),
> +	PINGROUP(13, NORTH, blsp_spi4, _, pri_mi2s_ws, _, _, phase_flag27, qdss_cti0_b, _, _),
> +	PINGROUP(14, NORTH, blsp_spi4, blsp_i2c4, pri_mi2s, _, phase_flag28, _, _, _, _),
> +	PINGROUP(15, NORTH, blsp_spi4, blsp_i2c4, pri_mi2s, _, _, _, _, _, _),
> +	PINGROUP(16, CENTER, blsp_uart5, blsp_spi5, blsp_uim5, _, _, _, _, _, _),
> +	PINGROUP(17, CENTER, blsp_uart5, blsp_spi5, blsp_uim5, _, phase_flag5, _, _, _, _),
> +	PINGROUP(18, CENTER, blsp_uart5, blsp_spi5, blsp_i2c5, _, _, _, _, _, _),
> +	PINGROUP(19, CENTER, blsp_uart5, blsp_spi5, blsp_i2c5, _, _, _, _, _, _),
> +	PINGROUP(20, SOUTH, _, _, blsp_uim6, _, _, _, _, _, _),
> +	PINGROUP(21, SOUTH, _, _, blsp_uim6, _, phase_flag11, qdss_cti0_b, vsense_data0, _, _),
> +	PINGROUP(22, CENTER, blsp_spi6, _, blsp_i2c6, _, phase_flag12, vsense_data1, _, _, _),
> +	PINGROUP(23, CENTER, blsp_spi6, _, blsp_i2c6, _, phase_flag13, vsense_mode, _, _, _),
> +	PINGROUP(24, NORTH, blsp_spi7, blsp_uart6_a, sec_mi2s, sndwire_clk, _, _, phase_flag17, vsense_clkout, _),
> +	PINGROUP(25, NORTH, blsp_spi7, blsp_uart6_a, sec_mi2s, sndwire_data, _, _, phase_flag18, _, _),
> +	PINGROUP(26, NORTH, blsp_spi7, blsp_uart6_a, blsp_i2c7, sec_mi2s, _, phase_flag19, _, _, _),
> +	PINGROUP(27, NORTH, blsp_spi7, blsp_uart6_a, blsp_i2c7, vfr_1, sec_mi2s, _, phase_flag20, _, _),
> +	PINGROUP(28, CENTER, blsp_spi8_a, blsp_uart6_b, m_voc, _, phase_flag21, _, _, _, _),
> +	PINGROUP(29, CENTER, blsp_spi8_a, blsp_uart6_b, _, _, phase_flag22, _, _, _, _),
> +	PINGROUP(30, CENTER, blsp_spi8_a, blsp_uart6_b, blsp_i2c8_a, blsp_spi3_cs1, _, phase_flag23, _, _, _),
> +	PINGROUP(31, CENTER, blsp_spi8_a, blsp_uart6_b, blsp_i2c8_a, pwr_modem, _, phase_flag24, qdss_gpio, _, _),
> +	PINGROUP(32, SOUTH, cam_mclk, pwr_nav, _, _, qdss_gpio0, _, _, _, _),
> +	PINGROUP(33, SOUTH, cam_mclk, qspi_data0, pwr_crypto, _, _, qdss_gpio1, _, _, _),
> +	PINGROUP(34, SOUTH, cam_mclk, qspi_data1, agera_pll, _, _, qdss_gpio2, _, _, _),
> +	PINGROUP(35, SOUTH, cam_mclk, qspi_data2, jitter_bist, _, _, qdss_gpio3, _, atest_usb2, _),
> +	PINGROUP(36, SOUTH, cci_i2c, pll_bypassnl, agera_pll, _, _, qdss_gpio4, atest_tsens, atest_usb21, _),
> +	PINGROUP(37, SOUTH, cci_i2c, pll_reset, _, _, qdss_gpio5, atest_usb23, _, _, _),
> +	PINGROUP(38, SOUTH, cci_i2c, _, _, qdss_gpio6, _, _, _, _, _),
> +	PINGROUP(39, SOUTH, cci_i2c, _, _, qdss_gpio7, _, _, _, _, _),
> +	PINGROUP(40, SOUTH, _, _, blsp_spi8_b, _, _, _, _, _, _),
> +	PINGROUP(41, SOUTH, _, _, blsp_spi8_b, _, _, _, _, _, _),
> +	PINGROUP(42, SOUTH, mdss_vsync0, mdss_vsync1, mdss_vsync2, mdss_vsync3, _, _, qdss_gpio9, _, _),
> +	PINGROUP(43, SOUTH, _, _, qspi_cs, _, _, qdss_gpio10, _, _, _),
> +	PINGROUP(44, SOUTH, _, _, blsp_spi8_b, blsp_i2c8_b, _, _, qdss_gpio11, _, _),
> +	PINGROUP(45, SOUTH, cci_async, _, _, qdss_gpio12, _, _, _, _, _),
> +	PINGROUP(46, SOUTH, blsp_spi1, _, _, qdss_gpio13, _, _, _, _, _),
> +	PINGROUP(47, SOUTH, qspi_clk, _, phase_flag30, qdss_gpio14, _, _, _, _, _),
> +	PINGROUP(48, SOUTH, _, phase_flag1, qdss_gpio15, _, _, _, _, _, _),
> +	PINGROUP(49, SOUTH, blsp_spi6, phase_flag2, qdss_cti0_a, _, _, _, _, _, _),
> +	PINGROUP(50, SOUTH, qspi_cs, _, phase_flag9, qdss_cti0_a, _, _, _, _, _),
> +	PINGROUP(51, SOUTH, qspi_data3, _, phase_flag15, qdss_gpio8, _, _, _, _, _),
> +	PINGROUP(52, SOUTH, _, blsp_spi8_b, blsp_i2c8_b, blsp_spi6, phase_flag16, qdss_gpio, _, _, _),
> +	PINGROUP(53, NORTH, _, phase_flag6, qdss_cti1_a, _, _, _, _, _, _),
> +	PINGROUP(54, NORTH, _, _, phase_flag29, _, _, _, _, _, _),
> +	PINGROUP(55, SOUTH, _, phase_flag25, qdss_cti1_a, _, _, _, _, _, _),
> +	PINGROUP(56, SOUTH, _, phase_flag10, qdss_gpio3, _, atest_usb20, _, _, _, _),
> +	PINGROUP(57, SOUTH, gcc_gp1, _, phase_flag4, atest_usb22, _, _, _, _, _),
> +	PINGROUP(58, SOUTH, _, gcc_gp2, _, _, atest_char, _, _, _, _),
> +	PINGROUP(59, NORTH, mdp_vsync, gcc_gp3, _, _, atest_char3, _, _, _, _),
> +	PINGROUP(60, NORTH, cri_trng0, _, _, atest_char2, _, _, _, _, _),
> +	PINGROUP(61, NORTH, pri_mi2s, cri_trng1, _, _, atest_char1, _, _, _, _),
> +	PINGROUP(62, NORTH, sec_mi2s, audio_ref, _, cri_trng, _, _, atest_char0, _, _),
> +	PINGROUP(63, NORTH, _, _, _, qdss_gpio1, _, _, _, _, _),
> +	PINGROUP(64, SOUTH, blsp_spi8_cs1, sp_cmu, _, _, qdss_gpio2, _, _, _, _),
> +	PINGROUP(65, SOUTH, _, nav_pps_a, nav_pps_a, gps_tx_a, blsp_spi3_cs2, adsp_ext, _, _, _),
> +	PINGROUP(66, NORTH, _, _, qdss_cti1_b, _, _, _, _, _, _),
> +	PINGROUP(67, NORTH, _, _, qdss_gpio0, _, _, _, _, _, _),
> +	PINGROUP(68, NORTH, isense_dbg, _, phase_flag0, qdss_gpio, _, _, _, _, _),
> +	PINGROUP(69, NORTH, _, phase_flag7, qdss_gpio, _, _, _, _, _, _),
> +	PINGROUP(70, NORTH, _, phase_flag8, qdss_gpio6, _, _, _, _, _, _),
> +	PINGROUP(71, NORTH, _, _, qdss_gpio7, tsense_pwm1, tsense_pwm2, _, _, _, _),
> +	PINGROUP(72, NORTH, _, qdss_gpio14, _, _, _, _, _, _, _),
> +	PINGROUP(73, NORTH, _, _, qdss_gpio15, _, _, _, _, _, _),
> +	PINGROUP(74, NORTH, mdp_vsync, _, _, _, _, _, _, _, _),
> +	PINGROUP(75, NORTH, _, _, qdss_gpio8, _, _, _, _, _, _),
> +	PINGROUP(76, NORTH, blsp_spi8_cs2, _, _, _, qdss_gpio9, _, _, _, _),
> +	PINGROUP(77, NORTH, _, _, qdss_gpio10, _, _, _, _, _, _),
> +	PINGROUP(78, NORTH, gcc_gp1, _, qdss_gpio13, _, _, _, _, _, _),
> +	PINGROUP(79, SOUTH, _, _, qdss_gpio11, _, _, _, _, _, _),
> +	PINGROUP(80, SOUTH, nav_pps_b, nav_pps_b, gps_tx_c, _, _, qdss_gpio12, _, _, _),
> +	PINGROUP(81, CENTER, mss_lte, gcc_gp2, _, _, _, _, _, _, _),
> +	PINGROUP(82, CENTER, mss_lte, gcc_gp3, _, _, _, _, _, _, _),
> +	PINGROUP(83, SOUTH, uim2_data, _, _, _, _, _, _, _, _),
> +	PINGROUP(84, SOUTH, uim2_clk, _, _, _, _, _, _, _, _),
> +	PINGROUP(85, SOUTH, uim2_reset, _, _, _, _, _, _, _, _),
> +	PINGROUP(86, SOUTH, uim2_present, _, _, _, _, _, _, _, _),
> +	PINGROUP(87, SOUTH, uim1_data, _, _, _, _, _, _, _, _),
> +	PINGROUP(88, SOUTH, uim1_clk, _, _, _, _, _, _, _, _),
> +	PINGROUP(89, SOUTH, uim1_reset, _, _, _, _, _, _, _, _),
> +	PINGROUP(90, SOUTH, uim1_present, _, _, _, _, _, _, _, _),
> +	PINGROUP(91, SOUTH, uim_batt, _, _, _, _, _, _, _, _),
> +	PINGROUP(92, SOUTH, _, _, pa_indicator, _, _, _, _, _, _),
> +	PINGROUP(93, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(94, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(95, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(96, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(97, SOUTH, _, ldo_en, _, _, _, _, _, _, _),
> +	PINGROUP(98, SOUTH, _, nav_pps_c, nav_pps_c, gps_tx_b, ldo_update, _, _, _, _),
> +	PINGROUP(99, SOUTH, qlink_request, _, _, _, _, _, _, _, _),
> +	PINGROUP(100, SOUTH, qlink_enable, _, _, _, _, _, _, _, _),
> +	PINGROUP(101, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(102, SOUTH, _, prng_rosc, _, _, _, _, _, _, _),
> +	PINGROUP(103, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(104, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(105, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(106, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(107, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(108, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(109, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(110, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(111, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(112, SOUTH, _, _, _, _, _, _, _, _, _),
> +	PINGROUP(113, SOUTH, _, _, _, _, _, _, _, _, _),
> +	SDC_QDSD_PINGROUP(sdc1_clk, 0x99a000, 13, 6),
> +	SDC_QDSD_PINGROUP(sdc1_cmd, 0x99a000, 11, 3),
> +	SDC_QDSD_PINGROUP(sdc1_data, 0x99a000, 9, 0),
> +	SDC_QDSD_PINGROUP(sdc2_clk, 0x99b000, 14, 6),
> +	SDC_QDSD_PINGROUP(sdc2_cmd, 0x99b000, 11, 3),
> +	SDC_QDSD_PINGROUP(sdc2_data, 0x99b000, 9, 0),
> +	SDC_QDSD_PINGROUP(sdc1_rclk, 0x99a000, 15, 0),
> +};
> +
> +static const struct msm_pinctrl_soc_data sdm660_pinctrl = {
> +	.pins = sdm660_pins,
> +	.npins = ARRAY_SIZE(sdm660_pins),
> +	.functions = sdm660_functions,
> +	.nfunctions = ARRAY_SIZE(sdm660_functions),
> +	.groups = sdm660_groups,
> +	.ngroups = ARRAY_SIZE(sdm660_groups),
> +	.ngpios = 114,
> +};
> +
> +static int sdm660_pinctrl_probe(struct platform_device *pdev)
> +{
> +	return msm_pinctrl_probe(pdev, &sdm660_pinctrl);
> +}
> +
> +static const struct of_device_id sdm660_pinctrl_of_match[] = {
> +	{ .compatible = "qcom,sdm660-pinctrl", },
> +	{ },
> +};
> +
> +static struct platform_driver sdm660_pinctrl_driver = {
> +	.driver = {
> +		.name = "sdm660-pinctrl",
> +		.of_match_table = sdm660_pinctrl_of_match,
> +	},
> +	.probe = sdm660_pinctrl_probe,
> +	.remove = msm_pinctrl_remove,
> +};
> +
> +static int __init sdm660_pinctrl_init(void)
> +{
> +	return platform_driver_register(&sdm660_pinctrl_driver);
> +}
> +arch_initcall(sdm660_pinctrl_init);
> +
> +static void __exit sdm660_pinctrl_exit(void)
> +{
> +	platform_driver_unregister(&sdm660_pinctrl_driver);
> +}
> +module_exit(sdm660_pinctrl_exit);
> +
> +MODULE_DESCRIPTION("QTI sdm660 pinctrl driver");
> +MODULE_LICENSE("GPL v2");
> +MODULE_DEVICE_TABLE(of, sdm660_pinctrl_of_match);
>
Craig Tatlor Aug. 13, 2018, 7:36 a.m. UTC | #2
On 13 August 2018 08:24:43 BST, "Michal Vokáč" <michal.vokac@ysoft.com> wrote:
>Hi Craig,
>On 12.8.2018 16:24, Craig Tatlor wrote:
>> Add initial pinctrl driver to support pin configuration with
>> pinctrl framework for sdm660.
>> Based off CAF implementation.
>> 
>> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
>> ---
>
>The documentation portion should be a separate patch.
>Please refer to
>Documentation/devicetree/bindings/submitting-patches.txt
>
>It is easier for DT maintainers to review just the relevant part.
>The binding patches are also rebased to a separate tree as they are not
>Linux specific and can be re-used in other OSes
>
>Best regards,
>Michal
I know, just did this because it is basically exactly same as other qcom pinctrl docs and they also only had one patch.

Sorry if you got this multiple times, apparently my email client adds HTML to non inline replies
>
>> Changes from v1:
>>    Adds gpio-ranges property to bindings
>> 
>> 
>>   .../bindings/pinctrl/qcom,sdm660-pinctrl.txt  |  202 +++
>>   drivers/pinctrl/qcom/Kconfig                  |   10 +
>>   drivers/pinctrl/qcom/Makefile                 |    1 +
>>   drivers/pinctrl/qcom/pinctrl-sdm660.c         | 1451
>+++++++++++++++++
>>   4 files changed, 1663 insertions(+)
>>   create mode 100644
>Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>>   create mode 100644 drivers/pinctrl/qcom/pinctrl-sdm660.c
>> 
>> diff --git
>a/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>> new file mode 100644
>> index 000000000000..801960ad2112
>> --- /dev/null
>> +++
>b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>> @@ -0,0 +1,202 @@
>> +Qualcomm Technologies, Inc. SDM660 TLMM block
>> +
>> +This binding describes the Top Level Mode Multiplexer block found in
>the
>> +SDM660 platform.
>> +
>> +- compatible:
>> +	Usage: required
>> +	Value type: <string>
>> +	Definition: must be "qcom,sdm660-pinctrl"
>> +
>> +- reg:
>> +	Usage: required
>> +	Value type: <prop-encoded-array>
>> +	Definition: the base address and size of the TLMM register space.
>> +
>> +- interrupts:
>> +	Usage: required
>> +	Value type: <prop-encoded-array>
>> +	Definition: should specify the TLMM summary IRQ.
>> +
>> +- interrupt-controller:
>> +	Usage: required
>> +	Value type: <none>
>> +	Definition: identifies this node as an interrupt controller
>> +
>> +- #interrupt-cells:
>> +	Usage: required
>> +	Value type: <u32>
>> +	Definition: must be 2. Specifying the pin number and flags, as
>defined
>> +		    in <dt-bindings/interrupt-controller/irq.h>
>> +
>> +- gpio-controller:
>> +	Usage: required
>> +	Value type: <none>
>> +	Definition: identifies this node as a gpio controller
>> +
>> +- gpio-ranges:
>> +	Usage: required
>> +	Value type: <prop-encoded-array>
>> +	Definition: Specifies the mapping between gpio controller and
>> +		    pin-controller pins.
>> +
>> +- #gpio-cells:
>> +	Usage: required
>> +	Value type: <u32>
>> +	Definition: must be 2. Specifying the pin number and flags, as
>defined
>> +		    in <dt-bindings/gpio/gpio.h>
>> +
>> +Please refer to ../gpio/gpio.txt and
>../interrupt-controller/interrupts.txt for
>> +a general description of GPIO and interrupt bindings.
>> +
>> +Please refer to pinctrl-bindings.txt in this directory for details
>of the
>> +common pinctrl bindings used by client devices, including the
>meaning of the
>> +phrase "pin configuration node".
>> +
>> +The pin configuration nodes act as a container for an arbitrary
>number of
>> +subnodes. Each of these subnodes represents some desired
>configuration for a
>> +pin, a group, or a list of pins or groups. This configuration can
>include the
>> +mux function to select on those pin(s)/group(s), and various pin
>configuration
>> +parameters, such as pull-up, drive strength, etc.
>> +
>> +
>> +PIN CONFIGURATION NODES:
>> +
>> +The name of each subnode is not important; all subnodes should be
>enumerated
>> +and processed purely based on their content.
>> +
>> +Each subnode only affects those parameters that are explicitly
>listed. In
>> +other words, a subnode that lists a mux function but no pin
>configuration
>> +parameters implies no information about any pin configuration
>parameters.
>> +Similarly, a pin subnode that describes a pullup parameter implies
>no
>> +information about e.g. the mux function.
>> +
>> +
>> +The following generic properties as defined in pinctrl-bindings.txt
>are valid
>> +to specify in a pin configuration subnode:
>> +
>> +- pins:
>> +	Usage: required
>> +	Value type: <string-array>
>> +	Definition: List of gpio pins affected by the properties specified
>in
>> +		    this subnode.  Valid pins are:
>> +		    gpio0-gpio113,
>> +		        Supports mux, bias and drive-strength
>> +		    sdc1_clk, sdc1_cmd, sdc1_data sdc2_clk, sdc2_cmd, sdc2_data
>sdc1_rclk,
>> +		        Supports bias and drive-strength
>> +
>> +- function:
>> +	Usage: required
>> +	Value type: <string>
>> +	Definition: Specify the alternative function to be configured for
>the
>> +		    specified pins. Functions are only valid for gpio pins.
>> +		    Valid values are:
>> +
>> +		    blsp_uart1, blsp_spi1, blsp_i2c1, blsp_uim1, atest_tsens,
>> +		    bimc_dte1, dac_calib0, blsp_spi8, blsp_uart8, blsp_uim8,
>> +		    qdss_cti_trig_out_b, bimc_dte0, dac_calib1,
>qdss_cti_trig_in_b,
>> +		    dac_calib2, atest_tsens2, atest_usb1, blsp_spi10, blsp_uart10,
>> +		    blsp_uim10, atest_bbrx1, atest_usb13, atest_bbrx0,
>atest_usb12,
>> +		    mdp_vsync, edp_lcd, blsp_i2c10, atest_gpsadc1, atest_usb11,
>> +		    atest_gpsadc0, edp_hot, atest_usb10, m_voc, dac_gpio,
>atest_char,
>> +		    cam_mclk, pll_bypassnl, qdss_stm7, blsp_i2c8,
>qdss_tracedata_b,
>> +		    pll_reset, qdss_stm6, qdss_stm5, qdss_stm4, atest_usb2,
>cci_i2c,
>> +		    qdss_stm3, dac_calib3, atest_usb23, atest_char3, dac_calib4,
>> +		    qdss_stm2, atest_usb22, atest_char2, qdss_stm1, dac_calib5,
>> +		    atest_usb21, atest_char1, dbg_out, qdss_stm0, dac_calib6,
>> +		    atest_usb20, atest_char0, dac_calib10, qdss_stm10,
>> +		    qdss_cti_trig_in_a, cci_timer4, blsp_spi6, blsp_uart6,
>blsp_uim6,
>> +		    blsp2_spi, qdss_stm9, qdss_cti_trig_out_a, dac_calib11,
>> +		    qdss_stm8, cci_timer0, qdss_stm13, dac_calib7, cci_timer1,
>> +		    qdss_stm12, dac_calib8, cci_timer2, blsp1_spi, qdss_stm11,
>> +		    dac_calib9, cci_timer3, cci_async, dac_calib12, blsp_i2c6,
>> +		    qdss_tracectl_a, dac_calib13, qdss_traceclk_a, dac_calib14,
>> +		    dac_calib15, hdmi_rcv, dac_calib16, hdmi_cec, pwr_modem,
>> +		    dac_calib17, hdmi_ddc, pwr_nav, dac_calib18, pwr_crypto,
>> +		    dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0,
>> +		    dac_calib22, dac_calib23, dac_calib24, tsif1_sync,
>dac_calib25,
>> +		    sd_write, tsif1_error, blsp_spi2, blsp_uart2, blsp_uim2,
>> +		    qdss_cti, blsp_i2c2, blsp_spi3, blsp_uart3, blsp_uim3,
>blsp_i2c3,
>> +		    uim3, blsp_spi9, blsp_uart9, blsp_uim9, blsp10_spi, blsp_i2c9,
>> +		    blsp_spi7, blsp_uart7, blsp_uim7, qdss_tracedata_a, blsp_i2c7,
>> +		    qua_mi2s, gcc_gp1_clk_a, ssc_irq, uim4, blsp_spi11,
>blsp_uart11,
>> +		    blsp_uim11, gcc_gp2_clk_a, gcc_gp3_clk_a, blsp_i2c11,
>cri_trng0,
>> +		    cri_trng1, cri_trng, qdss_stm18, pri_mi2s, qdss_stm17,
>blsp_spi4,
>> +		    blsp_uart4, blsp_uim4, qdss_stm16, qdss_stm15, blsp_i2c4,
>> +		    qdss_stm14, dac_calib26, spkr_i2s, audio_ref, lpass_slimbus,
>> +		    isense_dbg, tsense_pwm1, tsense_pwm2, btfm_slimbus, ter_mi2s,
>> +		    qdss_stm22, qdss_stm21, qdss_stm20, qdss_stm19, gcc_gp1_clk_b,
>> +		    sec_mi2s, blsp_spi5, blsp_uart5, blsp_uim5, gcc_gp2_clk_b,
>> +		    gcc_gp3_clk_b, blsp_i2c5, blsp_spi12, blsp_uart12, blsp_uim12,
>> +		    qdss_stm25, qdss_stm31, blsp_i2c12, qdss_stm30, qdss_stm29,
>> +		    tsif1_clk, qdss_stm28, tsif1_en, tsif1_data, sdc4_cmd,
>qdss_stm27,
>> +		    qdss_traceclk_b, tsif2_error, sdc43, vfr_1, qdss_stm26,
>tsif2_clk,
>> +		    sdc4_clk, qdss_stm24, tsif2_en, sdc42, qdss_stm23,
>qdss_tracectl_b,
>> +		    sd_card, tsif2_data, sdc41, tsif2_sync, sdc40, mdp_vsync_p_b,
>> +		    ldo_en, mdp_vsync_s_b, ldo_update, blsp11_uart_tx_b,
>blsp11_uart_rx_b,
>> +		    blsp11_i2c_sda_b, prng_rosc, blsp11_i2c_scl_b, uim2, uim1,
>uim_batt,
>> +		    pci_e2, pa_indicator, adsp_ext, ddr_bist, qdss_tracedata_11,
>> +		    qdss_tracedata_12, modem_tsync, nav_dr, nav_pps, pci_e1,
>gsm_tx,
>> +		    qspi_cs, ssbi2, ssbi1, mss_lte, qspi_clk, qspi0, qspi1, qspi2,
>qspi3,
>> +		    gpio
>> +
>> +- bias-disable:
>> +	Usage: optional
>> +	Value type: <none>
>> +	Definition: The specified pins should be configued as no pull.
>> +
>> +- bias-pull-down:
>> +	Usage: optional
>> +	Value type: <none>
>> +	Definition: The specified pins should be configued as pull down.
>> +
>> +- bias-pull-up:
>> +	Usage: optional
>> +	Value type: <none>
>> +	Definition: The specified pins should be configued as pull up.
>> +
>> +- output-high:
>> +	Usage: optional
>> +	Value type: <none>
>> +	Definition: The specified pins are configured in output mode,
>driven
>> +		    high.
>> +		    Not valid for sdc pins.
>> +
>> +- output-low:
>> +	Usage: optional
>> +	Value type: <none>
>> +	Definition: The specified pins are configured in output mode,
>driven
>> +		    low.
>> +		    Not valid for sdc pins.
>> +
>> +- drive-strength:
>> +	Usage: optional
>> +	Value type: <u32>
>> +	Definition: Selects the drive strength for the specified pins, in
>mA.
>> +		    Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16
>> +
>> +Example:
>> +
>> +	tlmm: pinctrl@1010000 {
>> +		compatible = "qcom,sdm660-pinctrl";
>> +		reg = <0x1010000 0x300000>;
>> +		interrupts = <0 208 0>;
>> +		gpio-controller;
>> +		gpio-ranges = <&tlmm 0 0 114>;
>> +		#gpio-cells = <2>;
>> +		interrupt-controller;
>> +		#interrupt-cells = <2>;
>> +
>> +		uart_console_active: uart_console_active {
>> +			mux {
>> +				pins = "gpio4", "gpio5";
>> +				function = "blsp_uart8";
>> +			};
>> +
>> +			config {
>> +				pins = "gpio4", "gpio5";
>> +				drive-strength = <2>;
>> +				bias-disable;
>> +			};
>> +		};
>> +	};
>> diff --git a/drivers/pinctrl/qcom/Kconfig
>b/drivers/pinctrl/qcom/Kconfig
>> index 195492033075..091beadb8a1c 100644
>> --- a/drivers/pinctrl/qcom/Kconfig
>> +++ b/drivers/pinctrl/qcom/Kconfig
>> @@ -147,6 +147,16 @@ config PINCTRL_QCOM_SSBI_PMIC
>>            which are using SSBI for communication with SoC. Example
>PMIC's
>>            devices are pm8058 and pm8921.
>>   
>> +config PINCTRL_SDM660
>> +       tristate "Qualcomm Technologies Inc SDM660 pin controller
>driver"
>> +       depends on GPIOLIB && OF
>> +       select PINCTRL_MSM
>> +       help
>> +         This is the pinctrl, pinmux, pinconf and gpiolib driver for
>the
>> +         Qualcomm Technologies Inc TLMM block found on the Qualcomm
>> +         Technologies Inc SDM660 platform.
>> +
>> +
>>   config PINCTRL_SDM845
>>          tristate "Qualcomm Technologies Inc SDM845 pin controller
>driver"
>>          depends on GPIOLIB && OF
>> diff --git a/drivers/pinctrl/qcom/Makefile
>b/drivers/pinctrl/qcom/Makefile
>> index 0c6f3ddc296d..9b08808a2f1c 100644
>> --- a/drivers/pinctrl/qcom/Makefile
>> +++ b/drivers/pinctrl/qcom/Makefile
>> @@ -19,4 +19,5 @@ obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) +=
>pinctrl-spmi-gpio.o
>>   obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-mpp.o
>>   obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-gpio.o
>>   obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-mpp.o
>> +obj-$(CONFIG_PINCTRL_SDM660)   += pinctrl-sdm660.o
>>   obj-$(CONFIG_PINCTRL_SDM845) += pinctrl-sdm845.o
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sdm660.c
>b/drivers/pinctrl/qcom/pinctrl-sdm660.c
>> new file mode 100644
>> index 000000000000..ded56111f168
>> --- /dev/null
>> +++ b/drivers/pinctrl/qcom/pinctrl-sdm660.c
>> @@ -0,0 +1,1451 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (c) 2016, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2018, Craig Tatlor.
>> + */
>> +
>> +#include <linux/module.h>
>> +#include <linux/of.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/pinctrl/pinctrl.h>
>> +
>> +#include "pinctrl-msm.h"
>> +
>> +#define NORTH	0x00900000
>> +#define CENTER	0x00500000
>> +#define SOUTH	0x00100000
>> +#define REG_SIZE 0x1000
>> +
>> +#define FUNCTION(fname)					\
>> +	[msm_mux_##fname] = {		                \
>> +		.name = #fname,				\
>> +		.groups = fname##_groups,               \
>> +		.ngroups = ARRAY_SIZE(fname##_groups),	\
>> +	}
>> +
>> +
>> +#define PINGROUP(id, base, f1, f2, f3, f4, f5, f6, f7, f8, f9)	\
>> +	{					        \
>> +		.name = "gpio" #id,			\
>> +		.pins = gpio##id##_pins,		\
>> +		.npins = (unsigned)ARRAY_SIZE(gpio##id##_pins),	\
>> +		.funcs = (int[]){			\
>> +			msm_mux_gpio, /* gpio mode */	\
>> +			msm_mux_##f1,			\
>> +			msm_mux_##f2,			\
>> +			msm_mux_##f3,			\
>> +			msm_mux_##f4,			\
>> +			msm_mux_##f5,			\
>> +			msm_mux_##f6,			\
>> +			msm_mux_##f7,			\
>> +			msm_mux_##f8,			\
>> +			msm_mux_##f9			\
>> +		},				        \
>> +		.nfuncs = 10,				\
>> +		.ctl_reg = base + REG_SIZE * id,	\
>> +		.io_reg = base + 0x4 + REG_SIZE * id,		\
>> +		.intr_cfg_reg = base + 0x8 + REG_SIZE * id,		\
>> +		.intr_status_reg = base + 0xc + REG_SIZE * id,	\
>> +		.intr_target_reg = base + 0x8 + REG_SIZE * id,	\
>> +		.mux_bit = 2,			\
>> +		.pull_bit = 0,			\
>> +		.drv_bit = 6,			\
>> +		.oe_bit = 9,			\
>> +		.in_bit = 0,			\
>> +		.out_bit = 1,			\
>> +		.intr_enable_bit = 0,		\
>> +		.intr_status_bit = 0,		\
>> +		.intr_target_bit = 5,		\
>> +		.intr_target_kpss_val = 3,	\
>> +		.intr_raw_status_bit = 4,	\
>> +		.intr_polarity_bit = 1,		\
>> +		.intr_detection_bit = 2,	\
>> +		.intr_detection_width = 2,	\
>> +	}
>> +
>> +#define SDC_QDSD_PINGROUP(pg_name, ctl, pull, drv)	\
>> +	{					        \
>> +		.name = #pg_name,			\
>> +		.pins = pg_name##_pins,			\
>> +		.npins = (unsigned)ARRAY_SIZE(pg_name##_pins),	\
>> +		.ctl_reg = ctl,				\
>> +		.io_reg = 0,				\
>> +		.intr_cfg_reg = 0,			\
>> +		.intr_status_reg = 0,			\
>> +		.intr_target_reg = 0,			\
>> +		.mux_bit = -1,				\
>> +		.pull_bit = pull,			\
>> +		.drv_bit = drv,				\
>> +		.oe_bit = -1,				\
>> +		.in_bit = -1,				\
>> +		.out_bit = -1,				\
>> +		.intr_enable_bit = -1,			\
>> +		.intr_status_bit = -1,			\
>> +		.intr_target_bit = -1,			\
>> +		.intr_raw_status_bit = -1,		\
>> +		.intr_polarity_bit = -1,		\
>> +		.intr_detection_bit = -1,		\
>> +		.intr_detection_width = -1,		\
>> +	}
>> +
>> +static const struct pinctrl_pin_desc sdm660_pins[] = {
>> +	PINCTRL_PIN(0, "GPIO_0"),
>> +	PINCTRL_PIN(1, "GPIO_1"),
>> +	PINCTRL_PIN(2, "GPIO_2"),
>> +	PINCTRL_PIN(3, "GPIO_3"),
>> +	PINCTRL_PIN(4, "GPIO_4"),
>> +	PINCTRL_PIN(5, "GPIO_5"),
>> +	PINCTRL_PIN(6, "GPIO_6"),
>> +	PINCTRL_PIN(7, "GPIO_7"),
>> +	PINCTRL_PIN(8, "GPIO_8"),
>> +	PINCTRL_PIN(9, "GPIO_9"),
>> +	PINCTRL_PIN(10, "GPIO_10"),
>> +	PINCTRL_PIN(11, "GPIO_11"),
>> +	PINCTRL_PIN(12, "GPIO_12"),
>> +	PINCTRL_PIN(13, "GPIO_13"),
>> +	PINCTRL_PIN(14, "GPIO_14"),
>> +	PINCTRL_PIN(15, "GPIO_15"),
>> +	PINCTRL_PIN(16, "GPIO_16"),
>> +	PINCTRL_PIN(17, "GPIO_17"),
>> +	PINCTRL_PIN(18, "GPIO_18"),
>> +	PINCTRL_PIN(19, "GPIO_19"),
>> +	PINCTRL_PIN(20, "GPIO_20"),
>> +	PINCTRL_PIN(21, "GPIO_21"),
>> +	PINCTRL_PIN(22, "GPIO_22"),
>> +	PINCTRL_PIN(23, "GPIO_23"),
>> +	PINCTRL_PIN(24, "GPIO_24"),
>> +	PINCTRL_PIN(25, "GPIO_25"),
>> +	PINCTRL_PIN(26, "GPIO_26"),
>> +	PINCTRL_PIN(27, "GPIO_27"),
>> +	PINCTRL_PIN(28, "GPIO_28"),
>> +	PINCTRL_PIN(29, "GPIO_29"),
>> +	PINCTRL_PIN(30, "GPIO_30"),
>> +	PINCTRL_PIN(31, "GPIO_31"),
>> +	PINCTRL_PIN(32, "GPIO_32"),
>> +	PINCTRL_PIN(33, "GPIO_33"),
>> +	PINCTRL_PIN(34, "GPIO_34"),
>> +	PINCTRL_PIN(35, "GPIO_35"),
>> +	PINCTRL_PIN(36, "GPIO_36"),
>> +	PINCTRL_PIN(37, "GPIO_37"),
>> +	PINCTRL_PIN(38, "GPIO_38"),
>> +	PINCTRL_PIN(39, "GPIO_39"),
>> +	PINCTRL_PIN(40, "GPIO_40"),
>> +	PINCTRL_PIN(41, "GPIO_41"),
>> +	PINCTRL_PIN(42, "GPIO_42"),
>> +	PINCTRL_PIN(43, "GPIO_43"),
>> +	PINCTRL_PIN(44, "GPIO_44"),
>> +	PINCTRL_PIN(45, "GPIO_45"),
>> +	PINCTRL_PIN(46, "GPIO_46"),
>> +	PINCTRL_PIN(47, "GPIO_47"),
>> +	PINCTRL_PIN(48, "GPIO_48"),
>> +	PINCTRL_PIN(49, "GPIO_49"),
>> +	PINCTRL_PIN(50, "GPIO_50"),
>> +	PINCTRL_PIN(51, "GPIO_51"),
>> +	PINCTRL_PIN(52, "GPIO_52"),
>> +	PINCTRL_PIN(53, "GPIO_53"),
>> +	PINCTRL_PIN(54, "GPIO_54"),
>> +	PINCTRL_PIN(55, "GPIO_55"),
>> +	PINCTRL_PIN(56, "GPIO_56"),
>> +	PINCTRL_PIN(57, "GPIO_57"),
>> +	PINCTRL_PIN(58, "GPIO_58"),
>> +	PINCTRL_PIN(59, "GPIO_59"),
>> +	PINCTRL_PIN(60, "GPIO_60"),
>> +	PINCTRL_PIN(61, "GPIO_61"),
>> +	PINCTRL_PIN(62, "GPIO_62"),
>> +	PINCTRL_PIN(63, "GPIO_63"),
>> +	PINCTRL_PIN(64, "GPIO_64"),
>> +	PINCTRL_PIN(65, "GPIO_65"),
>> +	PINCTRL_PIN(66, "GPIO_66"),
>> +	PINCTRL_PIN(67, "GPIO_67"),
>> +	PINCTRL_PIN(68, "GPIO_68"),
>> +	PINCTRL_PIN(69, "GPIO_69"),
>> +	PINCTRL_PIN(70, "GPIO_70"),
>> +	PINCTRL_PIN(71, "GPIO_71"),
>> +	PINCTRL_PIN(72, "GPIO_72"),
>> +	PINCTRL_PIN(73, "GPIO_73"),
>> +	PINCTRL_PIN(74, "GPIO_74"),
>> +	PINCTRL_PIN(75, "GPIO_75"),
>> +	PINCTRL_PIN(76, "GPIO_76"),
>> +	PINCTRL_PIN(77, "GPIO_77"),
>> +	PINCTRL_PIN(78, "GPIO_78"),
>> +	PINCTRL_PIN(79, "GPIO_79"),
>> +	PINCTRL_PIN(80, "GPIO_80"),
>> +	PINCTRL_PIN(81, "GPIO_81"),
>> +	PINCTRL_PIN(82, "GPIO_82"),
>> +	PINCTRL_PIN(83, "GPIO_83"),
>> +	PINCTRL_PIN(84, "GPIO_84"),
>> +	PINCTRL_PIN(85, "GPIO_85"),
>> +	PINCTRL_PIN(86, "GPIO_86"),
>> +	PINCTRL_PIN(87, "GPIO_87"),
>> +	PINCTRL_PIN(88, "GPIO_88"),
>> +	PINCTRL_PIN(89, "GPIO_89"),
>> +	PINCTRL_PIN(90, "GPIO_90"),
>> +	PINCTRL_PIN(91, "GPIO_91"),
>> +	PINCTRL_PIN(92, "GPIO_92"),
>> +	PINCTRL_PIN(93, "GPIO_93"),
>> +	PINCTRL_PIN(94, "GPIO_94"),
>> +	PINCTRL_PIN(95, "GPIO_95"),
>> +	PINCTRL_PIN(96, "GPIO_96"),
>> +	PINCTRL_PIN(97, "GPIO_97"),
>> +	PINCTRL_PIN(98, "GPIO_98"),
>> +	PINCTRL_PIN(99, "GPIO_99"),
>> +	PINCTRL_PIN(100, "GPIO_100"),
>> +	PINCTRL_PIN(101, "GPIO_101"),
>> +	PINCTRL_PIN(102, "GPIO_102"),
>> +	PINCTRL_PIN(103, "GPIO_103"),
>> +	PINCTRL_PIN(104, "GPIO_104"),
>> +	PINCTRL_PIN(105, "GPIO_105"),
>> +	PINCTRL_PIN(106, "GPIO_106"),
>> +	PINCTRL_PIN(107, "GPIO_107"),
>> +	PINCTRL_PIN(108, "GPIO_108"),
>> +	PINCTRL_PIN(109, "GPIO_109"),
>> +	PINCTRL_PIN(110, "GPIO_110"),
>> +	PINCTRL_PIN(111, "GPIO_111"),
>> +	PINCTRL_PIN(112, "GPIO_112"),
>> +	PINCTRL_PIN(113, "GPIO_113"),
>> +	PINCTRL_PIN(114, "SDC1_CLK"),
>> +	PINCTRL_PIN(115, "SDC1_CMD"),
>> +	PINCTRL_PIN(116, "SDC1_DATA"),
>> +	PINCTRL_PIN(117, "SDC2_CLK"),
>> +	PINCTRL_PIN(118, "SDC2_CMD"),
>> +	PINCTRL_PIN(119, "SDC2_DATA"),
>> +	PINCTRL_PIN(120, "SDC1_RCLK"),
>> +};
>> +
>> +#define DECLARE_MSM_GPIO_PINS(pin) \
>> +	static const unsigned int gpio##pin##_pins[] = { pin }
>> +DECLARE_MSM_GPIO_PINS(0);
>> +DECLARE_MSM_GPIO_PINS(1);
>> +DECLARE_MSM_GPIO_PINS(2);
>> +DECLARE_MSM_GPIO_PINS(3);
>> +DECLARE_MSM_GPIO_PINS(4);
>> +DECLARE_MSM_GPIO_PINS(5);
>> +DECLARE_MSM_GPIO_PINS(6);
>> +DECLARE_MSM_GPIO_PINS(7);
>> +DECLARE_MSM_GPIO_PINS(8);
>> +DECLARE_MSM_GPIO_PINS(9);
>> +DECLARE_MSM_GPIO_PINS(10);
>> +DECLARE_MSM_GPIO_PINS(11);
>> +DECLARE_MSM_GPIO_PINS(12);
>> +DECLARE_MSM_GPIO_PINS(13);
>> +DECLARE_MSM_GPIO_PINS(14);
>> +DECLARE_MSM_GPIO_PINS(15);
>> +DECLARE_MSM_GPIO_PINS(16);
>> +DECLARE_MSM_GPIO_PINS(17);
>> +DECLARE_MSM_GPIO_PINS(18);
>> +DECLARE_MSM_GPIO_PINS(19);
>> +DECLARE_MSM_GPIO_PINS(20);
>> +DECLARE_MSM_GPIO_PINS(21);
>> +DECLARE_MSM_GPIO_PINS(22);
>> +DECLARE_MSM_GPIO_PINS(23);
>> +DECLARE_MSM_GPIO_PINS(24);
>> +DECLARE_MSM_GPIO_PINS(25);
>> +DECLARE_MSM_GPIO_PINS(26);
>> +DECLARE_MSM_GPIO_PINS(27);
>> +DECLARE_MSM_GPIO_PINS(28);
>> +DECLARE_MSM_GPIO_PINS(29);
>> +DECLARE_MSM_GPIO_PINS(30);
>> +DECLARE_MSM_GPIO_PINS(31);
>> +DECLARE_MSM_GPIO_PINS(32);
>> +DECLARE_MSM_GPIO_PINS(33);
>> +DECLARE_MSM_GPIO_PINS(34);
>> +DECLARE_MSM_GPIO_PINS(35);
>> +DECLARE_MSM_GPIO_PINS(36);
>> +DECLARE_MSM_GPIO_PINS(37);
>> +DECLARE_MSM_GPIO_PINS(38);
>> +DECLARE_MSM_GPIO_PINS(39);
>> +DECLARE_MSM_GPIO_PINS(40);
>> +DECLARE_MSM_GPIO_PINS(41);
>> +DECLARE_MSM_GPIO_PINS(42);
>> +DECLARE_MSM_GPIO_PINS(43);
>> +DECLARE_MSM_GPIO_PINS(44);
>> +DECLARE_MSM_GPIO_PINS(45);
>> +DECLARE_MSM_GPIO_PINS(46);
>> +DECLARE_MSM_GPIO_PINS(47);
>> +DECLARE_MSM_GPIO_PINS(48);
>> +DECLARE_MSM_GPIO_PINS(49);
>> +DECLARE_MSM_GPIO_PINS(50);
>> +DECLARE_MSM_GPIO_PINS(51);
>> +DECLARE_MSM_GPIO_PINS(52);
>> +DECLARE_MSM_GPIO_PINS(53);
>> +DECLARE_MSM_GPIO_PINS(54);
>> +DECLARE_MSM_GPIO_PINS(55);
>> +DECLARE_MSM_GPIO_PINS(56);
>> +DECLARE_MSM_GPIO_PINS(57);
>> +DECLARE_MSM_GPIO_PINS(58);
>> +DECLARE_MSM_GPIO_PINS(59);
>> +DECLARE_MSM_GPIO_PINS(60);
>> +DECLARE_MSM_GPIO_PINS(61);
>> +DECLARE_MSM_GPIO_PINS(62);
>> +DECLARE_MSM_GPIO_PINS(63);
>> +DECLARE_MSM_GPIO_PINS(64);
>> +DECLARE_MSM_GPIO_PINS(65);
>> +DECLARE_MSM_GPIO_PINS(66);
>> +DECLARE_MSM_GPIO_PINS(67);
>> +DECLARE_MSM_GPIO_PINS(68);
>> +DECLARE_MSM_GPIO_PINS(69);
>> +DECLARE_MSM_GPIO_PINS(70);
>> +DECLARE_MSM_GPIO_PINS(71);
>> +DECLARE_MSM_GPIO_PINS(72);
>> +DECLARE_MSM_GPIO_PINS(73);
>> +DECLARE_MSM_GPIO_PINS(74);
>> +DECLARE_MSM_GPIO_PINS(75);
>> +DECLARE_MSM_GPIO_PINS(76);
>> +DECLARE_MSM_GPIO_PINS(77);
>> +DECLARE_MSM_GPIO_PINS(78);
>> +DECLARE_MSM_GPIO_PINS(79);
>> +DECLARE_MSM_GPIO_PINS(80);
>> +DECLARE_MSM_GPIO_PINS(81);
>> +DECLARE_MSM_GPIO_PINS(82);
>> +DECLARE_MSM_GPIO_PINS(83);
>> +DECLARE_MSM_GPIO_PINS(84);
>> +DECLARE_MSM_GPIO_PINS(85);
>> +DECLARE_MSM_GPIO_PINS(86);
>> +DECLARE_MSM_GPIO_PINS(87);
>> +DECLARE_MSM_GPIO_PINS(88);
>> +DECLARE_MSM_GPIO_PINS(89);
>> +DECLARE_MSM_GPIO_PINS(90);
>> +DECLARE_MSM_GPIO_PINS(91);
>> +DECLARE_MSM_GPIO_PINS(92);
>> +DECLARE_MSM_GPIO_PINS(93);
>> +DECLARE_MSM_GPIO_PINS(94);
>> +DECLARE_MSM_GPIO_PINS(95);
>> +DECLARE_MSM_GPIO_PINS(96);
>> +DECLARE_MSM_GPIO_PINS(97);
>> +DECLARE_MSM_GPIO_PINS(98);
>> +DECLARE_MSM_GPIO_PINS(99);
>> +DECLARE_MSM_GPIO_PINS(100);
>> +DECLARE_MSM_GPIO_PINS(101);
>> +DECLARE_MSM_GPIO_PINS(102);
>> +DECLARE_MSM_GPIO_PINS(103);
>> +DECLARE_MSM_GPIO_PINS(104);
>> +DECLARE_MSM_GPIO_PINS(105);
>> +DECLARE_MSM_GPIO_PINS(106);
>> +DECLARE_MSM_GPIO_PINS(107);
>> +DECLARE_MSM_GPIO_PINS(108);
>> +DECLARE_MSM_GPIO_PINS(109);
>> +DECLARE_MSM_GPIO_PINS(110);
>> +DECLARE_MSM_GPIO_PINS(111);
>> +DECLARE_MSM_GPIO_PINS(112);
>> +DECLARE_MSM_GPIO_PINS(113);
>> +
>> +static const unsigned int sdc1_clk_pins[] = { 114 };
>> +static const unsigned int sdc1_cmd_pins[] = { 115 };
>> +static const unsigned int sdc1_data_pins[] = { 116 };
>> +static const unsigned int sdc2_clk_pins[] = { 117 };
>> +static const unsigned int sdc2_cmd_pins[] = { 118 };
>> +static const unsigned int sdc2_data_pins[] = { 119 };
>> +static const unsigned int sdc1_rclk_pins[] = { 120 };
>> +
>> +enum sdm660_functions {
>> +	msm_mux_blsp_spi1,
>> +	msm_mux_gpio,
>> +	msm_mux_blsp_uim1,
>> +	msm_mux_tgu_ch0,
>> +	msm_mux_qdss_gpio4,
>> +	msm_mux_atest_gpsadc1,
>> +	msm_mux_blsp_uart1,
>> +	msm_mux_phase_flag14,
>> +	msm_mux_blsp_i2c2,
>> +	msm_mux_phase_flag31,
>> +	msm_mux_blsp_spi3,
>> +	msm_mux_blsp_spi3_cs1,
>> +	msm_mux_blsp_spi3_cs2,
>> +	msm_mux_wlan1_adc1,
>> +	msm_mux_atest_usb13,
>> +	msm_mux_tgu_ch1,
>> +	msm_mux_qdss_gpio5,
>> +	msm_mux_atest_gpsadc0,
>> +	msm_mux_blsp_i2c1,
>> +	msm_mux_ddr_bist,
>> +	msm_mux_atest_tsens2,
>> +	msm_mux_atest_usb1,
>> +	msm_mux_blsp_spi2,
>> +	msm_mux_blsp_uim2,
>> +	msm_mux_phase_flag3,
>> +	msm_mux_bimc_dte1,
>> +	msm_mux_wlan1_adc0,
>> +	msm_mux_atest_usb12,
>> +	msm_mux_bimc_dte0,
>> +	msm_mux_blsp_i2c3,
>> +	msm_mux_wlan2_adc1,
>> +	msm_mux_atest_usb11,
>> +	msm_mux_dbg_out,
>> +	msm_mux_wlan2_adc0,
>> +	msm_mux_atest_usb10,
>> +	msm_mux_blsp_spi4,
>> +	msm_mux_pri_mi2s,
>> +	msm_mux_phase_flag26,
>> +	msm_mux_qdss_cti0_a,
>> +	msm_mux_qdss_cti0_b,
>> +	msm_mux_qdss_cti1_a,
>> +	msm_mux_qdss_cti1_b,
>> +	msm_mux_pri_mi2s_ws,
>> +	msm_mux_phase_flag27,
>> +	msm_mux_blsp_i2c4,
>> +	msm_mux_phase_flag28,
>> +	msm_mux_blsp_uart5,
>> +	msm_mux_blsp_spi5,
>> +	msm_mux_blsp_uim5,
>> +	msm_mux_phase_flag5,
>> +	msm_mux_blsp_i2c5,
>> +	msm_mux_blsp_spi6,
>> +	msm_mux_blsp_uart2,
>> +	msm_mux_blsp_uim6,
>> +	msm_mux_phase_flag11,
>> +	msm_mux_vsense_data0,
>> +	msm_mux_blsp_i2c6,
>> +	msm_mux_phase_flag12,
>> +	msm_mux_vsense_data1,
>> +	msm_mux_phase_flag13,
>> +	msm_mux_vsense_mode,
>> +	msm_mux_blsp_spi7,
>> +	msm_mux_blsp_uart6_a,
>> +	msm_mux_blsp_uart6_b,
>> +	msm_mux_sec_mi2s,
>> +	msm_mux_sndwire_clk,
>> +	msm_mux_phase_flag17,
>> +	msm_mux_vsense_clkout,
>> +	msm_mux_sndwire_data,
>> +	msm_mux_phase_flag18,
>> +	msm_mux_blsp_i2c7,
>> +	msm_mux_phase_flag19,
>> +	msm_mux_vfr_1,
>> +	msm_mux_phase_flag20,
>> +	msm_mux_blsp_spi8_cs1,
>> +	msm_mux_blsp_spi8_cs2,
>> +	msm_mux_m_voc,
>> +	msm_mux_phase_flag21,
>> +	msm_mux_phase_flag22,
>> +	msm_mux_blsp_i2c8_a,
>> +	msm_mux_blsp_i2c8_b,
>> +	msm_mux_phase_flag23,
>> +	msm_mux_pwr_modem,
>> +	msm_mux_phase_flag24,
>> +	msm_mux_qdss_gpio,
>> +	msm_mux_cam_mclk,
>> +	msm_mux_pwr_nav,
>> +	msm_mux_qdss_gpio0,
>> +	msm_mux_qspi_data0,
>> +	msm_mux_pwr_crypto,
>> +	msm_mux_qdss_gpio1,
>> +	msm_mux_qspi_data1,
>> +	msm_mux_agera_pll,
>> +	msm_mux_qdss_gpio2,
>> +	msm_mux_qspi_data2,
>> +	msm_mux_jitter_bist,
>> +	msm_mux_qdss_gpio3,
>> +	msm_mux_qdss_gpio7,
>> +	msm_mux_mdss_vsync0,
>> +	msm_mux_mdss_vsync1,
>> +	msm_mux_mdss_vsync2,
>> +	msm_mux_mdss_vsync3,
>> +	msm_mux_qdss_gpio9,
>> +	msm_mux_atest_usb2,
>> +	msm_mux_cci_i2c,
>> +	msm_mux_pll_bypassnl,
>> +	msm_mux_atest_tsens,
>> +	msm_mux_atest_usb21,
>> +	msm_mux_pll_reset,
>> +	msm_mux_atest_usb23,
>> +	msm_mux_qdss_gpio6,
>> +	msm_mux_qspi_cs,
>> +	msm_mux_qdss_gpio10,
>> +	msm_mux_qdss_gpio11,
>> +	msm_mux_cci_async,
>> +	msm_mux_qdss_gpio12,
>> +	msm_mux_qdss_gpio13,
>> +	msm_mux_qspi_clk,
>> +	msm_mux_phase_flag30,
>> +	msm_mux_qdss_gpio14,
>> +	msm_mux_qspi_resetn,
>> +	msm_mux_phase_flag1,
>> +	msm_mux_qdss_gpio15,
>> +	msm_mux_phase_flag2,
>> +	msm_mux_phase_flag9,
>> +	msm_mux_qspi_data3,
>> +	msm_mux_phase_flag15,
>> +	msm_mux_qdss_gpio8,
>> +	msm_mux_phase_flag16,
>> +	msm_mux_phase_flag6,
>> +	msm_mux_phase_flag29,
>> +	msm_mux_phase_flag25,
>> +	msm_mux_phase_flag10,
>> +	msm_mux_atest_usb20,
>> +	msm_mux_gcc_gp1,
>> +	msm_mux_phase_flag4,
>> +	msm_mux_atest_usb22,
>> +	msm_mux_gcc_gp2,
>> +	msm_mux_atest_char,
>> +	msm_mux_mdp_vsync,
>> +	msm_mux_gcc_gp3,
>> +	msm_mux_atest_char3,
>> +	msm_mux_cri_trng0,
>> +	msm_mux_atest_char2,
>> +	msm_mux_cri_trng1,
>> +	msm_mux_atest_char1,
>> +	msm_mux_audio_ref,
>> +	msm_mux_cri_trng,
>> +	msm_mux_atest_char0,
>> +	msm_mux_blsp_spi8_a,
>> +	msm_mux_blsp_spi8_b,
>> +	msm_mux_sp_cmu,
>> +	msm_mux_nav_pps_a,
>> +	msm_mux_nav_pps_b,
>> +	msm_mux_nav_pps_c,
>> +	msm_mux_gps_tx_a,
>> +	msm_mux_gps_tx_b,
>> +	msm_mux_gps_tx_c,
>> +	msm_mux_adsp_ext,
>> +	msm_mux_ssc_irq,
>> +	msm_mux_isense_dbg,
>> +	msm_mux_phase_flag0,
>> +	msm_mux_phase_flag7,
>> +	msm_mux_phase_flag8,
>> +	msm_mux_tsense_pwm1,
>> +	msm_mux_tsense_pwm2,
>> +	msm_mux_mss_lte,
>> +	msm_mux_uim2_data,
>> +	msm_mux_uim2_clk,
>> +	msm_mux_uim2_reset,
>> +	msm_mux_uim2_present,
>> +	msm_mux_uim1_data,
>> +	msm_mux_uim1_clk,
>> +	msm_mux_uim1_reset,
>> +	msm_mux_uim1_present,
>> +	msm_mux_uim_batt,
>> +	msm_mux_pa_indicator,
>> +	msm_mux_ldo_en,
>> +	msm_mux_ldo_update,
>> +	msm_mux_qlink_request,
>> +	msm_mux_qlink_enable,
>> +	msm_mux_prng_rosc,
>> +	msm_mux__,
>> +};
>> +
>> +static const char * const gpio_groups[] = {
>> +	"gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6",
>"gpio7",
>> +	"gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
>> +	"gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20",
>"gpio21",
>> +	"gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27",
>"gpio28",
>> +	"gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34",
>"gpio35",
>> +	"gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41",
>"gpio42",
>> +	"gpio43", "gpio44", "gpio45", "gpio46", "gpio47", "gpio48",
>"gpio49",
>> +	"gpio50", "gpio51", "gpio52", "gpio53", "gpio54", "gpio55",
>"gpio56",
>> +	"gpio57", "gpio58", "gpio59", "gpio60", "gpio61", "gpio62",
>"gpio63",
>> +	"gpio64", "gpio65", "gpio66", "gpio67", "gpio68", "gpio69",
>"gpio70",
>> +	"gpio71", "gpio72", "gpio73", "gpio74", "gpio75", "gpio76",
>"gpio77",
>> +	"gpio78", "gpio79", "gpio80", "gpio81", "gpio82", "gpio83",
>"gpio84",
>> +	"gpio85", "gpio86", "gpio87", "gpio88", "gpio89", "gpio90",
>"gpio91",
>> +	"gpio92", "gpio93", "gpio94", "gpio95", "gpio96", "gpio97",
>"gpio98",
>> +	"gpio99", "gpio100", "gpio101", "gpio102", "gpio103", "gpio104",
>> +	"gpio105", "gpio106", "gpio107", "gpio108", "gpio109", "gpio110",
>> +	"gpio111", "gpio112", "gpio113",
>> +};
>> +static const char * const blsp_spi1_groups[] = {
>> +	"gpio0", "gpio1", "gpio2", "gpio3", "gpio46",
>> +};
>> +static const char * const blsp_uim1_groups[] = {
>> +	"gpio0", "gpio1",
>> +};
>> +static const char * const tgu_ch0_groups[] = {
>> +	"gpio0",
>> +};
>> +static const char * const qdss_gpio4_groups[] = {
>> +	"gpio0", "gpio36",
>> +};
>> +static const char * const atest_gpsadc1_groups[] = {
>> +	"gpio0",
>> +};
>> +static const char * const blsp_uart1_groups[] = {
>> +	"gpio0", "gpio1", "gpio2", "gpio3",
>> +};
>> +static const char * const phase_flag14_groups[] = {
>> +	"gpio5",
>> +};
>> +static const char * const blsp_i2c2_groups[] = {
>> +	"gpio6", "gpio7",
>> +};
>> +static const char * const phase_flag31_groups[] = {
>> +	"gpio6",
>> +};
>> +static const char * const blsp_spi3_groups[] = {
>> +	"gpio8", "gpio9", "gpio10", "gpio11",
>> +};
>> +static const char * const blsp_spi3_cs1_groups[] = {
>> +	"gpio30",
>> +};
>> +static const char * const blsp_spi3_cs2_groups[] = {
>> +	"gpio65",
>> +};
>> +static const char * const wlan1_adc1_groups[] = {
>> +	"gpio8",
>> +};
>> +static const char * const atest_usb13_groups[] = {
>> +	"gpio8",
>> +};
>> +static const char * const tgu_ch1_groups[] = {
>> +	"gpio1",
>> +};
>> +static const char * const qdss_gpio5_groups[] = {
>> +	"gpio1", "gpio37",
>> +};
>> +static const char * const atest_gpsadc0_groups[] = {
>> +	"gpio1",
>> +};
>> +static const char * const blsp_i2c1_groups[] = {
>> +	"gpio2", "gpio3",
>> +};
>> +static const char * const ddr_bist_groups[] = {
>> +	"gpio3", "gpio8", "gpio9", "gpio10",
>> +};
>> +static const char * const atest_tsens2_groups[] = {
>> +	"gpio3",
>> +};
>> +static const char * const atest_usb1_groups[] = {
>> +	"gpio3",
>> +};
>> +static const char * const blsp_spi2_groups[] = {
>> +	"gpio4", "gpio5", "gpio6", "gpio7",
>> +};
>> +static const char * const blsp_uim2_groups[] = {
>> +	"gpio4", "gpio5",
>> +};
>> +static const char * const phase_flag3_groups[] = {
>> +	"gpio4",
>> +};
>> +static const char * const bimc_dte1_groups[] = {
>> +	"gpio8", "gpio10",
>> +};
>> +static const char * const wlan1_adc0_groups[] = {
>> +	"gpio9",
>> +};
>> +static const char * const atest_usb12_groups[] = {
>> +	"gpio9",
>> +};
>> +static const char * const bimc_dte0_groups[] = {
>> +	"gpio9", "gpio11",
>> +};
>> +static const char * const blsp_i2c3_groups[] = {
>> +	"gpio10", "gpio11",
>> +};
>> +static const char * const wlan2_adc1_groups[] = {
>> +	"gpio10",
>> +};
>> +static const char * const atest_usb11_groups[] = {
>> +	"gpio10",
>> +};
>> +static const char * const dbg_out_groups[] = {
>> +	"gpio11",
>> +};
>> +static const char * const wlan2_adc0_groups[] = {
>> +	"gpio11",
>> +};
>> +static const char * const atest_usb10_groups[] = {
>> +	"gpio11",
>> +};
>> +static const char * const RCM_MARKER_groups[] = {
>> +	"gpio12", "gpio13",
>> +};
>> +static const char * const blsp_spi4_groups[] = {
>> +	"gpio12", "gpio13", "gpio14", "gpio15",
>> +};
>> +static const char * const pri_mi2s_groups[] = {
>> +	"gpio12", "gpio14", "gpio15", "gpio61",
>> +};
>> +static const char * const phase_flag26_groups[] = {
>> +	"gpio12",
>> +};
>> +static const char * const qdss_cti0_a_groups[] = {
>> +	"gpio49", "gpio50",
>> +};
>> +static const char * const qdss_cti0_b_groups[] = {
>> +	"gpio13", "gpio21",
>> +};
>> +static const char * const qdss_cti1_a_groups[] = {
>> +	"gpio53", "gpio55",
>> +};
>> +static const char * const qdss_cti1_b_groups[] = {
>> +	"gpio12", "gpio66",
>> +};
>> +static const char * const pri_mi2s_ws_groups[] = {
>> +	"gpio13",
>> +};
>> +static const char * const phase_flag27_groups[] = {
>> +	"gpio13",
>> +};
>> +static const char * const blsp_i2c4_groups[] = {
>> +	"gpio14", "gpio15",
>> +};
>> +static const char * const phase_flag28_groups[] = {
>> +	"gpio14",
>> +};
>> +static const char * const blsp_uart5_groups[] = {
>> +	"gpio16", "gpio17", "gpio18", "gpio19",
>> +};
>> +static const char * const blsp_spi5_groups[] = {
>> +	"gpio16", "gpio17", "gpio18", "gpio19",
>> +};
>> +static const char * const blsp_uim5_groups[] = {
>> +	"gpio16", "gpio17",
>> +};
>> +static const char * const phase_flag5_groups[] = {
>> +	"gpio17",
>> +};
>> +static const char * const blsp_i2c5_groups[] = {
>> +	"gpio18", "gpio19",
>> +};
>> +static const char * const blsp_spi6_groups[] = {
>> +	"gpio49", "gpio52", "gpio22", "gpio23",
>> +};
>> +static const char * const blsp_uart2_groups[] = {
>> +	"gpio4", "gpio5", "gpio6", "gpio7",
>> +};
>> +static const char * const blsp_uim6_groups[]
Craig Tatlor Aug. 13, 2018, 7:36 a.m. UTC | #3
On 13 August 2018 08:24:43 BST, "Michal Vokáč" <michal.vokac@ysoft.com> wrote:
>Hi Craig,
>On 12.8.2018 16:24, Craig Tatlor wrote:
>> Add initial pinctrl driver to support pin configuration with
>> pinctrl framework for sdm660.
>> Based off CAF implementation.
>> 
>> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
>> ---
>
>The documentation portion should be a separate patch.
>Please refer to
>Documentation/devicetree/bindings/submitting-patches.txt
>
>It is easier for DT maintainers to review just the relevant part.
>The binding patches are also rebased to a separate tree as they are not
>Linux specific and can be re-used in other OSes
>
>Best regards,
>Michal
I know, just did this because it is basically exactly same as other qcom pinctrl docs and they also only had one patch.

Sorry if you got this multiple times, apparently my email client adds HTML to non inline replies
>
>> Changes from v1:
>>    Adds gpio-ranges property to bindings
>> 
>> 
>>   .../bindings/pinctrl/qcom,sdm660-pinctrl.txt  |  202 +++
>>   drivers/pinctrl/qcom/Kconfig                  |   10 +
>>   drivers/pinctrl/qcom/Makefile                 |    1 +
>>   drivers/pinctrl/qcom/pinctrl-sdm660.c         | 1451
>+++++++++++++++++
>>   4 files changed, 1663 insertions(+)
>>   create mode 100644
>Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>>   create mode 100644 drivers/pinctrl/qcom/pinctrl-sdm660.c
>> 
>> diff --git
>a/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>> new file mode 100644
>> index 000000000000..801960ad2112
>> --- /dev/null
>> +++
>b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>> @@ -0,0 +1,202 @@
>> +Qualcomm Technologies, Inc. SDM660 TLMM block
>> +
>> +This binding describes the Top Level Mode Multiplexer block found in
>the
>> +SDM660 platform.
>> +
>> +- compatible:
>> +	Usage: required
>> +	Value type: <string>
>> +	Definition: must be "qcom,sdm660-pinctrl"
>> +
>> +- reg:
>> +	Usage: required
>> +	Value type: <prop-encoded-array>
>> +	Definition: the base address and size of the TLMM register space.
>> +
>> +- interrupts:
>> +	Usage: required
>> +	Value type: <prop-encoded-array>
>> +	Definition: should specify the TLMM summary IRQ.
>> +
>> +- interrupt-controller:
>> +	Usage: required
>> +	Value type: <none>
>> +	Definition: identifies this node as an interrupt controller
>> +
>> +- #interrupt-cells:
>> +	Usage: required
>> +	Value type: <u32>
>> +	Definition: must be 2. Specifying the pin number and flags, as
>defined
>> +		    in <dt-bindings/interrupt-controller/irq.h>
>> +
>> +- gpio-controller:
>> +	Usage: required
>> +	Value type: <none>
>> +	Definition: identifies this node as a gpio controller
>> +
>> +- gpio-ranges:
>> +	Usage: required
>> +	Value type: <prop-encoded-array>
>> +	Definition: Specifies the mapping between gpio controller and
>> +		    pin-controller pins.
>> +
>> +- #gpio-cells:
>> +	Usage: required
>> +	Value type: <u32>
>> +	Definition: must be 2. Specifying the pin number and flags, as
>defined
>> +		    in <dt-bindings/gpio/gpio.h>
>> +
>> +Please refer to ../gpio/gpio.txt and
>../interrupt-controller/interrupts.txt for
>> +a general description of GPIO and interrupt bindings.
>> +
>> +Please refer to pinctrl-bindings.txt in this directory for details
>of the
>> +common pinctrl bindings used by client devices, including the
>meaning of the
>> +phrase "pin configuration node".
>> +
>> +The pin configuration nodes act as a container for an arbitrary
>number of
>> +subnodes. Each of these subnodes represents some desired
>configuration for a
>> +pin, a group, or a list of pins or groups. This configuration can
>include the
>> +mux function to select on those pin(s)/group(s), and various pin
>configuration
>> +parameters, such as pull-up, drive strength, etc.
>> +
>> +
>> +PIN CONFIGURATION NODES:
>> +
>> +The name of each subnode is not important; all subnodes should be
>enumerated
>> +and processed purely based on their content.
>> +
>> +Each subnode only affects those parameters that are explicitly
>listed. In
>> +other words, a subnode that lists a mux function but no pin
>configuration
>> +parameters implies no information about any pin configuration
>parameters.
>> +Similarly, a pin subnode that describes a pullup parameter implies
>no
>> +information about e.g. the mux function.
>> +
>> +
>> +The following generic properties as defined in pinctrl-bindings.txt
>are valid
>> +to specify in a pin configuration subnode:
>> +
>> +- pins:
>> +	Usage: required
>> +	Value type: <string-array>
>> +	Definition: List of gpio pins affected by the properties specified
>in
>> +		    this subnode.  Valid pins are:
>> +		    gpio0-gpio113,
>> +		        Supports mux, bias and drive-strength
>> +		    sdc1_clk, sdc1_cmd, sdc1_data sdc2_clk, sdc2_cmd, sdc2_data
>sdc1_rclk,
>> +		        Supports bias and drive-strength
>> +
>> +- function:
>> +	Usage: required
>> +	Value type: <string>
>> +	Definition: Specify the alternative function to be configured for
>the
>> +		    specified pins. Functions are only valid for gpio pins.
>> +		    Valid values are:
>> +
>> +		    blsp_uart1, blsp_spi1, blsp_i2c1, blsp_uim1, atest_tsens,
>> +		    bimc_dte1, dac_calib0, blsp_spi8, blsp_uart8, blsp_uim8,
>> +		    qdss_cti_trig_out_b, bimc_dte0, dac_calib1,
>qdss_cti_trig_in_b,
>> +		    dac_calib2, atest_tsens2, atest_usb1, blsp_spi10, blsp_uart10,
>> +		    blsp_uim10, atest_bbrx1, atest_usb13, atest_bbrx0,
>atest_usb12,
>> +		    mdp_vsync, edp_lcd, blsp_i2c10, atest_gpsadc1, atest_usb11,
>> +		    atest_gpsadc0, edp_hot, atest_usb10, m_voc, dac_gpio,
>atest_char,
>> +		    cam_mclk, pll_bypassnl, qdss_stm7, blsp_i2c8,
>qdss_tracedata_b,
>> +		    pll_reset, qdss_stm6, qdss_stm5, qdss_stm4, atest_usb2,
>cci_i2c,
>> +		    qdss_stm3, dac_calib3, atest_usb23, atest_char3, dac_calib4,
>> +		    qdss_stm2, atest_usb22, atest_char2, qdss_stm1, dac_calib5,
>> +		    atest_usb21, atest_char1, dbg_out, qdss_stm0, dac_calib6,
>> +		    atest_usb20, atest_char0, dac_calib10, qdss_stm10,
>> +		    qdss_cti_trig_in_a, cci_timer4, blsp_spi6, blsp_uart6,
>blsp_uim6,
>> +		    blsp2_spi, qdss_stm9, qdss_cti_trig_out_a, dac_calib11,
>> +		    qdss_stm8, cci_timer0, qdss_stm13, dac_calib7, cci_timer1,
>> +		    qdss_stm12, dac_calib8, cci_timer2, blsp1_spi, qdss_stm11,
>> +		    dac_calib9, cci_timer3, cci_async, dac_calib12, blsp_i2c6,
>> +		    qdss_tracectl_a, dac_calib13, qdss_traceclk_a, dac_calib14,
>> +		    dac_calib15, hdmi_rcv, dac_calib16, hdmi_cec, pwr_modem,
>> +		    dac_calib17, hdmi_ddc, pwr_nav, dac_calib18, pwr_crypto,
>> +		    dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0,
>> +		    dac_calib22, dac_calib23, dac_calib24, tsif1_sync,
>dac_calib25,
>> +		    sd_write, tsif1_error, blsp_spi2, blsp_uart2, blsp_uim2,
>> +		    qdss_cti, blsp_i2c2, blsp_spi3, blsp_uart3, blsp_uim3,
>blsp_i2c3,
>> +		    uim3, blsp_spi9, blsp_uart9, blsp_uim9, blsp10_spi, blsp_i2c9,
>> +		    blsp_spi7, blsp_uart7, blsp_uim7, qdss_tracedata_a, blsp_i2c7,
>> +		    qua_mi2s, gcc_gp1_clk_a, ssc_irq, uim4, blsp_spi11,
>blsp_uart11,
>> +		    blsp_uim11, gcc_gp2_clk_a, gcc_gp3_clk_a, blsp_i2c11,
>cri_trng0,
>> +		    cri_trng1, cri_trng, qdss_stm18, pri_mi2s, qdss_stm17,
>blsp_spi4,
>> +		    blsp_uart4, blsp_uim4, qdss_stm16, qdss_stm15, blsp_i2c4,
>> +		    qdss_stm14, dac_calib26, spkr_i2s, audio_ref, lpass_slimbus,
>> +		    isense_dbg, tsense_pwm1, tsense_pwm2, btfm_slimbus, ter_mi2s,
>> +		    qdss_stm22, qdss_stm21, qdss_stm20, qdss_stm19, gcc_gp1_clk_b,
>> +		    sec_mi2s, blsp_spi5, blsp_uart5, blsp_uim5, gcc_gp2_clk_b,
>> +		    gcc_gp3_clk_b, blsp_i2c5, blsp_spi12, blsp_uart12, blsp_uim12,
>> +		    qdss_stm25, qdss_stm31, blsp_i2c12, qdss_stm30, qdss_stm29,
>> +		    tsif1_clk, qdss_stm28, tsif1_en, tsif1_data, sdc4_cmd,
>qdss_stm27,
>> +		    qdss_traceclk_b, tsif2_error, sdc43, vfr_1, qdss_stm26,
>tsif2_clk,
>> +		    sdc4_clk, qdss_stm24, tsif2_en, sdc42, qdss_stm23,
>qdss_tracectl_b,
>> +		    sd_card, tsif2_data, sdc41, tsif2_sync, sdc40, mdp_vsync_p_b,
>> +		    ldo_en, mdp_vsync_s_b, ldo_update, blsp11_uart_tx_b,
>blsp11_uart_rx_b,
>> +		    blsp11_i2c_sda_b, prng_rosc, blsp11_i2c_scl_b, uim2, uim1,
>uim_batt,
>> +		    pci_e2, pa_indicator, adsp_ext, ddr_bist, qdss_tracedata_11,
>> +		    qdss_tracedata_12, modem_tsync, nav_dr, nav_pps, pci_e1,
>gsm_tx,
>> +		    qspi_cs, ssbi2, ssbi1, mss_lte, qspi_clk, qspi0, qspi1, qspi2,
>qspi3,
>> +		    gpio
>> +
>> +- bias-disable:
>> +	Usage: optional
>> +	Value type: <none>
>> +	Definition: The specified pins should be configued as no pull.
>> +
>> +- bias-pull-down:
>> +	Usage: optional
>> +	Value type: <none>
>> +	Definition: The specified pins should be configued as pull down.
>> +
>> +- bias-pull-up:
>> +	Usage: optional
>> +	Value type: <none>
>> +	Definition: The specified pins should be configued as pull up.
>> +
>> +- output-high:
>> +	Usage: optional
>> +	Value type: <none>
>> +	Definition: The specified pins are configured in output mode,
>driven
>> +		    high.
>> +		    Not valid for sdc pins.
>> +
>> +- output-low:
>> +	Usage: optional
>> +	Value type: <none>
>> +	Definition: The specified pins are configured in output mode,
>driven
>> +		    low.
>> +		    Not valid for sdc pins.
>> +
>> +- drive-strength:
>> +	Usage: optional
>> +	Value type: <u32>
>> +	Definition: Selects the drive strength for the specified pins, in
>mA.
>> +		    Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16
>> +
>> +Example:
>> +
>> +	tlmm: pinctrl@1010000 {
>> +		compatible = "qcom,sdm660-pinctrl";
>> +		reg = <0x1010000 0x300000>;
>> +		interrupts = <0 208 0>;
>> +		gpio-controller;
>> +		gpio-ranges = <&tlmm 0 0 114>;
>> +		#gpio-cells = <2>;
>> +		interrupt-controller;
>> +		#interrupt-cells = <2>;
>> +
>> +		uart_console_active: uart_console_active {
>> +			mux {
>> +				pins = "gpio4", "gpio5";
>> +				function = "blsp_uart8";
>> +			};
>> +
>> +			config {
>> +				pins = "gpio4", "gpio5";
>> +				drive-strength = <2>;
>> +				bias-disable;
>> +			};
>> +		};
>> +	};
>> diff --git a/drivers/pinctrl/qcom/Kconfig
>b/drivers/pinctrl/qcom/Kconfig
>> index 195492033075..091beadb8a1c 100644
>> --- a/drivers/pinctrl/qcom/Kconfig
>> +++ b/drivers/pinctrl/qcom/Kconfig
>> @@ -147,6 +147,16 @@ config PINCTRL_QCOM_SSBI_PMIC
>>            which are using SSBI for communication with SoC. Example
>PMIC's
>>            devices are pm8058 and pm8921.
>>   
>> +config PINCTRL_SDM660
>> +       tristate "Qualcomm Technologies Inc SDM660 pin controller
>driver"
>> +       depends on GPIOLIB && OF
>> +       select PINCTRL_MSM
>> +       help
>> +         This is the pinctrl, pinmux, pinconf and gpiolib driver for
>the
>> +         Qualcomm Technologies Inc TLMM block found on the Qualcomm
>> +         Technologies Inc SDM660 platform.
>> +
>> +
>>   config PINCTRL_SDM845
>>          tristate "Qualcomm Technologies Inc SDM845 pin controller
>driver"
>>          depends on GPIOLIB && OF
>> diff --git a/drivers/pinctrl/qcom/Makefile
>b/drivers/pinctrl/qcom/Makefile
>> index 0c6f3ddc296d..9b08808a2f1c 100644
>> --- a/drivers/pinctrl/qcom/Makefile
>> +++ b/drivers/pinctrl/qcom/Makefile
>> @@ -19,4 +19,5 @@ obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) +=
>pinctrl-spmi-gpio.o
>>   obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-mpp.o
>>   obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-gpio.o
>>   obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-mpp.o
>> +obj-$(CONFIG_PINCTRL_SDM660)   += pinctrl-sdm660.o
>>   obj-$(CONFIG_PINCTRL_SDM845) += pinctrl-sdm845.o
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sdm660.c
>b/drivers/pinctrl/qcom/pinctrl-sdm660.c
>> new file mode 100644
>> index 000000000000..ded56111f168
>> --- /dev/null
>> +++ b/drivers/pinctrl/qcom/pinctrl-sdm660.c
>> @@ -0,0 +1,1451 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (c) 2016, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2018, Craig Tatlor.
>> + */
>> +
>> +#include <linux/module.h>
>> +#include <linux/of.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/pinctrl/pinctrl.h>
>> +
>> +#include "pinctrl-msm.h"
>> +
>> +#define NORTH	0x00900000
>> +#define CENTER	0x00500000
>> +#define SOUTH	0x00100000
>> +#define REG_SIZE 0x1000
>> +
>> +#define FUNCTION(fname)					\
>> +	[msm_mux_##fname] = {		                \
>> +		.name = #fname,				\
>> +		.groups = fname##_groups,               \
>> +		.ngroups = ARRAY_SIZE(fname##_groups),	\
>> +	}
>> +
>> +
>> +#define PINGROUP(id, base, f1, f2, f3, f4, f5, f6, f7, f8, f9)	\
>> +	{					        \
>> +		.name = "gpio" #id,			\
>> +		.pins = gpio##id##_pins,		\
>> +		.npins = (unsigned)ARRAY_SIZE(gpio##id##_pins),	\
>> +		.funcs = (int[]){			\
>> +			msm_mux_gpio, /* gpio mode */	\
>> +			msm_mux_##f1,			\
>> +			msm_mux_##f2,			\
>> +			msm_mux_##f3,			\
>> +			msm_mux_##f4,			\
>> +			msm_mux_##f5,			\
>> +			msm_mux_##f6,			\
>> +			msm_mux_##f7,			\
>> +			msm_mux_##f8,			\
>> +			msm_mux_##f9			\
>> +		},				        \
>> +		.nfuncs = 10,				\
>> +		.ctl_reg = base + REG_SIZE * id,	\
>> +		.io_reg = base + 0x4 + REG_SIZE * id,		\
>> +		.intr_cfg_reg = base + 0x8 + REG_SIZE * id,		\
>> +		.intr_status_reg = base + 0xc + REG_SIZE * id,	\
>> +		.intr_target_reg = base + 0x8 + REG_SIZE * id,	\
>> +		.mux_bit = 2,			\
>> +		.pull_bit = 0,			\
>> +		.drv_bit = 6,			\
>> +		.oe_bit = 9,			\
>> +		.in_bit = 0,			\
>> +		.out_bit = 1,			\
>> +		.intr_enable_bit = 0,		\
>> +		.intr_status_bit = 0,		\
>> +		.intr_target_bit = 5,		\
>> +		.intr_target_kpss_val = 3,	\
>> +		.intr_raw_status_bit = 4,	\
>> +		.intr_polarity_bit = 1,		\
>> +		.intr_detection_bit = 2,	\
>> +		.intr_detection_width = 2,	\
>> +	}
>> +
>> +#define SDC_QDSD_PINGROUP(pg_name, ctl, pull, drv)	\
>> +	{					        \
>> +		.name = #pg_name,			\
>> +		.pins = pg_name##_pins,			\
>> +		.npins = (unsigned)ARRAY_SIZE(pg_name##_pins),	\
>> +		.ctl_reg = ctl,				\
>> +		.io_reg = 0,				\
>> +		.intr_cfg_reg = 0,			\
>> +		.intr_status_reg = 0,			\
>> +		.intr_target_reg = 0,			\
>> +		.mux_bit = -1,				\
>> +		.pull_bit = pull,			\
>> +		.drv_bit = drv,				\
>> +		.oe_bit = -1,				\
>> +		.in_bit = -1,				\
>> +		.out_bit = -1,				\
>> +		.intr_enable_bit = -1,			\
>> +		.intr_status_bit = -1,			\
>> +		.intr_target_bit = -1,			\
>> +		.intr_raw_status_bit = -1,		\
>> +		.intr_polarity_bit = -1,		\
>> +		.intr_detection_bit = -1,		\
>> +		.intr_detection_width = -1,		\
>> +	}
>> +
>> +static const struct pinctrl_pin_desc sdm660_pins[] = {
>> +	PINCTRL_PIN(0, "GPIO_0"),
>> +	PINCTRL_PIN(1, "GPIO_1"),
>> +	PINCTRL_PIN(2, "GPIO_2"),
>> +	PINCTRL_PIN(3, "GPIO_3"),
>> +	PINCTRL_PIN(4, "GPIO_4"),
>> +	PINCTRL_PIN(5, "GPIO_5"),
>> +	PINCTRL_PIN(6, "GPIO_6"),
>> +	PINCTRL_PIN(7, "GPIO_7"),
>> +	PINCTRL_PIN(8, "GPIO_8"),
>> +	PINCTRL_PIN(9, "GPIO_9"),
>> +	PINCTRL_PIN(10, "GPIO_10"),
>> +	PINCTRL_PIN(11, "GPIO_11"),
>> +	PINCTRL_PIN(12, "GPIO_12"),
>> +	PINCTRL_PIN(13, "GPIO_13"),
>> +	PINCTRL_PIN(14, "GPIO_14"),
>> +	PINCTRL_PIN(15, "GPIO_15"),
>> +	PINCTRL_PIN(16, "GPIO_16"),
>> +	PINCTRL_PIN(17, "GPIO_17"),
>> +	PINCTRL_PIN(18, "GPIO_18"),
>> +	PINCTRL_PIN(19, "GPIO_19"),
>> +	PINCTRL_PIN(20, "GPIO_20"),
>> +	PINCTRL_PIN(21, "GPIO_21"),
>> +	PINCTRL_PIN(22, "GPIO_22"),
>> +	PINCTRL_PIN(23, "GPIO_23"),
>> +	PINCTRL_PIN(24, "GPIO_24"),
>> +	PINCTRL_PIN(25, "GPIO_25"),
>> +	PINCTRL_PIN(26, "GPIO_26"),
>> +	PINCTRL_PIN(27, "GPIO_27"),
>> +	PINCTRL_PIN(28, "GPIO_28"),
>> +	PINCTRL_PIN(29, "GPIO_29"),
>> +	PINCTRL_PIN(30, "GPIO_30"),
>> +	PINCTRL_PIN(31, "GPIO_31"),
>> +	PINCTRL_PIN(32, "GPIO_32"),
>> +	PINCTRL_PIN(33, "GPIO_33"),
>> +	PINCTRL_PIN(34, "GPIO_34"),
>> +	PINCTRL_PIN(35, "GPIO_35"),
>> +	PINCTRL_PIN(36, "GPIO_36"),
>> +	PINCTRL_PIN(37, "GPIO_37"),
>> +	PINCTRL_PIN(38, "GPIO_38"),
>> +	PINCTRL_PIN(39, "GPIO_39"),
>> +	PINCTRL_PIN(40, "GPIO_40"),
>> +	PINCTRL_PIN(41, "GPIO_41"),
>> +	PINCTRL_PIN(42, "GPIO_42"),
>> +	PINCTRL_PIN(43, "GPIO_43"),
>> +	PINCTRL_PIN(44, "GPIO_44"),
>> +	PINCTRL_PIN(45, "GPIO_45"),
>> +	PINCTRL_PIN(46, "GPIO_46"),
>> +	PINCTRL_PIN(47, "GPIO_47"),
>> +	PINCTRL_PIN(48, "GPIO_48"),
>> +	PINCTRL_PIN(49, "GPIO_49"),
>> +	PINCTRL_PIN(50, "GPIO_50"),
>> +	PINCTRL_PIN(51, "GPIO_51"),
>> +	PINCTRL_PIN(52, "GPIO_52"),
>> +	PINCTRL_PIN(53, "GPIO_53"),
>> +	PINCTRL_PIN(54, "GPIO_54"),
>> +	PINCTRL_PIN(55, "GPIO_55"),
>> +	PINCTRL_PIN(56, "GPIO_56"),
>> +	PINCTRL_PIN(57, "GPIO_57"),
>> +	PINCTRL_PIN(58, "GPIO_58"),
>> +	PINCTRL_PIN(59, "GPIO_59"),
>> +	PINCTRL_PIN(60, "GPIO_60"),
>> +	PINCTRL_PIN(61, "GPIO_61"),
>> +	PINCTRL_PIN(62, "GPIO_62"),
>> +	PINCTRL_PIN(63, "GPIO_63"),
>> +	PINCTRL_PIN(64, "GPIO_64"),
>> +	PINCTRL_PIN(65, "GPIO_65"),
>> +	PINCTRL_PIN(66, "GPIO_66"),
>> +	PINCTRL_PIN(67, "GPIO_67"),
>> +	PINCTRL_PIN(68, "GPIO_68"),
>> +	PINCTRL_PIN(69, "GPIO_69"),
>> +	PINCTRL_PIN(70, "GPIO_70"),
>> +	PINCTRL_PIN(71, "GPIO_71"),
>> +	PINCTRL_PIN(72, "GPIO_72"),
>> +	PINCTRL_PIN(73, "GPIO_73"),
>> +	PINCTRL_PIN(74, "GPIO_74"),
>> +	PINCTRL_PIN(75, "GPIO_75"),
>> +	PINCTRL_PIN(76, "GPIO_76"),
>> +	PINCTRL_PIN(77, "GPIO_77"),
>> +	PINCTRL_PIN(78, "GPIO_78"),
>> +	PINCTRL_PIN(79, "GPIO_79"),
>> +	PINCTRL_PIN(80, "GPIO_80"),
>> +	PINCTRL_PIN(81, "GPIO_81"),
>> +	PINCTRL_PIN(82, "GPIO_82"),
>> +	PINCTRL_PIN(83, "GPIO_83"),
>> +	PINCTRL_PIN(84, "GPIO_84"),
>> +	PINCTRL_PIN(85, "GPIO_85"),
>> +	PINCTRL_PIN(86, "GPIO_86"),
>> +	PINCTRL_PIN(87, "GPIO_87"),
>> +	PINCTRL_PIN(88, "GPIO_88"),
>> +	PINCTRL_PIN(89, "GPIO_89"),
>> +	PINCTRL_PIN(90, "GPIO_90"),
>> +	PINCTRL_PIN(91, "GPIO_91"),
>> +	PINCTRL_PIN(92, "GPIO_92"),
>> +	PINCTRL_PIN(93, "GPIO_93"),
>> +	PINCTRL_PIN(94, "GPIO_94"),
>> +	PINCTRL_PIN(95, "GPIO_95"),
>> +	PINCTRL_PIN(96, "GPIO_96"),
>> +	PINCTRL_PIN(97, "GPIO_97"),
>> +	PINCTRL_PIN(98, "GPIO_98"),
>> +	PINCTRL_PIN(99, "GPIO_99"),
>> +	PINCTRL_PIN(100, "GPIO_100"),
>> +	PINCTRL_PIN(101, "GPIO_101"),
>> +	PINCTRL_PIN(102, "GPIO_102"),
>> +	PINCTRL_PIN(103, "GPIO_103"),
>> +	PINCTRL_PIN(104, "GPIO_104"),
>> +	PINCTRL_PIN(105, "GPIO_105"),
>> +	PINCTRL_PIN(106, "GPIO_106"),
>> +	PINCTRL_PIN(107, "GPIO_107"),
>> +	PINCTRL_PIN(108, "GPIO_108"),
>> +	PINCTRL_PIN(109, "GPIO_109"),
>> +	PINCTRL_PIN(110, "GPIO_110"),
>> +	PINCTRL_PIN(111, "GPIO_111"),
>> +	PINCTRL_PIN(112, "GPIO_112"),
>> +	PINCTRL_PIN(113, "GPIO_113"),
>> +	PINCTRL_PIN(114, "SDC1_CLK"),
>> +	PINCTRL_PIN(115, "SDC1_CMD"),
>> +	PINCTRL_PIN(116, "SDC1_DATA"),
>> +	PINCTRL_PIN(117, "SDC2_CLK"),
>> +	PINCTRL_PIN(118, "SDC2_CMD"),
>> +	PINCTRL_PIN(119, "SDC2_DATA"),
>> +	PINCTRL_PIN(120, "SDC1_RCLK"),
>> +};
>> +
>> +#define DECLARE_MSM_GPIO_PINS(pin) \
>> +	static const unsigned int gpio##pin##_pins[] = { pin }
>> +DECLARE_MSM_GPIO_PINS(0);
>> +DECLARE_MSM_GPIO_PINS(1);
>> +DECLARE_MSM_GPIO_PINS(2);
>> +DECLARE_MSM_GPIO_PINS(3);
>> +DECLARE_MSM_GPIO_PINS(4);
>> +DECLARE_MSM_GPIO_PINS(5);
>> +DECLARE_MSM_GPIO_PINS(6);
>> +DECLARE_MSM_GPIO_PINS(7);
>> +DECLARE_MSM_GPIO_PINS(8);
>> +DECLARE_MSM_GPIO_PINS(9);
>> +DECLARE_MSM_GPIO_PINS(10);
>> +DECLARE_MSM_GPIO_PINS(11);
>> +DECLARE_MSM_GPIO_PINS(12);
>> +DECLARE_MSM_GPIO_PINS(13);
>> +DECLARE_MSM_GPIO_PINS(14);
>> +DECLARE_MSM_GPIO_PINS(15);
>> +DECLARE_MSM_GPIO_PINS(16);
>> +DECLARE_MSM_GPIO_PINS(17);
>> +DECLARE_MSM_GPIO_PINS(18);
>> +DECLARE_MSM_GPIO_PINS(19);
>> +DECLARE_MSM_GPIO_PINS(20);
>> +DECLARE_MSM_GPIO_PINS(21);
>> +DECLARE_MSM_GPIO_PINS(22);
>> +DECLARE_MSM_GPIO_PINS(23);
>> +DECLARE_MSM_GPIO_PINS(24);
>> +DECLARE_MSM_GPIO_PINS(25);
>> +DECLARE_MSM_GPIO_PINS(26);
>> +DECLARE_MSM_GPIO_PINS(27);
>> +DECLARE_MSM_GPIO_PINS(28);
>> +DECLARE_MSM_GPIO_PINS(29);
>> +DECLARE_MSM_GPIO_PINS(30);
>> +DECLARE_MSM_GPIO_PINS(31);
>> +DECLARE_MSM_GPIO_PINS(32);
>> +DECLARE_MSM_GPIO_PINS(33);
>> +DECLARE_MSM_GPIO_PINS(34);
>> +DECLARE_MSM_GPIO_PINS(35);
>> +DECLARE_MSM_GPIO_PINS(36);
>> +DECLARE_MSM_GPIO_PINS(37);
>> +DECLARE_MSM_GPIO_PINS(38);
>> +DECLARE_MSM_GPIO_PINS(39);
>> +DECLARE_MSM_GPIO_PINS(40);
>> +DECLARE_MSM_GPIO_PINS(41);
>> +DECLARE_MSM_GPIO_PINS(42);
>> +DECLARE_MSM_GPIO_PINS(43);
>> +DECLARE_MSM_GPIO_PINS(44);
>> +DECLARE_MSM_GPIO_PINS(45);
>> +DECLARE_MSM_GPIO_PINS(46);
>> +DECLARE_MSM_GPIO_PINS(47);
>> +DECLARE_MSM_GPIO_PINS(48);
>> +DECLARE_MSM_GPIO_PINS(49);
>> +DECLARE_MSM_GPIO_PINS(50);
>> +DECLARE_MSM_GPIO_PINS(51);
>> +DECLARE_MSM_GPIO_PINS(52);
>> +DECLARE_MSM_GPIO_PINS(53);
>> +DECLARE_MSM_GPIO_PINS(54);
>> +DECLARE_MSM_GPIO_PINS(55);
>> +DECLARE_MSM_GPIO_PINS(56);
>> +DECLARE_MSM_GPIO_PINS(57);
>> +DECLARE_MSM_GPIO_PINS(58);
>> +DECLARE_MSM_GPIO_PINS(59);
>> +DECLARE_MSM_GPIO_PINS(60);
>> +DECLARE_MSM_GPIO_PINS(61);
>> +DECLARE_MSM_GPIO_PINS(62);
>> +DECLARE_MSM_GPIO_PINS(63);
>> +DECLARE_MSM_GPIO_PINS(64);
>> +DECLARE_MSM_GPIO_PINS(65);
>> +DECLARE_MSM_GPIO_PINS(66);
>> +DECLARE_MSM_GPIO_PINS(67);
>> +DECLARE_MSM_GPIO_PINS(68);
>> +DECLARE_MSM_GPIO_PINS(69);
>> +DECLARE_MSM_GPIO_PINS(70);
>> +DECLARE_MSM_GPIO_PINS(71);
>> +DECLARE_MSM_GPIO_PINS(72);
>> +DECLARE_MSM_GPIO_PINS(73);
>> +DECLARE_MSM_GPIO_PINS(74);
>> +DECLARE_MSM_GPIO_PINS(75);
>> +DECLARE_MSM_GPIO_PINS(76);
>> +DECLARE_MSM_GPIO_PINS(77);
>> +DECLARE_MSM_GPIO_PINS(78);
>> +DECLARE_MSM_GPIO_PINS(79);
>> +DECLARE_MSM_GPIO_PINS(80);
>> +DECLARE_MSM_GPIO_PINS(81);
>> +DECLARE_MSM_GPIO_PINS(82);
>> +DECLARE_MSM_GPIO_PINS(83);
>> +DECLARE_MSM_GPIO_PINS(84);
>> +DECLARE_MSM_GPIO_PINS(85);
>> +DECLARE_MSM_GPIO_PINS(86);
>> +DECLARE_MSM_GPIO_PINS(87);
>> +DECLARE_MSM_GPIO_PINS(88);
>> +DECLARE_MSM_GPIO_PINS(89);
>> +DECLARE_MSM_GPIO_PINS(90);
>> +DECLARE_MSM_GPIO_PINS(91);
>> +DECLARE_MSM_GPIO_PINS(92);
>> +DECLARE_MSM_GPIO_PINS(93);
>> +DECLARE_MSM_GPIO_PINS(94);
>> +DECLARE_MSM_GPIO_PINS(95);
>> +DECLARE_MSM_GPIO_PINS(96);
>> +DECLARE_MSM_GPIO_PINS(97);
>> +DECLARE_MSM_GPIO_PINS(98);
>> +DECLARE_MSM_GPIO_PINS(99);
>> +DECLARE_MSM_GPIO_PINS(100);
>> +DECLARE_MSM_GPIO_PINS(101);
>> +DECLARE_MSM_GPIO_PINS(102);
>> +DECLARE_MSM_GPIO_PINS(103);
>> +DECLARE_MSM_GPIO_PINS(104);
>> +DECLARE_MSM_GPIO_PINS(105);
>> +DECLARE_MSM_GPIO_PINS(106);
>> +DECLARE_MSM_GPIO_PINS(107);
>> +DECLARE_MSM_GPIO_PINS(108);
>> +DECLARE_MSM_GPIO_PINS(109);
>> +DECLARE_MSM_GPIO_PINS(110);
>> +DECLARE_MSM_GPIO_PINS(111);
>> +DECLARE_MSM_GPIO_PINS(112);
>> +DECLARE_MSM_GPIO_PINS(113);
>> +
>> +static const unsigned int sdc1_clk_pins[] = { 114 };
>> +static const unsigned int sdc1_cmd_pins[] = { 115 };
>> +static const unsigned int sdc1_data_pins[] = { 116 };
>> +static const unsigned int sdc2_clk_pins[] = { 117 };
>> +static const unsigned int sdc2_cmd_pins[] = { 118 };
>> +static const unsigned int sdc2_data_pins[] = { 119 };
>> +static const unsigned int sdc1_rclk_pins[] = { 120 };
>> +
>> +enum sdm660_functions {
>> +	msm_mux_blsp_spi1,
>> +	msm_mux_gpio,
>> +	msm_mux_blsp_uim1,
>> +	msm_mux_tgu_ch0,
>> +	msm_mux_qdss_gpio4,
>> +	msm_mux_atest_gpsadc1,
>> +	msm_mux_blsp_uart1,
>> +	msm_mux_phase_flag14,
>> +	msm_mux_blsp_i2c2,
>> +	msm_mux_phase_flag31,
>> +	msm_mux_blsp_spi3,
>> +	msm_mux_blsp_spi3_cs1,
>> +	msm_mux_blsp_spi3_cs2,
>> +	msm_mux_wlan1_adc1,
>> +	msm_mux_atest_usb13,
>> +	msm_mux_tgu_ch1,
>> +	msm_mux_qdss_gpio5,
>> +	msm_mux_atest_gpsadc0,
>> +	msm_mux_blsp_i2c1,
>> +	msm_mux_ddr_bist,
>> +	msm_mux_atest_tsens2,
>> +	msm_mux_atest_usb1,
>> +	msm_mux_blsp_spi2,
>> +	msm_mux_blsp_uim2,
>> +	msm_mux_phase_flag3,
>> +	msm_mux_bimc_dte1,
>> +	msm_mux_wlan1_adc0,
>> +	msm_mux_atest_usb12,
>> +	msm_mux_bimc_dte0,
>> +	msm_mux_blsp_i2c3,
>> +	msm_mux_wlan2_adc1,
>> +	msm_mux_atest_usb11,
>> +	msm_mux_dbg_out,
>> +	msm_mux_wlan2_adc0,
>> +	msm_mux_atest_usb10,
>> +	msm_mux_blsp_spi4,
>> +	msm_mux_pri_mi2s,
>> +	msm_mux_phase_flag26,
>> +	msm_mux_qdss_cti0_a,
>> +	msm_mux_qdss_cti0_b,
>> +	msm_mux_qdss_cti1_a,
>> +	msm_mux_qdss_cti1_b,
>> +	msm_mux_pri_mi2s_ws,
>> +	msm_mux_phase_flag27,
>> +	msm_mux_blsp_i2c4,
>> +	msm_mux_phase_flag28,
>> +	msm_mux_blsp_uart5,
>> +	msm_mux_blsp_spi5,
>> +	msm_mux_blsp_uim5,
>> +	msm_mux_phase_flag5,
>> +	msm_mux_blsp_i2c5,
>> +	msm_mux_blsp_spi6,
>> +	msm_mux_blsp_uart2,
>> +	msm_mux_blsp_uim6,
>> +	msm_mux_phase_flag11,
>> +	msm_mux_vsense_data0,
>> +	msm_mux_blsp_i2c6,
>> +	msm_mux_phase_flag12,
>> +	msm_mux_vsense_data1,
>> +	msm_mux_phase_flag13,
>> +	msm_mux_vsense_mode,
>> +	msm_mux_blsp_spi7,
>> +	msm_mux_blsp_uart6_a,
>> +	msm_mux_blsp_uart6_b,
>> +	msm_mux_sec_mi2s,
>> +	msm_mux_sndwire_clk,
>> +	msm_mux_phase_flag17,
>> +	msm_mux_vsense_clkout,
>> +	msm_mux_sndwire_data,
>> +	msm_mux_phase_flag18,
>> +	msm_mux_blsp_i2c7,
>> +	msm_mux_phase_flag19,
>> +	msm_mux_vfr_1,
>> +	msm_mux_phase_flag20,
>> +	msm_mux_blsp_spi8_cs1,
>> +	msm_mux_blsp_spi8_cs2,
>> +	msm_mux_m_voc,
>> +	msm_mux_phase_flag21,
>> +	msm_mux_phase_flag22,
>> +	msm_mux_blsp_i2c8_a,
>> +	msm_mux_blsp_i2c8_b,
>> +	msm_mux_phase_flag23,
>> +	msm_mux_pwr_modem,
>> +	msm_mux_phase_flag24,
>> +	msm_mux_qdss_gpio,
>> +	msm_mux_cam_mclk,
>> +	msm_mux_pwr_nav,
>> +	msm_mux_qdss_gpio0,
>> +	msm_mux_qspi_data0,
>> +	msm_mux_pwr_crypto,
>> +	msm_mux_qdss_gpio1,
>> +	msm_mux_qspi_data1,
>> +	msm_mux_agera_pll,
>> +	msm_mux_qdss_gpio2,
>> +	msm_mux_qspi_data2,
>> +	msm_mux_jitter_bist,
>> +	msm_mux_qdss_gpio3,
>> +	msm_mux_qdss_gpio7,
>> +	msm_mux_mdss_vsync0,
>> +	msm_mux_mdss_vsync1,
>> +	msm_mux_mdss_vsync2,
>> +	msm_mux_mdss_vsync3,
>> +	msm_mux_qdss_gpio9,
>> +	msm_mux_atest_usb2,
>> +	msm_mux_cci_i2c,
>> +	msm_mux_pll_bypassnl,
>> +	msm_mux_atest_tsens,
>> +	msm_mux_atest_usb21,
>> +	msm_mux_pll_reset,
>> +	msm_mux_atest_usb23,
>> +	msm_mux_qdss_gpio6,
>> +	msm_mux_qspi_cs,
>> +	msm_mux_qdss_gpio10,
>> +	msm_mux_qdss_gpio11,
>> +	msm_mux_cci_async,
>> +	msm_mux_qdss_gpio12,
>> +	msm_mux_qdss_gpio13,
>> +	msm_mux_qspi_clk,
>> +	msm_mux_phase_flag30,
>> +	msm_mux_qdss_gpio14,
>> +	msm_mux_qspi_resetn,
>> +	msm_mux_phase_flag1,
>> +	msm_mux_qdss_gpio15,
>> +	msm_mux_phase_flag2,
>> +	msm_mux_phase_flag9,
>> +	msm_mux_qspi_data3,
>> +	msm_mux_phase_flag15,
>> +	msm_mux_qdss_gpio8,
>> +	msm_mux_phase_flag16,
>> +	msm_mux_phase_flag6,
>> +	msm_mux_phase_flag29,
>> +	msm_mux_phase_flag25,
>> +	msm_mux_phase_flag10,
>> +	msm_mux_atest_usb20,
>> +	msm_mux_gcc_gp1,
>> +	msm_mux_phase_flag4,
>> +	msm_mux_atest_usb22,
>> +	msm_mux_gcc_gp2,
>> +	msm_mux_atest_char,
>> +	msm_mux_mdp_vsync,
>> +	msm_mux_gcc_gp3,
>> +	msm_mux_atest_char3,
>> +	msm_mux_cri_trng0,
>> +	msm_mux_atest_char2,
>> +	msm_mux_cri_trng1,
>> +	msm_mux_atest_char1,
>> +	msm_mux_audio_ref,
>> +	msm_mux_cri_trng,
>> +	msm_mux_atest_char0,
>> +	msm_mux_blsp_spi8_a,
>> +	msm_mux_blsp_spi8_b,
>> +	msm_mux_sp_cmu,
>> +	msm_mux_nav_pps_a,
>> +	msm_mux_nav_pps_b,
>> +	msm_mux_nav_pps_c,
>> +	msm_mux_gps_tx_a,
>> +	msm_mux_gps_tx_b,
>> +	msm_mux_gps_tx_c,
>> +	msm_mux_adsp_ext,
>> +	msm_mux_ssc_irq,
>> +	msm_mux_isense_dbg,
>> +	msm_mux_phase_flag0,
>> +	msm_mux_phase_flag7,
>> +	msm_mux_phase_flag8,
>> +	msm_mux_tsense_pwm1,
>> +	msm_mux_tsense_pwm2,
>> +	msm_mux_mss_lte,
>> +	msm_mux_uim2_data,
>> +	msm_mux_uim2_clk,
>> +	msm_mux_uim2_reset,
>> +	msm_mux_uim2_present,
>> +	msm_mux_uim1_data,
>> +	msm_mux_uim1_clk,
>> +	msm_mux_uim1_reset,
>> +	msm_mux_uim1_present,
>> +	msm_mux_uim_batt,
>> +	msm_mux_pa_indicator,
>> +	msm_mux_ldo_en,
>> +	msm_mux_ldo_update,
>> +	msm_mux_qlink_request,
>> +	msm_mux_qlink_enable,
>> +	msm_mux_prng_rosc,
>> +	msm_mux__,
>> +};
>> +
>> +static const char * const gpio_groups[] = {
>> +	"gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6",
>"gpio7",
>> +	"gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
>> +	"gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20",
>"gpio21",
>> +	"gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27",
>"gpio28",
>> +	"gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34",
>"gpio35",
>> +	"gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41",
>"gpio42",
>> +	"gpio43", "gpio44", "gpio45", "gpio46", "gpio47", "gpio48",
>"gpio49",
>> +	"gpio50", "gpio51", "gpio52", "gpio53", "gpio54", "gpio55",
>"gpio56",
>> +	"gpio57", "gpio58", "gpio59", "gpio60", "gpio61", "gpio62",
>"gpio63",
>> +	"gpio64", "gpio65", "gpio66", "gpio67", "gpio68", "gpio69",
>"gpio70",
>> +	"gpio71", "gpio72", "gpio73", "gpio74", "gpio75", "gpio76",
>"gpio77",
>> +	"gpio78", "gpio79", "gpio80", "gpio81", "gpio82", "gpio83",
>"gpio84",
>> +	"gpio85", "gpio86", "gpio87", "gpio88", "gpio89", "gpio90",
>"gpio91",
>> +	"gpio92", "gpio93", "gpio94", "gpio95", "gpio96", "gpio97",
>"gpio98",
>> +	"gpio99", "gpio100", "gpio101", "gpio102", "gpio103", "gpio104",
>> +	"gpio105", "gpio106", "gpio107", "gpio108", "gpio109", "gpio110",
>> +	"gpio111", "gpio112", "gpio113",
>> +};
>> +static const char * const blsp_spi1_groups[] = {
>> +	"gpio0", "gpio1", "gpio2", "gpio3", "gpio46",
>> +};
>> +static const char * const blsp_uim1_groups[] = {
>> +	"gpio0", "gpio1",
>> +};
>> +static const char * const tgu_ch0_groups[] = {
>> +	"gpio0",
>> +};
>> +static const char * const qdss_gpio4_groups[] = {
>> +	"gpio0", "gpio36",
>> +};
>> +static const char * const atest_gpsadc1_groups[] = {
>> +	"gpio0",
>> +};
>> +static const char * const blsp_uart1_groups[] = {
>> +	"gpio0", "gpio1", "gpio2", "gpio3",
>> +};
>> +static const char * const phase_flag14_groups[] = {
>> +	"gpio5",
>> +};
>> +static const char * const blsp_i2c2_groups[] = {
>> +	"gpio6", "gpio7",
>> +};
>> +static const char * const phase_flag31_groups[] = {
>> +	"gpio6",
>> +};
>> +static const char * const blsp_spi3_groups[] = {
>> +	"gpio8", "gpio9", "gpio10", "gpio11",
>> +};
>> +static const char * const blsp_spi3_cs1_groups[] = {
>> +	"gpio30",
>> +};
>> +static const char * const blsp_spi3_cs2_groups[] = {
>> +	"gpio65",
>> +};
>> +static const char * const wlan1_adc1_groups[] = {
>> +	"gpio8",
>> +};
>> +static const char * const atest_usb13_groups[] = {
>> +	"gpio8",
>> +};
>> +static const char * const tgu_ch1_groups[] = {
>> +	"gpio1",
>> +};
>> +static const char * const qdss_gpio5_groups[] = {
>> +	"gpio1", "gpio37",
>> +};
>> +static const char * const atest_gpsadc0_groups[] = {
>> +	"gpio1",
>> +};
>> +static const char * const blsp_i2c1_groups[] = {
>> +	"gpio2", "gpio3",
>> +};
>> +static const char * const ddr_bist_groups[] = {
>> +	"gpio3", "gpio8", "gpio9", "gpio10",
>> +};
>> +static const char * const atest_tsens2_groups[] = {
>> +	"gpio3",
>> +};
>> +static const char * const atest_usb1_groups[] = {
>> +	"gpio3",
>> +};
>> +static const char * const blsp_spi2_groups[] = {
>> +	"gpio4", "gpio5", "gpio6", "gpio7",
>> +};
>> +static const char * const blsp_uim2_groups[] = {
>> +	"gpio4", "gpio5",
>> +};
>> +static const char * const phase_flag3_groups[] = {
>> +	"gpio4",
>> +};
>> +static const char * const bimc_dte1_groups[] = {
>> +	"gpio8", "gpio10",
>> +};
>> +static const char * const wlan1_adc0_groups[] = {
>> +	"gpio9",
>> +};
>> +static const char * const atest_usb12_groups[] = {
>> +	"gpio9",
>> +};
>> +static const char * const bimc_dte0_groups[] = {
>> +	"gpio9", "gpio11",
>> +};
>> +static const char * const blsp_i2c3_groups[] = {
>> +	"gpio10", "gpio11",
>> +};
>> +static const char * const wlan2_adc1_groups[] = {
>> +	"gpio10",
>> +};
>> +static const char * const atest_usb11_groups[] = {
>> +	"gpio10",
>> +};
>> +static const char * const dbg_out_groups[] = {
>> +	"gpio11",
>> +};
>> +static const char * const wlan2_adc0_groups[] = {
>> +	"gpio11",
>> +};
>> +static const char * const atest_usb10_groups[] = {
>> +	"gpio11",
>> +};
>> +static const char * const RCM_MARKER_groups[] = {
>> +	"gpio12", "gpio13",
>> +};
>> +static const char * const blsp_spi4_groups[] = {
>> +	"gpio12", "gpio13", "gpio14", "gpio15",
>> +};
>> +static const char * const pri_mi2s_groups[] = {
>> +	"gpio12", "gpio14", "gpio15", "gpio61",
>> +};
>> +static const char * const phase_flag26_groups[] = {
>> +	"gpio12",
>> +};
>> +static const char * const qdss_cti0_a_groups[] = {
>> +	"gpio49", "gpio50",
>> +};
>> +static const char * const qdss_cti0_b_groups[] = {
>> +	"gpio13", "gpio21",
>> +};
>> +static const char * const qdss_cti1_a_groups[] = {
>> +	"gpio53", "gpio55",
>> +};
>> +static const char * const qdss_cti1_b_groups[] = {
>> +	"gpio12", "gpio66",
>> +};
>> +static const char * const pri_mi2s_ws_groups[] = {
>> +	"gpio13",
>> +};
>> +static const char * const phase_flag27_groups[] = {
>> +	"gpio13",
>> +};
>> +static const char * const blsp_i2c4_groups[] = {
>> +	"gpio14", "gpio15",
>> +};
>> +static const char * const phase_flag28_groups[] = {
>> +	"gpio14",
>> +};
>> +static const char * const blsp_uart5_groups[] = {
>> +	"gpio16", "gpio17", "gpio18", "gpio19",
>> +};
>> +static const char * const blsp_spi5_groups[] = {
>> +	"gpio16", "gpio17", "gpio18", "gpio19",
>> +};
>> +static const char * const blsp_uim5_groups[] = {
>> +	"gpio16", "gpio17",
>> +};
>> +static const char * const phase_flag5_groups[] = {
>> +	"gpio17",
>> +};
>> +static const char * const blsp_i2c5_groups[] = {
>> +	"gpio18", "gpio19",
>> +};
>> +static const char * const blsp_spi6_groups[] = {
>> +	"gpio49", "gpio52", "gpio22", "gpio23",
>> +};
>> +static const char * const blsp_uart2_groups[] = {
>> +	"gpio4", "gpio5", "gpio6", "gpio7",
>> +};
>> +static const char * const blsp_uim6_groups[]
Michal Vokáč Aug. 13, 2018, 7:56 a.m. UTC | #4
On 13.8.2018 09:36, Craig Tatlor wrote:
> 
> 
> On 13 August 2018 08:24:43 BST, "Michal Vokáč" <michal.vokac@ysoft.com> wrote:
>> Hi Craig,
>> On 12.8.2018 16:24, Craig Tatlor wrote:
>>> Add initial pinctrl driver to support pin configuration with
>>> pinctrl framework for sdm660.
>>> Based off CAF implementation.
>>>
>>> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
>>> ---
>>
>> The documentation portion should be a separate patch.
>> Please refer to
>> Documentation/devicetree/bindings/submitting-patches.txt
>>
>> It is easier for DT maintainers to review just the relevant part.
>> The binding patches are also rebased to a separate tree as they are not
>> Linux specific and can be re-used in other OSes
>>
>> Best regards,
>> Michal
> I know, just did this because it is basically exactly same as other qcom pinctrl docs and they also only had one patch.

OK, I see. Anyway to me it seems that at some point this practice should
change. Is it not better to prepare the patches how we want them to look
like than how they looked like in the past?

I see the same problems elsewhere where folks are copying commits from
each other. Like the messy SPDX license headers transformation..

> 
> Sorry if you got this multiple times, apparently my email client adds HTML to non inline replies
>>
>>> Changes from v1:
>>>     Adds gpio-ranges property to bindings
>>>
>>>
>>>    .../bindings/pinctrl/qcom,sdm660-pinctrl.txt  |  202 +++
>>>    drivers/pinctrl/qcom/Kconfig                  |   10 +
>>>    drivers/pinctrl/qcom/Makefile                 |    1 +
>>>    drivers/pinctrl/qcom/pinctrl-sdm660.c         | 1451
>> +++++++++++++++++
>>>    4 files changed, 1663 insertions(+)
>>>    create mode 100644
>> Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>>>    create mode 100644 drivers/pinctrl/qcom/pinctrl-sdm660.c
>>>
>>> diff --git
>> a/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>> b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>>> new file mode 100644
>>> index 000000000000..801960ad2112
>>> --- /dev/null
>>> +++
>> b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>>> @@ -0,0 +1,202 @@
>>> +Qualcomm Technologies, Inc. SDM660 TLMM block
>>> +
>>> +This binding describes the Top Level Mode Multiplexer block found in
>> the
>>> +SDM660 platform.
>>> +
>>> +- compatible:
>>> +	Usage: required
>>> +	Value type: <string>
>>> +	Definition: must be "qcom,sdm660-pinctrl"
>>> +
>>> +- reg:
>>> +	Usage: required
>>> +	Value type: <prop-encoded-array>
>>> +	Definition: the base address and size of the TLMM register space.
>>> +
>>> +- interrupts:
>>> +	Usage: required
>>> +	Value type: <prop-encoded-array>
>>> +	Definition: should specify the TLMM summary IRQ.
>>> +
>>> +- interrupt-controller:
>>> +	Usage: required
>>> +	Value type: <none>
>>> +	Definition: identifies this node as an interrupt controller
>>> +
>>> +- #interrupt-cells:
>>> +	Usage: required
>>> +	Value type: <u32>
>>> +	Definition: must be 2. Specifying the pin number and flags, as
>> defined
>>> +		    in <dt-bindings/interrupt-controller/irq.h>
>>> +
>>> +- gpio-controller:
>>> +	Usage: required
>>> +	Value type: <none>
>>> +	Definition: identifies this node as a gpio controller
>>> +
>>> +- gpio-ranges:
>>> +	Usage: required
>>> +	Value type: <prop-encoded-array>
>>> +	Definition: Specifies the mapping between gpio controller and
>>> +		    pin-controller pins.
>>> +
>>> +- #gpio-cells:
>>> +	Usage: required
>>> +	Value type: <u32>
>>> +	Definition: must be 2. Specifying the pin number and flags, as
>> defined
>>> +		    in <dt-bindings/gpio/gpio.h>
>>> +
>>> +Please refer to ../gpio/gpio.txt and
>> ../interrupt-controller/interrupts.txt for
>>> +a general description of GPIO and interrupt bindings.
>>> +
>>> +Please refer to pinctrl-bindings.txt in this directory for details
>> of the
>>> +common pinctrl bindings used by client devices, including the
>> meaning of the
>>> +phrase "pin configuration node".
>>> +
>>> +The pin configuration nodes act as a container for an arbitrary
>> number of
>>> +subnodes. Each of these subnodes represents some desired
>> configuration for a
>>> +pin, a group, or a list of pins or groups. This configuration can
>> include the
>>> +mux function to select on those pin(s)/group(s), and various pin
>> configuration
>>> +parameters, such as pull-up, drive strength, etc.
>>> +
>>> +
>>> +PIN CONFIGURATION NODES:
>>> +
>>> +The name of each subnode is not important; all subnodes should be
>> enumerated
>>> +and processed purely based on their content.
>>> +
>>> +Each subnode only affects those parameters that are explicitly
>> listed. In
>>> +other words, a subnode that lists a mux function but no pin
>> configuration
>>> +parameters implies no information about any pin configuration
>> parameters.
>>> +Similarly, a pin subnode that describes a pullup parameter implies
>> no
>>> +information about e.g. the mux function.
>>> +
>>> +
>>> +The following generic properties as defined in pinctrl-bindings.txt
>> are valid
>>> +to specify in a pin configuration subnode:
>>> +
>>> +- pins:
>>> +	Usage: required
>>> +	Value type: <string-array>
>>> +	Definition: List of gpio pins affected by the properties specified
>> in
>>> +		    this subnode.  Valid pins are:
>>> +		    gpio0-gpio113,
>>> +		        Supports mux, bias and drive-strength
>>> +		    sdc1_clk, sdc1_cmd, sdc1_data sdc2_clk, sdc2_cmd, sdc2_data
>> sdc1_rclk,
>>> +		        Supports bias and drive-strength
>>> +
>>> +- function:
>>> +	Usage: required
>>> +	Value type: <string>
>>> +	Definition: Specify the alternative function to be configured for
>> the
>>> +		    specified pins. Functions are only valid for gpio pins.
>>> +		    Valid values are:
>>> +
>>> +		    blsp_uart1, blsp_spi1, blsp_i2c1, blsp_uim1, atest_tsens,
>>> +		    bimc_dte1, dac_calib0, blsp_spi8, blsp_uart8, blsp_uim8,
>>> +		    qdss_cti_trig_out_b, bimc_dte0, dac_calib1,
>> qdss_cti_trig_in_b,
>>> +		    dac_calib2, atest_tsens2, atest_usb1, blsp_spi10, blsp_uart10,
>>> +		    blsp_uim10, atest_bbrx1, atest_usb13, atest_bbrx0,
>> atest_usb12,
>>> +		    mdp_vsync, edp_lcd, blsp_i2c10, atest_gpsadc1, atest_usb11,
>>> +		    atest_gpsadc0, edp_hot, atest_usb10, m_voc, dac_gpio,
>> atest_char,
>>> +		    cam_mclk, pll_bypassnl, qdss_stm7, blsp_i2c8,
>> qdss_tracedata_b,
>>> +		    pll_reset, qdss_stm6, qdss_stm5, qdss_stm4, atest_usb2,
>> cci_i2c,
>>> +		    qdss_stm3, dac_calib3, atest_usb23, atest_char3, dac_calib4,
>>> +		    qdss_stm2, atest_usb22, atest_char2, qdss_stm1, dac_calib5,
>>> +		    atest_usb21, atest_char1, dbg_out, qdss_stm0, dac_calib6,
>>> +		    atest_usb20, atest_char0, dac_calib10, qdss_stm10,
>>> +		    qdss_cti_trig_in_a, cci_timer4, blsp_spi6, blsp_uart6,
>> blsp_uim6,
>>> +		    blsp2_spi, qdss_stm9, qdss_cti_trig_out_a, dac_calib11,
>>> +		    qdss_stm8, cci_timer0, qdss_stm13, dac_calib7, cci_timer1,
>>> +		    qdss_stm12, dac_calib8, cci_timer2, blsp1_spi, qdss_stm11,
>>> +		    dac_calib9, cci_timer3, cci_async, dac_calib12, blsp_i2c6,
>>> +		    qdss_tracectl_a, dac_calib13, qdss_traceclk_a, dac_calib14,
>>> +		    dac_calib15, hdmi_rcv, dac_calib16, hdmi_cec, pwr_modem,
>>> +		    dac_calib17, hdmi_ddc, pwr_nav, dac_calib18, pwr_crypto,
>>> +		    dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0,
>>> +		    dac_calib22, dac_calib23, dac_calib24, tsif1_sync,
>> dac_calib25,
>>> +		    sd_write, tsif1_error, blsp_spi2, blsp_uart2, blsp_uim2,
>>> +		    qdss_cti, blsp_i2c2, blsp_spi3, blsp_uart3, blsp_uim3,
>> blsp_i2c3,
>>> +		    uim3, blsp_spi9, blsp_uart9, blsp_uim9, blsp10_spi, blsp_i2c9,
>>> +		    blsp_spi7, blsp_uart7, blsp_uim7, qdss_tracedata_a, blsp_i2c7,
>>> +		    qua_mi2s, gcc_gp1_clk_a, ssc_irq, uim4, blsp_spi11,
>> blsp_uart11,
>>> +		    blsp_uim11, gcc_gp2_clk_a, gcc_gp3_clk_a, blsp_i2c11,
>> cri_trng0,
>>> +		    cri_trng1, cri_trng, qdss_stm18, pri_mi2s, qdss_stm17,
>> blsp_spi4,
>>> +		    blsp_uart4, blsp_uim4, qdss_stm16, qdss_stm15, blsp_i2c4,
>>> +		    qdss_stm14, dac_calib26, spkr_i2s, audio_ref, lpass_slimbus,
>>> +		    isense_dbg, tsense_pwm1, tsense_pwm2, btfm_slimbus, ter_mi2s,
>>> +		    qdss_stm22, qdss_stm21, qdss_stm20, qdss_stm19, gcc_gp1_clk_b,
>>> +		    sec_mi2s, blsp_spi5, blsp_uart5, blsp_uim5, gcc_gp2_clk_b,
>>> +		    gcc_gp3_clk_b, blsp_i2c5, blsp_spi12, blsp_uart12, blsp_uim12,
>>> +		    qdss_stm25, qdss_stm31, blsp_i2c12, qdss_stm30, qdss_stm29,
>>> +		    tsif1_clk, qdss_stm28, tsif1_en, tsif1_data, sdc4_cmd,
>> qdss_stm27,
>>> +		    qdss_traceclk_b, tsif2_error, sdc43, vfr_1, qdss_stm26,
>> tsif2_clk,
>>> +		    sdc4_clk, qdss_stm24, tsif2_en, sdc42, qdss_stm23,
>> qdss_tracectl_b,
>>> +		    sd_card, tsif2_data, sdc41, tsif2_sync, sdc40, mdp_vsync_p_b,
>>> +		    ldo_en, mdp_vsync_s_b, ldo_update, blsp11_uart_tx_b,
>> blsp11_uart_rx_b,
>>> +		    blsp11_i2c_sda_b, prng_rosc, blsp11_i2c_scl_b, uim2, uim1,
>> uim_batt,
>>> +		    pci_e2, pa_indicator, adsp_ext, ddr_bist, qdss_tracedata_11,
>>> +		    qdss_tracedata_12, modem_tsync, nav_dr, nav_pps, pci_e1,
>> gsm_tx,
>>> +		    qspi_cs, ssbi2, ssbi1, mss_lte, qspi_clk, qspi0, qspi1, qspi2,
>> qspi3,
>>> +		    gpio
>>> +
>>> +- bias-disable:
>>> +	Usage: optional
>>> +	Value type: <none>
>>> +	Definition: The specified pins should be configued as no pull.
>>> +
>>> +- bias-pull-down:
>>> +	Usage: optional
>>> +	Value type: <none>
>>> +	Definition: The specified pins should be configued as pull down.
>>> +
>>> +- bias-pull-up:
>>> +	Usage: optional
>>> +	Value type: <none>
>>> +	Definition: The specified pins should be configued as pull up.
>>> +
>>> +- output-high:
>>> +	Usage: optional
>>> +	Value type: <none>
>>> +	Definition: The specified pins are configured in output mode,
>> driven
>>> +		    high.
>>> +		    Not valid for sdc pins.
>>> +
>>> +- output-low:
>>> +	Usage: optional
>>> +	Value type: <none>
>>> +	Definition: The specified pins are configured in output mode,
>> driven
>>> +		    low.
>>> +		    Not valid for sdc pins.
>>> +
>>> +- drive-strength:
>>> +	Usage: optional
>>> +	Value type: <u32>
>>> +	Definition: Selects the drive strength for the specified pins, in
>> mA.
>>> +		    Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16
>>> +
>>> +Example:
>>> +
>>> +	tlmm: pinctrl@1010000 {
>>> +		compatible = "qcom,sdm660-pinctrl";
>>> +		reg = <0x1010000 0x300000>;
>>> +		interrupts = <0 208 0>;
>>> +		gpio-controller;
>>> +		gpio-ranges = <&tlmm 0 0 114>;
>>> +		#gpio-cells = <2>;
>>> +		interrupt-controller;
>>> +		#interrupt-cells = <2>;
>>> +
>>> +		uart_console_active: uart_console_active {
>>> +			mux {
>>> +				pins = "gpio4", "gpio5";
>>> +				function = "blsp_uart8";
>>> +			};
>>> +
>>> +			config {
>>> +				pins = "gpio4", "gpio5";
>>> +				drive-strength = <2>;
>>> +				bias-disable;
>>> +			};
>>> +		};
>>> +	};
>>> diff --git a/drivers/pinctrl/qcom/Kconfig
>> b/drivers/pinctrl/qcom/Kconfig
>>> index 195492033075..091beadb8a1c 100644
>>> --- a/drivers/pinctrl/qcom/Kconfig
>>> +++ b/drivers/pinctrl/qcom/Kconfig
>>> @@ -147,6 +147,16 @@ config PINCTRL_QCOM_SSBI_PMIC
>>>             which are using SSBI for communication with SoC. Example
>> PMIC's
>>>             devices are pm8058 and pm8921.
>>>    
>>> +config PINCTRL_SDM660
>>> +       tristate "Qualcomm Technologies Inc SDM660 pin controller
>> driver"
>>> +       depends on GPIOLIB && OF
>>> +       select PINCTRL_MSM
>>> +       help
>>> +         This is the pinctrl, pinmux, pinconf and gpiolib driver for
>> the
>>> +         Qualcomm Technologies Inc TLMM block found on the Qualcomm
>>> +         Technologies Inc SDM660 platform.
>>> +
>>> +
>>>    config PINCTRL_SDM845
>>>           tristate "Qualcomm Technologies Inc SDM845 pin controller
>> driver"
>>>           depends on GPIOLIB && OF
>>> diff --git a/drivers/pinctrl/qcom/Makefile
>> b/drivers/pinctrl/qcom/Makefile
>>> index 0c6f3ddc296d..9b08808a2f1c 100644
>>> --- a/drivers/pinctrl/qcom/Makefile
>>> +++ b/drivers/pinctrl/qcom/Makefile
>>> @@ -19,4 +19,5 @@ obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) +=
>> pinctrl-spmi-gpio.o
>>>    obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-mpp.o
>>>    obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-gpio.o
>>>    obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-mpp.o
>>> +obj-$(CONFIG_PINCTRL_SDM660)   += pinctrl-sdm660.o
>>>    obj-$(CONFIG_PINCTRL_SDM845) += pinctrl-sdm845.o
>>> diff --git a/drivers/pinctrl/qcom/pinctrl-sdm660.c
>> b/drivers/pinctrl/qcom/pinctrl-sdm660.c
>>> new file mode 100644
>>> index 000000000000..ded56111f168
>>> --- /dev/null
>>> +++ b/drivers/pinctrl/qcom/pinctrl-sdm660.c
>>> @@ -0,0 +1,1451 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +/*
>>> + * Copyright (c) 2016, The Linux Foundation. All rights reserved.
>>> + * Copyright (c) 2018, Craig Tatlor.
>>> + */
>>> +
>>> +#include <linux/module.h>
>>> +#include <linux/of.h>
>>> +#include <linux/platform_device.h>
>>> +#include <linux/pinctrl/pinctrl.h>
>>> +
>>> +#include "pinctrl-msm.h"
>>> +
>>> +#define NORTH	0x00900000
>>> +#define CENTER	0x00500000
>>> +#define SOUTH	0x00100000
>>> +#define REG_SIZE 0x1000
>>> +
>>> +#define FUNCTION(fname)					\
>>> +	[msm_mux_##fname] = {		                \
>>> +		.name = #fname,				\
>>> +		.groups = fname##_groups,               \
>>> +		.ngroups = ARRAY_SIZE(fname##_groups),	\
>>> +	}
>>> +
>>> +
>>> +#define PINGROUP(id, base, f1, f2, f3, f4, f5, f6, f7, f8, f9)	\
>>> +	{					        \
>>> +		.name = "gpio" #id,			\
>>> +		.pins = gpio##id##_pins,		\
>>> +		.npins = (unsigned)ARRAY_SIZE(gpio##id##_pins),	\
>>> +		.funcs = (int[]){			\
>>> +			msm_mux_gpio, /* gpio mode */	\
>>> +			msm_mux_##f1,			\
>>> +			msm_mux_##f2,			\
>>> +			msm_mux_##f3,			\
>>> +			msm_mux_##f4,			\
>>> +			msm_mux_##f5,			\
>>> +			msm_mux_##f6,			\
>>> +			msm_mux_##f7,			\
>>> +			msm_mux_##f8,			\
>>> +			msm_mux_##f9			\
>>> +		},				        \
>>> +		.nfuncs = 10,				\
>>> +		.ctl_reg = base + REG_SIZE * id,	\
>>> +		.io_reg = base + 0x4 + REG_SIZE * id,		\
>>> +		.intr_cfg_reg = base + 0x8 + REG_SIZE * id,		\
>>> +		.intr_status_reg = base + 0xc + REG_SIZE * id,	\
>>> +		.intr_target_reg = base + 0x8 + REG_SIZE * id,	\
>>> +		.mux_bit = 2,			\
>>> +		.pull_bit = 0,			\
>>> +		.drv_bit = 6,			\
>>> +		.oe_bit = 9,			\
>>> +		.in_bit = 0,			\
>>> +		.out_bit = 1,			\
>>> +		.intr_enable_bit = 0,		\
>>> +		.intr_status_bit = 0,		\
>>> +		.intr_target_bit = 5,		\
>>> +		.intr_target_kpss_val = 3,	\
>>> +		.intr_raw_status_bit = 4,	\
>>> +		.intr_polarity_bit = 1,		\
>>> +		.intr_detection_bit = 2,	\
>>> +		.intr_detection_width = 2,	\
>>> +	}
>>> +
>>> +#define SDC_QDSD_PINGROUP(pg_name, ctl, pull, drv)	\
>>> +	{					        \
>>> +		.name = #pg_name,			\
>>> +		.pins = pg_name##_pins,			\
>>> +		.npins = (unsigned)ARRAY_SIZE(pg_name##_pins),	\
>>> +		.ctl_reg = ctl,				\
>>> +		.io_reg = 0,				\
>>> +		.intr_cfg_reg = 0,			\
>>> +		.intr_status_reg = 0,			\
>>> +		.intr_target_reg = 0,			\
>>> +		.mux_bit = -1,				\
>>> +		.pull_bit = pull,			\
>>> +		.drv_bit = drv,				\
>>> +		.oe_bit = -1,				\
>>> +		.in_bit = -1,				\
>>> +		.out_bit = -1,				\
>>> +		.intr_enable_bit = -1,			\
>>> +		.intr_status_bit = -1,			\
>>> +		.intr_target_bit = -1,			\
>>> +		.intr_raw_status_bit = -1,		\
>>> +		.intr_polarity_bit = -1,		\
>>> +		.intr_detection_bit = -1,		\
>>> +		.intr_detection_width = -1,		\
>>> +	}
>>> +
>>> +static const struct pinctrl_pin_desc sdm660_pins[] = {
>>> +	PINCTRL_PIN(0, "GPIO_0"),
>>> +	PINCTRL_PIN(1, "GPIO_1"),
>>> +	PINCTRL_PIN(2, "GPIO_2"),
>>> +	PINCTRL_PIN(3, "GPIO_3"),
>>> +	PINCTRL_PIN(4, "GPIO_4"),
>>> +	PINCTRL_PIN(5, "GPIO_5"),
>>> +	PINCTRL_PIN(6, "GPIO_6"),
>>> +	PINCTRL_PIN(7, "GPIO_7"),
>>> +	PINCTRL_PIN(8, "GPIO_8"),
>>> +	PINCTRL_PIN(9, "GPIO_9"),
>>> +	PINCTRL_PIN(10, "GPIO_10"),
>>> +	PINCTRL_PIN(11, "GPIO_11"),
>>> +	PINCTRL_PIN(12, "GPIO_12"),
>>> +	PINCTRL_PIN(13, "GPIO_13"),
>>> +	PINCTRL_PIN(14, "GPIO_14"),
>>> +	PINCTRL_PIN(15, "GPIO_15"),
>>> +	PINCTRL_PIN(16, "GPIO_16"),
>>> +	PINCTRL_PIN(17, "GPIO_17"),
>>> +	PINCTRL_PIN(18, "GPIO_18"),
>>> +	PINCTRL_PIN(19, "GPIO_19"),
>>> +	PINCTRL_PIN(20, "GPIO_20"),
>>> +	PINCTRL_PIN(21, "GPIO_21"),
>>> +	PINCTRL_PIN(22, "GPIO_22"),
>>> +	PINCTRL_PIN(23, "GPIO_23"),
>>> +	PINCTRL_PIN(24, "GPIO_24"),
>>> +	PINCTRL_PIN(25, "GPIO_25"),
>>> +	PINCTRL_PIN(26, "GPIO_26"),
>>> +	PINCTRL_PIN(27, "GPIO_27"),
>>> +	PINCTRL_PIN(28, "GPIO_28"),
>>> +	PINCTRL_PIN(29, "GPIO_29"),
>>> +	PINCTRL_PIN(30, "GPIO_30"),
>>> +	PINCTRL_PIN(31, "GPIO_31"),
>>> +	PINCTRL_PIN(32, "GPIO_32"),
>>> +	PINCTRL_PIN(33, "GPIO_33"),
>>> +	PINCTRL_PIN(34, "GPIO_34"),
>>> +	PINCTRL_PIN(35, "GPIO_35"),
>>> +	PINCTRL_PIN(36, "GPIO_36"),
>>> +	PINCTRL_PIN(37, "GPIO_37"),
>>> +	PINCTRL_PIN(38, "GPIO_38"),
>>> +	PINCTRL_PIN(39, "GPIO_39"),
>>> +	PINCTRL_PIN(40, "GPIO_40"),
>>> +	PINCTRL_PIN(41, "GPIO_41"),
>>> +	PINCTRL_PIN(42, "GPIO_42"),
>>> +	PINCTRL_PIN(43, "GPIO_43"),
>>> +	PINCTRL_PIN(44, "GPIO_44"),
>>> +	PINCTRL_PIN(45, "GPIO_45"),
>>> +	PINCTRL_PIN(46, "GPIO_46"),
>>> +	PINCTRL_PIN(47, "GPIO_47"),
>>> +	PINCTRL_PIN(48, "GPIO_48"),
>>> +	PINCTRL_PIN(49, "GPIO_49"),
>>> +	PINCTRL_PIN(50, "GPIO_50"),
>>> +	PINCTRL_PIN(51, "GPIO_51"),
>>> +	PINCTRL_PIN(52, "GPIO_52"),
>>> +	PINCTRL_PIN(53, "GPIO_53"),
>>> +	PINCTRL_PIN(54, "GPIO_54"),
>>> +	PINCTRL_PIN(55, "GPIO_55"),
>>> +	PINCTRL_PIN(56, "GPIO_56"),
>>> +	PINCTRL_PIN(57, "GPIO_57"),
>>> +	PINCTRL_PIN(58, "GPIO_58"),
>>> +	PINCTRL_PIN(59, "GPIO_59"),
>>> +	PINCTRL_PIN(60, "GPIO_60"),
>>> +	PINCTRL_PIN(61, "GPIO_61"),
>>> +	PINCTRL_PIN(62, "GPIO_62"),
>>> +	PINCTRL_PIN(63, "GPIO_63"),
>>> +	PINCTRL_PIN(64, "GPIO_64"),
>>> +	PINCTRL_PIN(65, "GPIO_65"),
>>> +	PINCTRL_PIN(66, "GPIO_66"),
>>> +	PINCTRL_PIN(67, "GPIO_67"),
>>> +	PINCTRL_PIN(68, "GPIO_68"),
>>> +	PINCTRL_PIN(69, "GPIO_69"),
>>> +	PINCTRL_PIN(70, "GPIO_70"),
>>> +	PINCTRL_PIN(71, "GPIO_71"),
>>> +	PINCTRL_PIN(72, "GPIO_72"),
>>> +	PINCTRL_PIN(73, "GPIO_73"),
>>> +	PINCTRL_PIN(74, "GPIO_74"),
>>> +	PINCTRL_PIN(75, "GPIO_75"),
>>> +	PINCTRL_PIN(76, "GPIO_76"),
>>> +	PINCTRL_PIN(77, "GPIO_77"),
>>> +	PINCTRL_PIN(78, "GPIO_78"),
>>> +	PINCTRL_PIN(79, "GPIO_79"),
>>> +	PINCTRL_PIN(80, "GPIO_80"),
>>> +	PINCTRL_PIN(81, "GPIO_81"),
>>> +	PINCTRL_PIN(82, "GPIO_82"),
>>> +	PINCTRL_PIN(83, "GPIO_83"),
>>> +	PINCTRL_PIN(84, "GPIO_84"),
>>> +	PINCTRL_PIN(85, "GPIO_85"),
>>> +	PINCTRL_PIN(86, "GPIO_86"),
>>> +	PINCTRL_PIN(87, "GPIO_87"),
>>> +	PINCTRL_PIN(88, "GPIO_88"),
>>> +	PINCTRL_PIN(89, "GPIO_89"),
>>> +	PINCTRL_PIN(90, "GPIO_90"),
>>> +	PINCTRL_PIN(91, "GPIO_91"),
>>> +	PINCTRL_PIN(92, "GPIO_92"),
>>> +	PINCTRL_PIN(93, "GPIO_93"),
>>> +	PINCTRL_PIN(94, "GPIO_94"),
>>> +	PINCTRL_PIN(95, "GPIO_95"),
>>> +	PINCTRL_PIN(96, "GPIO_96"),
>>> +	PINCTRL_PIN(97, "GPIO_97"),
>>> +	PINCTRL_PIN(98, "GPIO_98"),
>>> +	PINCTRL_PIN(99, "GPIO_99"),
>>> +	PINCTRL_PIN(100, "GPIO_100"),
>>> +	PINCTRL_PIN(101, "GPIO_101"),
>>> +	PINCTRL_PIN(102, "GPIO_102"),
>>> +	PINCTRL_PIN(103, "GPIO_103"),
>>> +	PINCTRL_PIN(104, "GPIO_104"),
>>> +	PINCTRL_PIN(105, "GPIO_105"),
>>> +	PINCTRL_PIN(106, "GPIO_106"),
>>> +	PINCTRL_PIN(107, "GPIO_107"),
>>> +	PINCTRL_PIN(108, "GPIO_108"),
>>> +	PINCTRL_PIN(109, "GPIO_109"),
>>> +	PINCTRL_PIN(110, "GPIO_110"),
>>> +	PINCTRL_PIN(111, "GPIO_111"),
>>> +	PINCTRL_PIN(112, "GPIO_112"),
>>> +	PINCTRL_PIN(113, "GPIO_113"),
>>> +	PINCTRL_PIN(114, "SDC1_CLK"),
>>> +	PINCTRL_PIN(115, "SDC1_CMD"),
>>> +	PINCTRL_PIN(116, "SDC1_DATA"),
>>> +	PINCTRL_PIN(117, "SDC2_CLK"),
>>> +	PINCTRL_PIN(118, "SDC2_CMD"),
>>> +	PINCTRL_PIN(119, "SDC2_DATA"),
>>> +	PINCTRL_PIN(120, "SDC1_RCLK"),
>>> +};
>>> +
>>> +#define DECLARE_MSM_GPIO_PINS(pin) \
>>> +	static const unsigned int gpio##pin##_pins[] = { pin }
>>> +DECLARE_MSM_GPIO_PINS(0);
>>> +DECLARE_MSM_GPIO_PINS(1);
>>> +DECLARE_MSM_GPIO_PINS(2);
>>> +DECLARE_MSM_GPIO_PINS(3);
>>> +DECLARE_MSM_GPIO_PINS(4);
>>> +DECLARE_MSM_GPIO_PINS(5);
>>> +DECLARE_MSM_GPIO_PINS(6);
>>> +DECLARE_MSM_GPIO_PINS(7);
>>> +DECLARE_MSM_GPIO_PINS(8);
>>> +DECLARE_MSM_GPIO_PINS(9);
>>> +DECLARE_MSM_GPIO_PINS(10);
>>> +DECLARE_MSM_GPIO_PINS(11);
>>> +DECLARE_MSM_GPIO_PINS(12);
>>> +DECLARE_MSM_GPIO_PINS(13);
>>> +DECLARE_MSM_GPIO_PINS(14);
>>> +DECLARE_MSM_GPIO_PINS(15);
>>> +DECLARE_MSM_GPIO_PINS(16);
>>> +DECLARE_MSM_GPIO_PINS(17);
>>> +DECLARE_MSM_GPIO_PINS(18);
>>> +DECLARE_MSM_GPIO_PINS(19);
>>> +DECLARE_MSM_GPIO_PINS(20);
>>> +DECLARE_MSM_GPIO_PINS(21);
>>> +DECLARE_MSM_GPIO_PINS(22);
>>> +DECLARE_MSM_GPIO_PINS(23);
>>> +DECLARE_MSM_GPIO_PINS(24);
>>> +DECLARE_MSM_GPIO_PINS(25);
>>> +DECLARE_MSM_GPIO_PINS(26);
>>> +DECLARE_MSM_GPIO_PINS(27);
>>> +DECLARE_MSM_GPIO_PINS(28);
>>> +DECLARE_MSM_GPIO_PINS(29);
>>> +DECLARE_MSM_GPIO_PINS(30);
>>> +DECLARE_MSM_GPIO_PINS(31);
>>> +DECLARE_MSM_GPIO_PINS(32);
>>> +DECLARE_MSM_GPIO_PINS(33);
>>> +DECLARE_MSM_GPIO_PINS(34);
>>> +DECLARE_MSM_GPIO_PINS(35);
>>> +DECLARE_MSM_GPIO_PINS(36);
>>> +DECLARE_MSM_GPIO_PINS(37);
>>> +DECLARE_MSM_GPIO_PINS(38);
>>> +DECLARE_MSM_GPIO_PINS(39);
>>> +DECLARE_MSM_GPIO_PINS(40);
>>> +DECLARE_MSM_GPIO_PINS(41);
>>> +DECLARE_MSM_GPIO_PINS(42);
>>> +DECLARE_MSM_GPIO_PINS(43);
>>> +DECLARE_MSM_GPIO_PINS(44);
>>> +DECLARE_MSM_GPIO_PINS(45);
>>> +DECLARE_MSM_GPIO_PINS(46);
>>> +DECLARE_MSM_GPIO_PINS(47);
>>> +DECLARE_MSM_GPIO_PINS(48);
>>> +DECLARE_MSM_GPIO_PINS(49);
>>> +DECLARE_MSM_GPIO_PINS(50);
>>> +DECLARE_MSM_GPIO_PINS(51);
>>> +DECLARE_MSM_GPIO_PINS(52);
>>> +DECLARE_MSM_GPIO_PINS(53);
>>> +DECLARE_MSM_GPIO_PINS(54);
>>> +DECLARE_MSM_GPIO_PINS(55);
>>> +DECLARE_MSM_GPIO_PINS(56);
>>> +DECLARE_MSM_GPIO_PINS(57);
>>> +DECLARE_MSM_GPIO_PINS(58);
>>> +DECLARE_MSM_GPIO_PINS(59);
>>> +DECLARE_MSM_GPIO_PINS(60);
>>> +DECLARE_MSM_GPIO_PINS(61);
>>> +DECLARE_MSM_GPIO_PINS(62);
>>> +DECLARE_MSM_GPIO_PINS(63);
>>> +DECLARE_MSM_GPIO_PINS(64);
>>> +DECLARE_MSM_GPIO_PINS(65);
>>> +DECLARE_MSM_GPIO_PINS(66);
>>> +DECLARE_MSM_GPIO_PINS(67);
>>> +DECLARE_MSM_GPIO_PINS(68);
>>> +DECLARE_MSM_GPIO_PINS(69);
>>> +DECLARE_MSM_GPIO_PINS(70);
>>> +DECLARE_MSM_GPIO_PINS(71);
>>> +DECLARE_MSM_GPIO_PINS(72);
>>> +DECLARE_MSM_GPIO_PINS(73);
>>> +DECLARE_MSM_GPIO_PINS(74);
>>> +DECLARE_MSM_GPIO_PINS(75);
>>> +DECLARE_MSM_GPIO_PINS(76);
>>> +DECLARE_MSM_GPIO_PINS(77);
>>> +DECLARE_MSM_GPIO_PINS(78);
>>> +DECLARE_MSM_GPIO_PINS(79);
>>> +DECLARE_MSM_GPIO_PINS(80);
>>> +DECLARE_MSM_GPIO_PINS(81);
>>> +DECLARE_MSM_GPIO_PINS(82);
>>> +DECLARE_MSM_GPIO_PINS(83);
>>> +DECLARE_MSM_GPIO_PINS(84);
>>> +DECLARE_MSM_GPIO_PINS(85);
>>> +DECLARE_MSM_GPIO_PINS(86);
>>> +DECLARE_MSM_GPIO_PINS(87);
>>> +DECLARE_MSM_GPIO_PINS(88);
>>> +DECLARE_MSM_GPIO_PINS(89);
>>> +DECLARE_MSM_GPIO_PINS(90);
>>> +DECLARE_MSM_GPIO_PINS(91);
>>> +DECLARE_MSM_GPIO_PINS(92);
>>> +DECLARE_MSM_GPIO_PINS(93);
>>> +DECLARE_MSM_GPIO_PINS(94);
>>> +DECLARE_MSM_GPIO_PINS(95);
>>> +DECLARE_MSM_GPIO_PINS(96);
>>> +DECLARE_MSM_GPIO_PINS(97);
>>> +DECLARE_MSM_GPIO_PINS(98);
>>> +DECLARE_MSM_GPIO_PINS(99);
>>> +DECLARE_MSM_GPIO_PINS(100);
>>> +DECLARE_MSM_GPIO_PINS(101);
>>> +DECLARE_MSM_GPIO_PINS(102);
>>> +DECLARE_MSM_GPIO_PINS(103);
>>> +DECLARE_MSM_GPIO_PINS(104);
>>> +DECLARE_MSM_GPIO_PINS(105);
>>> +DECLARE_MSM_GPIO_PINS(106);
>>> +DECLARE_MSM_GPIO_PINS(107);
>>> +DECLARE_MSM_GPIO_PINS(108);
>>> +DECLARE_MSM_GPIO_PINS(109);
>>> +DECLARE_MSM_GPIO_PINS(110);
>>> +DECLARE_MSM_GPIO_PINS(111);
>>> +DECLARE_MSM_GPIO_PINS(112);
>>> +DECLARE_MSM_GPIO_PINS(113);
>>> +
>>> +static const unsigned int sdc1_clk_pins[] = { 114 };
>>> +static const unsigned int sdc1_cmd_pins[] = { 115 };
>>> +static const unsigned int sdc1_data_pins[] = { 116 };
>>> +static const unsigned int sdc2_clk_pins[] = { 117 };
>>> +static const unsigned int sdc2_cmd_pins[] = { 118 };
>>> +static const unsigned int sdc2_data_pins[] = { 119 };
>>> +static const unsigned int sdc1_rclk_pins[] = { 120 };
>>> +
>>> +enum sdm660_functions {
>>> +	msm_mux_blsp_spi1,
>>> +	msm_mux_gpio,
>>> +	msm_mux_blsp_uim1,
>>> +	msm_mux_tgu_ch0,
>>> +	msm_mux_qdss_gpio4,
>>> +	msm_mux_atest_gpsadc1,
>>> +	msm_mux_blsp_uart1,
>>> +	msm_mux_phase_flag14,
>>> +	msm_mux_blsp_i2c2,
>>> +	msm_mux_phase_flag31,
>>> +	msm_mux_blsp_spi3,
>>> +	msm_mux_blsp_spi3_cs1,
>>> +	msm_mux_blsp_spi3_cs2,
>>> +	msm_mux_wlan1_adc1,
>>> +	msm_mux_atest_usb13,
>>> +	msm_mux_tgu_ch1,
>>> +	msm_mux_qdss_gpio5,
>>> +	msm_mux_atest_gpsadc0,
>>> +	msm_mux_blsp_i2c1,
>>> +	msm_mux_ddr_bist,
>>> +	msm_mux_atest_tsens2,
>>> +	msm_mux_atest_usb1,
>>> +	msm_mux_blsp_spi2,
>>> +	msm_mux_blsp_uim2,
>>> +	msm_mux_phase_flag3,
>>> +	msm_mux_bimc_dte1,
>>> +	msm_mux_wlan1_adc0,
>>> +	msm_mux_atest_usb12,
>>> +	msm_mux_bimc_dte0,
>>> +	msm_mux_blsp_i2c3,
>>> +	msm_mux_wlan2_adc1,
>>> +	msm_mux_atest_usb11,
>>> +	msm_mux_dbg_out,
>>> +	msm_mux_wlan2_adc0,
>>> +	msm_mux_atest_usb10,
>>> +	msm_mux_blsp_spi4,
>>> +	msm_mux_pri_mi2s,
>>> +	msm_mux_phase_flag26,
>>> +	msm_mux_qdss_cti0_a,
>>> +	msm_mux_qdss_cti0_b,
>>> +	msm_mux_qdss_cti1_a,
>>> +	msm_mux_qdss_cti1_b,
>>> +	msm_mux_pri_mi2s_ws,
>>> +	msm_mux_phase_flag27,
>>> +	msm_mux_blsp_i2c4,
>>> +	msm_mux_phase_flag28,
>>> +	msm_mux_blsp_uart5,
>>> +	msm_mux_blsp_spi5,
>>> +	msm_mux_blsp_uim5,
>>> +	msm_mux_phase_flag5,
>>> +	msm_mux_blsp_i2c5,
>>> +	msm_mux_blsp_spi6,
>>> +	msm_mux_blsp_uart2,
>>> +	msm_mux_blsp_uim6,
>>> +	msm_mux_phase_flag11,
>>> +	msm_mux_vsense_data0,
>>> +	msm_mux_blsp_i2c6,
>>> +	msm_mux_phase_flag12,
>>> +	msm_mux_vsense_data1,
>>> +	msm_mux_phase_flag13,
>>> +	msm_mux_vsense_mode,
>>> +	msm_mux_blsp_spi7,
>>> +	msm_mux_blsp_uart6_a,
>>> +	msm_mux_blsp_uart6_b,
>>> +	msm_mux_sec_mi2s,
>>> +	msm_mux_sndwire_clk,
>>> +	msm_mux_phase_flag17,
>>> +	msm_mux_vsense_clkout,
>>> +	msm_mux_sndwire_data,
>>> +	msm_mux_phase_flag18,
>>> +	msm_mux_blsp_i2c7,
>>> +	msm_mux_phase_flag19,
>>> +	msm_mux_vfr_1,
>>> +	msm_mux_phase_flag20,
>>> +	msm_mux_blsp_spi8_cs1,
>>> +	msm_mux_blsp_spi8_cs2,
>>> +	msm_mux_m_voc,
>>> +	msm_mux_phase_flag21,
>>> +	msm_mux_phase_flag22,
>>> +	msm_mux_blsp_i2c8_a,
>>> +	msm_mux_blsp_i2c8_b,
>>> +	msm_mux_phase_flag23,
>>> +	msm_mux_pwr_modem,
>>> +	msm_mux_phase_flag24,
>>> +	msm_mux_qdss_gpio,
>>> +	msm_mux_cam_mclk,
>>> +	msm_mux_pwr_nav,
>>> +	msm_mux_qdss_gpio0,
>>> +	msm_mux_qspi_data0,
>>> +	msm_mux_pwr_crypto,
>>> +	msm_mux_qdss_gpio1,
>>> +	msm_mux_qspi_data1,
>>> +	msm_mux_agera_pll,
>>> +	msm_mux_qdss_gpio2,
>>> +	msm_mux_qspi_data2,
>>> +	msm_mux_jitter_bist,
>>> +	msm_mux_qdss_gpio3,
>>> +	msm_mux_qdss_gpio7,
>>> +	msm_mux_mdss_vsync0,
>>> +	msm_mux_mdss_vsync1,
>>> +	msm_mux_mdss_vsync2,
>>> +	msm_mux_mdss_vsync3,
>>> +	msm_mux_qdss_gpio9,
>>> +	msm_mux_atest_usb2,
>>> +	msm_mux_cci_i2c,
>>> +	msm_mux_pll_bypassnl,
>>> +	msm_mux_atest_tsens,
>>> +	msm_mux_atest_usb21,
>>> +	msm_mux_pll_reset,
>>> +	msm_mux_atest_usb23,
>>> +	msm_mux_qdss_gpio6,
>>> +	msm_mux_qspi_cs,
>>> +	msm_mux_qdss_gpio10,
>>> +	msm_mux_qdss_gpio11,
>>> +	msm_mux_cci_async,
>>> +	msm_mux_qdss_gpio12,
>>> +	msm_mux_qdss_gpio13,
>>> +	msm_mux_qspi_clk,
>>> +	msm_mux_phase_flag30,
>>> +	msm_mux_qdss_gpio14,
>>> +	msm_mux_qspi_resetn,
>>> +	msm_mux_phase_flag1,
>>> +	msm_mux_qdss_gpio15,
>>> +	msm_mux_phase_flag2,
>>> +	msm_mux_phase_flag9,
>>> +	msm_mux_qspi_data3,
>>> +	msm_mux_phase_flag15,
>>> +	msm_mux_qdss_gpio8,
>>> +	msm_mux_phase_flag16,
>>> +	msm_mux_phase_flag6,
>>> +	msm_mux_phase_flag29,
>>> +	msm_mux_phase_flag25,
>>> +	msm_mux_phase_flag10,
>>> +	msm_mux_atest_usb20,
>>> +	msm_mux_gcc_gp1,
>>> +	msm_mux_phase_flag4,
>>> +	msm_mux_atest_usb22,
>>> +	msm_mux_gcc_gp2,
>>> +	msm_mux_atest_char,
>>> +	msm_mux_mdp_vsync,
>>> +	msm_mux_gcc_gp3,
>>> +	msm_mux_atest_char3,
>>> +	msm_mux_cri_trng0,
>>> +	msm_mux_atest_char2,
>>> +	msm_mux_cri_trng1,
>>> +	msm_mux_atest_char1,
>>> +	msm_mux_audio_ref,
>>> +	msm_mux_cri_trng,
>>> +	msm_mux_atest_char0,
>>> +	msm_mux_blsp_spi8_a,
>>> +	msm_mux_blsp_spi8_b,
>>> +	msm_mux_sp_cmu,
>>> +	msm_mux_nav_pps_a,
>>> +	msm_mux_nav_pps_b,
>>> +	msm_mux_nav_pps_c,
>>> +	msm_mux_gps_tx_a,
>>> +	msm_mux_gps_tx_b,
>>> +	msm_mux_gps_tx_c,
>>> +	msm_mux_adsp_ext,
>>> +	msm_mux_ssc_irq,
>>> +	msm_mux_isense_dbg,
>>> +	msm_mux_phase_flag0,
>>> +	msm_mux_phase_flag7,
>>> +	msm_mux_phase_flag8,
>>> +	msm_mux_tsense_pwm1,
>>> +	msm_mux_tsense_pwm2,
>>> +	msm_mux_mss_lte,
>>> +	msm_mux_uim2_data,
>>> +	msm_mux_uim2_clk,
>>> +	msm_mux_uim2_reset,
>>> +	msm_mux_uim2_present,
>>> +	msm_mux_uim1_data,
>>> +	msm_mux_uim1_clk,
>>> +	msm_mux_uim1_reset,
>>> +	msm_mux_uim1_present,
>>> +	msm_mux_uim_batt,
>>> +	msm_mux_pa_indicator,
>>> +	msm_mux_ldo_en,
>>> +	msm_mux_ldo_update,
>>> +	msm_mux_qlink_request,
>>> +	msm_mux_qlink_enable,
>>> +	msm_mux_prng_rosc,
>>> +	msm_mux__,
>>> +};
>>> +
>>> +static const char * const gpio_groups[] = {
>>> +	"gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6",
>> "gpio7",
>>> +	"gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
>>> +	"gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20",
>> "gpio21",
>>> +	"gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27",
>> "gpio28",
>>> +	"gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34",
>> "gpio35",
>>> +	"gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41",
>> "gpio42",
>>> +	"gpio43", "gpio44", "gpio45", "gpio46", "gpio47", "gpio48",
>> "gpio49",
>>> +	"gpio50", "gpio51", "gpio52", "gpio53", "gpio54", "gpio55",
>> "gpio56",
>>> +	"gpio57", "gpio58", "gpio59", "gpio60", "gpio61", "gpio62",
>> "gpio63",
>>> +	"gpio64", "gpio65", "gpio66", "gpio67", "gpio68", "gpio69",
>> "gpio70",
>>> +	"gpio71", "gpio72", "gpio73", "gpio74", "gpio75", "gpio76",
>> "gpio77",
>>> +	"gpio78", "gpio79", "gpio80", "gpio81", "gpio82", "gpio83",
>> "gpio84",
>>> +	"gpio85", "gpio86", "gpio87", "gpio88", "gpio89", "gpio90",
>> "gpio91",
>>> +	"gpio92", "gpio93", "gpio94", "gpio95", "gpio96", "gpio97",
>> "gpio98",
>>> +	"gpio99", "gpio100", "gpio101", "gpio102", "gpio103", "gpio104",
>>> +	"gpio105", "gpio106", "gpio107", "gpio108", "gpio109", "gpio110",
>>> +	"gpio111", "gpio112", "gpio113",
>>> +};
>>> +static const char * const blsp_spi1_groups[] = {
>>> +	"gpio0", "gpio1", "gpio2", "gpio3", "gpio46",
>>> +};
>>> +static const char * const blsp_uim1_groups[] = {
>>> +	"gpio0", "gpio1",
>>> +};
>>> +static const char * const tgu_ch0_groups[] = {
>>> +	"gpio0",
>>> +};
>>> +static const char * const qdss_gpio4_groups[] = {
>>> +	"gpio0", "gpio36",
>>> +};
>>> +static const char * const atest_gpsadc1_groups[] = {
>>> +	"gpio0",
>>> +};
>>> +static const char * const blsp_uart1_groups[] = {
>>> +	"gpio0", "gpio1", "gpio2", "gpio3",
>>> +};
>>> +static const char * const phase_flag14_groups[] = {
>>> +	"gpio5",
>>> +};
>>> +static const char * const blsp_i2c2_groups[] = {
>>> +	"gpio6", "gpio7",
>>> +};
>>> +static const char * const phase_flag31_groups[] = {
>>> +	"gpio6",
>>> +};
>>> +static const char * const blsp_spi3_groups[] = {
>>> +	"gpio8", "gpio9", "gpio10", "gpio11",
>>> +};
>>> +static const char * const blsp_spi3_cs1_groups[] = {
>>> +	"gpio30",
>>> +};
>>> +static const char * const blsp_spi3_cs2_groups[] = {
>>> +	"gpio65",
>>> +};
>>> +static const char * const wlan1_adc1_groups[] = {
>>> +	"gpio8",
>>> +};
>>> +static const char * const atest_usb13_groups[] = {
>>> +	"gpio8",
>>> +};
>>> +static const char * const tgu_ch1_groups[] = {
>>> +	"gpio1",
>>> +};
>>> +static const char * const qdss_gpio5_groups[] = {
>>> +	"gpio1", "gpio37",
>>> +};
>>> +static const char * const atest_gpsadc0_groups[] = {
>>> +	"gpio1",
>>> +};
>>> +static const char * const blsp_i2c1_groups[] = {
>>> +	"gpio2", "gpio3",
>>> +};
>>> +static const char * const ddr_bist_groups[] = {
>>> +	"gpio3", "gpio8", "gpio9", "gpio10",
>>> +};
>>> +static const char * const atest_tsens2_groups[] = {
>>> +	"gpio3",
>>> +};
>>> +static const char * const atest_usb1_groups[] = {
>>> +	"gpio3",
>>> +};
>>> +static const char * const blsp_spi2_groups[] = {
>>> +	"gpio4", "gpio5", "gpio6", "gpio7",
>>> +};
>>> +static const char * const blsp_uim2_groups[] = {
>>> +	"gpio4", "gpio5",
>>> +};
>>> +static const char * const phase_flag3_groups[] = {
>>> +	"gpio4",
>>> +};
>>> +static const char * const bimc_dte1_groups[] = {
>>> +	"gpio8", "gpio10",
>>> +};
>>> +static const char * const wlan1_adc0_groups[] = {
>>> +	"gpio9",
>>> +};
>>> +static const char * const atest_usb12_groups[] = {
>>> +	"gpio9",
>>> +};
>>> +static const char * const bimc_dte0_groups[] = {
>>> +	"gpio9", "gpio11",
>>> +};
>>> +static const char * const blsp_i2c3_groups[] = {
>>> +	"gpio10", "gpio11",
>>> +};
>>> +static const char * const wlan2_adc1_groups[] = {
>>> +	"gpio10",
>>> +};
>>> +static const char * const atest_usb11_groups[] = {
>>> +	"gpio10",
>>> +};
>>> +static const char * const dbg_out_groups[] = {
>>> +	"gpio11",
>>> +};
>>> +static const char * const wlan2_adc0_groups[] = {
>>> +	"gpio11",
>>> +};
>>> +static const char * const atest_usb10_groups[] = {
>>> +	"gpio11",
>>> +};
>>> +static const char * const RCM_MARKER_groups[] = {
>>> +	"gpio12", "gpio13",
>>> +};
>>> +static const char * const blsp_spi4_groups[] = {
>>> +	"gpio12", "gpio13", "gpio14", "gpio15",
>>> +};
>>> +static const char * const pri_mi2s_groups[] = {
>>> +	"gpio12", "gpio14", "gpio15", "gpio61",
>>> +};
>>> +static const char * const phase_flag26_groups[] = {
>>> +	"gpio12",
>>> +};
>>> +static const char * const qdss_cti0_a_groups[] = {
>>> +	"gpio49", "gpio50",
>>> +};
>>> +static const char * const qdss_cti0_b_groups[] = {
>>> +	"gpio13", "gpio21",
>>> +};
>>> +static const char * const qdss_cti1_a_groups[] = {
>>> +	"gpio53", "gpio55",
>>> +};
>>> +static const char * const qdss_cti1_b_groups[] = {
>>> +	"gpio12", "gpio66",
>>> +};
>>> +static const char * const pri_mi2s_ws_groups[] = {
>>> +	"gpio13",
>>> +};
>>> +static const char * const phase_flag27_groups[] = {
>>> +	"gpio13",
>>> +};
>>> +static const char * const blsp_i2c4_groups[] = {
>>> +	"gpio14", "gpio15",
>>> +};
>>> +static const char * const phase_flag28_groups[] = {
>>> +	"gpio14",
>>> +};
>>> +static const char * const blsp_uart5_groups[] = {
>>> +	"gpio16", "gpio17", "gpio18", "gpio19",
>>> +};
>>> +static const char * const blsp_spi5_groups[] = {
>>> +	"gpio16", "gpio17", "gpio18", "gpio19",
>>> +};
>>> +static const char * const blsp_uim5_groups[] = {
>>> +	"gpio16", "gpio17",
>>> +};
>>> +static const char * const phase_flag5_groups[] = {
>>> +	"gpio17",
>>> +};
>>> +static const char * const blsp_i2c5_groups[] = {
>>> +	"gpio18", "gpio19",
>>> +};
>>> +static const char * const blsp_spi6_groups[] = {
>>> +	"gpio49", "gpio52", "gpio22", "gpio23",
>>> +};
>>> +static const char * const blsp_uart2_groups[] = {
>>> +	"gpio4", "gpio5", "gpio6", "gpio7",
>>> +};
>>> +static const char * const blsp_uim6_groups[]
>
Bjorn Andersson Sept. 24, 2018, 6:53 p.m. UTC | #5
On Sun 12 Aug 07:24 PDT 2018, Craig Tatlor wrote:

> Add initial pinctrl driver to support pin configuration with
> pinctrl framework for sdm660.
> Based off CAF implementation.
> 
> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
> ---
> 
> Changes from v1:
>   Adds gpio-ranges property to bindings
> 
> 
>  .../bindings/pinctrl/qcom,sdm660-pinctrl.txt  |  202 +++

As the DT binding part of the patch is significant, please split it into
its own patch.

>  drivers/pinctrl/qcom/Kconfig                  |   10 +
>  drivers/pinctrl/qcom/Makefile                 |    1 +
>  drivers/pinctrl/qcom/pinctrl-sdm660.c         | 1451 +++++++++++++++++
>  4 files changed, 1663 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>  create mode 100644 drivers/pinctrl/qcom/pinctrl-sdm660.c
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
[..]
> +- function:
> +	Usage: required
> +	Value type: <string>
> +	Definition: Specify the alternative function to be configured for the
> +		    specified pins. Functions are only valid for gpio pins.
> +		    Valid values are:
> +
> +		    blsp_uart1, blsp_spi1, blsp_i2c1, blsp_uim1, atest_tsens,
> +		    bimc_dte1, dac_calib0, blsp_spi8, blsp_uart8, blsp_uim8,
> +		    qdss_cti_trig_out_b, bimc_dte0, dac_calib1, qdss_cti_trig_in_b,
> +		    dac_calib2, atest_tsens2, atest_usb1, blsp_spi10, blsp_uart10,
> +		    blsp_uim10, atest_bbrx1, atest_usb13, atest_bbrx0, atest_usb12,
> +		    mdp_vsync, edp_lcd, blsp_i2c10, atest_gpsadc1, atest_usb11,
> +		    atest_gpsadc0, edp_hot, atest_usb10, m_voc, dac_gpio, atest_char,
> +		    cam_mclk, pll_bypassnl, qdss_stm7, blsp_i2c8, qdss_tracedata_b,
> +		    pll_reset, qdss_stm6, qdss_stm5, qdss_stm4, atest_usb2, cci_i2c,
> +		    qdss_stm3, dac_calib3, atest_usb23, atest_char3, dac_calib4,
> +		    qdss_stm2, atest_usb22, atest_char2, qdss_stm1, dac_calib5,
> +		    atest_usb21, atest_char1, dbg_out, qdss_stm0, dac_calib6,
> +		    atest_usb20, atest_char0, dac_calib10, qdss_stm10,
> +		    qdss_cti_trig_in_a, cci_timer4, blsp_spi6, blsp_uart6, blsp_uim6,
> +		    blsp2_spi, qdss_stm9, qdss_cti_trig_out_a, dac_calib11,
> +		    qdss_stm8, cci_timer0, qdss_stm13, dac_calib7, cci_timer1,
> +		    qdss_stm12, dac_calib8, cci_timer2, blsp1_spi, qdss_stm11,
> +		    dac_calib9, cci_timer3, cci_async, dac_calib12, blsp_i2c6,
> +		    qdss_tracectl_a, dac_calib13, qdss_traceclk_a, dac_calib14,
> +		    dac_calib15, hdmi_rcv, dac_calib16, hdmi_cec, pwr_modem,
> +		    dac_calib17, hdmi_ddc, pwr_nav, dac_calib18, pwr_crypto,
> +		    dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0,
> +		    dac_calib22, dac_calib23, dac_calib24, tsif1_sync, dac_calib25,
> +		    sd_write, tsif1_error, blsp_spi2, blsp_uart2, blsp_uim2,
> +		    qdss_cti, blsp_i2c2, blsp_spi3, blsp_uart3, blsp_uim3, blsp_i2c3,
> +		    uim3, blsp_spi9, blsp_uart9, blsp_uim9, blsp10_spi, blsp_i2c9,
> +		    blsp_spi7, blsp_uart7, blsp_uim7, qdss_tracedata_a, blsp_i2c7,
> +		    qua_mi2s, gcc_gp1_clk_a, ssc_irq, uim4, blsp_spi11, blsp_uart11,
> +		    blsp_uim11, gcc_gp2_clk_a, gcc_gp3_clk_a, blsp_i2c11, cri_trng0,
> +		    cri_trng1, cri_trng, qdss_stm18, pri_mi2s, qdss_stm17, blsp_spi4,
> +		    blsp_uart4, blsp_uim4, qdss_stm16, qdss_stm15, blsp_i2c4,
> +		    qdss_stm14, dac_calib26, spkr_i2s, audio_ref, lpass_slimbus,
> +		    isense_dbg, tsense_pwm1, tsense_pwm2, btfm_slimbus, ter_mi2s,
> +		    qdss_stm22, qdss_stm21, qdss_stm20, qdss_stm19, gcc_gp1_clk_b,
> +		    sec_mi2s, blsp_spi5, blsp_uart5, blsp_uim5, gcc_gp2_clk_b,
> +		    gcc_gp3_clk_b, blsp_i2c5, blsp_spi12, blsp_uart12, blsp_uim12,
> +		    qdss_stm25, qdss_stm31, blsp_i2c12, qdss_stm30, qdss_stm29,
> +		    tsif1_clk, qdss_stm28, tsif1_en, tsif1_data, sdc4_cmd, qdss_stm27,
> +		    qdss_traceclk_b, tsif2_error, sdc43, vfr_1, qdss_stm26, tsif2_clk,
> +		    sdc4_clk, qdss_stm24, tsif2_en, sdc42, qdss_stm23, qdss_tracectl_b,
> +		    sd_card, tsif2_data, sdc41, tsif2_sync, sdc40, mdp_vsync_p_b,
> +		    ldo_en, mdp_vsync_s_b, ldo_update, blsp11_uart_tx_b, blsp11_uart_rx_b,
> +		    blsp11_i2c_sda_b, prng_rosc, blsp11_i2c_scl_b, uim2, uim1, uim_batt,
> +		    pci_e2, pa_indicator, adsp_ext, ddr_bist, qdss_tracedata_11,
> +		    qdss_tracedata_12, modem_tsync, nav_dr, nav_pps, pci_e1, gsm_tx,
> +		    qspi_cs, ssbi2, ssbi1, mss_lte, qspi_clk, qspi0, qspi1, qspi2, qspi3,
> +		    gpio

Please review this list, there are a few items in here that are not
valid functions in your driver.

[..]
> +
> +Example:
> +
> +	tlmm: pinctrl@1010000 {
> +		compatible = "qcom,sdm660-pinctrl";
> +		reg = <0x1010000 0x300000>;
> +		interrupts = <0 208 0>;

Replace the 0s in the interrupts specifier.

> +		gpio-controller;
> +		gpio-ranges = <&tlmm 0 0 114>;
> +		#gpio-cells = <2>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +
> +		uart_console_active: uart_console_active {
> +			mux {
> +				pins = "gpio4", "gpio5";
> +				function = "blsp_uart8";
> +			};
> +
> +			config {
> +				pins = "gpio4", "gpio5";
> +				drive-strength = <2>;
> +				bias-disable;
> +			};
> +		};

This example isn't valid. Please update it, or just drop the pinctrl
state from the example.

> +	};
> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
> index 195492033075..091beadb8a1c 100644
> --- a/drivers/pinctrl/qcom/Kconfig
> +++ b/drivers/pinctrl/qcom/Kconfig
> @@ -147,6 +147,16 @@ config PINCTRL_QCOM_SSBI_PMIC
>           which are using SSBI for communication with SoC. Example PMIC's
>           devices are pm8058 and pm8921.
>  
> +config PINCTRL_SDM660
> +       tristate "Qualcomm Technologies Inc SDM660 pin controller driver"
> +       depends on GPIOLIB && OF
> +       select PINCTRL_MSM
> +       help
> +         This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> +         Qualcomm Technologies Inc TLMM block found on the Qualcomm
> +         Technologies Inc SDM660 platform.
> +
> +

Extra empty line.

>  config PINCTRL_SDM845
>         tristate "Qualcomm Technologies Inc SDM845 pin controller driver"
>         depends on GPIOLIB && OF
> diff --git a/drivers/pinctrl/qcom/Makefile b/drivers/pinctrl/qcom/Makefile
> index 0c6f3ddc296d..9b08808a2f1c 100644
> --- a/drivers/pinctrl/qcom/Makefile
> +++ b/drivers/pinctrl/qcom/Makefile
> @@ -19,4 +19,5 @@ obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-gpio.o
>  obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-mpp.o
>  obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-gpio.o
>  obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-mpp.o
> +obj-$(CONFIG_PINCTRL_SDM660)   += pinctrl-sdm660.o
>  obj-$(CONFIG_PINCTRL_SDM845) += pinctrl-sdm845.o
> diff --git a/drivers/pinctrl/qcom/pinctrl-sdm660.c b/drivers/pinctrl/qcom/pinctrl-sdm660.c
> new file mode 100644
> index 000000000000..ded56111f168
> --- /dev/null
> +++ b/drivers/pinctrl/qcom/pinctrl-sdm660.c
> @@ -0,0 +1,1451 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2018, Craig Tatlor.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/pinctrl/pinctrl.h>
> +
> +#include "pinctrl-msm.h"
> +
> +#define NORTH	0x00900000
> +#define CENTER	0x00500000
> +#define SOUTH	0x00100000

Please respin this on top of the QCS404 series, where we describe each
tile explicitly in DT.

The three regions are:

South:  0x03100000 size 0x300000
Center: 0x03500000 size 0x300000
North:  0x03900000 size 0x300000

[..]
> +static const unsigned int sdc1_clk_pins[] = { 114 };
> +static const unsigned int sdc1_cmd_pins[] = { 115 };
> +static const unsigned int sdc1_data_pins[] = { 116 };
> +static const unsigned int sdc2_clk_pins[] = { 117 };
> +static const unsigned int sdc2_cmd_pins[] = { 118 };
> +static const unsigned int sdc2_data_pins[] = { 119 };
> +static const unsigned int sdc1_rclk_pins[] = { 120 };

The numbering of these "fake" pins isn't significant, so please reorder
sdc1_rclk to follow the other sdc1 pins.

> +
> +enum sdm660_functions {
> +	msm_mux_blsp_spi1,

There's no harm in sorting this list, but it makes it easier to read.
> +
> +static const struct msm_function sdm660_functions[] = {
> +	FUNCTION(blsp_spi1),

Ditto.

[..]
> +static const struct msm_pingroup sdm660_groups[] = {
[..]
> +	SDC_QDSD_PINGROUP(sdc1_clk, 0x99a000, 13, 6),
> +	SDC_QDSD_PINGROUP(sdc1_cmd, 0x99a000, 11, 3),
> +	SDC_QDSD_PINGROUP(sdc1_data, 0x99a000, 9, 0),
> +	SDC_QDSD_PINGROUP(sdc2_clk, 0x99b000, 14, 6),
> +	SDC_QDSD_PINGROUP(sdc2_cmd, 0x99b000, 11, 3),
> +	SDC_QDSD_PINGROUP(sdc2_data, 0x99b000, 9, 0),
> +	SDC_QDSD_PINGROUP(sdc1_rclk, 0x99a000, 15, 0),

Move the sdc1_rclk up to the other sdc1 groups.

> +};

Regards,
Bjorn
Craig Tatlor Sept. 24, 2018, 8:37 p.m. UTC | #6
On 24 September 2018 19:53:06 BST, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>On Sun 12 Aug 07:24 PDT 2018, Craig Tatlor wrote:
>
>> Add initial pinctrl driver to support pin configuration with
>> pinctrl framework for sdm660.
>> Based off CAF implementation.
>> 
>> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
>> ---
>> 
>> Changes from v1:
>>   Adds gpio-ranges property to bindings
>> 
>> 
>>  .../bindings/pinctrl/qcom,sdm660-pinctrl.txt  |  202 +++
>
>As the DT binding part of the patch is significant, please split it
>into
>its own patch.
>
Right
>>  drivers/pinctrl/qcom/Kconfig                  |   10 +
>>  drivers/pinctrl/qcom/Makefile                 |    1 +
>>  drivers/pinctrl/qcom/pinctrl-sdm660.c         | 1451
>+++++++++++++++++
>>  4 files changed, 1663 insertions(+)
>>  create mode 100644
>Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>>  create mode 100644 drivers/pinctrl/qcom/pinctrl-sdm660.c
>> 
>> diff --git
>a/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
>[..]
>> +- function:
>> +	Usage: required
>> +	Value type: <string>
>> +	Definition: Specify the alternative function to be configured for
>the
>> +		    specified pins. Functions are only valid for gpio pins.
>> +		    Valid values are:
>> +
>> +		    blsp_uart1, blsp_spi1, blsp_i2c1, blsp_uim1, atest_tsens,
>> +		    bimc_dte1, dac_calib0, blsp_spi8, blsp_uart8, blsp_uim8,
>> +		    qdss_cti_trig_out_b, bimc_dte0, dac_calib1,
>qdss_cti_trig_in_b,
>> +		    dac_calib2, atest_tsens2, atest_usb1, blsp_spi10, blsp_uart10,
>> +		    blsp_uim10, atest_bbrx1, atest_usb13, atest_bbrx0,
>atest_usb12,
>> +		    mdp_vsync, edp_lcd, blsp_i2c10, atest_gpsadc1, atest_usb11,
>> +		    atest_gpsadc0, edp_hot, atest_usb10, m_voc, dac_gpio,
>atest_char,
>> +		    cam_mclk, pll_bypassnl, qdss_stm7, blsp_i2c8,
>qdss_tracedata_b,
>> +		    pll_reset, qdss_stm6, qdss_stm5, qdss_stm4, atest_usb2,
>cci_i2c,
>> +		    qdss_stm3, dac_calib3, atest_usb23, atest_char3, dac_calib4,
>> +		    qdss_stm2, atest_usb22, atest_char2, qdss_stm1, dac_calib5,
>> +		    atest_usb21, atest_char1, dbg_out, qdss_stm0, dac_calib6,
>> +		    atest_usb20, atest_char0, dac_calib10, qdss_stm10,
>> +		    qdss_cti_trig_in_a, cci_timer4, blsp_spi6, blsp_uart6,
>blsp_uim6,
>> +		    blsp2_spi, qdss_stm9, qdss_cti_trig_out_a, dac_calib11,
>> +		    qdss_stm8, cci_timer0, qdss_stm13, dac_calib7, cci_timer1,
>> +		    qdss_stm12, dac_calib8, cci_timer2, blsp1_spi, qdss_stm11,
>> +		    dac_calib9, cci_timer3, cci_async, dac_calib12, blsp_i2c6,
>> +		    qdss_tracectl_a, dac_calib13, qdss_traceclk_a, dac_calib14,
>> +		    dac_calib15, hdmi_rcv, dac_calib16, hdmi_cec, pwr_modem,
>> +		    dac_calib17, hdmi_ddc, pwr_nav, dac_calib18, pwr_crypto,
>> +		    dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0,
>> +		    dac_calib22, dac_calib23, dac_calib24, tsif1_sync,
>dac_calib25,
>> +		    sd_write, tsif1_error, blsp_spi2, blsp_uart2, blsp_uim2,
>> +		    qdss_cti, blsp_i2c2, blsp_spi3, blsp_uart3, blsp_uim3,
>blsp_i2c3,
>> +		    uim3, blsp_spi9, blsp_uart9, blsp_uim9, blsp10_spi, blsp_i2c9,
>> +		    blsp_spi7, blsp_uart7, blsp_uim7, qdss_tracedata_a, blsp_i2c7,
>> +		    qua_mi2s, gcc_gp1_clk_a, ssc_irq, uim4, blsp_spi11,
>blsp_uart11,
>> +		    blsp_uim11, gcc_gp2_clk_a, gcc_gp3_clk_a, blsp_i2c11,
>cri_trng0,
>> +		    cri_trng1, cri_trng, qdss_stm18, pri_mi2s, qdss_stm17,
>blsp_spi4,
>> +		    blsp_uart4, blsp_uim4, qdss_stm16, qdss_stm15, blsp_i2c4,
>> +		    qdss_stm14, dac_calib26, spkr_i2s, audio_ref, lpass_slimbus,
>> +		    isense_dbg, tsense_pwm1, tsense_pwm2, btfm_slimbus, ter_mi2s,
>> +		    qdss_stm22, qdss_stm21, qdss_stm20, qdss_stm19, gcc_gp1_clk_b,
>> +		    sec_mi2s, blsp_spi5, blsp_uart5, blsp_uim5, gcc_gp2_clk_b,
>> +		    gcc_gp3_clk_b, blsp_i2c5, blsp_spi12, blsp_uart12, blsp_uim12,
>> +		    qdss_stm25, qdss_stm31, blsp_i2c12, qdss_stm30, qdss_stm29,
>> +		    tsif1_clk, qdss_stm28, tsif1_en, tsif1_data, sdc4_cmd,
>qdss_stm27,
>> +		    qdss_traceclk_b, tsif2_error, sdc43, vfr_1, qdss_stm26,
>tsif2_clk,
>> +		    sdc4_clk, qdss_stm24, tsif2_en, sdc42, qdss_stm23,
>qdss_tracectl_b,
>> +		    sd_card, tsif2_data, sdc41, tsif2_sync, sdc40, mdp_vsync_p_b,
>> +		    ldo_en, mdp_vsync_s_b, ldo_update, blsp11_uart_tx_b,
>blsp11_uart_rx_b,
>> +		    blsp11_i2c_sda_b, prng_rosc, blsp11_i2c_scl_b, uim2, uim1,
>uim_batt,
>> +		    pci_e2, pa_indicator, adsp_ext, ddr_bist, qdss_tracedata_11,
>> +		    qdss_tracedata_12, modem_tsync, nav_dr, nav_pps, pci_e1,
>gsm_tx,
>> +		    qspi_cs, ssbi2, ssbi1, mss_lte, qspi_clk, qspi0, qspi1, qspi2,
>qspi3,
>> +		    gpio
>
>Please review this list, there are a few items in here that are not
>valid functions in your driver.
>
Okay, will do
>[..]
>> +
>> +Example:
>> +
>> +	tlmm: pinctrl@1010000 {
>> +		compatible = "qcom,sdm660-pinctrl";
>> +		reg = <0x1010000 0x300000>;
>> +		interrupts = <0 208 0>;
>
>Replace the 0s in the interrupts specifier.
Okay
>
>> +		gpio-controller;
>> +		gpio-ranges = <&tlmm 0 0 114>;
>> +		#gpio-cells = <2>;
>> +		interrupt-controller;
>> +		#interrupt-cells = <2>;
>> +
>> +		uart_console_active: uart_console_active {
>> +			mux {
>> +				pins = "gpio4", "gpio5";
>> +				function = "blsp_uart8";
>> +			};
>> +
>> +			config {
>> +				pins = "gpio4", "gpio5";
>> +				drive-strength = <2>;
>> +				bias-disable;
>> +			};
>> +		};
>
>This example isn't valid. Please update it, or just drop the pinctrl
>state from the example.
>
Right, will drop it
>> +	};
>> diff --git a/drivers/pinctrl/qcom/Kconfig
>b/drivers/pinctrl/qcom/Kconfig
>> index 195492033075..091beadb8a1c 100644
>> --- a/drivers/pinctrl/qcom/Kconfig
>> +++ b/drivers/pinctrl/qcom/Kconfig
>> @@ -147,6 +147,16 @@ config PINCTRL_QCOM_SSBI_PMIC
>>           which are using SSBI for communication with SoC. Example
>PMIC's
>>           devices are pm8058 and pm8921.
>>  
>> +config PINCTRL_SDM660
>> +       tristate "Qualcomm Technologies Inc SDM660 pin controller
>driver"
>> +       depends on GPIOLIB && OF
>> +       select PINCTRL_MSM
>> +       help
>> +         This is the pinctrl, pinmux, pinconf and gpiolib driver for
>the
>> +         Qualcomm Technologies Inc TLMM block found on the Qualcomm
>> +         Technologies Inc SDM660 platform.
>> +
>> +
>
>Extra empty line
Yeah
>
>>  config PINCTRL_SDM845
>>         tristate "Qualcomm Technologies Inc SDM845 pin controller
>driver"
>>         depends on GPIOLIB && OF
>> diff --git a/drivers/pinctrl/qcom/Makefile
>b/drivers/pinctrl/qcom/Makefile
>> index 0c6f3ddc296d..9b08808a2f1c 100644
>> --- a/drivers/pinctrl/qcom/Makefile
>> +++ b/drivers/pinctrl/qcom/Makefile
>> @@ -19,4 +19,5 @@ obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) +=
>pinctrl-spmi-gpio.o
>>  obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-mpp.o
>>  obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-gpio.o
>>  obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-mpp.o
>> +obj-$(CONFIG_PINCTRL_SDM660)   += pinctrl-sdm660.o
>>  obj-$(CONFIG_PINCTRL_SDM845) += pinctrl-sdm845.o
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sdm660.c
>b/drivers/pinctrl/qcom/pinctrl-sdm660.c
>> new file mode 100644
>> index 000000000000..ded56111f168
>> --- /dev/null
>> +++ b/drivers/pinctrl/qcom/pinctrl-sdm660.c
>> @@ -0,0 +1,1451 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (c) 2016, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2018, Craig Tatlor.
>> + */
>> +
>> +#include <linux/module.h>
>> +#include <linux/of.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/pinctrl/pinctrl.h>
>> +
>> +#include "pinctrl-msm.h"
>> +
>> +#define NORTH	0x00900000
>> +#define CENTER	0x00500000
>> +#define SOUTH	0x00100000
>
>Please respin this on top of the QCS404 series, where we describe each
>tile explicitly in DT.
>
>The three regions are:
>
>South:  0x03100000 size 0x300000
>Center: 0x03500000 size 0x300000
>North:  0x03900000 size 0x300000
Right, will do
>
>[..]
>> +static const unsigned int sdc1_clk_pins[] = { 114 };
>> +static const unsigned int sdc1_cmd_pins[] = { 115 };
>> +static const unsigned int sdc1_data_pins[] = { 116 };
>> +static const unsigned int sdc2_clk_pins[] = { 117 };
>> +static const unsigned int sdc2_cmd_pins[] = { 118 };
>> +static const unsigned int sdc2_data_pins[] = { 119 };
>> +static const unsigned int sdc1_rclk_pins[] = { 120 };
>
>The numbering of these "fake" pins isn't significant, so please reorder
>sdc1_rclk to follow the other sdc1 pins.
Yup
>
>> +
>> +enum sdm660_functions {
>> +	msm_mux_blsp_spi1,
>
>There's no harm in sorting this list, but it makes it easier to read.
>> +
Okay, will do, alphabetically I guess?
>> +static const struct msm_function sdm660_functions[] = {
>> +	FUNCTION(blsp_spi1),
>
>Ditto.
>
>[..]
>> +static const struct msm_pingroup sdm660_groups[] = {
>[..]
>> +	SDC_QDSD_PINGROUP(sdc1_clk, 0x99a000, 13, 6),
>> +	SDC_QDSD_PINGROUP(sdc1_cmd, 0x99a000, 11, 3),
>> +	SDC_QDSD_PINGROUP(sdc1_data, 0x99a000, 9, 0),
>> +	SDC_QDSD_PINGROUP(sdc2_clk, 0x99b000, 14, 6),
>> +	SDC_QDSD_PINGROUP(sdc2_cmd, 0x99b000, 11, 3),
>> +	SDC_QDSD_PINGROUP(sdc2_data, 0x99b000, 9, 0),
>> +	SDC_QDSD_PINGROUP(sdc1_rclk, 0x99a000, 15, 0),
>
>Move the sdc1_rclk up to the other sdc1 groups.
Right
>
>> +};
>
>Regards,
>Bjorn
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
new file mode 100644
index 000000000000..801960ad2112
--- /dev/null
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
@@ -0,0 +1,202 @@ 
+Qualcomm Technologies, Inc. SDM660 TLMM block
+
+This binding describes the Top Level Mode Multiplexer block found in the
+SDM660 platform.
+
+- compatible:
+	Usage: required
+	Value type: <string>
+	Definition: must be "qcom,sdm660-pinctrl"
+
+- reg:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: the base address and size of the TLMM register space.
+
+- interrupts:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: should specify the TLMM summary IRQ.
+
+- interrupt-controller:
+	Usage: required
+	Value type: <none>
+	Definition: identifies this node as an interrupt controller
+
+- #interrupt-cells:
+	Usage: required
+	Value type: <u32>
+	Definition: must be 2. Specifying the pin number and flags, as defined
+		    in <dt-bindings/interrupt-controller/irq.h>
+
+- gpio-controller:
+	Usage: required
+	Value type: <none>
+	Definition: identifies this node as a gpio controller
+
+- gpio-ranges:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: Specifies the mapping between gpio controller and
+		    pin-controller pins.
+
+- #gpio-cells:
+	Usage: required
+	Value type: <u32>
+	Definition: must be 2. Specifying the pin number and flags, as defined
+		    in <dt-bindings/gpio/gpio.h>
+
+Please refer to ../gpio/gpio.txt and ../interrupt-controller/interrupts.txt for
+a general description of GPIO and interrupt bindings.
+
+Please refer to pinctrl-bindings.txt in this directory for details of the
+common pinctrl bindings used by client devices, including the meaning of the
+phrase "pin configuration node".
+
+The pin configuration nodes act as a container for an arbitrary number of
+subnodes. Each of these subnodes represents some desired configuration for a
+pin, a group, or a list of pins or groups. This configuration can include the
+mux function to select on those pin(s)/group(s), and various pin configuration
+parameters, such as pull-up, drive strength, etc.
+
+
+PIN CONFIGURATION NODES:
+
+The name of each subnode is not important; all subnodes should be enumerated
+and processed purely based on their content.
+
+Each subnode only affects those parameters that are explicitly listed. In
+other words, a subnode that lists a mux function but no pin configuration
+parameters implies no information about any pin configuration parameters.
+Similarly, a pin subnode that describes a pullup parameter implies no
+information about e.g. the mux function.
+
+
+The following generic properties as defined in pinctrl-bindings.txt are valid
+to specify in a pin configuration subnode:
+
+- pins:
+	Usage: required
+	Value type: <string-array>
+	Definition: List of gpio pins affected by the properties specified in
+		    this subnode.  Valid pins are:
+		    gpio0-gpio113,
+		        Supports mux, bias and drive-strength
+		    sdc1_clk, sdc1_cmd, sdc1_data sdc2_clk, sdc2_cmd, sdc2_data sdc1_rclk,
+		        Supports bias and drive-strength
+
+- function:
+	Usage: required
+	Value type: <string>
+	Definition: Specify the alternative function to be configured for the
+		    specified pins. Functions are only valid for gpio pins.
+		    Valid values are:
+
+		    blsp_uart1, blsp_spi1, blsp_i2c1, blsp_uim1, atest_tsens,
+		    bimc_dte1, dac_calib0, blsp_spi8, blsp_uart8, blsp_uim8,
+		    qdss_cti_trig_out_b, bimc_dte0, dac_calib1, qdss_cti_trig_in_b,
+		    dac_calib2, atest_tsens2, atest_usb1, blsp_spi10, blsp_uart10,
+		    blsp_uim10, atest_bbrx1, atest_usb13, atest_bbrx0, atest_usb12,
+		    mdp_vsync, edp_lcd, blsp_i2c10, atest_gpsadc1, atest_usb11,
+		    atest_gpsadc0, edp_hot, atest_usb10, m_voc, dac_gpio, atest_char,
+		    cam_mclk, pll_bypassnl, qdss_stm7, blsp_i2c8, qdss_tracedata_b,
+		    pll_reset, qdss_stm6, qdss_stm5, qdss_stm4, atest_usb2, cci_i2c,
+		    qdss_stm3, dac_calib3, atest_usb23, atest_char3, dac_calib4,
+		    qdss_stm2, atest_usb22, atest_char2, qdss_stm1, dac_calib5,
+		    atest_usb21, atest_char1, dbg_out, qdss_stm0, dac_calib6,
+		    atest_usb20, atest_char0, dac_calib10, qdss_stm10,
+		    qdss_cti_trig_in_a, cci_timer4, blsp_spi6, blsp_uart6, blsp_uim6,
+		    blsp2_spi, qdss_stm9, qdss_cti_trig_out_a, dac_calib11,
+		    qdss_stm8, cci_timer0, qdss_stm13, dac_calib7, cci_timer1,
+		    qdss_stm12, dac_calib8, cci_timer2, blsp1_spi, qdss_stm11,
+		    dac_calib9, cci_timer3, cci_async, dac_calib12, blsp_i2c6,
+		    qdss_tracectl_a, dac_calib13, qdss_traceclk_a, dac_calib14,
+		    dac_calib15, hdmi_rcv, dac_calib16, hdmi_cec, pwr_modem,
+		    dac_calib17, hdmi_ddc, pwr_nav, dac_calib18, pwr_crypto,
+		    dac_calib19, hdmi_hot, dac_calib20, dac_calib21, pci_e0,
+		    dac_calib22, dac_calib23, dac_calib24, tsif1_sync, dac_calib25,
+		    sd_write, tsif1_error, blsp_spi2, blsp_uart2, blsp_uim2,
+		    qdss_cti, blsp_i2c2, blsp_spi3, blsp_uart3, blsp_uim3, blsp_i2c3,
+		    uim3, blsp_spi9, blsp_uart9, blsp_uim9, blsp10_spi, blsp_i2c9,
+		    blsp_spi7, blsp_uart7, blsp_uim7, qdss_tracedata_a, blsp_i2c7,
+		    qua_mi2s, gcc_gp1_clk_a, ssc_irq, uim4, blsp_spi11, blsp_uart11,
+		    blsp_uim11, gcc_gp2_clk_a, gcc_gp3_clk_a, blsp_i2c11, cri_trng0,
+		    cri_trng1, cri_trng, qdss_stm18, pri_mi2s, qdss_stm17, blsp_spi4,
+		    blsp_uart4, blsp_uim4, qdss_stm16, qdss_stm15, blsp_i2c4,
+		    qdss_stm14, dac_calib26, spkr_i2s, audio_ref, lpass_slimbus,
+		    isense_dbg, tsense_pwm1, tsense_pwm2, btfm_slimbus, ter_mi2s,
+		    qdss_stm22, qdss_stm21, qdss_stm20, qdss_stm19, gcc_gp1_clk_b,
+		    sec_mi2s, blsp_spi5, blsp_uart5, blsp_uim5, gcc_gp2_clk_b,
+		    gcc_gp3_clk_b, blsp_i2c5, blsp_spi12, blsp_uart12, blsp_uim12,
+		    qdss_stm25, qdss_stm31, blsp_i2c12, qdss_stm30, qdss_stm29,
+		    tsif1_clk, qdss_stm28, tsif1_en, tsif1_data, sdc4_cmd, qdss_stm27,
+		    qdss_traceclk_b, tsif2_error, sdc43, vfr_1, qdss_stm26, tsif2_clk,
+		    sdc4_clk, qdss_stm24, tsif2_en, sdc42, qdss_stm23, qdss_tracectl_b,
+		    sd_card, tsif2_data, sdc41, tsif2_sync, sdc40, mdp_vsync_p_b,
+		    ldo_en, mdp_vsync_s_b, ldo_update, blsp11_uart_tx_b, blsp11_uart_rx_b,
+		    blsp11_i2c_sda_b, prng_rosc, blsp11_i2c_scl_b, uim2, uim1, uim_batt,
+		    pci_e2, pa_indicator, adsp_ext, ddr_bist, qdss_tracedata_11,
+		    qdss_tracedata_12, modem_tsync, nav_dr, nav_pps, pci_e1, gsm_tx,
+		    qspi_cs, ssbi2, ssbi1, mss_lte, qspi_clk, qspi0, qspi1, qspi2, qspi3,
+		    gpio
+
+- bias-disable:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins should be configued as no pull.
+
+- bias-pull-down:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins should be configued as pull down.
+
+- bias-pull-up:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins should be configued as pull up.
+
+- output-high:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins are configured in output mode, driven
+		    high.
+		    Not valid for sdc pins.
+
+- output-low:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins are configured in output mode, driven
+		    low.
+		    Not valid for sdc pins.
+
+- drive-strength:
+	Usage: optional
+	Value type: <u32>
+	Definition: Selects the drive strength for the specified pins, in mA.
+		    Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16
+
+Example:
+
+	tlmm: pinctrl@1010000 {
+		compatible = "qcom,sdm660-pinctrl";
+		reg = <0x1010000 0x300000>;
+		interrupts = <0 208 0>;
+		gpio-controller;
+		gpio-ranges = <&tlmm 0 0 114>;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+
+		uart_console_active: uart_console_active {
+			mux {
+				pins = "gpio4", "gpio5";
+				function = "blsp_uart8";
+			};
+
+			config {
+				pins = "gpio4", "gpio5";
+				drive-strength = <2>;
+				bias-disable;
+			};
+		};
+	};
diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
index 195492033075..091beadb8a1c 100644
--- a/drivers/pinctrl/qcom/Kconfig
+++ b/drivers/pinctrl/qcom/Kconfig
@@ -147,6 +147,16 @@  config PINCTRL_QCOM_SSBI_PMIC
          which are using SSBI for communication with SoC. Example PMIC's
          devices are pm8058 and pm8921.
 
+config PINCTRL_SDM660
+       tristate "Qualcomm Technologies Inc SDM660 pin controller driver"
+       depends on GPIOLIB && OF
+       select PINCTRL_MSM
+       help
+         This is the pinctrl, pinmux, pinconf and gpiolib driver for the
+         Qualcomm Technologies Inc TLMM block found on the Qualcomm
+         Technologies Inc SDM660 platform.
+
+
 config PINCTRL_SDM845
        tristate "Qualcomm Technologies Inc SDM845 pin controller driver"
        depends on GPIOLIB && OF
diff --git a/drivers/pinctrl/qcom/Makefile b/drivers/pinctrl/qcom/Makefile
index 0c6f3ddc296d..9b08808a2f1c 100644
--- a/drivers/pinctrl/qcom/Makefile
+++ b/drivers/pinctrl/qcom/Makefile
@@ -19,4 +19,5 @@  obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-gpio.o
 obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-mpp.o
 obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-gpio.o
 obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-mpp.o
+obj-$(CONFIG_PINCTRL_SDM660)   += pinctrl-sdm660.o
 obj-$(CONFIG_PINCTRL_SDM845) += pinctrl-sdm845.o
diff --git a/drivers/pinctrl/qcom/pinctrl-sdm660.c b/drivers/pinctrl/qcom/pinctrl-sdm660.c
new file mode 100644
index 000000000000..ded56111f168
--- /dev/null
+++ b/drivers/pinctrl/qcom/pinctrl-sdm660.c
@@ -0,0 +1,1451 @@ 
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2016, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2018, Craig Tatlor.
+ */
+
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/pinctrl/pinctrl.h>
+
+#include "pinctrl-msm.h"
+
+#define NORTH	0x00900000
+#define CENTER	0x00500000
+#define SOUTH	0x00100000
+#define REG_SIZE 0x1000
+
+#define FUNCTION(fname)					\
+	[msm_mux_##fname] = {		                \
+		.name = #fname,				\
+		.groups = fname##_groups,               \
+		.ngroups = ARRAY_SIZE(fname##_groups),	\
+	}
+
+
+#define PINGROUP(id, base, f1, f2, f3, f4, f5, f6, f7, f8, f9)	\
+	{					        \
+		.name = "gpio" #id,			\
+		.pins = gpio##id##_pins,		\
+		.npins = (unsigned)ARRAY_SIZE(gpio##id##_pins),	\
+		.funcs = (int[]){			\
+			msm_mux_gpio, /* gpio mode */	\
+			msm_mux_##f1,			\
+			msm_mux_##f2,			\
+			msm_mux_##f3,			\
+			msm_mux_##f4,			\
+			msm_mux_##f5,			\
+			msm_mux_##f6,			\
+			msm_mux_##f7,			\
+			msm_mux_##f8,			\
+			msm_mux_##f9			\
+		},				        \
+		.nfuncs = 10,				\
+		.ctl_reg = base + REG_SIZE * id,	\
+		.io_reg = base + 0x4 + REG_SIZE * id,		\
+		.intr_cfg_reg = base + 0x8 + REG_SIZE * id,		\
+		.intr_status_reg = base + 0xc + REG_SIZE * id,	\
+		.intr_target_reg = base + 0x8 + REG_SIZE * id,	\
+		.mux_bit = 2,			\
+		.pull_bit = 0,			\
+		.drv_bit = 6,			\
+		.oe_bit = 9,			\
+		.in_bit = 0,			\
+		.out_bit = 1,			\
+		.intr_enable_bit = 0,		\
+		.intr_status_bit = 0,		\
+		.intr_target_bit = 5,		\
+		.intr_target_kpss_val = 3,	\
+		.intr_raw_status_bit = 4,	\
+		.intr_polarity_bit = 1,		\
+		.intr_detection_bit = 2,	\
+		.intr_detection_width = 2,	\
+	}
+
+#define SDC_QDSD_PINGROUP(pg_name, ctl, pull, drv)	\
+	{					        \
+		.name = #pg_name,			\
+		.pins = pg_name##_pins,			\
+		.npins = (unsigned)ARRAY_SIZE(pg_name##_pins),	\
+		.ctl_reg = ctl,				\
+		.io_reg = 0,				\
+		.intr_cfg_reg = 0,			\
+		.intr_status_reg = 0,			\
+		.intr_target_reg = 0,			\
+		.mux_bit = -1,				\
+		.pull_bit = pull,			\
+		.drv_bit = drv,				\
+		.oe_bit = -1,				\
+		.in_bit = -1,				\
+		.out_bit = -1,				\
+		.intr_enable_bit = -1,			\
+		.intr_status_bit = -1,			\
+		.intr_target_bit = -1,			\
+		.intr_raw_status_bit = -1,		\
+		.intr_polarity_bit = -1,		\
+		.intr_detection_bit = -1,		\
+		.intr_detection_width = -1,		\
+	}
+
+static const struct pinctrl_pin_desc sdm660_pins[] = {
+	PINCTRL_PIN(0, "GPIO_0"),
+	PINCTRL_PIN(1, "GPIO_1"),
+	PINCTRL_PIN(2, "GPIO_2"),
+	PINCTRL_PIN(3, "GPIO_3"),
+	PINCTRL_PIN(4, "GPIO_4"),
+	PINCTRL_PIN(5, "GPIO_5"),
+	PINCTRL_PIN(6, "GPIO_6"),
+	PINCTRL_PIN(7, "GPIO_7"),
+	PINCTRL_PIN(8, "GPIO_8"),
+	PINCTRL_PIN(9, "GPIO_9"),
+	PINCTRL_PIN(10, "GPIO_10"),
+	PINCTRL_PIN(11, "GPIO_11"),
+	PINCTRL_PIN(12, "GPIO_12"),
+	PINCTRL_PIN(13, "GPIO_13"),
+	PINCTRL_PIN(14, "GPIO_14"),
+	PINCTRL_PIN(15, "GPIO_15"),
+	PINCTRL_PIN(16, "GPIO_16"),
+	PINCTRL_PIN(17, "GPIO_17"),
+	PINCTRL_PIN(18, "GPIO_18"),
+	PINCTRL_PIN(19, "GPIO_19"),
+	PINCTRL_PIN(20, "GPIO_20"),
+	PINCTRL_PIN(21, "GPIO_21"),
+	PINCTRL_PIN(22, "GPIO_22"),
+	PINCTRL_PIN(23, "GPIO_23"),
+	PINCTRL_PIN(24, "GPIO_24"),
+	PINCTRL_PIN(25, "GPIO_25"),
+	PINCTRL_PIN(26, "GPIO_26"),
+	PINCTRL_PIN(27, "GPIO_27"),
+	PINCTRL_PIN(28, "GPIO_28"),
+	PINCTRL_PIN(29, "GPIO_29"),
+	PINCTRL_PIN(30, "GPIO_30"),
+	PINCTRL_PIN(31, "GPIO_31"),
+	PINCTRL_PIN(32, "GPIO_32"),
+	PINCTRL_PIN(33, "GPIO_33"),
+	PINCTRL_PIN(34, "GPIO_34"),
+	PINCTRL_PIN(35, "GPIO_35"),
+	PINCTRL_PIN(36, "GPIO_36"),
+	PINCTRL_PIN(37, "GPIO_37"),
+	PINCTRL_PIN(38, "GPIO_38"),
+	PINCTRL_PIN(39, "GPIO_39"),
+	PINCTRL_PIN(40, "GPIO_40"),
+	PINCTRL_PIN(41, "GPIO_41"),
+	PINCTRL_PIN(42, "GPIO_42"),
+	PINCTRL_PIN(43, "GPIO_43"),
+	PINCTRL_PIN(44, "GPIO_44"),
+	PINCTRL_PIN(45, "GPIO_45"),
+	PINCTRL_PIN(46, "GPIO_46"),
+	PINCTRL_PIN(47, "GPIO_47"),
+	PINCTRL_PIN(48, "GPIO_48"),
+	PINCTRL_PIN(49, "GPIO_49"),
+	PINCTRL_PIN(50, "GPIO_50"),
+	PINCTRL_PIN(51, "GPIO_51"),
+	PINCTRL_PIN(52, "GPIO_52"),
+	PINCTRL_PIN(53, "GPIO_53"),
+	PINCTRL_PIN(54, "GPIO_54"),
+	PINCTRL_PIN(55, "GPIO_55"),
+	PINCTRL_PIN(56, "GPIO_56"),
+	PINCTRL_PIN(57, "GPIO_57"),
+	PINCTRL_PIN(58, "GPIO_58"),
+	PINCTRL_PIN(59, "GPIO_59"),
+	PINCTRL_PIN(60, "GPIO_60"),
+	PINCTRL_PIN(61, "GPIO_61"),
+	PINCTRL_PIN(62, "GPIO_62"),
+	PINCTRL_PIN(63, "GPIO_63"),
+	PINCTRL_PIN(64, "GPIO_64"),
+	PINCTRL_PIN(65, "GPIO_65"),
+	PINCTRL_PIN(66, "GPIO_66"),
+	PINCTRL_PIN(67, "GPIO_67"),
+	PINCTRL_PIN(68, "GPIO_68"),
+	PINCTRL_PIN(69, "GPIO_69"),
+	PINCTRL_PIN(70, "GPIO_70"),
+	PINCTRL_PIN(71, "GPIO_71"),
+	PINCTRL_PIN(72, "GPIO_72"),
+	PINCTRL_PIN(73, "GPIO_73"),
+	PINCTRL_PIN(74, "GPIO_74"),
+	PINCTRL_PIN(75, "GPIO_75"),
+	PINCTRL_PIN(76, "GPIO_76"),
+	PINCTRL_PIN(77, "GPIO_77"),
+	PINCTRL_PIN(78, "GPIO_78"),
+	PINCTRL_PIN(79, "GPIO_79"),
+	PINCTRL_PIN(80, "GPIO_80"),
+	PINCTRL_PIN(81, "GPIO_81"),
+	PINCTRL_PIN(82, "GPIO_82"),
+	PINCTRL_PIN(83, "GPIO_83"),
+	PINCTRL_PIN(84, "GPIO_84"),
+	PINCTRL_PIN(85, "GPIO_85"),
+	PINCTRL_PIN(86, "GPIO_86"),
+	PINCTRL_PIN(87, "GPIO_87"),
+	PINCTRL_PIN(88, "GPIO_88"),
+	PINCTRL_PIN(89, "GPIO_89"),
+	PINCTRL_PIN(90, "GPIO_90"),
+	PINCTRL_PIN(91, "GPIO_91"),
+	PINCTRL_PIN(92, "GPIO_92"),
+	PINCTRL_PIN(93, "GPIO_93"),
+	PINCTRL_PIN(94, "GPIO_94"),
+	PINCTRL_PIN(95, "GPIO_95"),
+	PINCTRL_PIN(96, "GPIO_96"),
+	PINCTRL_PIN(97, "GPIO_97"),
+	PINCTRL_PIN(98, "GPIO_98"),
+	PINCTRL_PIN(99, "GPIO_99"),
+	PINCTRL_PIN(100, "GPIO_100"),
+	PINCTRL_PIN(101, "GPIO_101"),
+	PINCTRL_PIN(102, "GPIO_102"),
+	PINCTRL_PIN(103, "GPIO_103"),
+	PINCTRL_PIN(104, "GPIO_104"),
+	PINCTRL_PIN(105, "GPIO_105"),
+	PINCTRL_PIN(106, "GPIO_106"),
+	PINCTRL_PIN(107, "GPIO_107"),
+	PINCTRL_PIN(108, "GPIO_108"),
+	PINCTRL_PIN(109, "GPIO_109"),
+	PINCTRL_PIN(110, "GPIO_110"),
+	PINCTRL_PIN(111, "GPIO_111"),
+	PINCTRL_PIN(112, "GPIO_112"),
+	PINCTRL_PIN(113, "GPIO_113"),
+	PINCTRL_PIN(114, "SDC1_CLK"),
+	PINCTRL_PIN(115, "SDC1_CMD"),
+	PINCTRL_PIN(116, "SDC1_DATA"),
+	PINCTRL_PIN(117, "SDC2_CLK"),
+	PINCTRL_PIN(118, "SDC2_CMD"),
+	PINCTRL_PIN(119, "SDC2_DATA"),
+	PINCTRL_PIN(120, "SDC1_RCLK"),
+};
+
+#define DECLARE_MSM_GPIO_PINS(pin) \
+	static const unsigned int gpio##pin##_pins[] = { pin }
+DECLARE_MSM_GPIO_PINS(0);
+DECLARE_MSM_GPIO_PINS(1);
+DECLARE_MSM_GPIO_PINS(2);
+DECLARE_MSM_GPIO_PINS(3);
+DECLARE_MSM_GPIO_PINS(4);
+DECLARE_MSM_GPIO_PINS(5);
+DECLARE_MSM_GPIO_PINS(6);
+DECLARE_MSM_GPIO_PINS(7);
+DECLARE_MSM_GPIO_PINS(8);
+DECLARE_MSM_GPIO_PINS(9);
+DECLARE_MSM_GPIO_PINS(10);
+DECLARE_MSM_GPIO_PINS(11);
+DECLARE_MSM_GPIO_PINS(12);
+DECLARE_MSM_GPIO_PINS(13);
+DECLARE_MSM_GPIO_PINS(14);
+DECLARE_MSM_GPIO_PINS(15);
+DECLARE_MSM_GPIO_PINS(16);
+DECLARE_MSM_GPIO_PINS(17);
+DECLARE_MSM_GPIO_PINS(18);
+DECLARE_MSM_GPIO_PINS(19);
+DECLARE_MSM_GPIO_PINS(20);
+DECLARE_MSM_GPIO_PINS(21);
+DECLARE_MSM_GPIO_PINS(22);
+DECLARE_MSM_GPIO_PINS(23);
+DECLARE_MSM_GPIO_PINS(24);
+DECLARE_MSM_GPIO_PINS(25);
+DECLARE_MSM_GPIO_PINS(26);
+DECLARE_MSM_GPIO_PINS(27);
+DECLARE_MSM_GPIO_PINS(28);
+DECLARE_MSM_GPIO_PINS(29);
+DECLARE_MSM_GPIO_PINS(30);
+DECLARE_MSM_GPIO_PINS(31);
+DECLARE_MSM_GPIO_PINS(32);
+DECLARE_MSM_GPIO_PINS(33);
+DECLARE_MSM_GPIO_PINS(34);
+DECLARE_MSM_GPIO_PINS(35);
+DECLARE_MSM_GPIO_PINS(36);
+DECLARE_MSM_GPIO_PINS(37);
+DECLARE_MSM_GPIO_PINS(38);
+DECLARE_MSM_GPIO_PINS(39);
+DECLARE_MSM_GPIO_PINS(40);
+DECLARE_MSM_GPIO_PINS(41);
+DECLARE_MSM_GPIO_PINS(42);
+DECLARE_MSM_GPIO_PINS(43);
+DECLARE_MSM_GPIO_PINS(44);
+DECLARE_MSM_GPIO_PINS(45);
+DECLARE_MSM_GPIO_PINS(46);
+DECLARE_MSM_GPIO_PINS(47);
+DECLARE_MSM_GPIO_PINS(48);
+DECLARE_MSM_GPIO_PINS(49);
+DECLARE_MSM_GPIO_PINS(50);
+DECLARE_MSM_GPIO_PINS(51);
+DECLARE_MSM_GPIO_PINS(52);
+DECLARE_MSM_GPIO_PINS(53);
+DECLARE_MSM_GPIO_PINS(54);
+DECLARE_MSM_GPIO_PINS(55);
+DECLARE_MSM_GPIO_PINS(56);
+DECLARE_MSM_GPIO_PINS(57);
+DECLARE_MSM_GPIO_PINS(58);
+DECLARE_MSM_GPIO_PINS(59);
+DECLARE_MSM_GPIO_PINS(60);
+DECLARE_MSM_GPIO_PINS(61);
+DECLARE_MSM_GPIO_PINS(62);
+DECLARE_MSM_GPIO_PINS(63);
+DECLARE_MSM_GPIO_PINS(64);
+DECLARE_MSM_GPIO_PINS(65);
+DECLARE_MSM_GPIO_PINS(66);
+DECLARE_MSM_GPIO_PINS(67);
+DECLARE_MSM_GPIO_PINS(68);
+DECLARE_MSM_GPIO_PINS(69);
+DECLARE_MSM_GPIO_PINS(70);
+DECLARE_MSM_GPIO_PINS(71);
+DECLARE_MSM_GPIO_PINS(72);
+DECLARE_MSM_GPIO_PINS(73);
+DECLARE_MSM_GPIO_PINS(74);
+DECLARE_MSM_GPIO_PINS(75);
+DECLARE_MSM_GPIO_PINS(76);
+DECLARE_MSM_GPIO_PINS(77);
+DECLARE_MSM_GPIO_PINS(78);
+DECLARE_MSM_GPIO_PINS(79);
+DECLARE_MSM_GPIO_PINS(80);
+DECLARE_MSM_GPIO_PINS(81);
+DECLARE_MSM_GPIO_PINS(82);
+DECLARE_MSM_GPIO_PINS(83);
+DECLARE_MSM_GPIO_PINS(84);
+DECLARE_MSM_GPIO_PINS(85);
+DECLARE_MSM_GPIO_PINS(86);
+DECLARE_MSM_GPIO_PINS(87);
+DECLARE_MSM_GPIO_PINS(88);
+DECLARE_MSM_GPIO_PINS(89);
+DECLARE_MSM_GPIO_PINS(90);
+DECLARE_MSM_GPIO_PINS(91);
+DECLARE_MSM_GPIO_PINS(92);
+DECLARE_MSM_GPIO_PINS(93);
+DECLARE_MSM_GPIO_PINS(94);
+DECLARE_MSM_GPIO_PINS(95);
+DECLARE_MSM_GPIO_PINS(96);
+DECLARE_MSM_GPIO_PINS(97);
+DECLARE_MSM_GPIO_PINS(98);
+DECLARE_MSM_GPIO_PINS(99);
+DECLARE_MSM_GPIO_PINS(100);
+DECLARE_MSM_GPIO_PINS(101);
+DECLARE_MSM_GPIO_PINS(102);
+DECLARE_MSM_GPIO_PINS(103);
+DECLARE_MSM_GPIO_PINS(104);
+DECLARE_MSM_GPIO_PINS(105);
+DECLARE_MSM_GPIO_PINS(106);
+DECLARE_MSM_GPIO_PINS(107);
+DECLARE_MSM_GPIO_PINS(108);
+DECLARE_MSM_GPIO_PINS(109);
+DECLARE_MSM_GPIO_PINS(110);
+DECLARE_MSM_GPIO_PINS(111);
+DECLARE_MSM_GPIO_PINS(112);
+DECLARE_MSM_GPIO_PINS(113);
+
+static const unsigned int sdc1_clk_pins[] = { 114 };
+static const unsigned int sdc1_cmd_pins[] = { 115 };
+static const unsigned int sdc1_data_pins[] = { 116 };
+static const unsigned int sdc2_clk_pins[] = { 117 };
+static const unsigned int sdc2_cmd_pins[] = { 118 };
+static const unsigned int sdc2_data_pins[] = { 119 };
+static const unsigned int sdc1_rclk_pins[] = { 120 };
+
+enum sdm660_functions {
+	msm_mux_blsp_spi1,
+	msm_mux_gpio,
+	msm_mux_blsp_uim1,
+	msm_mux_tgu_ch0,
+	msm_mux_qdss_gpio4,
+	msm_mux_atest_gpsadc1,
+	msm_mux_blsp_uart1,
+	msm_mux_phase_flag14,
+	msm_mux_blsp_i2c2,
+	msm_mux_phase_flag31,
+	msm_mux_blsp_spi3,
+	msm_mux_blsp_spi3_cs1,
+	msm_mux_blsp_spi3_cs2,
+	msm_mux_wlan1_adc1,
+	msm_mux_atest_usb13,
+	msm_mux_tgu_ch1,
+	msm_mux_qdss_gpio5,
+	msm_mux_atest_gpsadc0,
+	msm_mux_blsp_i2c1,
+	msm_mux_ddr_bist,
+	msm_mux_atest_tsens2,
+	msm_mux_atest_usb1,
+	msm_mux_blsp_spi2,
+	msm_mux_blsp_uim2,
+	msm_mux_phase_flag3,
+	msm_mux_bimc_dte1,
+	msm_mux_wlan1_adc0,
+	msm_mux_atest_usb12,
+	msm_mux_bimc_dte0,
+	msm_mux_blsp_i2c3,
+	msm_mux_wlan2_adc1,
+	msm_mux_atest_usb11,
+	msm_mux_dbg_out,
+	msm_mux_wlan2_adc0,
+	msm_mux_atest_usb10,
+	msm_mux_blsp_spi4,
+	msm_mux_pri_mi2s,
+	msm_mux_phase_flag26,
+	msm_mux_qdss_cti0_a,
+	msm_mux_qdss_cti0_b,
+	msm_mux_qdss_cti1_a,
+	msm_mux_qdss_cti1_b,
+	msm_mux_pri_mi2s_ws,
+	msm_mux_phase_flag27,
+	msm_mux_blsp_i2c4,
+	msm_mux_phase_flag28,
+	msm_mux_blsp_uart5,
+	msm_mux_blsp_spi5,
+	msm_mux_blsp_uim5,
+	msm_mux_phase_flag5,
+	msm_mux_blsp_i2c5,
+	msm_mux_blsp_spi6,
+	msm_mux_blsp_uart2,
+	msm_mux_blsp_uim6,
+	msm_mux_phase_flag11,
+	msm_mux_vsense_data0,
+	msm_mux_blsp_i2c6,
+	msm_mux_phase_flag12,
+	msm_mux_vsense_data1,
+	msm_mux_phase_flag13,
+	msm_mux_vsense_mode,
+	msm_mux_blsp_spi7,
+	msm_mux_blsp_uart6_a,
+	msm_mux_blsp_uart6_b,
+	msm_mux_sec_mi2s,
+	msm_mux_sndwire_clk,
+	msm_mux_phase_flag17,
+	msm_mux_vsense_clkout,
+	msm_mux_sndwire_data,
+	msm_mux_phase_flag18,
+	msm_mux_blsp_i2c7,
+	msm_mux_phase_flag19,
+	msm_mux_vfr_1,
+	msm_mux_phase_flag20,
+	msm_mux_blsp_spi8_cs1,
+	msm_mux_blsp_spi8_cs2,
+	msm_mux_m_voc,
+	msm_mux_phase_flag21,
+	msm_mux_phase_flag22,
+	msm_mux_blsp_i2c8_a,
+	msm_mux_blsp_i2c8_b,
+	msm_mux_phase_flag23,
+	msm_mux_pwr_modem,
+	msm_mux_phase_flag24,
+	msm_mux_qdss_gpio,
+	msm_mux_cam_mclk,
+	msm_mux_pwr_nav,
+	msm_mux_qdss_gpio0,
+	msm_mux_qspi_data0,
+	msm_mux_pwr_crypto,
+	msm_mux_qdss_gpio1,
+	msm_mux_qspi_data1,
+	msm_mux_agera_pll,
+	msm_mux_qdss_gpio2,
+	msm_mux_qspi_data2,
+	msm_mux_jitter_bist,
+	msm_mux_qdss_gpio3,
+	msm_mux_qdss_gpio7,
+	msm_mux_mdss_vsync0,
+	msm_mux_mdss_vsync1,
+	msm_mux_mdss_vsync2,
+	msm_mux_mdss_vsync3,
+	msm_mux_qdss_gpio9,
+	msm_mux_atest_usb2,
+	msm_mux_cci_i2c,
+	msm_mux_pll_bypassnl,
+	msm_mux_atest_tsens,
+	msm_mux_atest_usb21,
+	msm_mux_pll_reset,
+	msm_mux_atest_usb23,
+	msm_mux_qdss_gpio6,
+	msm_mux_qspi_cs,
+	msm_mux_qdss_gpio10,
+	msm_mux_qdss_gpio11,
+	msm_mux_cci_async,
+	msm_mux_qdss_gpio12,
+	msm_mux_qdss_gpio13,
+	msm_mux_qspi_clk,
+	msm_mux_phase_flag30,
+	msm_mux_qdss_gpio14,
+	msm_mux_qspi_resetn,
+	msm_mux_phase_flag1,
+	msm_mux_qdss_gpio15,
+	msm_mux_phase_flag2,
+	msm_mux_phase_flag9,
+	msm_mux_qspi_data3,
+	msm_mux_phase_flag15,
+	msm_mux_qdss_gpio8,
+	msm_mux_phase_flag16,
+	msm_mux_phase_flag6,
+	msm_mux_phase_flag29,
+	msm_mux_phase_flag25,
+	msm_mux_phase_flag10,
+	msm_mux_atest_usb20,
+	msm_mux_gcc_gp1,
+	msm_mux_phase_flag4,
+	msm_mux_atest_usb22,
+	msm_mux_gcc_gp2,
+	msm_mux_atest_char,
+	msm_mux_mdp_vsync,
+	msm_mux_gcc_gp3,
+	msm_mux_atest_char3,
+	msm_mux_cri_trng0,
+	msm_mux_atest_char2,
+	msm_mux_cri_trng1,
+	msm_mux_atest_char1,
+	msm_mux_audio_ref,
+	msm_mux_cri_trng,
+	msm_mux_atest_char0,
+	msm_mux_blsp_spi8_a,
+	msm_mux_blsp_spi8_b,
+	msm_mux_sp_cmu,
+	msm_mux_nav_pps_a,
+	msm_mux_nav_pps_b,
+	msm_mux_nav_pps_c,
+	msm_mux_gps_tx_a,
+	msm_mux_gps_tx_b,
+	msm_mux_gps_tx_c,
+	msm_mux_adsp_ext,
+	msm_mux_ssc_irq,
+	msm_mux_isense_dbg,
+	msm_mux_phase_flag0,
+	msm_mux_phase_flag7,
+	msm_mux_phase_flag8,
+	msm_mux_tsense_pwm1,
+	msm_mux_tsense_pwm2,
+	msm_mux_mss_lte,
+	msm_mux_uim2_data,
+	msm_mux_uim2_clk,
+	msm_mux_uim2_reset,
+	msm_mux_uim2_present,
+	msm_mux_uim1_data,
+	msm_mux_uim1_clk,
+	msm_mux_uim1_reset,
+	msm_mux_uim1_present,
+	msm_mux_uim_batt,
+	msm_mux_pa_indicator,
+	msm_mux_ldo_en,
+	msm_mux_ldo_update,
+	msm_mux_qlink_request,
+	msm_mux_qlink_enable,
+	msm_mux_prng_rosc,
+	msm_mux__,
+};
+
+static const char * const gpio_groups[] = {
+	"gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
+	"gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
+	"gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
+	"gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
+	"gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
+	"gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
+	"gpio43", "gpio44", "gpio45", "gpio46", "gpio47", "gpio48", "gpio49",
+	"gpio50", "gpio51", "gpio52", "gpio53", "gpio54", "gpio55", "gpio56",
+	"gpio57", "gpio58", "gpio59", "gpio60", "gpio61", "gpio62", "gpio63",
+	"gpio64", "gpio65", "gpio66", "gpio67", "gpio68", "gpio69", "gpio70",
+	"gpio71", "gpio72", "gpio73", "gpio74", "gpio75", "gpio76", "gpio77",
+	"gpio78", "gpio79", "gpio80", "gpio81", "gpio82", "gpio83", "gpio84",
+	"gpio85", "gpio86", "gpio87", "gpio88", "gpio89", "gpio90", "gpio91",
+	"gpio92", "gpio93", "gpio94", "gpio95", "gpio96", "gpio97", "gpio98",
+	"gpio99", "gpio100", "gpio101", "gpio102", "gpio103", "gpio104",
+	"gpio105", "gpio106", "gpio107", "gpio108", "gpio109", "gpio110",
+	"gpio111", "gpio112", "gpio113",
+};
+static const char * const blsp_spi1_groups[] = {
+	"gpio0", "gpio1", "gpio2", "gpio3", "gpio46",
+};
+static const char * const blsp_uim1_groups[] = {
+	"gpio0", "gpio1",
+};
+static const char * const tgu_ch0_groups[] = {
+	"gpio0",
+};
+static const char * const qdss_gpio4_groups[] = {
+	"gpio0", "gpio36",
+};
+static const char * const atest_gpsadc1_groups[] = {
+	"gpio0",
+};
+static const char * const blsp_uart1_groups[] = {
+	"gpio0", "gpio1", "gpio2", "gpio3",
+};
+static const char * const phase_flag14_groups[] = {
+	"gpio5",
+};
+static const char * const blsp_i2c2_groups[] = {
+	"gpio6", "gpio7",
+};
+static const char * const phase_flag31_groups[] = {
+	"gpio6",
+};
+static const char * const blsp_spi3_groups[] = {
+	"gpio8", "gpio9", "gpio10", "gpio11",
+};
+static const char * const blsp_spi3_cs1_groups[] = {
+	"gpio30",
+};
+static const char * const blsp_spi3_cs2_groups[] = {
+	"gpio65",
+};
+static const char * const wlan1_adc1_groups[] = {
+	"gpio8",
+};
+static const char * const atest_usb13_groups[] = {
+	"gpio8",
+};
+static const char * const tgu_ch1_groups[] = {
+	"gpio1",
+};
+static const char * const qdss_gpio5_groups[] = {
+	"gpio1", "gpio37",
+};
+static const char * const atest_gpsadc0_groups[] = {
+	"gpio1",
+};
+static const char * const blsp_i2c1_groups[] = {
+	"gpio2", "gpio3",
+};
+static const char * const ddr_bist_groups[] = {
+	"gpio3", "gpio8", "gpio9", "gpio10",
+};
+static const char * const atest_tsens2_groups[] = {
+	"gpio3",
+};
+static const char * const atest_usb1_groups[] = {
+	"gpio3",
+};
+static const char * const blsp_spi2_groups[] = {
+	"gpio4", "gpio5", "gpio6", "gpio7",
+};
+static const char * const blsp_uim2_groups[] = {
+	"gpio4", "gpio5",
+};
+static const char * const phase_flag3_groups[] = {
+	"gpio4",
+};
+static const char * const bimc_dte1_groups[] = {
+	"gpio8", "gpio10",
+};
+static const char * const wlan1_adc0_groups[] = {
+	"gpio9",
+};
+static const char * const atest_usb12_groups[] = {
+	"gpio9",
+};
+static const char * const bimc_dte0_groups[] = {
+	"gpio9", "gpio11",
+};
+static const char * const blsp_i2c3_groups[] = {
+	"gpio10", "gpio11",
+};
+static const char * const wlan2_adc1_groups[] = {
+	"gpio10",
+};
+static const char * const atest_usb11_groups[] = {
+	"gpio10",
+};
+static const char * const dbg_out_groups[] = {
+	"gpio11",
+};
+static const char * const wlan2_adc0_groups[] = {
+	"gpio11",
+};
+static const char * const atest_usb10_groups[] = {
+	"gpio11",
+};
+static const char * const RCM_MARKER_groups[] = {
+	"gpio12", "gpio13",
+};
+static const char * const blsp_spi4_groups[] = {
+	"gpio12", "gpio13", "gpio14", "gpio15",
+};
+static const char * const pri_mi2s_groups[] = {
+	"gpio12", "gpio14", "gpio15", "gpio61",
+};
+static const char * const phase_flag26_groups[] = {
+	"gpio12",
+};
+static const char * const qdss_cti0_a_groups[] = {
+	"gpio49", "gpio50",
+};
+static const char * const qdss_cti0_b_groups[] = {
+	"gpio13", "gpio21",
+};
+static const char * const qdss_cti1_a_groups[] = {
+	"gpio53", "gpio55",
+};
+static const char * const qdss_cti1_b_groups[] = {
+	"gpio12", "gpio66",
+};
+static const char * const pri_mi2s_ws_groups[] = {
+	"gpio13",
+};
+static const char * const phase_flag27_groups[] = {
+	"gpio13",
+};
+static const char * const blsp_i2c4_groups[] = {
+	"gpio14", "gpio15",
+};
+static const char * const phase_flag28_groups[] = {
+	"gpio14",
+};
+static const char * const blsp_uart5_groups[] = {
+	"gpio16", "gpio17", "gpio18", "gpio19",
+};
+static const char * const blsp_spi5_groups[] = {
+	"gpio16", "gpio17", "gpio18", "gpio19",
+};
+static const char * const blsp_uim5_groups[] = {
+	"gpio16", "gpio17",
+};
+static const char * const phase_flag5_groups[] = {
+	"gpio17",
+};
+static const char * const blsp_i2c5_groups[] = {
+	"gpio18", "gpio19",
+};
+static const char * const blsp_spi6_groups[] = {
+	"gpio49", "gpio52", "gpio22", "gpio23",
+};
+static const char * const blsp_uart2_groups[] = {
+	"gpio4", "gpio5", "gpio6", "gpio7",
+};
+static const char * const blsp_uim6_groups[] = {
+	"gpio20", "gpio21",
+};
+static const char * const phase_flag11_groups[] = {
+	"gpio21",
+};
+static const char * const vsense_data0_groups[] = {
+	"gpio21",
+};
+static const char * const blsp_i2c6_groups[] = {
+	"gpio22", "gpio23",
+};
+static const char * const phase_flag12_groups[] = {
+	"gpio22",
+};
+static const char * const vsense_data1_groups[] = {
+	"gpio22",
+};
+static const char * const phase_flag13_groups[] = {
+	"gpio23",
+};
+static const char * const vsense_mode_groups[] = {
+	"gpio23",
+};
+static const char * const blsp_spi7_groups[] = {
+	"gpio24", "gpio25", "gpio26", "gpio27",
+};
+static const char * const blsp_uart6_a_groups[] = {
+	"gpio24", "gpio25", "gpio26", "gpio27",
+};
+static const char * const blsp_uart6_b_groups[] = {
+	"gpio28", "gpio29", "gpio30", "gpio31",
+};
+static const char * const sec_mi2s_groups[] = {
+	"gpio24", "gpio25", "gpio26", "gpio27", "gpio62",
+};
+static const char * const sndwire_clk_groups[] = {
+	"gpio24",
+};
+static const char * const phase_flag17_groups[] = {
+	"gpio24",
+};
+static const char * const vsense_clkout_groups[] = {
+	"gpio24",
+};
+static const char * const sndwire_data_groups[] = {
+	"gpio25",
+};
+static const char * const phase_flag18_groups[] = {
+	"gpio25",
+};
+static const char * const blsp_i2c7_groups[] = {
+	"gpio26", "gpio27",
+};
+static const char * const phase_flag19_groups[] = {
+	"gpio26",
+};
+static const char * const vfr_1_groups[] = {
+	"gpio27",
+};
+static const char * const phase_flag20_groups[] = {
+	"gpio27",
+};
+static const char * const NFC_INT_groups[] = {
+	"gpio28",
+};
+static const char * const blsp_spi8_a_groups[] = {
+	"gpio28", "gpio29", "gpio30", "gpio31",
+};
+static const char * const blsp_spi8_b_groups[] = {
+	"gpio40", "gpio41", "gpio44", "gpio52",
+};
+static const char * const m_voc_groups[] = {
+	"gpio28",
+};
+static const char * const phase_flag21_groups[] = {
+	"gpio28",
+};
+static const char * const phase_flag22_groups[] = {
+	"gpio29",
+};
+static const char * const blsp_i2c8_a_groups[] = {
+	"gpio30", "gpio31",
+};
+static const char * const blsp_i2c8_b_groups[] = {
+	"gpio44", "gpio52",
+};
+static const char * const phase_flag23_groups[] = {
+	"gpio30",
+};
+static const char * const NFC_ESE_groups[] = {
+	"gpio31",
+};
+static const char * const pwr_modem_groups[] = {
+	"gpio31",
+};
+static const char * const phase_flag24_groups[] = {
+	"gpio31",
+};
+static const char * const qdss_gpio_groups[] = {
+	"gpio31", "gpio52", "gpio68", "gpio69",
+};
+static const char * const cam_mclk_groups[] = {
+	"gpio32", "gpio33", "gpio34", "gpio35",
+};
+static const char * const pwr_nav_groups[] = {
+	"gpio32",
+};
+static const char * const qdss_gpio0_groups[] = {
+	"gpio32", "gpio67",
+};
+static const char * const qspi_data0_groups[] = {
+	"gpio33",
+};
+static const char * const pwr_crypto_groups[] = {
+	"gpio33",
+};
+static const char * const qdss_gpio1_groups[] = {
+	"gpio33", "gpio63",
+};
+static const char * const qspi_data1_groups[] = {
+	"gpio34",
+};
+static const char * const agera_pll_groups[] = {
+	"gpio34", "gpio36",
+};
+static const char * const qdss_gpio2_groups[] = {
+	"gpio34", "gpio64",
+};
+static const char * const qspi_data2_groups[] = {
+	"gpio35",
+};
+static const char * const jitter_bist_groups[] = {
+	"gpio35",
+};
+static const char * const qdss_gpio3_groups[] = {
+	"gpio35", "gpio56",
+};
+static const char * const qdss_gpio7_groups[] = {
+	"gpio39", "gpio71",
+};
+static const char * const mdss_vsync0_groups[] = {
+	"gpio42",
+};
+static const char * const mdss_vsync1_groups[] = {
+	"gpio42",
+};
+static const char * const mdss_vsync2_groups[] = {
+	"gpio42",
+};
+static const char * const mdss_vsync3_groups[] = {
+	"gpio42",
+};
+static const char * const qdss_gpio9_groups[] = {
+	"gpio42", "gpio76",
+};
+static const char * const atest_usb2_groups[] = {
+	"gpio35",
+};
+static const char * const cci_i2c_groups[] = {
+	"gpio36", "gpio37", "gpio38", "gpio39",
+};
+static const char * const pll_bypassnl_groups[] = {
+	"gpio36",
+};
+static const char * const atest_tsens_groups[] = {
+	"gpio36",
+};
+static const char * const atest_usb21_groups[] = {
+	"gpio36",
+};
+static const char * const pll_reset_groups[] = {
+	"gpio37",
+};
+static const char * const atest_usb23_groups[] = {
+	"gpio37",
+};
+static const char * const qdss_gpio6_groups[] = {
+	"gpio38", "gpio70",
+};
+static const char * const qspi_cs_groups[] = {
+	"gpio43", "gpio50",
+};
+static const char * const qdss_gpio10_groups[] = {
+	"gpio43", "gpio77",
+};
+static const char * const qdss_gpio11_groups[] = {
+	"gpio44", "gpio79",
+};
+static const char * const cci_async_groups[] = {
+	"gpio45",
+};
+static const char * const qdss_gpio12_groups[] = {
+	"gpio45", "gpio80",
+};
+static const char * const qdss_gpio13_groups[] = {
+	"gpio46", "gpio78",
+};
+static const char * const qspi_clk_groups[] = {
+	"gpio47",
+};
+static const char * const phase_flag30_groups[] = {
+	"gpio47",
+};
+static const char * const qdss_gpio14_groups[] = {
+	"gpio47", "gpio72",
+};
+static const char * const qspi_resetn_groups[] = {
+	"gpio48",
+};
+static const char * const phase_flag1_groups[] = {
+	"gpio48",
+};
+static const char * const qdss_gpio15_groups[] = {
+	"gpio48", "gpio73",
+};
+static const char * const phase_flag2_groups[] = {
+	"gpio49",
+};
+static const char * const phase_flag9_groups[] = {
+	"gpio50",
+};
+static const char * const qspi_data3_groups[] = {
+	"gpio51",
+};
+static const char * const phase_flag15_groups[] = {
+	"gpio51",
+};
+static const char * const qdss_gpio8_groups[] = {
+	"gpio51", "gpio75",
+};
+static const char * const phase_flag16_groups[] = {
+	"gpio52",
+};
+static const char * const phase_flag6_groups[] = {
+	"gpio53",
+};
+static const char * const phase_flag29_groups[] = {
+	"gpio54",
+};
+static const char * const phase_flag25_groups[] = {
+	"gpio55",
+};
+static const char * const phase_flag10_groups[] = {
+	"gpio56",
+};
+static const char * const atest_usb20_groups[] = {
+	"gpio56",
+};
+static const char * const gcc_gp1_groups[] = {
+	"gpio57", "gpio78",
+};
+static const char * const phase_flag4_groups[] = {
+	"gpio57",
+};
+static const char * const atest_usb22_groups[] = {
+	"gpio57",
+};
+static const char * const gcc_gp2_groups[] = {
+	"gpio58", "gpio81",
+};
+static const char * const atest_char_groups[] = {
+	"gpio58",
+};
+static const char * const mdp_vsync_groups[] = {
+	"gpio59", "gpio74",
+};
+static const char * const gcc_gp3_groups[] = {
+	"gpio59", "gpio82",
+};
+static const char * const atest_char3_groups[] = {
+	"gpio59",
+};
+static const char * const cri_trng0_groups[] = {
+	"gpio60",
+};
+static const char * const atest_char2_groups[] = {
+	"gpio60",
+};
+static const char * const cri_trng1_groups[] = {
+	"gpio61",
+};
+static const char * const atest_char1_groups[] = {
+	"gpio61",
+};
+static const char * const audio_ref_groups[] = {
+	"gpio62",
+};
+static const char * const cri_trng_groups[] = {
+	"gpio62",
+};
+static const char * const atest_char0_groups[] = {
+	"gpio62",
+};
+static const char * const blsp_spi8_cs1_groups[] = {
+	"gpio64",
+};
+static const char * const blsp_spi8_cs2_groups[] = {
+	"gpio76",
+};
+static const char * const sp_cmu_groups[] = {
+	"gpio64",
+};
+static const char * const nav_pps_a_groups[] = {
+	"gpio65",
+};
+static const char * const nav_pps_b_groups[] = {
+	"gpio98",
+};
+static const char * const nav_pps_c_groups[] = {
+	"gpio80",
+};
+static const char * const gps_tx_a_groups[] = {
+	"gpio65",
+};
+static const char * const gps_tx_b_groups[] = {
+	"gpio98",
+};
+static const char * const gps_tx_c_groups[] = {
+	"gpio80",
+};
+static const char * const adsp_ext_groups[] = {
+	"gpio65",
+};
+static const char * const ssc_irq_groups[] = {
+	"gpio67", "gpio68", "gpio69", "gpio70", "gpio71", "gpio72", "gpio74",
+	"gpio75", "gpio76",
+};
+static const char * const isense_dbg_groups[] = {
+	"gpio68",
+};
+static const char * const phase_flag0_groups[] = {
+	"gpio68",
+};
+static const char * const phase_flag7_groups[] = {
+	"gpio69",
+};
+static const char * const phase_flag8_groups[] = {
+	"gpio70",
+};
+static const char * const tsense_pwm1_groups[] = {
+	"gpio71",
+};
+static const char * const tsense_pwm2_groups[] = {
+	"gpio71",
+};
+static const char * const mss_lte_groups[] = {
+	"gpio81", "gpio82",
+};
+static const char * const uim2_data_groups[] = {
+	"gpio83",
+};
+static const char * const uim2_clk_groups[] = {
+	"gpio84",
+};
+static const char * const uim2_reset_groups[] = {
+	"gpio85",
+};
+static const char * const uim2_present_groups[] = {
+	"gpio86",
+};
+static const char * const uim1_data_groups[] = {
+	"gpio87",
+};
+static const char * const uim1_clk_groups[] = {
+	"gpio88",
+};
+static const char * const uim1_reset_groups[] = {
+	"gpio89",
+};
+static const char * const uim1_present_groups[] = {
+	"gpio90",
+};
+static const char * const uim_batt_groups[] = {
+	"gpio91",
+};
+static const char * const pa_indicator_groups[] = {
+	"gpio92",
+};
+static const char * const ldo_en_groups[] = {
+	"gpio97",
+};
+static const char * const ldo_update_groups[] = {
+	"gpio98",
+};
+static const char * const qlink_request_groups[] = {
+	"gpio99",
+};
+static const char * const qlink_enable_groups[] = {
+	"gpio100",
+};
+static const char * const prng_rosc_groups[] = {
+	"gpio102",
+};
+
+static const struct msm_function sdm660_functions[] = {
+	FUNCTION(blsp_spi1),
+	FUNCTION(gpio),
+	FUNCTION(blsp_uim1),
+	FUNCTION(tgu_ch0),
+	FUNCTION(qdss_gpio4),
+	FUNCTION(atest_gpsadc1),
+	FUNCTION(blsp_uart1),
+	FUNCTION(phase_flag14),
+	FUNCTION(blsp_i2c2),
+	FUNCTION(phase_flag31),
+	FUNCTION(blsp_spi3),
+	FUNCTION(blsp_spi3_cs1),
+	FUNCTION(blsp_spi3_cs2),
+	FUNCTION(wlan1_adc1),
+	FUNCTION(atest_usb13),
+	FUNCTION(tgu_ch1),
+	FUNCTION(qdss_gpio5),
+	FUNCTION(atest_gpsadc0),
+	FUNCTION(blsp_i2c1),
+	FUNCTION(ddr_bist),
+	FUNCTION(atest_tsens2),
+	FUNCTION(atest_usb1),
+	FUNCTION(blsp_spi2),
+	FUNCTION(blsp_uim2),
+	FUNCTION(phase_flag3),
+	FUNCTION(bimc_dte1),
+	FUNCTION(wlan1_adc0),
+	FUNCTION(atest_usb12),
+	FUNCTION(bimc_dte0),
+	FUNCTION(blsp_i2c3),
+	FUNCTION(wlan2_adc1),
+	FUNCTION(atest_usb11),
+	FUNCTION(dbg_out),
+	FUNCTION(wlan2_adc0),
+	FUNCTION(atest_usb10),
+	FUNCTION(blsp_spi4),
+	FUNCTION(pri_mi2s),
+	FUNCTION(phase_flag26),
+	FUNCTION(qdss_cti0_a),
+	FUNCTION(qdss_cti0_b),
+	FUNCTION(qdss_cti1_a),
+	FUNCTION(qdss_cti1_b),
+	FUNCTION(pri_mi2s_ws),
+	FUNCTION(phase_flag27),
+	FUNCTION(blsp_i2c4),
+	FUNCTION(phase_flag28),
+	FUNCTION(blsp_uart5),
+	FUNCTION(blsp_spi5),
+	FUNCTION(blsp_uim5),
+	FUNCTION(phase_flag5),
+	FUNCTION(blsp_i2c5),
+	FUNCTION(blsp_spi6),
+	FUNCTION(blsp_uart2),
+	FUNCTION(blsp_uim6),
+	FUNCTION(phase_flag11),
+	FUNCTION(vsense_data0),
+	FUNCTION(blsp_i2c6),
+	FUNCTION(phase_flag12),
+	FUNCTION(vsense_data1),
+	FUNCTION(phase_flag13),
+	FUNCTION(vsense_mode),
+	FUNCTION(blsp_spi7),
+	FUNCTION(blsp_uart6_a),
+	FUNCTION(blsp_uart6_b),
+	FUNCTION(sec_mi2s),
+	FUNCTION(sndwire_clk),
+	FUNCTION(phase_flag17),
+	FUNCTION(vsense_clkout),
+	FUNCTION(sndwire_data),
+	FUNCTION(phase_flag18),
+	FUNCTION(blsp_i2c7),
+	FUNCTION(phase_flag19),
+	FUNCTION(vfr_1),
+	FUNCTION(phase_flag20),
+	FUNCTION(blsp_spi8_cs1),
+	FUNCTION(blsp_spi8_cs2),
+	FUNCTION(m_voc),
+	FUNCTION(phase_flag21),
+	FUNCTION(phase_flag22),
+	FUNCTION(blsp_i2c8_a),
+	FUNCTION(blsp_i2c8_b),
+	FUNCTION(phase_flag23),
+	FUNCTION(pwr_modem),
+	FUNCTION(phase_flag24),
+	FUNCTION(qdss_gpio),
+	FUNCTION(cam_mclk),
+	FUNCTION(pwr_nav),
+	FUNCTION(qdss_gpio0),
+	FUNCTION(qspi_data0),
+	FUNCTION(pwr_crypto),
+	FUNCTION(qdss_gpio1),
+	FUNCTION(qspi_data1),
+	FUNCTION(agera_pll),
+	FUNCTION(qdss_gpio2),
+	FUNCTION(qspi_data2),
+	FUNCTION(jitter_bist),
+	FUNCTION(qdss_gpio3),
+	FUNCTION(qdss_gpio7),
+	FUNCTION(mdss_vsync0),
+	FUNCTION(mdss_vsync1),
+	FUNCTION(mdss_vsync2),
+	FUNCTION(mdss_vsync3),
+	FUNCTION(qdss_gpio9),
+	FUNCTION(atest_usb2),
+	FUNCTION(cci_i2c),
+	FUNCTION(pll_bypassnl),
+	FUNCTION(atest_tsens),
+	FUNCTION(atest_usb21),
+	FUNCTION(pll_reset),
+	FUNCTION(atest_usb23),
+	FUNCTION(qdss_gpio6),
+	FUNCTION(qspi_cs),
+	FUNCTION(qdss_gpio10),
+	FUNCTION(qdss_gpio11),
+	FUNCTION(cci_async),
+	FUNCTION(qdss_gpio12),
+	FUNCTION(qdss_gpio13),
+	FUNCTION(qspi_clk),
+	FUNCTION(phase_flag30),
+	FUNCTION(qdss_gpio14),
+	FUNCTION(qspi_resetn),
+	FUNCTION(phase_flag1),
+	FUNCTION(qdss_gpio15),
+	FUNCTION(phase_flag2),
+	FUNCTION(phase_flag9),
+	FUNCTION(qspi_data3),
+	FUNCTION(phase_flag15),
+	FUNCTION(qdss_gpio8),
+	FUNCTION(phase_flag16),
+	FUNCTION(phase_flag6),
+	FUNCTION(phase_flag29),
+	FUNCTION(phase_flag25),
+	FUNCTION(phase_flag10),
+	FUNCTION(atest_usb20),
+	FUNCTION(gcc_gp1),
+	FUNCTION(phase_flag4),
+	FUNCTION(atest_usb22),
+	FUNCTION(gcc_gp2),
+	FUNCTION(atest_char),
+	FUNCTION(mdp_vsync),
+	FUNCTION(gcc_gp3),
+	FUNCTION(atest_char3),
+	FUNCTION(cri_trng0),
+	FUNCTION(atest_char2),
+	FUNCTION(cri_trng1),
+	FUNCTION(atest_char1),
+	FUNCTION(audio_ref),
+	FUNCTION(cri_trng),
+	FUNCTION(atest_char0),
+	FUNCTION(blsp_spi8_a),
+	FUNCTION(blsp_spi8_b),
+	FUNCTION(sp_cmu),
+	FUNCTION(nav_pps_a),
+	FUNCTION(nav_pps_b),
+	FUNCTION(nav_pps_c),
+	FUNCTION(gps_tx_a),
+	FUNCTION(gps_tx_b),
+	FUNCTION(gps_tx_c),
+	FUNCTION(adsp_ext),
+	FUNCTION(ssc_irq),
+	FUNCTION(isense_dbg),
+	FUNCTION(phase_flag0),
+	FUNCTION(phase_flag7),
+	FUNCTION(phase_flag8),
+	FUNCTION(tsense_pwm1),
+	FUNCTION(tsense_pwm2),
+	FUNCTION(mss_lte),
+	FUNCTION(uim2_data),
+	FUNCTION(uim2_clk),
+	FUNCTION(uim2_reset),
+	FUNCTION(uim2_present),
+	FUNCTION(uim1_data),
+	FUNCTION(uim1_clk),
+	FUNCTION(uim1_reset),
+	FUNCTION(uim1_present),
+	FUNCTION(uim_batt),
+	FUNCTION(pa_indicator),
+	FUNCTION(ldo_en),
+	FUNCTION(ldo_update),
+	FUNCTION(qlink_request),
+	FUNCTION(qlink_enable),
+	FUNCTION(prng_rosc),
+};
+
+static const struct msm_pingroup sdm660_groups[] = {
+	PINGROUP(0, SOUTH, blsp_spi1, blsp_uart1, blsp_uim1, tgu_ch0, _, _, qdss_gpio4, atest_gpsadc1, _),
+	PINGROUP(1, SOUTH, blsp_spi1, blsp_uart1, blsp_uim1, tgu_ch1, _, _, qdss_gpio5, atest_gpsadc0, _),
+	PINGROUP(2, SOUTH, blsp_spi1, blsp_uart1, blsp_i2c1, _, _, _, _, _, _),
+	PINGROUP(3, SOUTH, blsp_spi1, blsp_uart1, blsp_i2c1, ddr_bist, _, _, atest_tsens2, atest_usb1, _),
+	PINGROUP(4, NORTH, blsp_spi2, blsp_uim2, blsp_uart2, phase_flag3, _, _, _, _, _),
+	PINGROUP(5, SOUTH, blsp_spi2, blsp_uim2, blsp_uart2, phase_flag14, _, _, _, _, _),
+	PINGROUP(6, SOUTH, blsp_spi2, blsp_i2c2, blsp_uart2, phase_flag31, _, _, _, _, _),
+	PINGROUP(7, SOUTH, blsp_spi2, blsp_i2c2, blsp_uart2, _, _, _, _, _, _),
+	PINGROUP(8, NORTH, blsp_spi3, ddr_bist, _, _, _, wlan1_adc1, atest_usb13, bimc_dte1, _),
+	PINGROUP(9, NORTH, blsp_spi3, ddr_bist, _, _, _, wlan1_adc0, atest_usb12, bimc_dte0, _),
+	PINGROUP(10, NORTH, blsp_spi3, blsp_i2c3, ddr_bist, _, _, wlan2_adc1, atest_usb11, bimc_dte1, _),
+	PINGROUP(11, NORTH, blsp_spi3, blsp_i2c3, _, dbg_out, wlan2_adc0, atest_usb10, bimc_dte0, _, _),
+	PINGROUP(12, NORTH, blsp_spi4, pri_mi2s, _, phase_flag26, qdss_cti1_b, _, _, _, _),
+	PINGROUP(13, NORTH, blsp_spi4, _, pri_mi2s_ws, _, _, phase_flag27, qdss_cti0_b, _, _),
+	PINGROUP(14, NORTH, blsp_spi4, blsp_i2c4, pri_mi2s, _, phase_flag28, _, _, _, _),
+	PINGROUP(15, NORTH, blsp_spi4, blsp_i2c4, pri_mi2s, _, _, _, _, _, _),
+	PINGROUP(16, CENTER, blsp_uart5, blsp_spi5, blsp_uim5, _, _, _, _, _, _),
+	PINGROUP(17, CENTER, blsp_uart5, blsp_spi5, blsp_uim5, _, phase_flag5, _, _, _, _),
+	PINGROUP(18, CENTER, blsp_uart5, blsp_spi5, blsp_i2c5, _, _, _, _, _, _),
+	PINGROUP(19, CENTER, blsp_uart5, blsp_spi5, blsp_i2c5, _, _, _, _, _, _),
+	PINGROUP(20, SOUTH, _, _, blsp_uim6, _, _, _, _, _, _),
+	PINGROUP(21, SOUTH, _, _, blsp_uim6, _, phase_flag11, qdss_cti0_b, vsense_data0, _, _),
+	PINGROUP(22, CENTER, blsp_spi6, _, blsp_i2c6, _, phase_flag12, vsense_data1, _, _, _),
+	PINGROUP(23, CENTER, blsp_spi6, _, blsp_i2c6, _, phase_flag13, vsense_mode, _, _, _),
+	PINGROUP(24, NORTH, blsp_spi7, blsp_uart6_a, sec_mi2s, sndwire_clk, _, _, phase_flag17, vsense_clkout, _),
+	PINGROUP(25, NORTH, blsp_spi7, blsp_uart6_a, sec_mi2s, sndwire_data, _, _, phase_flag18, _, _),
+	PINGROUP(26, NORTH, blsp_spi7, blsp_uart6_a, blsp_i2c7, sec_mi2s, _, phase_flag19, _, _, _),
+	PINGROUP(27, NORTH, blsp_spi7, blsp_uart6_a, blsp_i2c7, vfr_1, sec_mi2s, _, phase_flag20, _, _),
+	PINGROUP(28, CENTER, blsp_spi8_a, blsp_uart6_b, m_voc, _, phase_flag21, _, _, _, _),
+	PINGROUP(29, CENTER, blsp_spi8_a, blsp_uart6_b, _, _, phase_flag22, _, _, _, _),
+	PINGROUP(30, CENTER, blsp_spi8_a, blsp_uart6_b, blsp_i2c8_a, blsp_spi3_cs1, _, phase_flag23, _, _, _),
+	PINGROUP(31, CENTER, blsp_spi8_a, blsp_uart6_b, blsp_i2c8_a, pwr_modem, _, phase_flag24, qdss_gpio, _, _),
+	PINGROUP(32, SOUTH, cam_mclk, pwr_nav, _, _, qdss_gpio0, _, _, _, _),
+	PINGROUP(33, SOUTH, cam_mclk, qspi_data0, pwr_crypto, _, _, qdss_gpio1, _, _, _),
+	PINGROUP(34, SOUTH, cam_mclk, qspi_data1, agera_pll, _, _, qdss_gpio2, _, _, _),
+	PINGROUP(35, SOUTH, cam_mclk, qspi_data2, jitter_bist, _, _, qdss_gpio3, _, atest_usb2, _),
+	PINGROUP(36, SOUTH, cci_i2c, pll_bypassnl, agera_pll, _, _, qdss_gpio4, atest_tsens, atest_usb21, _),
+	PINGROUP(37, SOUTH, cci_i2c, pll_reset, _, _, qdss_gpio5, atest_usb23, _, _, _),
+	PINGROUP(38, SOUTH, cci_i2c, _, _, qdss_gpio6, _, _, _, _, _),
+	PINGROUP(39, SOUTH, cci_i2c, _, _, qdss_gpio7, _, _, _, _, _),
+	PINGROUP(40, SOUTH, _, _, blsp_spi8_b, _, _, _, _, _, _),
+	PINGROUP(41, SOUTH, _, _, blsp_spi8_b, _, _, _, _, _, _),
+	PINGROUP(42, SOUTH, mdss_vsync0, mdss_vsync1, mdss_vsync2, mdss_vsync3, _, _, qdss_gpio9, _, _),
+	PINGROUP(43, SOUTH, _, _, qspi_cs, _, _, qdss_gpio10, _, _, _),
+	PINGROUP(44, SOUTH, _, _, blsp_spi8_b, blsp_i2c8_b, _, _, qdss_gpio11, _, _),
+	PINGROUP(45, SOUTH, cci_async, _, _, qdss_gpio12, _, _, _, _, _),
+	PINGROUP(46, SOUTH, blsp_spi1, _, _, qdss_gpio13, _, _, _, _, _),
+	PINGROUP(47, SOUTH, qspi_clk, _, phase_flag30, qdss_gpio14, _, _, _, _, _),
+	PINGROUP(48, SOUTH, _, phase_flag1, qdss_gpio15, _, _, _, _, _, _),
+	PINGROUP(49, SOUTH, blsp_spi6, phase_flag2, qdss_cti0_a, _, _, _, _, _, _),
+	PINGROUP(50, SOUTH, qspi_cs, _, phase_flag9, qdss_cti0_a, _, _, _, _, _),
+	PINGROUP(51, SOUTH, qspi_data3, _, phase_flag15, qdss_gpio8, _, _, _, _, _),
+	PINGROUP(52, SOUTH, _, blsp_spi8_b, blsp_i2c8_b, blsp_spi6, phase_flag16, qdss_gpio, _, _, _),
+	PINGROUP(53, NORTH, _, phase_flag6, qdss_cti1_a, _, _, _, _, _, _),
+	PINGROUP(54, NORTH, _, _, phase_flag29, _, _, _, _, _, _),
+	PINGROUP(55, SOUTH, _, phase_flag25, qdss_cti1_a, _, _, _, _, _, _),
+	PINGROUP(56, SOUTH, _, phase_flag10, qdss_gpio3, _, atest_usb20, _, _, _, _),
+	PINGROUP(57, SOUTH, gcc_gp1, _, phase_flag4, atest_usb22, _, _, _, _, _),
+	PINGROUP(58, SOUTH, _, gcc_gp2, _, _, atest_char, _, _, _, _),
+	PINGROUP(59, NORTH, mdp_vsync, gcc_gp3, _, _, atest_char3, _, _, _, _),
+	PINGROUP(60, NORTH, cri_trng0, _, _, atest_char2, _, _, _, _, _),
+	PINGROUP(61, NORTH, pri_mi2s, cri_trng1, _, _, atest_char1, _, _, _, _),
+	PINGROUP(62, NORTH, sec_mi2s, audio_ref, _, cri_trng, _, _, atest_char0, _, _),
+	PINGROUP(63, NORTH, _, _, _, qdss_gpio1, _, _, _, _, _),
+	PINGROUP(64, SOUTH, blsp_spi8_cs1, sp_cmu, _, _, qdss_gpio2, _, _, _, _),
+	PINGROUP(65, SOUTH, _, nav_pps_a, nav_pps_a, gps_tx_a, blsp_spi3_cs2, adsp_ext, _, _, _),
+	PINGROUP(66, NORTH, _, _, qdss_cti1_b, _, _, _, _, _, _),
+	PINGROUP(67, NORTH, _, _, qdss_gpio0, _, _, _, _, _, _),
+	PINGROUP(68, NORTH, isense_dbg, _, phase_flag0, qdss_gpio, _, _, _, _, _),
+	PINGROUP(69, NORTH, _, phase_flag7, qdss_gpio, _, _, _, _, _, _),
+	PINGROUP(70, NORTH, _, phase_flag8, qdss_gpio6, _, _, _, _, _, _),
+	PINGROUP(71, NORTH, _, _, qdss_gpio7, tsense_pwm1, tsense_pwm2, _, _, _, _),
+	PINGROUP(72, NORTH, _, qdss_gpio14, _, _, _, _, _, _, _),
+	PINGROUP(73, NORTH, _, _, qdss_gpio15, _, _, _, _, _, _),
+	PINGROUP(74, NORTH, mdp_vsync, _, _, _, _, _, _, _, _),
+	PINGROUP(75, NORTH, _, _, qdss_gpio8, _, _, _, _, _, _),
+	PINGROUP(76, NORTH, blsp_spi8_cs2, _, _, _, qdss_gpio9, _, _, _, _),
+	PINGROUP(77, NORTH, _, _, qdss_gpio10, _, _, _, _, _, _),
+	PINGROUP(78, NORTH, gcc_gp1, _, qdss_gpio13, _, _, _, _, _, _),
+	PINGROUP(79, SOUTH, _, _, qdss_gpio11, _, _, _, _, _, _),
+	PINGROUP(80, SOUTH, nav_pps_b, nav_pps_b, gps_tx_c, _, _, qdss_gpio12, _, _, _),
+	PINGROUP(81, CENTER, mss_lte, gcc_gp2, _, _, _, _, _, _, _),
+	PINGROUP(82, CENTER, mss_lte, gcc_gp3, _, _, _, _, _, _, _),
+	PINGROUP(83, SOUTH, uim2_data, _, _, _, _, _, _, _, _),
+	PINGROUP(84, SOUTH, uim2_clk, _, _, _, _, _, _, _, _),
+	PINGROUP(85, SOUTH, uim2_reset, _, _, _, _, _, _, _, _),
+	PINGROUP(86, SOUTH, uim2_present, _, _, _, _, _, _, _, _),
+	PINGROUP(87, SOUTH, uim1_data, _, _, _, _, _, _, _, _),
+	PINGROUP(88, SOUTH, uim1_clk, _, _, _, _, _, _, _, _),
+	PINGROUP(89, SOUTH, uim1_reset, _, _, _, _, _, _, _, _),
+	PINGROUP(90, SOUTH, uim1_present, _, _, _, _, _, _, _, _),
+	PINGROUP(91, SOUTH, uim_batt, _, _, _, _, _, _, _, _),
+	PINGROUP(92, SOUTH, _, _, pa_indicator, _, _, _, _, _, _),
+	PINGROUP(93, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(94, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(95, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(96, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(97, SOUTH, _, ldo_en, _, _, _, _, _, _, _),
+	PINGROUP(98, SOUTH, _, nav_pps_c, nav_pps_c, gps_tx_b, ldo_update, _, _, _, _),
+	PINGROUP(99, SOUTH, qlink_request, _, _, _, _, _, _, _, _),
+	PINGROUP(100, SOUTH, qlink_enable, _, _, _, _, _, _, _, _),
+	PINGROUP(101, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(102, SOUTH, _, prng_rosc, _, _, _, _, _, _, _),
+	PINGROUP(103, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(104, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(105, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(106, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(107, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(108, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(109, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(110, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(111, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(112, SOUTH, _, _, _, _, _, _, _, _, _),
+	PINGROUP(113, SOUTH, _, _, _, _, _, _, _, _, _),
+	SDC_QDSD_PINGROUP(sdc1_clk, 0x99a000, 13, 6),
+	SDC_QDSD_PINGROUP(sdc1_cmd, 0x99a000, 11, 3),
+	SDC_QDSD_PINGROUP(sdc1_data, 0x99a000, 9, 0),
+	SDC_QDSD_PINGROUP(sdc2_clk, 0x99b000, 14, 6),
+	SDC_QDSD_PINGROUP(sdc2_cmd, 0x99b000, 11, 3),
+	SDC_QDSD_PINGROUP(sdc2_data, 0x99b000, 9, 0),
+	SDC_QDSD_PINGROUP(sdc1_rclk, 0x99a000, 15, 0),
+};
+
+static const struct msm_pinctrl_soc_data sdm660_pinctrl = {
+	.pins = sdm660_pins,
+	.npins = ARRAY_SIZE(sdm660_pins),
+	.functions = sdm660_functions,
+	.nfunctions = ARRAY_SIZE(sdm660_functions),
+	.groups = sdm660_groups,
+	.ngroups = ARRAY_SIZE(sdm660_groups),
+	.ngpios = 114,
+};
+
+static int sdm660_pinctrl_probe(struct platform_device *pdev)
+{
+	return msm_pinctrl_probe(pdev, &sdm660_pinctrl);
+}
+
+static const struct of_device_id sdm660_pinctrl_of_match[] = {
+	{ .compatible = "qcom,sdm660-pinctrl", },
+	{ },
+};
+
+static struct platform_driver sdm660_pinctrl_driver = {
+	.driver = {
+		.name = "sdm660-pinctrl",
+		.of_match_table = sdm660_pinctrl_of_match,
+	},
+	.probe = sdm660_pinctrl_probe,
+	.remove = msm_pinctrl_remove,
+};
+
+static int __init sdm660_pinctrl_init(void)
+{
+	return platform_driver_register(&sdm660_pinctrl_driver);
+}
+arch_initcall(sdm660_pinctrl_init);
+
+static void __exit sdm660_pinctrl_exit(void)
+{
+	platform_driver_unregister(&sdm660_pinctrl_driver);
+}
+module_exit(sdm660_pinctrl_exit);
+
+MODULE_DESCRIPTION("QTI sdm660 pinctrl driver");
+MODULE_LICENSE("GPL v2");
+MODULE_DEVICE_TABLE(of, sdm660_pinctrl_of_match);