[1/2] linux-user: cleanup msync output in strace

Message ID 20180810185321.20017-1-laurent@vivier.eu
State New
Headers show
Series
  • [1/2] linux-user: cleanup msync output in strace
Related show

Commit Message

Laurent Vivier Aug. 10, 2018, 6:53 p.m.
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/strace.list | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Henderson Aug. 10, 2018, 7:28 p.m. | #1
On 08/10/2018 11:53 AM, Laurent Vivier wrote:
> -{ TARGET_NR_msync, "msync" , NULL, NULL, NULL },
> +{ TARGET_NR_msync, "msync" , "%s(%#x,%d,%x)", NULL, NULL },

Would you mind having a look at my linux-user reorg proposal?
It would make this change redundant.

https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg02935.html


r~
Laurent Vivier Aug. 10, 2018, 7:43 p.m. | #2
Le 10/08/2018 à 21:28, Richard Henderson a écrit :
> On 08/10/2018 11:53 AM, Laurent Vivier wrote:
>> -{ TARGET_NR_msync, "msync" , NULL, NULL, NULL },
>> +{ TARGET_NR_msync, "msync" , "%s(%#x,%d,%x)", NULL, NULL },
> 
> Would you mind having a look at my linux-user reorg proposal?
> It would make this change redundant.
> 
> https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg02935.html
> 

Yes, I know your series. I posted this patch because it helped me to
debug the patch 2/2. I can remove it for this series if you prefer.

Thanks,
Laurent

Patch

diff --git a/linux-user/strace.list b/linux-user/strace.list
index ff8bb19f5f..c4a0e3510a 100644
--- a/linux-user/strace.list
+++ b/linux-user/strace.list
@@ -624,7 +624,7 @@ 
 { TARGET_NR_msgsnd, "msgsnd" , NULL, NULL, NULL },
 #endif
 #ifdef TARGET_NR_msync
-{ TARGET_NR_msync, "msync" , NULL, NULL, NULL },
+{ TARGET_NR_msync, "msync" , "%s(%#x,%d,%x)", NULL, NULL },
 #endif
 #ifdef TARGET_NR_multiplexer
 { TARGET_NR_multiplexer, "multiplexer" , NULL, NULL, NULL },