[18/18] Add to DEVELOPERS file

Message ID 20180810161502.21598-19-chrismcc@gmail.com
State Rejected
Headers show
Series
  • more perl modules
Related show

Commit Message

Christopher McCrory Aug. 10, 2018, 4:15 p.m.
Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
 DEVELOPERS | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Comments

Thomas Petazzoni Aug. 10, 2018, 9:10 p.m. | #1
Hello,

On Fri, 10 Aug 2018 09:15:02 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
>  DEVELOPERS | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 215506c71c..c693f6765b 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -479,6 +479,25 @@ F:	package/python-rtslib-fb/
>  F:	package/python-urwid/
>  F:	package/targetcli-fb/
>  
> +N:	Christopher McCrory <chrismcc@gmail.com>
> +F:	package/perl-appconfig
> +F:	package/perl-astro-suntime
> +F:	package/perl-cgi
> +F:	package/perl-class-std
> +F:	package/perl-data-uuid
> +F:	package/perl-date-manip
> +F:	package/perl-dbi
> +F:	package/perl-device-serialport
> +F:	package/perl-file-slurp
> +F:	package/perl-io-interface
> +F:	package/perl-json-maybexs
> +F:	package/perl-module-runtime
> +F:	package/perl-number-bytes-human
> +F:	package/perl-params-util
> +F:	package/perl-sub-install
> +F:	package/perl-sys-meminfo
> +F:	package/perl-sys-mmap

This should normally be done in each patch adding each individual
package. Indeed, if I partially merge your patch series (say up to
patch 10), then you won't be added to the DEVELOPERS file.

Best regards,

Thomas
Christopher McCrory Aug. 10, 2018, 10:12 p.m. | #2
On Fri, Aug 10, 2018, 2:10 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com>
wrote:

> Hello,
>
> On Fri, 10 Aug 2018 09:15:02 -0700, Christopher McCrory wrote:
> > Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> > ---
> >  DEVELOPERS | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 215506c71c..c693f6765b 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -479,6 +479,25 @@ F:       package/python-rtslib-fb/
> >  F:   package/python-urwid/
> >  F:   package/targetcli-fb/
> >
> > +N:   Christopher McCrory <chrismcc@gmail.com>
> > +F:   package/perl-appconfig
> > +F:   package/perl-astro-suntime
> > +F:   package/perl-cgi
> > +F:   package/perl-class-std
> > +F:   package/perl-data-uuid
> > +F:   package/perl-date-manip
> > +F:   package/perl-dbi
> > +F:   package/perl-device-serialport
> > +F:   package/perl-file-slurp
> > +F:   package/perl-io-interface
> > +F:   package/perl-json-maybexs
> > +F:   package/perl-module-runtime
> > +F:   package/perl-number-bytes-human
> > +F:   package/perl-params-util
> > +F:   package/perl-sub-install
> > +F:   package/perl-sys-meminfo
> > +F:   package/perl-sys-mmap
>
> This should normally be done in each patch adding each individual
> package. Indeed, if I partially merge your patch series (say up to
> patch 10), then you won't be added to the DEVELOPERS file.
>
>
> I wasn't sure what to do.  If you accepted all but one in the middle, then
> the ones after it would all break.  Plus the four I sent earlier might
> conflict.  So I played it safe.  I have ten ish more that either depend on
> this series or are more complicated.  I can do those adds per commit.
>

Via phone so formatting might be off.



>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 10, 2018, 2:10 PM Thomas Petazzoni &lt;<a href="mailto:thomas.petazzoni@bootlin.com" target="_blank" rel="noreferrer">thomas.petazzoni@bootlin.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
On Fri, 10 Aug 2018 09:15:02 -0700, Christopher McCrory wrote:<br>
&gt; Signed-off-by: Christopher McCrory &lt;<a href="mailto:chrismcc@gmail.com" rel="noreferrer noreferrer" target="_blank">chrismcc@gmail.com</a>&gt;<br>
&gt; ---<br>
&gt;  DEVELOPERS | 19 +++++++++++++++++++<br>
&gt;  1 file changed, 19 insertions(+)<br>
&gt; <br>
&gt; diff --git a/DEVELOPERS b/DEVELOPERS<br>
&gt; index 215506c71c..c693f6765b 100644<br>
&gt; --- a/DEVELOPERS<br>
&gt; +++ b/DEVELOPERS<br>
&gt; @@ -479,6 +479,25 @@ F:       package/python-rtslib-fb/<br>
&gt;  F:   package/python-urwid/<br>
&gt;  F:   package/targetcli-fb/<br>
&gt;  <br>
&gt; +N:   Christopher McCrory &lt;<a href="mailto:chrismcc@gmail.com" rel="noreferrer noreferrer" target="_blank">chrismcc@gmail.com</a>&gt;<br>
&gt; +F:   package/perl-appconfig<br>
&gt; +F:   package/perl-astro-suntime<br>
&gt; +F:   package/perl-cgi<br>
&gt; +F:   package/perl-class-std<br>
&gt; +F:   package/perl-data-uuid<br>
&gt; +F:   package/perl-date-manip<br>
&gt; +F:   package/perl-dbi<br>
&gt; +F:   package/perl-device-serialport<br>
&gt; +F:   package/perl-file-slurp<br>
&gt; +F:   package/perl-io-interface<br>
&gt; +F:   package/perl-json-maybexs<br>
&gt; +F:   package/perl-module-runtime<br>
&gt; +F:   package/perl-number-bytes-human<br>
&gt; +F:   package/perl-params-util<br>
&gt; +F:   package/perl-sub-install<br>
&gt; +F:   package/perl-sys-meminfo<br>
&gt; +F:   package/perl-sys-mmap<br>
<br>
This should normally be done in each patch adding each individual<br>
package. Indeed, if I partially merge your patch series (say up to<br>
patch 10), then you won&#39;t be added to the DEVELOPERS file.<br><br><br>I wasn&#39;t sure what to do.  If you accepted all but one in the middle, then the ones after it would all break.  Plus the four I sent earlier might conflict.  So I played it safe.  I have ten ish more that either depend on this series or are more complicated.  I can do those adds per commit.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Via phone so formatting might be off.</div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><br>
Best regards,<br>
<br>
Thomas<br>
-- <br>
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)<br>
Embedded Linux and Kernel engineering<br>
<a href="https://bootlin.com" rel="noreferrer noreferrer noreferrer" target="_blank">https://bootlin.com</a><br>
</blockquote></div></div></div>
Thomas Petazzoni Aug. 13, 2018, 10:02 a.m. | #3
Hello,

On Fri, 10 Aug 2018 09:15:02 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>

I marked this patch as "Rejected", since I did the updates to the
DEVELOPERS file in each patch adding each individual Perl package.

Thanks!

Thomas

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 215506c71c..c693f6765b 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -479,6 +479,25 @@  F:	package/python-rtslib-fb/
 F:	package/python-urwid/
 F:	package/targetcli-fb/
 
+N:	Christopher McCrory <chrismcc@gmail.com>
+F:	package/perl-appconfig
+F:	package/perl-astro-suntime
+F:	package/perl-cgi
+F:	package/perl-class-std
+F:	package/perl-data-uuid
+F:	package/perl-date-manip
+F:	package/perl-dbi
+F:	package/perl-device-serialport
+F:	package/perl-file-slurp
+F:	package/perl-io-interface
+F:	package/perl-json-maybexs
+F:	package/perl-module-runtime
+F:	package/perl-number-bytes-human
+F:	package/perl-params-util
+F:	package/perl-sub-install
+F:	package/perl-sys-meminfo
+F:	package/perl-sys-mmap
+
 N:	Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
 F:	package/audit/
 F:	package/checkpolicy/