From patchwork Fri Aug 10 09:39:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 956163 X-Patchwork-Delegate: bmeng.cn@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="e1oXnBfM"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 41n0Rb3Q43z9s7Q for ; Fri, 10 Aug 2018 19:38:19 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id B5AD9C21DA1; Fri, 10 Aug 2018 09:37:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 6518BC21E13; Fri, 10 Aug 2018 09:37:12 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id F2E14C21DED; Fri, 10 Aug 2018 09:37:08 +0000 (UTC) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by lists.denx.de (Postfix) with ESMTPS id 615CDC21C93 for ; Fri, 10 Aug 2018 09:37:02 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id u24-v6so4251730pfn.13 for ; Fri, 10 Aug 2018 02:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=RknHoqJSRx+s6bFvO95hh8qVj7Vf55xExCz4qmXps24=; b=e1oXnBfMil1e0JDNjs0B8AjQb0dn+czMeAeOZ5Y29PTh/SBbuXWOOdFwmd3uhD5Otk bDhch1tBSM+0vei6c7j3EnnnG1SorvQ+sp2S1hTXZ3HK2ssFgZt7P5TC3BRh4SER4HUf vlRjgszIIK8IO7KzHcw+xDZxXP+Zrzfqa70g3vNcTgWYSIzqOkvUDh6x+MDRaC9/yB9O nTbCHT6L6/1bI4uRGw1LAm39zyn8p19uZEneKPHlYZSMODMLEt9M8jlgeM0I/rw1T//+ 7vE61yIJ/yPGaspNMtBylgaYeQKvW0a2Z8RO3rBxaJJCJUGWH+I72WXgQYW3u13nrb0J jocA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=RknHoqJSRx+s6bFvO95hh8qVj7Vf55xExCz4qmXps24=; b=BxECnACfC4AYLtku/ov0CPSV16j1vAiu2m7FBAo3OUfF9lhlXjhlMyLJnbUpAgFjJ4 t9Nx+LVamVX+OChin0mC5aCbzv7cPFoOwKJnsmGJ3iv4CDtRsq2PdJ0ytTD+32cyM8HE 1dp4L2lJqhB2TyBoobIXpIhnKU/HFaZ0FKAiIz2bfekjpJnqvoBFqsk439F23zzqbDHR gPQhygNCBh+ZKzntkEnC0sz+YrBkWVPpjlrDLhOIUZyZ2Q2z/LjbAqooQPBq7OK78y/R RbMrJiOLhOT66K2E32FTAuR5r2W4A59ubSJSR3SskF6/uEA4MlEol/GiYnlOlsixrZII 7A3w== X-Gm-Message-State: AOUpUlG5ewE1Tel2s/lyOf61vA1edPRGSGoxFS7ha3wxusGHmJZhzPUL xyY6FfntORq5Tn+0NijBDEXnVuJS X-Google-Smtp-Source: AA+uWPxzb/UgGDZDbSipjh4HsxC2aSNT5CO/YkRmA9gCTn6bg7snNQ+eRqzifMNu3PMZAlb/mn6OTQ== X-Received: by 2002:a63:c60:: with SMTP id 32-v6mr5731279pgm.155.1533893821059; Fri, 10 Aug 2018 02:37:01 -0700 (PDT) Received: from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com. [147.11.156.139]) by smtp.gmail.com with ESMTPSA id u71-v6sm30416717pfk.174.2018.08.10.02.36.59 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 10 Aug 2018 02:37:00 -0700 (PDT) From: Bin Meng To: Simon Glass , George McCollister , U-Boot Mailing List Date: Fri, 10 Aug 2018 02:39:35 -0700 Message-Id: <1533893978-12838-3-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1533893978-12838-1-git-send-email-bmeng.cn@gmail.com> References: <1533893978-12838-1-git-send-email-bmeng.cn@gmail.com> Subject: [U-Boot] [PATCH 3/6] x86: dts: Remove coreboot_fb.dtsi X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" There is no need to keep a separate coreboot_fb.dtsi since now we have a generic coreboot payload dts. While we are here, this also remove the out-of-date description in the documentation regarding to coreboot framebuffer driver with U-Boot loaded as a payload from coreboot. As the testing result with QEMU 2.5.0 shows, the driver just works like a charm. Signed-off-by: Bin Meng Reviewed-by: Simon Glass --- arch/x86/dts/bayleybay.dts | 1 - arch/x86/dts/chromebook_link.dts | 1 - arch/x86/dts/chromebook_samus.dts | 1 - arch/x86/dts/chromebox_panther.dts | 1 - arch/x86/dts/coreboot_fb.dtsi | 5 ----- arch/x86/dts/minnowmax.dts | 1 - doc/README.x86 | 7 ------- 7 files changed, 17 deletions(-) delete mode 100644 arch/x86/dts/coreboot_fb.dtsi diff --git a/arch/x86/dts/bayleybay.dts b/arch/x86/dts/bayleybay.dts index 9683c52..291dc07 100644 --- a/arch/x86/dts/bayleybay.dts +++ b/arch/x86/dts/bayleybay.dts @@ -15,7 +15,6 @@ /include/ "reset.dtsi" /include/ "rtc.dtsi" /include/ "tsc_timer.dtsi" -/include/ "coreboot_fb.dtsi" / { model = "Intel Bayley Bay"; diff --git a/arch/x86/dts/chromebook_link.dts b/arch/x86/dts/chromebook_link.dts index 115a088..f9f0979 100644 --- a/arch/x86/dts/chromebook_link.dts +++ b/arch/x86/dts/chromebook_link.dts @@ -8,7 +8,6 @@ /include/ "reset.dtsi" /include/ "rtc.dtsi" /include/ "tsc_timer.dtsi" -/include/ "coreboot_fb.dtsi" / { model = "Google Link"; diff --git a/arch/x86/dts/chromebook_samus.dts b/arch/x86/dts/chromebook_samus.dts index 9c48c9a..b58936b 100644 --- a/arch/x86/dts/chromebook_samus.dts +++ b/arch/x86/dts/chromebook_samus.dts @@ -8,7 +8,6 @@ /include/ "reset.dtsi" /include/ "rtc.dtsi" /include/ "tsc_timer.dtsi" -/include/ "coreboot_fb.dtsi" / { model = "Google Samus"; diff --git a/arch/x86/dts/chromebox_panther.dts b/arch/x86/dts/chromebox_panther.dts index a72a85e..f56e482 100644 --- a/arch/x86/dts/chromebox_panther.dts +++ b/arch/x86/dts/chromebox_panther.dts @@ -5,7 +5,6 @@ /include/ "reset.dtsi" /include/ "rtc.dtsi" /include/ "tsc_timer.dtsi" -/include/ "coreboot_fb.dtsi" / { model = "Google Panther"; diff --git a/arch/x86/dts/coreboot_fb.dtsi b/arch/x86/dts/coreboot_fb.dtsi deleted file mode 100644 index 7d72f18..0000000 --- a/arch/x86/dts/coreboot_fb.dtsi +++ /dev/null @@ -1,5 +0,0 @@ -/ { - coreboot-fb { - compatible = "coreboot-fb"; - }; -}; diff --git a/arch/x86/dts/minnowmax.dts b/arch/x86/dts/minnowmax.dts index 02ab4c1..6c65fb9 100644 --- a/arch/x86/dts/minnowmax.dts +++ b/arch/x86/dts/minnowmax.dts @@ -14,7 +14,6 @@ /include/ "reset.dtsi" /include/ "rtc.dtsi" /include/ "tsc_timer.dtsi" -/include/ "coreboot_fb.dtsi" / { model = "Intel Minnowboard Max"; diff --git a/doc/README.x86 b/doc/README.x86 index 6015ca4..8cc4672 100644 --- a/doc/README.x86 +++ b/doc/README.x86 @@ -412,17 +412,10 @@ To enable video you must enable these options in coreboot: - Set framebuffer graphics resolution (1280x1024 32k-color (1:5:5)) - Keep VESA framebuffer -And include coreboot_fb.dtsi in your board's device tree source file, like: - - /include/ "coreboot_fb.dtsi" - At present it seems that for Minnowboard Max, coreboot does not pass through the video information correctly (it always says the resolution is 0x0). This works correctly for link though. -Note: coreboot framebuffer driver does not work on QEMU. The reason is unknown -at this point. Patches are welcome if you figure out anything wrong. - Test with QEMU for bare mode ---------------------------- QEMU is a fancy emulator that can enable us to test U-Boot without access to