From patchwork Fri Aug 10 06:12:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilias Apalodimas X-Patchwork-Id: 955950 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="FsXOm+gO"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41mvtx2nClz9s8k for ; Fri, 10 Aug 2018 16:13:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727461AbeHJIle (ORCPT ); Fri, 10 Aug 2018 04:41:34 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:56272 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725784AbeHJIld (ORCPT ); Fri, 10 Aug 2018 04:41:33 -0400 Received: by mail-wm0-f65.google.com with SMTP id f21-v6so619019wmc.5 for ; Thu, 09 Aug 2018 23:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=J7J536chYQMuP2f8Ap1goSIjCZyTXPKdr51AcsLoKG0=; b=FsXOm+gOt7iPq2F8A0pLbxEMXncmPn9D9vWZCns0N6Nrx3wtMASUcebxx0tB6GJ7hA lxcJhHq/DeHuFO/vewh7pVSw2uJjax2sSJTur0K1r/3RXU3gJeyP7QFPFWOUbfwkM0Cc rwjhBdYdpN89OlyVu8gxbMETl4zwQszDqkG6o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=J7J536chYQMuP2f8Ap1goSIjCZyTXPKdr51AcsLoKG0=; b=cHRM9wvQ9qHWSRI0flohl6CQgOIZwEd37Aash+DyF3VQ1rppLCjystiL/9yfuRi+14 VKPzxkJM0QQf4XENiKGnfCt8F7fTdUhgvApv2ncwyTuUOva9qv5u1nCO6HwB4/lp0MOk DfpTj6tD2FyVpsSYJn4eWKIxyUCtsFZey/DvPIGskytdJi0/vAjlyNvJ0lffuwK+nZJ4 SAmg9oxP26NTuhhDVBx48q0wBgoaF9IxIqW//73xFMUItkkTU+emqf3hXj72BT/ysT7T iLbgBRb1QdjTEgQMhE4ywoIdXEu3MEtCii7GKG/kdfvJH4aoNES2k6iJAp/CZ/cbL4MT 3d6w== X-Gm-Message-State: AOUpUlFMye4W1EdJwq5IUTpBV+QUhVSNPth9ikmknNGL4H1F0/GpiTVd Z0Gy7DKoWqUfZJRVVN2gVMzwUBeLttA= X-Google-Smtp-Source: AA+uWPyuZRE3QDZc0rWqeV0huIQpL7TS1k4xU97JwHXBIxndAhnIavX2zh3vCisE+m7/4MVwyz69jg== X-Received: by 2002:a1c:790b:: with SMTP id l11-v6mr538061wme.66.1533881589662; Thu, 09 Aug 2018 23:13:09 -0700 (PDT) Received: from localhost.localdomain ([2a02:587:4605:8300:2e56:dcff:fe9a:8f06]) by smtp.gmail.com with ESMTPSA id i1-v6sm6182483wrq.69.2018.08.09.23.13.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Aug 2018 23:13:09 -0700 (PDT) From: Ilias Apalodimas To: netdev@vger.kernel.org, jaswinder.singh@linaro.org Cc: ard.biesheuvel@linaro.org, masami.hiramatsu@linaro.org, arnd@arndb.de, Ilias Apalodimas Subject: [net-next, PATCH 2/2 v2] net: socionext: Increase descriptors to 256 Date: Fri, 10 Aug 2018 09:12:39 +0300 Message-Id: <1533881559-18589-3-git-send-email-ilias.apalodimas@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1533881559-18589-1-git-send-email-ilias.apalodimas@linaro.org> References: <1533881559-18589-1-git-send-email-ilias.apalodimas@linaro.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Increasing descriptors to 256 from 128 and adjusting the NAPI weight to 64 increases performace on Rx by ~20% on 64byte packets Signed-off-by: Ilias Apalodimas --- drivers/net/ethernet/socionext/netsec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c index 334b618..7aa5ebb 100644 --- a/drivers/net/ethernet/socionext/netsec.c +++ b/drivers/net/ethernet/socionext/netsec.c @@ -232,8 +232,7 @@ #define NETSEC_EEPROM_PKT_ME_ADDRESS 0x20 #define NETSEC_EEPROM_PKT_ME_SIZE 0x24 -#define DESC_NUM 128 -#define NAPI_BUDGET (DESC_NUM / 2) +#define DESC_NUM 256 #define DESC_SZ sizeof(struct netsec_de) @@ -1659,7 +1658,7 @@ static int netsec_probe(struct platform_device *pdev) dev_info(&pdev->dev, "hardware revision %d.%d\n", hw_ver >> 16, hw_ver & 0xffff); - netif_napi_add(ndev, &priv->napi, netsec_napi_poll, NAPI_BUDGET); + netif_napi_add(ndev, &priv->napi, netsec_napi_poll, NAPI_POLL_WEIGHT); ndev->netdev_ops = &netsec_netdev_ops; ndev->ethtool_ops = &netsec_ethtool_ops;