acpitables: remove unnecessary new line character

Message ID 20180810003801.32580-1-alex.hung@canonical.com
State Accepted
Headers show
Series
  • acpitables: remove unnecessary new line character
Related show

Commit Message

Alex Hung Aug. 10, 2018, 12:38 a.m.
There are no functional changes.

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/acpitables/acpitables.c | 2 +-
 src/sbbr/acpitables/acpitables.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Colin King Aug. 10, 2018, 7:52 a.m. | #1
On 10/08/18 01:38, Alex Hung wrote:
> There are no functional changes.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/acpitables/acpitables.c | 2 +-
>  src/sbbr/acpitables/acpitables.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
> index 6f0b110a..c32b42c0 100644
> --- a/src/acpi/acpitables/acpitables.c
> +++ b/src/acpi/acpitables/acpitables.c
> @@ -48,7 +48,7 @@ static bool acpi_table_check_field_test(
>  	if (!acpi_table_check_field(field, len)) {
>  		fwts_failed(fw, LOG_LEVEL_LOW, "ACPITableHdrInfo",
>  			"ACPI Table %s has non-ASCII characters in "
> -			"header field %s\n", table_name, field_name);
> +			"header field %s", table_name, field_name);
>  		return false;
>  	}
>  	return true;
> diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c
> index 7d0d1987..e6786eec 100644
> --- a/src/sbbr/acpitables/acpitables.c
> +++ b/src/sbbr/acpitables/acpitables.c
> @@ -59,7 +59,7 @@ static bool acpi_table_check_field_test(
>  	if (!acpi_table_check_field(field, len)) {
>  		fwts_failed(fw, LOG_LEVEL_LOW, "ACPITableHdrInfo",
>  			"ACPI Table %s has non-ASCII characters in "
> -			"header field %s\n", table_name, field_name);
> +			"header field %s", table_name, field_name);
>  		return false;
>  	}
>  	return true;
> 
Good catch!

Acked-by: Colin Ian King <colin.king@canonical.com>
ivanhu Aug. 14, 2018, 7:44 a.m. | #2
On 08/10/2018 08:38 AM, Alex Hung wrote:
> There are no functional changes.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   src/acpi/acpitables/acpitables.c | 2 +-
>   src/sbbr/acpitables/acpitables.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
> index 6f0b110a..c32b42c0 100644
> --- a/src/acpi/acpitables/acpitables.c
> +++ b/src/acpi/acpitables/acpitables.c
> @@ -48,7 +48,7 @@ static bool acpi_table_check_field_test(
>   	if (!acpi_table_check_field(field, len)) {
>   		fwts_failed(fw, LOG_LEVEL_LOW, "ACPITableHdrInfo",
>   			"ACPI Table %s has non-ASCII characters in "
> -			"header field %s\n", table_name, field_name);
> +			"header field %s", table_name, field_name);
>   		return false;
>   	}
>   	return true;
> diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c
> index 7d0d1987..e6786eec 100644
> --- a/src/sbbr/acpitables/acpitables.c
> +++ b/src/sbbr/acpitables/acpitables.c
> @@ -59,7 +59,7 @@ static bool acpi_table_check_field_test(
>   	if (!acpi_table_check_field(field, len)) {
>   		fwts_failed(fw, LOG_LEVEL_LOW, "ACPITableHdrInfo",
>   			"ACPI Table %s has non-ASCII characters in "
> -			"header field %s\n", table_name, field_name);
> +			"header field %s", table_name, field_name);
>   		return false;
>   	}
>   	return true;
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
index 6f0b110a..c32b42c0 100644
--- a/src/acpi/acpitables/acpitables.c
+++ b/src/acpi/acpitables/acpitables.c
@@ -48,7 +48,7 @@  static bool acpi_table_check_field_test(
 	if (!acpi_table_check_field(field, len)) {
 		fwts_failed(fw, LOG_LEVEL_LOW, "ACPITableHdrInfo",
 			"ACPI Table %s has non-ASCII characters in "
-			"header field %s\n", table_name, field_name);
+			"header field %s", table_name, field_name);
 		return false;
 	}
 	return true;
diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c
index 7d0d1987..e6786eec 100644
--- a/src/sbbr/acpitables/acpitables.c
+++ b/src/sbbr/acpitables/acpitables.c
@@ -59,7 +59,7 @@  static bool acpi_table_check_field_test(
 	if (!acpi_table_check_field(field, len)) {
 		fwts_failed(fw, LOG_LEVEL_LOW, "ACPITableHdrInfo",
 			"ACPI Table %s has non-ASCII characters in "
-			"header field %s\n", table_name, field_name);
+			"header field %s", table_name, field_name);
 		return false;
 	}
 	return true;