From patchwork Wed Aug 8 16:01:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Yang X-Patchwork-Id: 955437 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cn.fujitsu.com Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41mPZJ2cjqz9s0n for ; Thu, 9 Aug 2018 20:27:01 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 89EE63E7218 for ; Thu, 9 Aug 2018 12:26:58 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) by picard.linux.it (Postfix) with ESMTP id 431373E71EB for ; Thu, 9 Aug 2018 12:26:56 +0200 (CEST) Received: from heian.cn.fujitsu.com (mail.cn.fujitsu.com [183.91.158.132]) by in-5.smtp.seeweb.it (Postfix) with ESMTP id 2DE97600202 for ; Thu, 9 Aug 2018 12:26:54 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="43286066" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 09 Aug 2018 18:26:51 +0800 Received: from G08CNEXCHPEKD03.g08.fujitsu.local (unknown [10.167.33.85]) by cn.fujitsu.com (Postfix) with ESMTP id 747A74B6ADFF for ; Thu, 9 Aug 2018 18:26:48 +0800 (CST) Received: from RHEL7U5Alpha_SERVER.g08.fujitsu.local (10.167.220.156) by G08CNEXCHPEKD03.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.399.0; Thu, 9 Aug 2018 18:26:48 +0800 From: Xiao Yang To: Date: Thu, 9 Aug 2018 00:01:09 +0800 Message-ID: <1533744069-24715-1-git-send-email-yangx.jy@cn.fujitsu.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.167.220.156] X-yoursite-MailScanner-ID: 747A74B6ADFF.ABCCF X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: yangx.jy@cn.fujitsu.com X-Spam-Status: No, score=0.8 required=7.0 tests=DATE_IN_PAST_12_24 autolearn=disabled version=3.4.0 X-Virus-Scanned: clamav-milter 0.99.2 at in-5.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-5.smtp.seeweb.it Subject: [LTP] [PATCH] syscalls/fsetxattr02.c: Fix the failure of opening device files X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" If temporary directory(TMPDIR/TEMPDIR) is on the mountpoint which is mounted with nodev option or temporary directory is mounted with with nodev option directly(e.g. tmpfs is mounted on /tmp), open(2) has no permission to open device files in the temporary directory and returned EACCES. as below: -------------------------------------------------------------------- safe_macros.c:225: BROK: fsetxattr02.c:215: open(fsetxattr02chr,0,00) failed: EACCES -------------------------------------------------------------------- We try to fix this issue by creating device files in /dev/ instead. This is the same issue reported by open11, please see the mail: http://lists.linux.it/pipermail/ltp/2018-July/008641.html Signed-off-by: Xiao Yang --- testcases/kernel/syscalls/fsetxattr/fsetxattr02.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/testcases/kernel/syscalls/fsetxattr/fsetxattr02.c b/testcases/kernel/syscalls/fsetxattr/fsetxattr02.c index a1be652..356e527 100644 --- a/testcases/kernel/syscalls/fsetxattr/fsetxattr02.c +++ b/testcases/kernel/syscalls/fsetxattr/fsetxattr02.c @@ -52,11 +52,13 @@ #define FILENAME "fsetxattr02testfile" #define DIRNAME "fsetxattr02testdir" #define SYMLINK "fsetxattr02symlink" -#define FIFO "fsetxattr02fifo" -#define CHR "fsetxattr02chr" -#define BLK "fsetxattr02blk" +#define FIFO "/dev/fsetxattr02fifo" +#define CHR "/dev/fsetxattr02chr" +#define BLK "/dev/fsetxattr02blk" #define SOCK "fsetxattr02sock" +static char *dev_files[3] = {FIFO, CHR, BLK}; + struct test_case { char *fname; int fd; @@ -240,6 +242,11 @@ static void cleanup(void) if (tc[i].fd > 0) SAFE_CLOSE(tc[i].fd); } + + for (i = 0; i < ARRAY_SIZE(dev_files); i++) { + if (!access(dev_files[i], F_OK)) + SAFE_UNLINK(dev_files[i]); + } } static struct tst_test test = {