ext4: Fix build error when DX_DEBUG is defined

Message ID 20180808182043.13986-1-krisman@collabora.co.uk
State Superseded
Headers show
Series
  • ext4: Fix build error when DX_DEBUG is defined
Related show

Commit Message

Gabriel Krisman Bertazi Aug. 8, 2018, 6:20 p.m.
Enabling DX_DEBUG triggers the build error below.  The info pointer
should be accessed via the dxroot pointer.

linux/fs/ext4/namei.c:2264:12: error: ‘info’
undeclared (first use in this function); did you mean ‘insl’?
	   	  info->indirect_levels));

Fixes: e08ac99fa2a2 ("ext4: add largedir feature")
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
---
 fs/ext4/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lukas Czerner Aug. 9, 2018, 8:10 a.m. | #1
On Wed, Aug 08, 2018 at 02:20:43PM -0400, Gabriel Krisman Bertazi wrote:
> Enabling DX_DEBUG triggers the build error below.  The info pointer
> should be accessed via the dxroot pointer.
> 
> linux/fs/ext4/namei.c:2264:12: error: ‘info’
> undeclared (first use in this function); did you mean ‘insl’?
> 	   	  info->indirect_levels));

Looks good,

Reviewed-by: Lukas Czerner <lczerner@redhat.com>

Thanks!
-Lukas

> 
> Fixes: e08ac99fa2a2 ("ext4: add largedir feature")
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> ---
>  fs/ext4/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 116ff68c5bd4..35b635b4df58 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -2261,7 +2261,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,
>  			dxroot->info.indirect_levels += 1;
>  			dxtrace(printk(KERN_DEBUG
>  				       "Creating %d level index...\n",
> -				       info->indirect_levels));
> +				       dxroot->info.indirect_levels));
>  			err = ext4_handle_dirty_dx_node(handle, dir, frame->bh);
>  			if (err)
>  				goto journal_error;
> -- 
> 2.18.0
>
Gabriel Krisman Bertazi Aug. 29, 2018, 4:45 a.m. | #2
Gabriel Krisman Bertazi <krisman@collabora.co.uk> writes:

> Enabling DX_DEBUG triggers the build error below.  The info pointer
> should be accessed via the dxroot pointer.
>
> linux/fs/ext4/namei.c:2264:12: error: ‘info’
> undeclared (first use in this function); did you mean ‘insl’?
> 	   	  info->indirect_levels));
>
> Fixes: e08ac99fa2a2 ("ext4: add largedir feature")
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>

Hi, I suspect this might have drown in the list noise, is there any
opposition?

If it is merged, sorry for the noise. :)

Patch

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 116ff68c5bd4..35b635b4df58 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2261,7 +2261,7 @@  static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,
 			dxroot->info.indirect_levels += 1;
 			dxtrace(printk(KERN_DEBUG
 				       "Creating %d level index...\n",
-				       info->indirect_levels));
+				       dxroot->info.indirect_levels));
 			err = ext4_handle_dirty_dx_node(handle, dir, frame->bh);
 			if (err)
 				goto journal_error;