| Message ID | 20180808120449.ezhesrq7o5qdert2@kili.mountain |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: nomadik: silence uninitialized variable warning | expand |
On Wed, Aug 8, 2018 at 2:04 PM Dan Carpenter <dan.carpenter@oracle.com> wrote: > This is harmless, but "val" isn't necessarily initialized if > abx500_get_register_interruptible() fails. I've re-arranged the code to > just return an error code in that situation. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/nomadik/pinctrl-abx500.c b/drivers/pinctrl/nomadik/pinctrl-abx500.c index aa592ef23a29..e3689cc62a41 100644 --- a/drivers/pinctrl/nomadik/pinctrl-abx500.c +++ b/drivers/pinctrl/nomadik/pinctrl-abx500.c @@ -101,15 +101,16 @@ static int abx500_gpio_get_bit(struct gpio_chip *chip, u8 reg, reg += offset / 8; ret = abx500_get_register_interruptible(pct->dev, AB8500_MISC, reg, &val); - - *bit = !!(val & BIT(pos)); - - if (ret < 0) + if (ret < 0) { dev_err(pct->dev, "%s read reg =%x, offset=%x failed (%d)\n", __func__, reg, offset, ret); + return ret; + } - return ret; + *bit = !!(val & BIT(pos)); + + return 0; } static int abx500_gpio_set_bits(struct gpio_chip *chip, u8 reg,
This is harmless, but "val" isn't necessarily initialized if abx500_get_register_interruptible() fails. I've re-arranged the code to just return an error code in that situation. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html