| Message ID | 20180808095433.230882-5-sjg@chromium.org |
|---|---|
| State | Superseded, archived |
| Delegated to: | Alexander Graf |
| Headers | show |
| Series | efi: Enable sandbox support for EFI loader | expand |
On 08.08.18 11:54, Simon Glass wrote: > This allows this feature to build within sandbox. This is for testing > purposes only since it is not possible for sandbox to load native code. Last time I tried I successfully ran native code? Alex > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v9: None > Changes in v8: None > Changes in v7: > - Update patch subject s/builder/build/ > > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: > - Init the 'rows' and 'cols' vars to avoid a compiler error (gcc 4.8.4) > > Changes in v2: None > > lib/efi_loader/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > index ce6a09f0b43..bfd7b19d791 100644 > --- a/lib/efi_loader/Kconfig > +++ b/lib/efi_loader/Kconfig > @@ -1,6 +1,6 @@ > config EFI_LOADER > bool "Support running EFI Applications in U-Boot" > - depends on (ARM || X86 || RISCV) && OF_LIBFDT > + depends on (ARM || X86 || RISCV || SANDBOX) && OF_LIBFDT > # We need EFI_STUB_64BIT to be set on x86_64 with EFI_STUB > depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT > # We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB >
Hi Alex, On 26 August 2018 at 18:55, Alexander Graf <agraf@suse.de> wrote: > > > On 08.08.18 11:54, Simon Glass wrote: >> This allows this feature to build within sandbox. This is for testing >> purposes only since it is not possible for sandbox to load native code. > > Last time I tried I successfully ran native code? OK well I'll update the commit message. I thought that exit was broken but perhaps you fixed that? Regards, Simon
On 14.09.18 17:46, Simon Glass wrote: > Hi Alex, > > On 26 August 2018 at 18:55, Alexander Graf <agraf@suse.de> wrote: >> >> >> On 08.08.18 11:54, Simon Glass wrote: >>> This allows this feature to build within sandbox. This is for testing >>> purposes only since it is not possible for sandbox to load native code. >> >> Last time I tried I successfully ran native code? > > OK well I'll update the commit message. I thought that exit was broken > but perhaps you fixed that? The only reason for exit to break is the longjmp/setjmp complication. With that resolved, exit should just work as is too :) Alex
Hi Alex, On 15 September 2018 at 10:11, Alexander Graf <agraf@suse.de> wrote: > > > On 14.09.18 17:46, Simon Glass wrote: >> Hi Alex, >> >> On 26 August 2018 at 18:55, Alexander Graf <agraf@suse.de> wrote: >>> >>> >>> On 08.08.18 11:54, Simon Glass wrote: >>>> This allows this feature to build within sandbox. This is for testing >>>> purposes only since it is not possible for sandbox to load native code. >>> >>> Last time I tried I successfully ran native code? >> >> OK well I'll update the commit message. I thought that exit was broken >> but perhaps you fixed that? > > The only reason for exit to break is the longjmp/setjmp complication. > With that resolved, exit should just work as is too :) OK well let's go with your solution for that. We can print an error if not on GNU linux, etc. Regards, Simon
diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index ce6a09f0b43..bfd7b19d791 100644 --- a/lib/efi_loader/Kconfig +++ b/lib/efi_loader/Kconfig @@ -1,6 +1,6 @@ config EFI_LOADER bool "Support running EFI Applications in U-Boot" - depends on (ARM || X86 || RISCV) && OF_LIBFDT + depends on (ARM || X86 || RISCV || SANDBOX) && OF_LIBFDT # We need EFI_STUB_64BIT to be set on x86_64 with EFI_STUB depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT # We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB
This allows this feature to build within sandbox. This is for testing purposes only since it is not possible for sandbox to load native code. Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v9: None Changes in v8: None Changes in v7: - Update patch subject s/builder/build/ Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - Init the 'rows' and 'cols' vars to avoid a compiler error (gcc 4.8.4) Changes in v2: None lib/efi_loader/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)