libgo patch committed: Uncomment trace.Stop call in testing package

Message ID CAOyqgcUomx_jj9AvxNzfeNzRDHSAYmKLscA=BzsCEhkQ0TVHiA@mail.gmail.com
State New
Headers show
Series
  • libgo patch committed: Uncomment trace.Stop call in testing package
Related show

Commit Message

Ian Lance Taylor Aug. 7, 2018, 5:28 p.m.
This patch by Than McIntosh uncomments the call to trace.Stop in the
testing package.  It was commented out when the runtime/trace package
did not build with gccgo, but now it does and has for some time.  The
fixes the go test -test.trace option.  Bootstrapped and ran Go
testsuite on x86_64-pc-linux-gnu.  Committed to mainline.

Ian

Patch

Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE	(revision 263362)
+++ gcc/go/gofrontend/MERGE	(working copy)
@@ -1,4 +1,4 @@ 
-8997a3afcc746824cb70b48b32d9c86b4814807d
+274c88df4d6f9360dcd657b6e069a3b5a1d37a90
 
 The first line of this file holds the git revision number of the last
 merge done from the gofrontend repository.
Index: libgo/go/testing/testing.go
===================================================================
--- libgo/go/testing/testing.go	(revision 263362)
+++ libgo/go/testing/testing.go	(working copy)
@@ -1159,7 +1159,7 @@  func (m *M) writeProfiles() {
 		m.deps.StopCPUProfile() // flushes profile to disk
 	}
 	if *traceFile != "" {
-		// trace.Stop() // flushes trace to disk
+		trace.Stop() // flushes trace to disk
 	}
 	if *memProfile != "" {
 		f, err := os.Create(toOutputDir(*memProfile))