| Message ID | 20180806222918.12644-2-jmkrzyszt@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | [RFC,v2,01/12] mtd: rawnand: ams-delta: Assign mtd->dev.parent, not mtd->owner | expand |
On 08/07/2018 12:29 AM, Janusz Krzysztofik wrote: > Fix missing mtd->dev.parent assignment and drop useless mtd->owner. You fail to explain why this fix is required. > Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com> > --- > drivers/mtd/nand/raw/ams-delta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/ams-delta.c b/drivers/mtd/nand/raw/ams-delta.c > index 2a8872ebd14a..af313c620264 100644 > --- a/drivers/mtd/nand/raw/ams-delta.c > +++ b/drivers/mtd/nand/raw/ams-delta.c > @@ -162,7 +162,7 @@ static int ams_delta_init(struct platform_device *pdev) > } > > ams_delta_mtd = nand_to_mtd(this); > - ams_delta_mtd->owner = THIS_MODULE; > + ams_delta_mtd->dev.parent = &pdev->dev; > > /* > * Don't try to request the memory region from here, >
On Tue, 7 Aug 2018 00:29:07 +0200 Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote: > Fix missing mtd->dev.parent assignment and drop useless mtd->owner. > > Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com> Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com> > --- > drivers/mtd/nand/raw/ams-delta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/ams-delta.c b/drivers/mtd/nand/raw/ams-delta.c > index 2a8872ebd14a..af313c620264 100644 > --- a/drivers/mtd/nand/raw/ams-delta.c > +++ b/drivers/mtd/nand/raw/ams-delta.c > @@ -162,7 +162,7 @@ static int ams_delta_init(struct platform_device *pdev) > } > > ams_delta_mtd = nand_to_mtd(this); > - ams_delta_mtd->owner = THIS_MODULE; > + ams_delta_mtd->dev.parent = &pdev->dev; > > /* > * Don't try to request the memory region from here,
Hi Marek, On Tuesday, August 7, 2018 1:54:10 AM CEST Marek Vasut wrote: > On 08/07/2018 12:29 AM, Janusz Krzysztofik wrote: > > Fix missing mtd->dev.parent assignment and drop useless mtd->owner. > > You fail to explain why this fix is required. OK, I'll have a look at similar patches from the past and add an explanation. Thanks, Janusz
diff --git a/drivers/mtd/nand/raw/ams-delta.c b/drivers/mtd/nand/raw/ams-delta.c index 2a8872ebd14a..af313c620264 100644 --- a/drivers/mtd/nand/raw/ams-delta.c +++ b/drivers/mtd/nand/raw/ams-delta.c @@ -162,7 +162,7 @@ static int ams_delta_init(struct platform_device *pdev) } ams_delta_mtd = nand_to_mtd(this); - ams_delta_mtd->owner = THIS_MODULE; + ams_delta_mtd->dev.parent = &pdev->dev; /* * Don't try to request the memory region from here,
Fix missing mtd->dev.parent assignment and drop useless mtd->owner. Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com> --- drivers/mtd/nand/raw/ams-delta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)