| Message ID | 1305244212-19183-3-git-send-email-sboyd@codeaurora.org |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2011-05-12 at 16:50 -0700, Stephen Boyd wrote: > Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following > warning: > > In file included from arch/x86/include/asm/uaccess.h:573, > from include/net/checksum.h:25, > from include/linux/skbuff.h:28, > from drivers/net/wireless/iwlwifi/iwl-agn-rs.c:28: > In function 'copy_from_user', > inlined from 'rs_sta_dbgfs_scale_table_write' at > drivers/net/wireless/iwlwifi/iwl-agn-rs.c:3099: > arch/x86/include/asm/uaccess_64.h:65: > warning: call to 'copy_from_user_overflow' declared with > attribute warning: copy_from_user() buffer size is not provably > correct > > presumably due to buf_size being signed causing GCC to fail to > see that buf_size can't become negative. > > Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com> > --- > drivers/net/wireless/iwlwifi/iwl-agn-rs.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Thank you Wey -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c index d03b473..abcc9f2 100644 --- a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c +++ b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c @@ -3087,7 +3087,7 @@ static ssize_t rs_sta_dbgfs_scale_table_write(struct file *file, struct iwl_lq_sta *lq_sta = file->private_data; struct iwl_priv *priv; char buf[64]; - int buf_size; + size_t buf_size; u32 parsed_rate; struct iwl_station_priv *sta_priv = container_of(lq_sta, struct iwl_station_priv, lq_sta);
Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following warning: In file included from arch/x86/include/asm/uaccess.h:573, from include/net/checksum.h:25, from include/linux/skbuff.h:28, from drivers/net/wireless/iwlwifi/iwl-agn-rs.c:28: In function 'copy_from_user', inlined from 'rs_sta_dbgfs_scale_table_write' at drivers/net/wireless/iwlwifi/iwl-agn-rs.c:3099: arch/x86/include/asm/uaccess_64.h:65: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct presumably due to buf_size being signed causing GCC to fail to see that buf_size can't become negative. Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/net/wireless/iwlwifi/iwl-agn-rs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)