| Message ID | 20110512195514.GA14028@intel.com |
|---|---|
| State | New |
| Headers | show |
On Thu, May 12, 2011 at 9:55 PM, H.J. Lu <hongjiu.lu@intel.com> wrote: > Hi, > > This patch changes maybe_eh_return to bool. OK for trunk? > > Thanks. > > H.J. > --- > 2011-05-12 H.J. Lu <hongjiu.lu@intel.com> > > * config/i386/i386.c (ix86_save_reg): Change maybe_eh_return > to bool. > (ix86_emit_restore_regs_using_mov): Likewise. > (ix86_emit_restore_sse_regs_using_mov): Likewise. OK. FWIW, the return type of ix86_save_reg (and ix86_hard_regno_mode_ok and perhaps many others...) can also be changed to bool. Thanks, Uros.
On Thu, May 12, 2011 at 2:09 PM, Uros Bizjak <ubizjak@gmail.com> wrote: > On Thu, May 12, 2011 at 9:55 PM, H.J. Lu <hongjiu.lu@intel.com> wrote: >> Hi, >> >> This patch changes maybe_eh_return to bool. OK for trunk? >> >> Thanks. >> >> H.J. >> --- >> 2011-05-12 H.J. Lu <hongjiu.lu@intel.com> >> >> * config/i386/i386.c (ix86_save_reg): Change maybe_eh_return >> to bool. >> (ix86_emit_restore_regs_using_mov): Likewise. >> (ix86_emit_restore_sse_regs_using_mov): Likewise. > > OK. > > FWIW, the return type of ix86_save_reg (and ix86_hard_regno_mode_ok > and perhaps many others...) can also be changed to bool. > I will prepare a separate patch. Thanks.
diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 1cf8933..357e57c 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -9066,7 +9066,7 @@ ix86_select_alt_pic_regnum (void) /* Return 1 if we need to save REGNO. */ static int -ix86_save_reg (unsigned int regno, int maybe_eh_return) +ix86_save_reg (unsigned int regno, bool maybe_eh_return) { if (pic_offset_table_rtx && regno == REAL_PIC_OFFSET_TABLE_REGNUM @@ -10898,7 +10898,7 @@ ix86_emit_leave (void) First register is restored from CFA - CFA_OFFSET. */ static void ix86_emit_restore_regs_using_mov (HOST_WIDE_INT cfa_offset, - int maybe_eh_return) + bool maybe_eh_return) { struct machine_function *m = cfun->machine; unsigned int regno; @@ -10937,7 +10937,7 @@ ix86_emit_restore_regs_using_mov (HOST_WIDE_INT cfa_offset, First register is restored from CFA - CFA_OFFSET. */ static void ix86_emit_restore_sse_regs_using_mov (HOST_WIDE_INT cfa_offset, - int maybe_eh_return) + bool maybe_eh_return) { unsigned int regno;