[net-next] net: sched: cls_flower: Fix an error code in fl_tmplt_create()
diff mbox series

Message ID 20180803192754.vggls5m46jw6ynfc@kili.mountain
State Rejected, archived
Delegated to: David Miller
Headers show
Series
  • [net-next] net: sched: cls_flower: Fix an error code in fl_tmplt_create()
Related show

Commit Message

Dan Carpenter Aug. 3, 2018, 7:27 p.m. UTC
We forgot to set the error code on this path, so we return NULL instead
of an error pointer.  In the current code kzalloc() won't fail for small
allocations so this doesn't really affect runtime.

Fixes: b95ec7eb3b4d ("net: sched: cls_flower: implement chain templates")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

David Miller Aug. 6, 2018, 12:26 a.m. UTC | #1
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 3 Aug 2018 22:27:55 +0300

> We forgot to set the error code on this path, so we return NULL instead
> of an error pointer.  In the current code kzalloc() won't fail for small
> allocations so this doesn't really affect runtime.
> 
> Fixes: b95ec7eb3b4d ("net: sched: cls_flower: implement chain templates")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks Dan.

Patch
diff mbox series

diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
index e8bd08ba998a..a3b69bb6f4b0 100644
--- a/net/sched/cls_flower.c
+++ b/net/sched/cls_flower.c
@@ -1250,8 +1250,10 @@  static void *fl_tmplt_create(struct net *net, struct tcf_chain *chain,
 		goto errout_tb;
 
 	tmplt = kzalloc(sizeof(*tmplt), GFP_KERNEL);
-	if (!tmplt)
+	if (!tmplt) {
+		err = -ENOMEM;
 		goto errout_tb;
+	}
 	tmplt->chain = chain;
 	err = fl_set_key(net, tb, &tmplt->dummy_key, &tmplt->mask, extack);
 	if (err)